[PATCH 0/1] Make missing checksums an error

[PATCH 0/1] Make missing checksums an error

[Joshua Lock]

NOTE: this requires a patch I sent to the BitBake list[1] to error cleanly,
otherwise you'll see a Python backtrace and the build fail...

Per some discussion on the list recently this patch sets BB_STRICT_CHECKSUM
in the default-distrovars.inc so that missing checksums in recipes raises an
error.

Cheers,
Joshua

1. lists.linuxtogo.org/pipermail/bitbake-devel/2011-December/thread.html 

The following changes since commit 044324465bd54d53ae768f3c1e7468ae0e0c6200:

  dpkg-native: Fix perl path (2011-12-02 15:31:03 +0000)

are available in the git repository at:
  git://git.openembedded.org/openembedded-core-contrib josh/checksums
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=josh/checksums

Joshua Lock (1):
  default-distrovars: missing checksums should raise an error

 meta/conf/distro/include/default-distrovars.inc |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

-- 
1.7.7.3

[PATCH 1/1] default-distrovars: missing checksums should raise an error

[Joshua Lock]

Set BB_STRICT_CHECKSUM in default-distrovars so that an error is raised
if no checksum is set.

Signed-off-by: Joshua Lock <josh@linux.intel.com>
---
 meta/conf/distro/include/default-distrovars.inc |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/meta/conf/distro/include/default-distrovars.inc b/meta/conf/distro/include/default-distrovars.inc
index 6f5f1c0..e1594f3 100644
--- a/meta/conf/distro/include/default-distrovars.inc
+++ b/meta/conf/distro/include/default-distrovars.inc
@@ -48,3 +48,6 @@ NO32LIBS ??= "1"
 BBINCLUDELOGS ??= "yes"
 SDK_VERSION ??= "oe-core.0"
 DISTRO_VERSION ??= "oe-core.0"
+
+# Missing checksums should raise an error
+BB_STRICT_CHECKSUM = "1"
-- 
1.7.7.3

Re: [PATCH 0/1] Make missing checksums an error

[Joshua Lock]

On 02/12/11 11:20, Joshua Lock wrote:
> NOTE: this requires a patch I sent to the BitBake list[1] to error cleanly,
> otherwise you'll see a Python backtrace and the build fail...

This patch has now been merged into BitBake master.

Cheers,
Joshua
-- 
Joshua Lock
        Yocto Project "Johannes factotum"
        Intel Open Source Technology Centre

Re: [PATCH 0/1] Make missing checksums an error

[Richard Purdie]

On Fri, 2011-12-02 at 11:20 -0800, Joshua Lock wrote:
> NOTE: this requires a patch I sent to the BitBake list[1] to error cleanly,
> otherwise you'll see a Python backtrace and the build fail...
> 
> Per some discussion on the list recently this patch sets BB_STRICT_CHECKSUM
> in the default-distrovars.inc so that missing checksums in recipes raises an
> error.
> 
> Cheers,
> Joshua

What's the state of master? If I merge this, how badly do things
explode?

Cheers,

Richard

Re: [PATCH 0/1] Make missing checksums an error

[Joshua Lock]

On 05/12/11 14:50, Richard Purdie wrote:
> On Fri, 2011-12-02 at 11:20 -0800, Joshua Lock wrote:
>> NOTE: this requires a patch I sent to the BitBake list[1] to error cleanly,
>> otherwise you'll see a Python backtrace and the build fail...
>>
>> Per some discussion on the list recently this patch sets BB_STRICT_CHECKSUM
>> in the default-distrovars.inc so that missing checksums in recipes raises an
>> error.
>>
>> Cheers,
>> Joshua
> 
> What's the state of master? If I merge this, how badly do things
> explode?

Let me run a universe fetchall and get back to you...

Joshua
-- 
Joshua Lock
        Yocto Project "Johannes factotum"
        Intel Open Source Technology Centre

Re: [PATCH 0/1] Make missing checksums an error

[Joshua Lock]

On 05/12/11 14:55, Joshua Lock wrote:
> On 05/12/11 14:50, Richard Purdie wrote:
>> On Fri, 2011-12-02 at 11:20 -0800, Joshua Lock wrote:
>>> NOTE: this requires a patch I sent to the BitBake list[1] to error cleanly,
>>> otherwise you'll see a Python backtrace and the build fail...
>>>
>>> Per some discussion on the list recently this patch sets BB_STRICT_CHECKSUM
>>> in the default-distrovars.inc so that missing checksums in recipes raises an
>>> error.
>>>
>>> Cheers,
>>> Joshua
>>
>> What's the state of master? If I merge this, how badly do things
>> explode?
> 
> Let me run a universe fetchall and get back to you...

Two recipes in oe-core require checksums adding, puzzles and
omap3-sgx-modules - a v2 of this request with those patches is incoming.

Joshua
-- 
Joshua Lock
        Yocto Project "Johannes factotum"
        Intel Open Source Technology Centre

Re: [PATCH 0/1] Make missing checksums an error

[Koen Kooi]

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]


Op 6 dec. 2011, om 03:13 heeft Joshua Lock het volgende geschreven:

> 
> 
> On 05/12/11 14:55, Joshua Lock wrote:
>> On 05/12/11 14:50, Richard Purdie wrote:
>>> On Fri, 2011-12-02 at 11:20 -0800, Joshua Lock wrote:
>>>> NOTE: this requires a patch I sent to the BitBake list[1] to error cleanly,
>>>> otherwise you'll see a Python backtrace and the build fail...
>>>> 
>>>> Per some discussion on the list recently this patch sets BB_STRICT_CHECKSUM
>>>> in the default-distrovars.inc so that missing checksums in recipes raises an
>>>> error.
>>>> 
>>>> Cheers,
>>>> Joshua
>>> 
>>> What's the state of master? If I merge this, how badly do things
>>> explode?
>> 
>> Let me run a universe fetchall and get back to you...
> 
> Two recipes in oe-core require checksums adding, puzzles and
> omap3-sgx-modules - a v2 of this request with those patches is incoming.

Omap3-sgx-modules has no place in OE-core, so it should get deleted.

regards,

KOen

[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 169 bytes --]

Re: [PATCH 0/1] Make missing checksums an error

[Paul Eggleton]

On Tuesday 06 December 2011 08:18:30 Koen Kooi wrote:
> Omap3-sgx-modules has no place in OE-core, so it should get deleted.

Sounds good, would you mind sending a patch that does that?

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre