From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Cc: philb@gnu.org
Subject: Re: [PATCH v2] conf: machine: includes: add armv6-novfp support
Date: Tue, 27 Dec 2011 11:02:55 -0800 [thread overview]
Message-ID: <4EFA165F.1060309@linux.intel.com> (raw)
In-Reply-To: <1324505762-30279-1-git-send-email-victor.quicksilver@gmail.com>
On 12/21/2011 02:16 PM, Víctor Enríquez wrote:
> This work was made by Victor Enriquez and then modified by Denis Carikli who was helped by Mark Hatle comments (who is fray on
> #yocto channel on Freenode).
>
> The changes are for adding support to armv6-novfp, for building binaries for armv6 machines without vfp, for example the htc
> dream.
>
> Signed-off-by: Mark Hatle<mark.hatle@windriver.com>
> Signed-off-by: Denis 'GNUtoo' Carikli<GNUtoo@no-log.org>
> Signed-off-by: Víctor Enríquez<victor.quicksilver@gmail.com>
> ---
> meta/conf/machine/include/arm/arch-armv6.inc | 28 +++++++++++++-------
> meta/conf/machine/include/arm/feature-arm-vfp.inc | 4 ++-
> 2 files changed, 21 insertions(+), 11 deletions(-)
>
> diff --git a/meta/conf/machine/include/arm/arch-armv6.inc b/meta/conf/machine/include/arm/arch-armv6.inc
> index da8274e..f9c112e 100644
> --- a/meta/conf/machine/include/arm/arch-armv6.inc
> +++ b/meta/conf/machine/include/arm/arch-armv6.inc
> @@ -10,24 +10,32 @@ MACHINEOVERRIDES .= "${@bb.utils.contains("TUNE_FEATURES", "armv6", ":armv6", ""
> require conf/machine/include/arm/arch-armv5-dsp.inc
>
> # Little Endian
> -AVAILTUNES += "armv6 armv6t armv6hf armv6thf"
> +AVAILTUNES += "armv6-novfp armv6 armv6t armv6t-novfp armv6hf armv6thf"
> +TUNE_FEATURES_tune-armv6-novfp ?= "armv6"
> TUNE_FEATURES_tune-armv6 ?= "armv6 vfp"
> +TUNE_FEATURES_tune-armv6t-novfp ?= "armv6 thumb"
> TUNE_FEATURES_tune-armv6t ?= "armv6 vfp thumb"
> TUNE_FEATURES_tune-armv6hf ?= "${TUNE_FEATURES_tune-armv6} callconvention-hard"
> TUNE_FEATURES_tune-armv6thf ?= "${TUNE_FEATURES_tune-armv6t} callconvention-hard"
> -PACKAGE_EXTRA_ARCHS_tune-armv6 = "${PACKAGE_EXTRA_ARCHS_tune-armv5e-vfp} armv6-vfp"
> -PACKAGE_EXTRA_ARCHS_tune-armv6t = "${PACKAGE_EXTRA_ARCHS_tune-armv5te-vfp} armv6-vfp armv6t-vfp"
> -PACKAGE_EXTRA_ARCHS_tune-armv6hf = "${PACKAGE_EXTRA_ARCHS_tune-armv5ehf-vfp} armv6hf-vfp"
> -PACKAGE_EXTRA_ARCHS_tune-armv6thf = "${PACKAGE_EXTRA_ARCHS_tune-armv5tehf-vfp} armv6hf-vfp armv6thf-vfp"
> +PACKAGE_EXTRA_ARCHS_tune-armv6-novfp = "${PACKAGE_EXTRA_ARCHS_tune-armv5e} armv6-novfp"
> +PACKAGE_EXTRA_ARCHS_tune-armv6 = "${PACKAGE_EXTRA_ARCHS_tune-armv5e-vfp} armv6-novfp armv6"
> +PACKAGE_EXTRA_ARCHS_tune-armv6t-novfp = "${PACKAGE_EXTRA_ARCHS_tune-armv5e} armv6-novfp armv6t-novfp"
> +PACKAGE_EXTRA_ARCHS_tune-armv6t = "${PACKAGE_EXTRA_ARCHS_tune-armv5te-vfp} armv6-novfp armv6t-novfp armv6-vfp armv6t"
I am not sure I fully understand the changes here, so this might be a
mis-understanding on my part, but should this and the tune-armv6 have
both -vfp and -novfp in it?
> +PACKAGE_EXTRA_ARCHS_tune-armv6hf = "${PACKAGE_EXTRA_ARCHS_tune-armv5ehf-vfp} armv6hf"
> +PACKAGE_EXTRA_ARCHS_tune-armv6thf = "${PACKAGE_EXTRA_ARCHS_tune-armv5tehf-vfp} armv6hf-vfp armv6thf"
>
> # Big Endian
> -AVAILTUNES += "armv6b armv6tb armv6hfb armv6thfb"
> +AVAILTUNES += "armv6b-novfp armv6b armv6tb-novfp armv6tb armv6hfb armv6thfb"
> +TUNE_FEATURES_tune-armv6b-novfp ?= "${TUNE_FEATURES_tune-armv6-novfp} bigendian"
> TUNE_FEATURES_tune-armv6b ?= "${TUNE_FEATURES_tune-armv6} bigendian"
> +TUNE_FEATURES_tune-armv6tb-novfp ?= "${TUNE_FEATURES_tune-armv6t-novfp} bigendian"
> TUNE_FEATURES_tune-armv6tb ?= "${TUNE_FEATURES_tune-armv6t} bigendian"
> TUNE_FEATURES_tune-armv6hfb ?= "${TUNE_FEATURES_tune-armv6b} callconvention-hard"
> TUNE_FEATURES_tune-armv6thfb ?= "${TUNE_FEATURES_tune-armv6tb} callconvention-hard"
> -PACKAGE_EXTRA_ARCHS_tune-armv6b = "${PACKAGE_EXTRA_ARCHS_tune-armv5eb-vfp} armv6b-vfp"
> -PACKAGE_EXTRA_ARCHS_tune-armv6tb = "${PACKAGE_EXTRA_ARCHS_tune-armv5teb-vfp} armv6b-vfp armv6tb-vfp"
> -PACKAGE_EXTRA_ARCHS_tune-armv6hfb = "${PACKAGE_EXTRA_ARCHS_tune-armv5ehfb-vfp} armv6hfb-vfp"
> -PACKAGE_EXTRA_ARCHS_tune-armv6thfb = "${PACKAGE_EXTRA_ARCHS_tune-armv5tehfb-vfp} armv6hfb-vfp armv6thfb-vfp"
> +PACKAGE_EXTRA_ARCHS_tune-armv6b-novfp = "${PACKAGE_EXTRA_ARCHS_tune-armv5eb} armv6b-novfp"
> +PACKAGE_EXTRA_ARCHS_tune-armv6b = "${PACKAGE_EXTRA_ARCHS_tune-armv5eb-vfp} armv6b"
Why not like the armv6 above with -novfp (again, maybe my misunderstanding
> +PACKAGE_EXTRA_ARCHS_tune-armv6tb-novfp = "${PACKAGE_EXTRA_ARCHS_tune-armv5eb} armv6b-novfp armv6tb-novfp"
> +PACKAGE_EXTRA_ARCHS_tune-armv6tb = "${PACKAGE_EXTRA_ARCHS_tune-armv5teb-vfp} armv6b-novfp armv6tb-novfp armv6b-vfp armv6tb"
This seems to match armv6t above.
> +PACKAGE_EXTRA_ARCHS_tune-armv6hfb = "${PACKAGE_EXTRA_ARCHS_tune-armv5ehfb-vfp} armv6hfb"
> +PACKAGE_EXTRA_ARCHS_tune-armv6thfb = "${PACKAGE_EXTRA_ARCHS_tune-armv5tehfb-vfp} armv6hfb-vfp armv6thfb"
>
> diff --git a/meta/conf/machine/include/arm/feature-arm-vfp.inc b/meta/conf/machine/include/arm/feature-arm-vfp.inc
> index 29a925c..78f453c 100644
> --- a/meta/conf/machine/include/arm/feature-arm-vfp.inc
> +++ b/meta/conf/machine/include/arm/feature-arm-vfp.inc
> @@ -1,5 +1,7 @@
> TUNEVALID[vfp] = "Enable Vector Floating Point (vfp) unit."
> -ARMPKGSFX_FPU .= "${@bb.utils.contains("TUNE_FEATURES", "vfp", "-vfp", "" ,d)}"
> +TUNE_ARM_VFP = "${@bb.utils.contains("ARMPKGARCH", "armv6", "", "vfp" ,d)}"
should this be -vfp?
> +TUNE_ARM_NOVFP = "${@bb.utils.contains("ARMPKGARCH", "armv6", "-novfp", "" ,d)}"
> +ARMPKGSFX_FPU .= "${@bb.utils.contains("TUNE_FEATURES", "vfp", "${TUNE_ARM_VFP}", "${TUNE_ARM_NOVFP}" ,d)}"
>
> TUNEVALID[callconvention-hard] = "Enable EABI hard float call convention, requires VFP."
> TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "vfp", bb.utils.contains("TUNE_FEATURES", "callconvention-hard", "-mfloat-abi=hard", "-mfloat-abi=softfp", d), "" ,d)}"
next prev parent reply other threads:[~2011-12-27 19:10 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 7:44 [oe-core 0/4] Qt4, armv6, xserver-xorg changes Martin Jansa
2011-10-12 7:45 ` [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input Martin Jansa
2011-10-12 8:02 ` Eric Bénard
2011-10-12 9:20 ` Koen Kooi
2011-10-12 19:04 ` Chris Larson
2011-10-12 18:10 ` Simon Busch
2011-10-12 18:14 ` Koen Kooi
2011-10-12 18:34 ` Simon Busch
2011-10-12 19:09 ` Koen Kooi
2011-10-12 19:24 ` Simon Busch
2011-10-12 19:29 ` Simon Busch
2011-10-12 19:52 ` Simon Busch
2011-10-12 20:09 ` Eric Bénard
2011-10-12 19:41 ` Chris Larson
2011-10-12 19:22 ` Eric Bénard
2011-10-12 7:45 ` [oe-core 2/4] qt4-x11-free: bring back pkg-config fixups Martin Jansa
2011-10-12 9:23 ` Paul Eggleton
2011-10-12 18:05 ` Simon Busch
2011-10-19 19:02 ` Simon Busch
2011-10-12 7:45 ` [oe-core 3/4] conf: machine: includes: add armv6-novfp support Martin Jansa
2011-10-12 21:26 ` Phil Blundell
2011-10-13 10:49 ` Denis 'GNUtoo' Carikli
2011-10-13 19:42 ` Phil Blundell
2011-12-21 19:48 ` [PATCH] " vquicksilver
2011-12-21 19:57 ` Mark Hatle
2011-12-21 20:06 ` Otavio Salvador
2011-12-21 20:12 ` Koen Kooi
2011-12-21 22:16 ` [PATCH v2] " Víctor Enríquez
2011-12-27 19:02 ` Saul Wold [this message]
2011-10-12 7:45 ` [oe-core 4/4] xserver-xorg: drop xorg-minimal-fonts from RDEPENDS Martin Jansa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EFA165F.1060309@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=philb@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox