Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Simon Busch <morphis@gravedo.de>
To: openembedded-core@lists.openembedded.org
Subject: Re: [oe-core 2/4] qt4-x11-free: bring back pkg-config fixups
Date: Wed, 19 Oct 2011 21:02:29 +0200	[thread overview]
Message-ID: <4E9F1EC5.5030502@gravedo.de> (raw)
In-Reply-To: <4E95D6EB.4050703@gravedo.de>

On 12.10.2011 20:05, Simon Busch wrote:
> On 12.10.2011 11:23, Paul Eggleton wrote:
>> On Wednesday 12 October 2011 08:45:03 Martin Jansa wrote:
>>> From: Simon Busch <morphis@gravedo.de>
>>>
>>> With b40b9c024be5e1ec81a31961158b3e6b529acfe0 some pkg-config fixups where
>>> removed from qt4.inc which breaks the pkg-config files for qt4-embedded.
>>> Without that the pkg-config files for qt4-x11-free are broken. So this
>>> patch puts the fixes into the qt4-x11-free.inc file to be used by
>>> qt4-x11-free and not qt4-embedded.
>>
>> So why do we need these only in the X11 version? Surely they should be 
>> applicable to both embedded and X11, or not at all...?
> 
> With b40b9c024be5e1ec81a31961158b3e6b529acfe0 I removed this fixups from
> qt4.inc as I had problems with building agains qt4-embedded as cflags
> were incorrect in the created pkg-config files.
> 
> Now I switched my application to x11 and got other problems with the
> pkg-config files from qt4-x11-free which can be resolved with the fixups
> I removed before.
> 
> So you are right we need them for qt4-x11-free but not for qt4-embedded.
> I didn't investigated from where these differences are coming.
> 
> regards,
> Simon
> 

Still any comments on this or is the patch already accepted?

regards,
Simon

-- 
Simon Busch - http://mm.gravedo.de/blog/



  reply	other threads:[~2011-10-19 19:08 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-12  7:44 [oe-core 0/4] Qt4, armv6, xserver-xorg changes Martin Jansa
2011-10-12  7:45 ` [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input Martin Jansa
2011-10-12  8:02   ` Eric Bénard
2011-10-12  9:20     ` Koen Kooi
2011-10-12 19:04       ` Chris Larson
2011-10-12 18:10     ` Simon Busch
2011-10-12 18:14       ` Koen Kooi
2011-10-12 18:34         ` Simon Busch
2011-10-12 19:09           ` Koen Kooi
2011-10-12 19:24             ` Simon Busch
2011-10-12 19:29               ` Simon Busch
2011-10-12 19:52                 ` Simon Busch
2011-10-12 20:09                   ` Eric Bénard
2011-10-12 19:41               ` Chris Larson
2011-10-12 19:22       ` Eric Bénard
2011-10-12  7:45 ` [oe-core 2/4] qt4-x11-free: bring back pkg-config fixups Martin Jansa
2011-10-12  9:23   ` Paul Eggleton
2011-10-12 18:05     ` Simon Busch
2011-10-19 19:02       ` Simon Busch [this message]
2011-10-12  7:45 ` [oe-core 3/4] conf: machine: includes: add armv6-novfp support Martin Jansa
2011-10-12 21:26   ` Phil Blundell
2011-10-13 10:49     ` Denis 'GNUtoo' Carikli
2011-10-13 19:42       ` Phil Blundell
2011-12-21 19:48         ` [PATCH] " vquicksilver
2011-12-21 19:57           ` Mark Hatle
2011-12-21 20:06           ` Otavio Salvador
2011-12-21 20:12             ` Koen Kooi
2011-12-21 22:16         ` [PATCH v2] " Víctor Enríquez
2011-12-27 19:02           ` Saul Wold
2011-10-12  7:45 ` [oe-core 4/4] xserver-xorg: drop xorg-minimal-fonts from RDEPENDS Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E9F1EC5.5030502@gravedo.de \
    --to=morphis@gravedo.de \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox