* [oe-core 0/4] Qt4, armv6, xserver-xorg changes
@ 2011-10-12 7:44 Martin Jansa
2011-10-12 7:45 ` [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input Martin Jansa
` (3 more replies)
0 siblings, 4 replies; 30+ messages in thread
From: Martin Jansa @ 2011-10-12 7:44 UTC (permalink / raw)
To: openembedded-core
The following changes since commit 486b17af3e4cced76e9852e7634f75ea87433db2:
shared-mime-info: Fix a parallel make race (2011-10-11 18:06:56 +0100)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib jansa/pull
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/pull
GNUtoo (1):
conf: machine: includes: add armv6-novfp support
Martin Jansa (1):
xserver-xorg: drop xorg-minimal-fonts from RDEPENDS
Simon Busch (2):
qt4-embedded: remove dependency on tslib and use std. linux input
qt4-x11-free: bring back pkg-config fixups
meta/conf/machine/include/arm/arch-armv6.inc | 45 +++++++++++++-------
meta/conf/machine/include/tune-arm1136j-s.inc | 10 ++++
.../xorg-xserver/xserver-xorg-1.11.1.inc | 2 +
.../xorg-xserver/xserver-xorg-common.inc | 1 -
meta/recipes-qt/qt4/files/qte.sh | 2 +-
meta/recipes-qt/qt4/qt4-embedded.inc | 6 +-
meta/recipes-qt/qt4/qt4-x11-free.inc | 16 +++++++-
7 files changed, 60 insertions(+), 22 deletions(-)
create mode 100644 meta/conf/machine/include/tune-arm1136j-s.inc
--
1.7.7
^ permalink raw reply [flat|nested] 30+ messages in thread
* [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
2011-10-12 7:44 [oe-core 0/4] Qt4, armv6, xserver-xorg changes Martin Jansa
@ 2011-10-12 7:45 ` Martin Jansa
2011-10-12 8:02 ` Eric Bénard
2011-10-12 7:45 ` [oe-core 2/4] qt4-x11-free: bring back pkg-config fixups Martin Jansa
` (2 subsequent siblings)
3 siblings, 1 reply; 30+ messages in thread
From: Martin Jansa @ 2011-10-12 7:45 UTC (permalink / raw)
To: openembedded-core
From: Simon Busch <morphis@gravedo.de>
In most cases we don't need tslib in std. configuration as touchscreen access in most
devices today is done with linux input interface. If some specific machine has a need for
tslib support it should add the dependency in it's machine layer again and modify the
profile script accordingly.
Signed-off-by: Simon Busch <morphis@gravedo.de>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
meta/recipes-qt/qt4/files/qte.sh | 2 +-
meta/recipes-qt/qt4/qt4-embedded.inc | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/meta/recipes-qt/qt4/files/qte.sh b/meta/recipes-qt/qt4/files/qte.sh
index 21d6ecb..bb8dfae 100644
--- a/meta/recipes-qt/qt4/files/qte.sh
+++ b/meta/recipes-qt/qt4/files/qte.sh
@@ -2,6 +2,6 @@
if [ -e /dev/input/touchscreen0 ]
then
- QWS_MOUSE_PROTO=Tslib:/dev/input/touchscreen0
+ QWS_MOUSE_PROTO=LinuxInput:/dev/input/touchscreen0
export QWS_MOUSE_PROTO
fi
diff --git a/meta/recipes-qt/qt4/qt4-embedded.inc b/meta/recipes-qt/qt4/qt4-embedded.inc
index bee7345..179de87 100644
--- a/meta/recipes-qt/qt4/qt4-embedded.inc
+++ b/meta/recipes-qt/qt4/qt4-embedded.inc
@@ -2,8 +2,8 @@ DESCRIPTION = "Qt is a versatile cross-platform application framework -- this is
SECTION = "libs"
LICENSE = "LGPLv2.1 | GPLv3"
HOMEPAGE = "http://qt.nokia.com"
-DEPENDS += "directfb tslib"
-INC_PR = "r36"
+DEPENDS += "directfb"
+INC_PR = "r37"
QT_BASE_NAME ?= "qt4-embedded"
QT_BASE_LIB ?= "libqt-embedded"
@@ -15,7 +15,7 @@ QT_CONFIG_FLAGS += " \
-embedded ${QT_ARCH} \
-qtlibinfix ${QT_LIBINFIX} \
-plugin-gfx-transformed -plugin-gfx-qvfb -plugin-gfx-vnc -plugin-gfx-directfb \
- -plugin-mouse-tslib -qt-mouse-pc -qt-mouse-qvfb -qt-mouse-linuxinput \
+ -qt-mouse-pc -qt-mouse-qvfb -qt-mouse-linuxinput \
-qt-kbd-tty \
-DQT_KEYPAD_NAVIGATION \
"
--
1.7.7
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [oe-core 2/4] qt4-x11-free: bring back pkg-config fixups
2011-10-12 7:44 [oe-core 0/4] Qt4, armv6, xserver-xorg changes Martin Jansa
2011-10-12 7:45 ` [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input Martin Jansa
@ 2011-10-12 7:45 ` Martin Jansa
2011-10-12 9:23 ` Paul Eggleton
2011-10-12 7:45 ` [oe-core 3/4] conf: machine: includes: add armv6-novfp support Martin Jansa
2011-10-12 7:45 ` [oe-core 4/4] xserver-xorg: drop xorg-minimal-fonts from RDEPENDS Martin Jansa
3 siblings, 1 reply; 30+ messages in thread
From: Martin Jansa @ 2011-10-12 7:45 UTC (permalink / raw)
To: openembedded-core
From: Simon Busch <morphis@gravedo.de>
With b40b9c024be5e1ec81a31961158b3e6b529acfe0 some pkg-config fixups where removed from
qt4.inc which breaks the pkg-config files for qt4-embedded. Without that the pkg-config
files for qt4-x11-free are broken. So this patch puts the fixes into the qt4-x11-free.inc
file to be used by qt4-x11-free and not qt4-embedded.
Signed-off-by: Simon Busch <morphis@gravedo.de>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
meta/recipes-qt/qt4/qt4-x11-free.inc | 16 +++++++++++++++-
1 files changed, 15 insertions(+), 1 deletions(-)
diff --git a/meta/recipes-qt/qt4/qt4-x11-free.inc b/meta/recipes-qt/qt4/qt4-x11-free.inc
index f391028..04b7885 100644
--- a/meta/recipes-qt/qt4/qt4-x11-free.inc
+++ b/meta/recipes-qt/qt4/qt4-x11-free.inc
@@ -5,7 +5,7 @@ HOMEPAGE = "http://qt.nokia.com"
SECTION = "x11/libs"
DEPENDS += "virtual/libgl virtual/libx11 fontconfig libxft libxext libxrender libxrandr libxcursor"
-INC_PR = "r32"
+INC_PR = "r33"
QT_GLFLAGS ?= "${@base_contains('DISTRO_FEATURES', 'opengl', '-opengl', '-no-opengl', d)} "
QT_GLFLAGS_qemux86 = "-opengl"
@@ -16,3 +16,17 @@ QT_BASE_LIB ?= "libqt"
inherit qt4x11
+do_install_append() {
+ # fix pkgconfig, libtool and prl files
+ sed -i -e 's#I/usr/include#Iincludedir}#g' \
+ -e 's#Iin#I${in#g' \
+ ${D}${libdir}/*.la ${D}${libdir}/*.prl ${D}${libdir}/pkgconfig/*.pc
+
+ # QT abuses $includedir to point to its headers, which breaks pkgconfig sysroot, so
+ # manually fix it up here:
+ for pc in ${D}${libdir}/pkgconfig/*.pc ; do
+ sed -i -e "s:prefix}include/${QT_BASE_NAME}/$(basename $pc .pc):prefix}/include:" \
+ -e "s,Cflags: ,Cflags: -IP{includedir}/${QT_BASE_NAME}/$(basename $pc .pc) ," \
+ -e 's:IP{:I${:g' $pc
+ done
+}
--
1.7.7
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [oe-core 3/4] conf: machine: includes: add armv6-novfp support
2011-10-12 7:44 [oe-core 0/4] Qt4, armv6, xserver-xorg changes Martin Jansa
2011-10-12 7:45 ` [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input Martin Jansa
2011-10-12 7:45 ` [oe-core 2/4] qt4-x11-free: bring back pkg-config fixups Martin Jansa
@ 2011-10-12 7:45 ` Martin Jansa
2011-10-12 21:26 ` Phil Blundell
2011-10-12 7:45 ` [oe-core 4/4] xserver-xorg: drop xorg-minimal-fonts from RDEPENDS Martin Jansa
3 siblings, 1 reply; 30+ messages in thread
From: Martin Jansa @ 2011-10-12 7:45 UTC (permalink / raw)
To: openembedded-core
From: GNUtoo <GNUtoo@no-log.org>
Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
meta/conf/machine/include/arm/arch-armv6.inc | 45 ++++++++++++++++---------
meta/conf/machine/include/tune-arm1136j-s.inc | 10 +++++
2 files changed, 39 insertions(+), 16 deletions(-)
create mode 100644 meta/conf/machine/include/tune-arm1136j-s.inc
diff --git a/meta/conf/machine/include/arm/arch-armv6.inc b/meta/conf/machine/include/arm/arch-armv6.inc
index 9f2e9ac..3dd6566 100644
--- a/meta/conf/machine/include/arm/arch-armv6.inc
+++ b/meta/conf/machine/include/arm/arch-armv6.inc
@@ -9,24 +9,37 @@ TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "armv6", "-march=armv6", "
require conf/machine/include/arm/arch-armv5-dsp.inc
# Little Endian
-AVAILTUNES += "armv6 armv6t armv6hf armv6thf"
-TUNE_FEATURES_tune-armv6 ?= "armv6 vfp"
-TUNE_FEATURES_tune-armv6t ?= "armv6 vfp thumb"
-TUNE_FEATURES_tune-armv6hf ?= "${TUNE_FEATURES_tune-armv6} callconvention-hard"
-TUNE_FEATURES_tune-armv6thf ?= "${TUNE_FEATURES_tune-armv6t} callconvention-hard"
-PACKAGE_EXTRA_ARCHS_tune-armv6 = "${PACKAGE_EXTRA_ARCHS_tune-armv5e-vfp} armv6-vfp"
-PACKAGE_EXTRA_ARCHS_tune-armv6t = "${PACKAGE_EXTRA_ARCHS_tune-armv5te-vfp} armv6-vfp armv6t-vfp"
-PACKAGE_EXTRA_ARCHS_tune-armv6hf = "${PACKAGE_EXTRA_ARCHS_tune-armv5ehf-vfp} armv6hf-vfp"
-PACKAGE_EXTRA_ARCHS_tune-armv6thf = "${PACKAGE_EXTRA_ARCHS_tune-armv5tehf-vfp} armv6hf-vfp armv6thf-vfp"
+AVAILTUNES += "armv6 armv6t"
+TUNE_FEATURES_tune-armv6 ?= "armv6"
+TUNE_FEATURES_tune-armv6t ?= "armv6 thumb"
+PACKAGE_EXTRA_ARCHS_tune-armv6 = "${PACKAGE_EXTRA_ARCHS_tune-armv5} armv6"
+PACKAGE_EXTRA_ARCHS_tune-armv6t = "${PACKAGE_EXTRA_ARCHS_tune-armv5t} armv6 armv6t"
+
+# Little Endian + VFP
+AVAILTUNES += "armv6-vfp armv6t-vfp armv6hf-vfp armv6thf-vfp"
+TUNE_FEATURES_tune-armv6-vfp ?= "armv6 vfp"
+TUNE_FEATURES_tune-armv6t-vfp ?= "armv6 vfp thumb"
+TUNE_FEATURES_tune-armv6hf-vfp ?= "${TUNE_FEATURES_tune-armv6-vfp} callconvention-hard"
+TUNE_FEATURES_tune-armv6thf-vfp ?= "${TUNE_FEATURES_tune-armv6t-vfp} callconvention-hard"
+PACKAGE_EXTRA_ARCHS_tune-armv6-vfp = "${PACKAGE_EXTRA_ARCHS_tune-armv5-vfp} armv6-vfp"
+PACKAGE_EXTRA_ARCHS_tune-armv6t-vfp = "${PACKAGE_EXTRA_ARCHS_tune-armv5t-vfp} armv6-vfp armv6t-vfp"
+PACKAGE_EXTRA_ARCHS_tune-armv6hf-vfp = "${PACKAGE_EXTRA_ARCHS_tune-armv5hf-vfp} armv6hf-vfp"
+PACKAGE_EXTRA_ARCHS_tune-armv6thf-vfp = "${PACKAGE_EXTRA_ARCHS_tune-armv5thf-vfp} armv6hf-vfp armv6thf-vfp"
# Big Endian
-AVAILTUNES += "armv6b armv6tb armv6hfb armv6thfb"
+AVAILTUNES += "armv6b armv6tb"
TUNE_FEATURES_tune-armv6b ?= "${TUNE_FEATURES_tune-armv6} bigendian"
TUNE_FEATURES_tune-armv6tb ?= "${TUNE_FEATURES_tune-armv6t} bigendian"
-TUNE_FEATURES_tune-armv6hfb ?= "${TUNE_FEATURES_tune-armv6b} callconvention-hard"
-TUNE_FEATURES_tune-armv6thfb ?= "${TUNE_FEATURES_tune-armv6tb} callconvention-hard"
-PACKAGE_EXTRA_ARCHS_tune-armv6b = "${PACKAGE_EXTRA_ARCHS_tune-armv5eb-vfp} armv6b-vfp"
-PACKAGE_EXTRA_ARCHS_tune-armv6tb = "${PACKAGE_EXTRA_ARCHS_tune-armv5teb-vfp} armv6b-vfp armv6tb-vfp"
-PACKAGE_EXTRA_ARCHS_tune-armv6hfb = "${PACKAGE_EXTRA_ARCHS_tune-armv5ehfb-vfp} armv6hfb-vfp"
-PACKAGE_EXTRA_ARCHS_tune-armv6thfb = "${PACKAGE_EXTRA_ARCHS_tune-armv5tehfb-vfp} armv6hfb-vfp armv6thfb-vfp"
+PACKAGE_EXTRA_ARCHS_tune-armv6b = "${PACKAGE_EXTRA_ARCHS_tune-armv5} armv6b"
+PACKAGE_EXTRA_ARCHS_tune-armv6tb = "${PACKAGE_EXTRA_ARCHS_tune-armv5t} armv6b armv6tb"
+# Big Endian + VFP
+AVAILTUNES += "armv6b-vfp armv6tb-vfp armv6hfb-vfp armv6thfb-vfp"
+TUNE_FEATURES_tune-armv6b-vfp ?= "${TUNE_FEATURES_tune-armv6-vfp} bigendian"
+TUNE_FEATURES_tune-armv6tb-vfp ?= "${TUNE_FEATURES_tune-armv6t-vfp} bigendian"
+TUNE_FEATURES_tune-armv6hfb-vfp ?= "${TUNE_FEATURES_tune-armv6b-vfp} callconvention-hard"
+TUNE_FEATURES_tune-armv6thfb-vfp ?= "${TUNE_FEATURES_tune-armv6tb-vfp} callconvention-hard"
+PACKAGE_EXTRA_ARCHS_tune-armv6b-vfp = "${PACKAGE_EXTRA_ARCHS_tune-armv6b} armv6b-vfp"
+PACKAGE_EXTRA_ARCHS_tune-armv6tb-vfp = "${PACKAGE_EXTRA_ARCHS_tune-armv6t} armv6b-vfp armv6tb-vfp"
+PACKAGE_EXTRA_ARCHS_tune-armv6hfb-vfp = "armv6hfb-vfp"
+PACKAGE_EXTRA_ARCHS_tune-armv6thfb-vfp = "armv6hfb-vfp armv6thfb-vfp"
diff --git a/meta/conf/machine/include/tune-arm1136j-s.inc b/meta/conf/machine/include/tune-arm1136j-s.inc
new file mode 100644
index 0000000..ce9ae7c
--- /dev/null
+++ b/meta/conf/machine/include/tune-arm1136j-s.inc
@@ -0,0 +1,10 @@
+DEFAULTTUNE ?= "arm1136js"
+
+require conf/machine/include/arm/arch-armv6.inc
+
+TUNEVALID[arm1136js] = "Enable arm1136js specific processor optimizations"
+TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "arm1136js", "-mtune=arm1136j-s", "", d)}"
+
+AVAILTUNES += "arm1136js"
+TUNE_FEATURES_tune-arm1136js = "${TUNE_FEATURES_tune-armv6t} arm1136js"
+PACKAGE_EXTRA_ARCHS_tune-arm1136js = "${PACKAGE_EXTRA_ARCHS_tune-armv6t}"
--
1.7.7
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [oe-core 4/4] xserver-xorg: drop xorg-minimal-fonts from RDEPENDS
2011-10-12 7:44 [oe-core 0/4] Qt4, armv6, xserver-xorg changes Martin Jansa
` (2 preceding siblings ...)
2011-10-12 7:45 ` [oe-core 3/4] conf: machine: includes: add armv6-novfp support Martin Jansa
@ 2011-10-12 7:45 ` Martin Jansa
3 siblings, 0 replies; 30+ messages in thread
From: Martin Jansa @ 2011-10-12 7:45 UTC (permalink / raw)
To: openembedded-core
* as discussed here http://lists.linuxtogo.org/pipermail/openembedded-core/2011-October/010899.html
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
.../xorg-xserver/xserver-xorg-1.11.1.inc | 2 ++
.../xorg-xserver/xserver-xorg-common.inc | 1 -
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.1.inc b/meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.1.inc
index 690de3f..2c5bb0a 100644
--- a/meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.1.inc
+++ b/meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.1.inc
@@ -3,5 +3,7 @@ SRC_URI += "file://crosscompile.patch"
# Misc build failure for master HEAD
SRC_URI += "file://fix_open_max_preprocessor_error.patch"
+PR = "r1"
+
SRC_URI[md5sum] = "4cdf54dc569b6a5548257c93a45dcd3d"
SRC_URI[sha256sum] = "c069c177d9a80bca2ee1d49aa1af6d9f996c83e4ff12393cab2ca3f8817276f6"
diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc b/meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc
index 0cc3dc0..a8c7b0a 100644
--- a/meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc
+++ b/meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc
@@ -60,7 +60,6 @@ PACKAGES =+ "${PN}-security-policy \
${PN}-module-libxf1bpp \
${PN}-module-libxf4bpp"
-RDEPENDS_${PN} += "xorg-minimal-fonts"
RRECOMMENDS_${PN} += "${PN}-security-policy xkeyboard-config rgb xserver-xf86-config"
RDEPENDS_${PN}-xvfb += "xkeyboard-config"
--
1.7.7
^ permalink raw reply related [flat|nested] 30+ messages in thread
* Re: [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
2011-10-12 7:45 ` [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input Martin Jansa
@ 2011-10-12 8:02 ` Eric Bénard
2011-10-12 9:20 ` Koen Kooi
2011-10-12 18:10 ` Simon Busch
0 siblings, 2 replies; 30+ messages in thread
From: Eric Bénard @ 2011-10-12 8:02 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: Martin Jansa
Hi,
Le 12/10/2011 09:45, Martin Jansa a écrit :
> From: Simon Busch<morphis@gravedo.de>
>
> In most cases we don't need tslib in std. configuration as touchscreen access in most
> devices today is done with linux input interface. If some specific machine has a need for
> tslib support it should add the dependency in it's machine layer again and modify the
> profile script accordingly.
>
When using a resistive touchscreen, tslib is a common solution to handle
calibration and raw value processing : do you think this is a good thing to
remove this ?
Eric
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
2011-10-12 8:02 ` Eric Bénard
@ 2011-10-12 9:20 ` Koen Kooi
2011-10-12 19:04 ` Chris Larson
2011-10-12 18:10 ` Simon Busch
1 sibling, 1 reply; 30+ messages in thread
From: Koen Kooi @ 2011-10-12 9:20 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: Martin Jansa
Op 12 okt. 2011, om 10:02 heeft Eric Bénard het volgende geschreven:
> Hi,
>
> Le 12/10/2011 09:45, Martin Jansa a écrit :
>> From: Simon Busch<morphis@gravedo.de>
>>
>> In most cases we don't need tslib in std. configuration as touchscreen access in most
>> devices today is done with linux input interface. If some specific machine has a need for
>> tslib support it should add the dependency in it's machine layer again and modify the
>> profile script accordingly.
>>
> When using a resistive touchscreen, tslib is a common solution to handle calibration and raw value processing : do you think this is a good thing to remove this ?
We ran into this at work and like Eric, I'm curious how calibration (and e.g. dejitter) works in the linux-input world combined with qt/e.
regards,
Koen
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [oe-core 2/4] qt4-x11-free: bring back pkg-config fixups
2011-10-12 7:45 ` [oe-core 2/4] qt4-x11-free: bring back pkg-config fixups Martin Jansa
@ 2011-10-12 9:23 ` Paul Eggleton
2011-10-12 18:05 ` Simon Busch
0 siblings, 1 reply; 30+ messages in thread
From: Paul Eggleton @ 2011-10-12 9:23 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: Martin Jansa
On Wednesday 12 October 2011 08:45:03 Martin Jansa wrote:
> From: Simon Busch <morphis@gravedo.de>
>
> With b40b9c024be5e1ec81a31961158b3e6b529acfe0 some pkg-config fixups where
> removed from qt4.inc which breaks the pkg-config files for qt4-embedded.
> Without that the pkg-config files for qt4-x11-free are broken. So this
> patch puts the fixes into the qt4-x11-free.inc file to be used by
> qt4-x11-free and not qt4-embedded.
So why do we need these only in the X11 version? Surely they should be
applicable to both embedded and X11, or not at all...?
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [oe-core 2/4] qt4-x11-free: bring back pkg-config fixups
2011-10-12 9:23 ` Paul Eggleton
@ 2011-10-12 18:05 ` Simon Busch
2011-10-19 19:02 ` Simon Busch
0 siblings, 1 reply; 30+ messages in thread
From: Simon Busch @ 2011-10-12 18:05 UTC (permalink / raw)
To: Paul Eggleton
Cc: Martin Jansa, Patches and discussions about the oe-core layer
On 12.10.2011 11:23, Paul Eggleton wrote:
> On Wednesday 12 October 2011 08:45:03 Martin Jansa wrote:
>> From: Simon Busch <morphis@gravedo.de>
>>
>> With b40b9c024be5e1ec81a31961158b3e6b529acfe0 some pkg-config fixups where
>> removed from qt4.inc which breaks the pkg-config files for qt4-embedded.
>> Without that the pkg-config files for qt4-x11-free are broken. So this
>> patch puts the fixes into the qt4-x11-free.inc file to be used by
>> qt4-x11-free and not qt4-embedded.
>
> So why do we need these only in the X11 version? Surely they should be
> applicable to both embedded and X11, or not at all...?
With b40b9c024be5e1ec81a31961158b3e6b529acfe0 I removed this fixups from
qt4.inc as I had problems with building agains qt4-embedded as cflags
were incorrect in the created pkg-config files.
Now I switched my application to x11 and got other problems with the
pkg-config files from qt4-x11-free which can be resolved with the fixups
I removed before.
So you are right we need them for qt4-x11-free but not for qt4-embedded.
I didn't investigated from where these differences are coming.
regards,
Simon
--
Simon Busch - http://mm.gravedo.de/blog/
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
2011-10-12 8:02 ` Eric Bénard
2011-10-12 9:20 ` Koen Kooi
@ 2011-10-12 18:10 ` Simon Busch
2011-10-12 18:14 ` Koen Kooi
2011-10-12 19:22 ` Eric Bénard
1 sibling, 2 replies; 30+ messages in thread
From: Simon Busch @ 2011-10-12 18:10 UTC (permalink / raw)
To: Eric Bénard
Cc: Martin Jansa, Patches and discussions about the oe-core layer
On 12.10.2011 10:02, Eric Bénard wrote:
> Hi,
>
> Le 12/10/2011 09:45, Martin Jansa a écrit :
>> From: Simon Busch<morphis@gravedo.de>
>>
>> In most cases we don't need tslib in std. configuration as touchscreen
>> access in most
>> devices today is done with linux input interface. If some specific
>> machine has a need for
>> tslib support it should add the dependency in it's machine layer again
>> and modify the
>> profile script accordingly.
>>
> When using a resistive touchscreen, tslib is a common solution to handle
> calibration and raw value processing : do you think this is a good thing
> to remove this ?
Thats up to the environment you are using qt4-embedded in. In my case
the setup is a little bit more complicated. We're using tslib but not
directly in qt4-embedded (we can get rid of tslib completely but time is
missing).
I removed the dependency from qt4-embedded as qt4-embedded in oe-core
should be the general thing used in all environments and therefore
should be only a minimal setup with minimal dependencies.
If someone needs tslib for qt4-embedded for his machine layer he should
include tslib support in the machine layer itself.
regards,
Simon
--
Simon Busch - http://mm.gravedo.de/blog/
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
2011-10-12 18:10 ` Simon Busch
@ 2011-10-12 18:14 ` Koen Kooi
2011-10-12 18:34 ` Simon Busch
2011-10-12 19:22 ` Eric Bénard
1 sibling, 1 reply; 30+ messages in thread
From: Koen Kooi @ 2011-10-12 18:14 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
Cc: Martin Jansa, Patches and discussions about the oe-core layer
Op 12 okt. 2011 om 20:10 heeft Simon Busch <morphis@gravedo.de> het volgende geschreven:
> On 12.10.2011 10:02, Eric Bénard wrote:
>> Hi,
>>
>> Le 12/10/2011 09:45, Martin Jansa a écrit :
>>> From: Simon Busch<morphis@gravedo.de>
>>>
>>> In most cases we don't need tslib in std. configuration as touchscreen
>>> access in most
>>> devices today is done with linux input interface. If some specific
>>> machine has a need for
>>> tslib support it should add the dependency in it's machine layer again
>>> and modify the
>>> profile script accordingly.
>>>
>> When using a resistive touchscreen, tslib is a common solution to handle
>> calibration and raw value processing : do you think this is a good thing
>> to remove this ?
>
> Thats up to the environment you are using qt4-embedded in. In my case
> the setup is a little bit more complicated. We're using tslib but not
> directly in qt4-embedded (we can get rid of tslib completely but time is
> missing).
>
> I removed the dependency from qt4-embedded as qt4-embedded in oe-core
> should be the general thing used in all environments and therefore
> should be only a minimal setup with minimal dependencies.
No, it should work in most cases, breaking qt:e like is not acceptable.
>
> If someone needs tslib for qt4-embedded for his machine layer he should
> include tslib support in the machine layer itself.
>
> regards,
> Simon
>
> --
> Simon Busch - http://mm.gravedo.de/blog/
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
2011-10-12 18:14 ` Koen Kooi
@ 2011-10-12 18:34 ` Simon Busch
2011-10-12 19:09 ` Koen Kooi
0 siblings, 1 reply; 30+ messages in thread
From: Simon Busch @ 2011-10-12 18:34 UTC (permalink / raw)
To: openembedded-core
On 12.10.2011 20:14, Koen Kooi wrote:
>
>
> Op 12 okt. 2011 om 20:10 heeft Simon Busch <morphis@gravedo.de> het volgende geschreven:
>
>> On 12.10.2011 10:02, Eric Bénard wrote:
>>> Hi,
>>>
>>> Le 12/10/2011 09:45, Martin Jansa a écrit :
>>>> From: Simon Busch<morphis@gravedo.de>
>>>>
>>>> In most cases we don't need tslib in std. configuration as touchscreen
>>>> access in most
>>>> devices today is done with linux input interface. If some specific
>>>> machine has a need for
>>>> tslib support it should add the dependency in it's machine layer again
>>>> and modify the
>>>> profile script accordingly.
>>>>
>>> When using a resistive touchscreen, tslib is a common solution to handle
>>> calibration and raw value processing : do you think this is a good thing
>>> to remove this ?
>>
>> Thats up to the environment you are using qt4-embedded in. In my case
>> the setup is a little bit more complicated. We're using tslib but not
>> directly in qt4-embedded (we can get rid of tslib completely but time is
>> missing).
>>
>> I removed the dependency from qt4-embedded as qt4-embedded in oe-core
>> should be the general thing used in all environments and therefore
>> should be only a minimal setup with minimal dependencies.
>
> No, it should work in most cases, breaking qt:e like is not acceptable.
What is breaking qt:e in this case? For me it's just a feature reduction
and not a break (as qt:e still works fine with the linux input interface).
--
Simon Busch - http://mm.gravedo.de/blog/
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
2011-10-12 9:20 ` Koen Kooi
@ 2011-10-12 19:04 ` Chris Larson
0 siblings, 0 replies; 30+ messages in thread
From: Chris Larson @ 2011-10-12 19:04 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: Martin Jansa
On Wed, Oct 12, 2011 at 2:20 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
> Op 12 okt. 2011, om 10:02 heeft Eric Bénard het volgende geschreven:
>
>> Hi,
>>
>> Le 12/10/2011 09:45, Martin Jansa a écrit :
>>> From: Simon Busch<morphis@gravedo.de>
>>>
>>> In most cases we don't need tslib in std. configuration as touchscreen access in most
>>> devices today is done with linux input interface. If some specific machine has a need for
>>> tslib support it should add the dependency in it's machine layer again and modify the
>>> profile script accordingly.
>>>
>> When using a resistive touchscreen, tslib is a common solution to handle calibration and raw value processing : do you think this is a good thing to remove this ?
>
> We ran into this at work and like Eric, I'm curious how calibration (and e.g. dejitter) works in the linux-input world combined with qt/e.
Not directly applicable, but I keep meaning to take a look at
http://atrey.karlin.mff.cuni.cz/~metan/evfilter/ - it seems quite
interesting.
--
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
2011-10-12 18:34 ` Simon Busch
@ 2011-10-12 19:09 ` Koen Kooi
2011-10-12 19:24 ` Simon Busch
0 siblings, 1 reply; 30+ messages in thread
From: Koen Kooi @ 2011-10-12 19:09 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
Op 12 okt. 2011, om 20:34 heeft Simon Busch het volgende geschreven:
> On 12.10.2011 20:14, Koen Kooi wrote:
>>
>>
>> Op 12 okt. 2011 om 20:10 heeft Simon Busch <morphis@gravedo.de> het volgende geschreven:
>>
>>> On 12.10.2011 10:02, Eric Bénard wrote:
>>>> Hi,
>>>>
>>>> Le 12/10/2011 09:45, Martin Jansa a écrit :
>>>>> From: Simon Busch<morphis@gravedo.de>
>>>>>
>>>>> In most cases we don't need tslib in std. configuration as touchscreen
>>>>> access in most
>>>>> devices today is done with linux input interface. If some specific
>>>>> machine has a need for
>>>>> tslib support it should add the dependency in it's machine layer again
>>>>> and modify the
>>>>> profile script accordingly.
>>>>>
>>>> When using a resistive touchscreen, tslib is a common solution to handle
>>>> calibration and raw value processing : do you think this is a good thing
>>>> to remove this ?
>>>
>>> Thats up to the environment you are using qt4-embedded in. In my case
>>> the setup is a little bit more complicated. We're using tslib but not
>>> directly in qt4-embedded (we can get rid of tslib completely but time is
>>> missing).
>>>
>>> I removed the dependency from qt4-embedded as qt4-embedded in oe-core
>>> should be the general thing used in all environments and therefore
>>> should be only a minimal setup with minimal dependencies.
>>
>> No, it should work in most cases, breaking qt:e like is not acceptable.
>
> What is breaking qt:e in this case? For me it's just a feature reduction
> and not a break (as qt:e still works fine with the linux input interface).
When your TS is suddenly uncalibrated and jittery, it's a breakage, not a feature reduction.
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
2011-10-12 18:10 ` Simon Busch
2011-10-12 18:14 ` Koen Kooi
@ 2011-10-12 19:22 ` Eric Bénard
1 sibling, 0 replies; 30+ messages in thread
From: Eric Bénard @ 2011-10-12 19:22 UTC (permalink / raw)
To: Simon Busch
Cc: Koen Kooi, Martin Jansa,
Patches and discussions about the oe-core layer
Hi,
Le 12/10/2011 20:10, Simon Busch a écrit :
> On 12.10.2011 10:02, Eric Bénard wrote:
>> Le 12/10/2011 09:45, Martin Jansa a écrit :
>>> From: Simon Busch<morphis@gravedo.de>
>>>
>>> In most cases we don't need tslib in std. configuration as touchscreen
>>> access in most
>>> devices today is done with linux input interface. If some specific
>>> machine has a need for
>>> tslib support it should add the dependency in it's machine layer again
>>> and modify the
>>> profile script accordingly.
>>>
>> When using a resistive touchscreen, tslib is a common solution to handle
>> calibration and raw value processing : do you think this is a good thing
>> to remove this ?
>
> Thats up to the environment you are using qt4-embedded in. In my case
> the setup is a little bit more complicated. We're using tslib but not
> directly in qt4-embedded (we can get rid of tslib completely but time is
> missing).
>
> I removed the dependency from qt4-embedded as qt4-embedded in oe-core
> should be the general thing used in all environments and therefore
> should be only a minimal setup with minimal dependencies.
>
> If someone needs tslib for qt4-embedded for his machine layer he should
> include tslib support in the machine layer itself.
>
removing tslib plugin in qt4e seems not the good solution as this plugin can
be built but not installed by default.
In my opinion that's only the qte.sh script which could be more generic and
maybe could be in its own configuration package so that several machines can
share the same qt4e packages (picking the plugins they need) and have their
own qte-config (for example) package.
Else, why don't you akso remove plugin-gfx-transformed which is not used be
many machines, or plugin-gfx-vnc or plugin-gfx-directfb which is only used on
machine needing directfb or plugin-gfx-qvfb as real machine don't need a
virtual framebuffer or even qt-mouse-pc as you may think that pc with mouses
don't need qtembedded ... in the end we may also notice that basic platforms
can use qt without a display, so why not removing graphic support at all to
make the think even more generic and reduce the number of dependencies ;-)
Eric
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
2011-10-12 19:09 ` Koen Kooi
@ 2011-10-12 19:24 ` Simon Busch
2011-10-12 19:29 ` Simon Busch
2011-10-12 19:41 ` Chris Larson
0 siblings, 2 replies; 30+ messages in thread
From: Simon Busch @ 2011-10-12 19:24 UTC (permalink / raw)
To: openembedded-core
On 12.10.2011 21:09, Koen Kooi wrote:
>> What is breaking qt:e in this case? For me it's just a feature reduction
>> and not a break (as qt:e still works fine with the linux input interface).
>
> When your TS is suddenly uncalibrated and jittery, it's a breakage, not a feature reduction.
You're talking here about one case where tslib is needed to get a
working touchscreen. But there are even cases where tslib is not needed
to get a working touchscreen.
qt:e does not strongly depends on tslib, it can work without. So if you
need it you should add it to your machine layer as it is really machine
specific if you need tslib or not.
regards,
Simon
--
Simon Busch - http://mm.gravedo.de/blog/
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
2011-10-12 19:24 ` Simon Busch
@ 2011-10-12 19:29 ` Simon Busch
2011-10-12 19:52 ` Simon Busch
2011-10-12 19:41 ` Chris Larson
1 sibling, 1 reply; 30+ messages in thread
From: Simon Busch @ 2011-10-12 19:29 UTC (permalink / raw)
To: openembedded-core
On 12.10.2011 21:24, Simon Busch wrote:
> On 12.10.2011 21:09, Koen Kooi wrote:
>>> What is breaking qt:e in this case? For me it's just a feature reduction
>>> and not a break (as qt:e still works fine with the linux input interface).
>>
>> When your TS is suddenly uncalibrated and jittery, it's a breakage, not a feature reduction.
>
> You're talking here about one case where tslib is needed to get a
> working touchscreen. But there are even cases where tslib is not needed
> to get a working touchscreen.
>
> qt:e does not strongly depends on tslib, it can work without. So if you
> need it you should add it to your machine layer as it is really machine
> specific if you need tslib or not.
Eric brings it to the point, only resetting the qte.sh script to a
default one which uses a linux input even node should be enough.
--
Simon Busch - http://mm.gravedo.de/blog/
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
2011-10-12 19:24 ` Simon Busch
2011-10-12 19:29 ` Simon Busch
@ 2011-10-12 19:41 ` Chris Larson
1 sibling, 0 replies; 30+ messages in thread
From: Chris Larson @ 2011-10-12 19:41 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Wed, Oct 12, 2011 at 12:24 PM, Simon Busch <morphis@gravedo.de> wrote:
> On 12.10.2011 21:09, Koen Kooi wrote:
>>> What is breaking qt:e in this case? For me it's just a feature reduction
>>> and not a break (as qt:e still works fine with the linux input interface).
>>
>> When your TS is suddenly uncalibrated and jittery, it's a breakage, not a feature reduction.
>
> You're talking here about one case where tslib is needed to get a
> working touchscreen. But there are even cases where tslib is not needed
> to get a working touchscreen.
The base should be the bare min necessary to function in the common
case, in my opinion. Touchscreens that don't require calibration are
few and far between, so making the majority of machines with
touchscreens have to override it seems far from ideal.
--
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
2011-10-12 19:29 ` Simon Busch
@ 2011-10-12 19:52 ` Simon Busch
2011-10-12 20:09 ` Eric Bénard
0 siblings, 1 reply; 30+ messages in thread
From: Simon Busch @ 2011-10-12 19:52 UTC (permalink / raw)
To: openembedded-core
On 12.10.2011 21:29, Simon Busch wrote:
> On 12.10.2011 21:24, Simon Busch wrote:
>> On 12.10.2011 21:09, Koen Kooi wrote:
>>>> What is breaking qt:e in this case? For me it's just a feature reduction
>>>> and not a break (as qt:e still works fine with the linux input interface).
>>>
>>> When your TS is suddenly uncalibrated and jittery, it's a breakage, not a feature reduction.
>>
>> You're talking here about one case where tslib is needed to get a
>> working touchscreen. But there are even cases where tslib is not needed
>> to get a working touchscreen.
>>
>> qt:e does not strongly depends on tslib, it can work without. So if you
>> need it you should add it to your machine layer as it is really machine
>> specific if you need tslib or not.
>
> Eric brings it to the point, only resetting the qte.sh script to a
> default one which uses a linux input even node should be enough.
Sorry for my little generic trip ... :)
I will provide another patch in the following days which just makes
qte.sh use of a std. linux input dev node instead of a tslib one if
nobody has any objections against this.
regards,
Simon
--
Simon Busch - http://mm.gravedo.de/blog/
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
2011-10-12 19:52 ` Simon Busch
@ 2011-10-12 20:09 ` Eric Bénard
0 siblings, 0 replies; 30+ messages in thread
From: Eric Bénard @ 2011-10-12 20:09 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
Hi,
Le 12/10/2011 21:52, Simon Busch a écrit :
> I will provide another patch in the following days which just makes
> qte.sh use of a std. linux input dev node instead of a tslib one if
> nobody has any objections against this.
>
maybe moving qt4-embedded-conf in its own recipe would be better : that would
allow qte.sh customization without having to rebuild qt4-embedded.
Then you could have qte.sh with linux input in your machine's overlay and
could keep the default qte.sh as it actually is in oe-core.
Also, does defaulting to linux input dev works in qemu machines (for example
with qt4e-demo-image ?
Eric
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [oe-core 3/4] conf: machine: includes: add armv6-novfp support
2011-10-12 7:45 ` [oe-core 3/4] conf: machine: includes: add armv6-novfp support Martin Jansa
@ 2011-10-12 21:26 ` Phil Blundell
2011-10-13 10:49 ` Denis 'GNUtoo' Carikli
0 siblings, 1 reply; 30+ messages in thread
From: Phil Blundell @ 2011-10-12 21:26 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Wed, 2011-10-12 at 09:45 +0200, Martin Jansa wrote:
>-TUNE_FEATURES_tune-armv6 ?= "armv6 vfp"
<-TUNE_FEATURES_tune-armv6t ?= "armv6 vfp thumb"
> +AVAILTUNES += "armv6 armv6t"
> +TUNE_FEATURES_tune-armv6 ?= "armv6"
> +TUNE_FEATURES_tune-armv6t ?= "armv6 thumb"
> +PACKAGE_EXTRA_ARCHS_tune-armv6 = "${PACKAGE_EXTRA_ARCHS_tune-armv5} armv6"
> +PACKAGE_EXTRA_ARCHS_tune-armv6t = "${PACKAGE_EXTRA_ARCHS_tune-armv5t} armv6 armv6t"
> +
> +# Little Endian + VFP
> +AVAILTUNES += "armv6-vfp armv6t-vfp armv6hf-vfp armv6thf-vfp"
> +TUNE_FEATURES_tune-armv6-vfp ?= "armv6 vfp"
This patch doesn't seem to do what it says in the subject line. It
doesn't add an "armv6-novfp" tune, instead it removes vfp from the
existing armv6 and armv6t tunes.
p.
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [oe-core 3/4] conf: machine: includes: add armv6-novfp support
2011-10-12 21:26 ` Phil Blundell
@ 2011-10-13 10:49 ` Denis 'GNUtoo' Carikli
2011-10-13 19:42 ` Phil Blundell
0 siblings, 1 reply; 30+ messages in thread
From: Denis 'GNUtoo' Carikli @ 2011-10-13 10:49 UTC (permalink / raw)
To: openembedded-core; +Cc: Phil Blundell
>This patch doesn't seem to do what it says in the subject line. It
>doesn't add an "armv6-novfp" tune, instead it removes vfp from the
>existing armv6 and armv6t tunes.
yes that's what it does,but it also adds an armv6-vfp.
The commit message is wrong, sorry.
by the way is the content ok? or should I re-do the content too(if so I would
need some indications of what the right way is)?
Denis.
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [oe-core 3/4] conf: machine: includes: add armv6-novfp support
2011-10-13 10:49 ` Denis 'GNUtoo' Carikli
@ 2011-10-13 19:42 ` Phil Blundell
2011-12-21 19:48 ` [PATCH] " vquicksilver
2011-12-21 22:16 ` [PATCH v2] " Víctor Enríquez
0 siblings, 2 replies; 30+ messages in thread
From: Phil Blundell @ 2011-10-13 19:42 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Thu, 2011-10-13 at 12:49 +0200, Denis 'GNUtoo' Carikli wrote:
> >This patch doesn't seem to do what it says in the subject line. It
> >doesn't add an "armv6-novfp" tune, instead it removes vfp from the
> >existing armv6 and armv6t tunes.
> yes that's what it does,but it also adds an armv6-vfp.
> The commit message is wrong, sorry.
>
> by the way is the content ok? or should I re-do the content too(if so I would
> need some indications of what the right way is)?
Well, if it were up to me, I would prefer to leave armv6 and armv6t
alone and (as the subject line implied this patch was going to) add new
tunes for the non-vfp variants of them. Otherwise everybody who is
currently using armv6 is liable to get a nasty surprise when the meaning
suddenly changes underneath them.
p.
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [oe-core 2/4] qt4-x11-free: bring back pkg-config fixups
2011-10-12 18:05 ` Simon Busch
@ 2011-10-19 19:02 ` Simon Busch
0 siblings, 0 replies; 30+ messages in thread
From: Simon Busch @ 2011-10-19 19:02 UTC (permalink / raw)
To: openembedded-core
On 12.10.2011 20:05, Simon Busch wrote:
> On 12.10.2011 11:23, Paul Eggleton wrote:
>> On Wednesday 12 October 2011 08:45:03 Martin Jansa wrote:
>>> From: Simon Busch <morphis@gravedo.de>
>>>
>>> With b40b9c024be5e1ec81a31961158b3e6b529acfe0 some pkg-config fixups where
>>> removed from qt4.inc which breaks the pkg-config files for qt4-embedded.
>>> Without that the pkg-config files for qt4-x11-free are broken. So this
>>> patch puts the fixes into the qt4-x11-free.inc file to be used by
>>> qt4-x11-free and not qt4-embedded.
>>
>> So why do we need these only in the X11 version? Surely they should be
>> applicable to both embedded and X11, or not at all...?
>
> With b40b9c024be5e1ec81a31961158b3e6b529acfe0 I removed this fixups from
> qt4.inc as I had problems with building agains qt4-embedded as cflags
> were incorrect in the created pkg-config files.
>
> Now I switched my application to x11 and got other problems with the
> pkg-config files from qt4-x11-free which can be resolved with the fixups
> I removed before.
>
> So you are right we need them for qt4-x11-free but not for qt4-embedded.
> I didn't investigated from where these differences are coming.
>
> regards,
> Simon
>
Still any comments on this or is the patch already accepted?
regards,
Simon
--
Simon Busch - http://mm.gravedo.de/blog/
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH] conf: machine: includes: add armv6-novfp support
2011-10-13 19:42 ` Phil Blundell
@ 2011-12-21 19:48 ` vquicksilver
2011-12-21 19:57 ` Mark Hatle
2011-12-21 20:06 ` Otavio Salvador
2011-12-21 22:16 ` [PATCH v2] " Víctor Enríquez
1 sibling, 2 replies; 30+ messages in thread
From: vquicksilver @ 2011-12-21 19:48 UTC (permalink / raw)
To: openembedded-core, philb, GNUtoo
This work was made by Victor Enriquez and then modified by
Denis Carikli who was helped by Mark Hatle comments( who is
fray on #yocto channel on Freenode ).
The changes are for adding support to armv6-novfp, forbuilding
binaries for armv6 machines without vfp, for examplethe htcdream.
Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
Signed-off-by: vquicksilver <victor.quicksilver@gmail.com>
---
meta/conf/machine/include/arm/arch-armv6.inc | 31 +++++++++++++--------
meta/conf/machine/include/arm/feature-arm-vfp.inc | 4 ++-
2 files changed, 22 insertions(+), 13 deletions(-)
diff --git a/meta/conf/machine/include/arm/arch-armv6.inc b/meta/conf/machine/include/arm/arch-armv6.inc
index da8274e..3396c69 100644
--- a/meta/conf/machine/include/arm/arch-armv6.inc
+++ b/meta/conf/machine/include/arm/arch-armv6.inc
@@ -1,33 +1,40 @@
DEFAULTTUNE ?= "armv6"
-ARMPKGARCH ?= "armv6"
+ARMPKGARCH := "armv6"
TUNEVALID[armv6] = "Enable instructions for ARMv6"
TUNE_CONFLICTS[armv6] = "armv4 armv5"
TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "armv6", "-march=armv6", "", d)}"
-MACHINEOVERRIDES .= "${@bb.utils.contains("TUNE_FEATURES", "armv6", ":armv6", "" ,d)}"
require conf/machine/include/arm/arch-armv5-dsp.inc
# Little Endian
-AVAILTUNES += "armv6 armv6t armv6hf armv6thf"
+AVAILTUNES += "armv6-novfp armv6 armv6t armv6t-novfp armv6hf armv6thf"
+TUNE_FEATURES_tune-armv6-novfp ?= "armv6"
TUNE_FEATURES_tune-armv6 ?= "armv6 vfp"
+TUNE_FEATURES_tune-armv6t-novfp ?= "armv6 thumb"
TUNE_FEATURES_tune-armv6t ?= "armv6 vfp thumb"
TUNE_FEATURES_tune-armv6hf ?= "${TUNE_FEATURES_tune-armv6} callconvention-hard"
TUNE_FEATURES_tune-armv6thf ?= "${TUNE_FEATURES_tune-armv6t} callconvention-hard"
-PACKAGE_EXTRA_ARCHS_tune-armv6 = "${PACKAGE_EXTRA_ARCHS_tune-armv5e-vfp} armv6-vfp"
-PACKAGE_EXTRA_ARCHS_tune-armv6t = "${PACKAGE_EXTRA_ARCHS_tune-armv5te-vfp} armv6-vfp armv6t-vfp"
-PACKAGE_EXTRA_ARCHS_tune-armv6hf = "${PACKAGE_EXTRA_ARCHS_tune-armv5ehf-vfp} armv6hf-vfp"
-PACKAGE_EXTRA_ARCHS_tune-armv6thf = "${PACKAGE_EXTRA_ARCHS_tune-armv5tehf-vfp} armv6hf-vfp armv6thf-vfp"
+PACKAGE_EXTRA_ARCHS_tune-armv6-novfp = "${PACKAGE_EXTRA_ARCHS_tune-armv5e} armv6-novfp"
+PACKAGE_EXTRA_ARCHS_tune-armv6 = "${PACKAGE_EXTRA_ARCHS_tune-armv5e-vfp} armv6-novfp armv6"
+PACKAGE_EXTRA_ARCHS_tune-armv6t-novfp = "${PACKAGE_EXTRA_ARCHS_tune-armv5e} armv6-novfp armv6t-novfp"
+PACKAGE_EXTRA_ARCHS_tune-armv6t = "${PACKAGE_EXTRA_ARCHS_tune-armv5te-vfp} armv6-novfp armv6t-novfp armv6-vfp armv6t"
+PACKAGE_EXTRA_ARCHS_tune-armv6hf = "${PACKAGE_EXTRA_ARCHS_tune-armv5ehf-vfp} armv6hf"
+PACKAGE_EXTRA_ARCHS_tune-armv6thf = "${PACKAGE_EXTRA_ARCHS_tune-armv5tehf-vfp} armv6hf-vfp armv6thf"
# Big Endian
-AVAILTUNES += "armv6b armv6tb armv6hfb armv6thfb"
+AVAILTUNES += "armv6b-novfp armv6b armv6tb-novfp armv6tb armv6hfb armv6thfb"
+TUNE_FEATURES_tune-armv6b-novfp ?= "${TUNE_FEATURES_tune-armv6-novfp} bigendian"
TUNE_FEATURES_tune-armv6b ?= "${TUNE_FEATURES_tune-armv6} bigendian"
+TUNE_FEATURES_tune-armv6tb-novfp ?= "${TUNE_FEATURES_tune-armv6t-novfp} bigendian"
TUNE_FEATURES_tune-armv6tb ?= "${TUNE_FEATURES_tune-armv6t} bigendian"
TUNE_FEATURES_tune-armv6hfb ?= "${TUNE_FEATURES_tune-armv6b} callconvention-hard"
TUNE_FEATURES_tune-armv6thfb ?= "${TUNE_FEATURES_tune-armv6tb} callconvention-hard"
-PACKAGE_EXTRA_ARCHS_tune-armv6b = "${PACKAGE_EXTRA_ARCHS_tune-armv5eb-vfp} armv6b-vfp"
-PACKAGE_EXTRA_ARCHS_tune-armv6tb = "${PACKAGE_EXTRA_ARCHS_tune-armv5teb-vfp} armv6b-vfp armv6tb-vfp"
-PACKAGE_EXTRA_ARCHS_tune-armv6hfb = "${PACKAGE_EXTRA_ARCHS_tune-armv5ehfb-vfp} armv6hfb-vfp"
-PACKAGE_EXTRA_ARCHS_tune-armv6thfb = "${PACKAGE_EXTRA_ARCHS_tune-armv5tehfb-vfp} armv6hfb-vfp armv6thfb-vfp"
+PACKAGE_EXTRA_ARCHS_tune-armv6b-novfp = "${PACKAGE_EXTRA_ARCHS_tune-armv5eb} armv6b-novfp"
+PACKAGE_EXTRA_ARCHS_tune-armv6b = "${PACKAGE_EXTRA_ARCHS_tune-armv5eb-vfp} armv6b"
+PACKAGE_EXTRA_ARCHS_tune-armv6tb-novfp = "${PACKAGE_EXTRA_ARCHS_tune-armv5eb} armv6b-novfp armv6tb-novfp"
+PACKAGE_EXTRA_ARCHS_tune-armv6tb = "${PACKAGE_EXTRA_ARCHS_tune-armv5teb-vfp} armv6b-novfp armv6tb-novfp armv6b-vfp armv6tb"
+PACKAGE_EXTRA_ARCHS_tune-armv6hfb = "${PACKAGE_EXTRA_ARCHS_tune-armv5ehfb-vfp} armv6hfb"
+PACKAGE_EXTRA_ARCHS_tune-armv6thfb = "${PACKAGE_EXTRA_ARCHS_tune-armv5tehfb-vfp} armv6hfb-vfp armv6thfb"
diff --git a/meta/conf/machine/include/arm/feature-arm-vfp.inc b/meta/conf/machine/include/arm/feature-arm-vfp.inc
index 29a925c..78f453c 100644
--- a/meta/conf/machine/include/arm/feature-arm-vfp.inc
+++ b/meta/conf/machine/include/arm/feature-arm-vfp.inc
@@ -1,5 +1,7 @@
TUNEVALID[vfp] = "Enable Vector Floating Point (vfp) unit."
-ARMPKGSFX_FPU .= "${@bb.utils.contains("TUNE_FEATURES", "vfp", "-vfp", "" ,d)}"
+TUNE_ARM_VFP = "${@bb.utils.contains("ARMPKGARCH", "armv6", "", "vfp" ,d)}"
+TUNE_ARM_NOVFP = "${@bb.utils.contains("ARMPKGARCH", "armv6", "-novfp", "" ,d)}"
+ARMPKGSFX_FPU .= "${@bb.utils.contains("TUNE_FEATURES", "vfp", "${TUNE_ARM_VFP}", "${TUNE_ARM_NOVFP}" ,d)}"
TUNEVALID[callconvention-hard] = "Enable EABI hard float call convention, requires VFP."
TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "vfp", bb.utils.contains("TUNE_FEATURES", "callconvention-hard", "-mfloat-abi=hard", "-mfloat-abi=softfp", d), "" ,d)}"
--
1.7.8
^ permalink raw reply related [flat|nested] 30+ messages in thread
* Re: [PATCH] conf: machine: includes: add armv6-novfp support
2011-12-21 19:48 ` [PATCH] " vquicksilver
@ 2011-12-21 19:57 ` Mark Hatle
2011-12-21 20:06 ` Otavio Salvador
1 sibling, 0 replies; 30+ messages in thread
From: Mark Hatle @ 2011-12-21 19:57 UTC (permalink / raw)
To: openembedded-core
On 12/21/11 1:48 PM, vquicksilver wrote:
> This work was made by Victor Enriquez and then modified by
> Denis Carikli who was helped by Mark Hatle comments( who is
> fray on #yocto channel on Freenode ).
>
> The changes are for adding support to armv6-novfp, forbuilding
> binaries for armv6 machines without vfp, for examplethe htcdream.
>
> Signed-off-by: Denis 'GNUtoo' Carikli<GNUtoo@no-log.org>
> Signed-off-by: vquicksilver<victor.quicksilver@gmail.com>
> ---
> meta/conf/machine/include/arm/arch-armv6.inc | 31 +++++++++++++--------
> meta/conf/machine/include/arm/feature-arm-vfp.inc | 4 ++-
> 2 files changed, 22 insertions(+), 13 deletions(-)
>
> diff --git a/meta/conf/machine/include/arm/arch-armv6.inc b/meta/conf/machine/include/arm/arch-armv6.inc
> index da8274e..3396c69 100644
> --- a/meta/conf/machine/include/arm/arch-armv6.inc
> +++ b/meta/conf/machine/include/arm/arch-armv6.inc
> @@ -1,33 +1,40 @@
> DEFAULTTUNE ?= "armv6"
>
> -ARMPKGARCH ?= "armv6"
> +ARMPKGARCH := "armv6"
The ?= is what is needed here. The ARMPKGARCH needs to be able to be
overwritten by other config files. (The order in which arch-armv6 and
potentially other arm archs are included by a machine matters...)
> TUNEVALID[armv6] = "Enable instructions for ARMv6"
> TUNE_CONFLICTS[armv6] = "armv4 armv5"
> TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "armv6", "-march=armv6", "", d)}"
> -MACHINEOVERRIDES .= "${@bb.utils.contains("TUNE_FEATURES", "armv6", ":armv6", "" ,d)}"
I believe the override is still needed as well. This allows someone to do armv6
specific options -- such as: OE_CONFIG_armv6 = "--cpu-config=armv6"
... I think everything else looks good..
--Mark
> require conf/machine/include/arm/arch-armv5-dsp.inc
>
> # Little Endian
> -AVAILTUNES += "armv6 armv6t armv6hf armv6thf"
> +AVAILTUNES += "armv6-novfp armv6 armv6t armv6t-novfp armv6hf armv6thf"
> +TUNE_FEATURES_tune-armv6-novfp ?= "armv6"
> TUNE_FEATURES_tune-armv6 ?= "armv6 vfp"
> +TUNE_FEATURES_tune-armv6t-novfp ?= "armv6 thumb"
> TUNE_FEATURES_tune-armv6t ?= "armv6 vfp thumb"
> TUNE_FEATURES_tune-armv6hf ?= "${TUNE_FEATURES_tune-armv6} callconvention-hard"
> TUNE_FEATURES_tune-armv6thf ?= "${TUNE_FEATURES_tune-armv6t} callconvention-hard"
> -PACKAGE_EXTRA_ARCHS_tune-armv6 = "${PACKAGE_EXTRA_ARCHS_tune-armv5e-vfp} armv6-vfp"
> -PACKAGE_EXTRA_ARCHS_tune-armv6t = "${PACKAGE_EXTRA_ARCHS_tune-armv5te-vfp} armv6-vfp armv6t-vfp"
> -PACKAGE_EXTRA_ARCHS_tune-armv6hf = "${PACKAGE_EXTRA_ARCHS_tune-armv5ehf-vfp} armv6hf-vfp"
> -PACKAGE_EXTRA_ARCHS_tune-armv6thf = "${PACKAGE_EXTRA_ARCHS_tune-armv5tehf-vfp} armv6hf-vfp armv6thf-vfp"
> +PACKAGE_EXTRA_ARCHS_tune-armv6-novfp = "${PACKAGE_EXTRA_ARCHS_tune-armv5e} armv6-novfp"
> +PACKAGE_EXTRA_ARCHS_tune-armv6 = "${PACKAGE_EXTRA_ARCHS_tune-armv5e-vfp} armv6-novfp armv6"
> +PACKAGE_EXTRA_ARCHS_tune-armv6t-novfp = "${PACKAGE_EXTRA_ARCHS_tune-armv5e} armv6-novfp armv6t-novfp"
> +PACKAGE_EXTRA_ARCHS_tune-armv6t = "${PACKAGE_EXTRA_ARCHS_tune-armv5te-vfp} armv6-novfp armv6t-novfp armv6-vfp armv6t"
> +PACKAGE_EXTRA_ARCHS_tune-armv6hf = "${PACKAGE_EXTRA_ARCHS_tune-armv5ehf-vfp} armv6hf"
> +PACKAGE_EXTRA_ARCHS_tune-armv6thf = "${PACKAGE_EXTRA_ARCHS_tune-armv5tehf-vfp} armv6hf-vfp armv6thf"
>
> # Big Endian
> -AVAILTUNES += "armv6b armv6tb armv6hfb armv6thfb"
> +AVAILTUNES += "armv6b-novfp armv6b armv6tb-novfp armv6tb armv6hfb armv6thfb"
> +TUNE_FEATURES_tune-armv6b-novfp ?= "${TUNE_FEATURES_tune-armv6-novfp} bigendian"
> TUNE_FEATURES_tune-armv6b ?= "${TUNE_FEATURES_tune-armv6} bigendian"
> +TUNE_FEATURES_tune-armv6tb-novfp ?= "${TUNE_FEATURES_tune-armv6t-novfp} bigendian"
> TUNE_FEATURES_tune-armv6tb ?= "${TUNE_FEATURES_tune-armv6t} bigendian"
> TUNE_FEATURES_tune-armv6hfb ?= "${TUNE_FEATURES_tune-armv6b} callconvention-hard"
> TUNE_FEATURES_tune-armv6thfb ?= "${TUNE_FEATURES_tune-armv6tb} callconvention-hard"
> -PACKAGE_EXTRA_ARCHS_tune-armv6b = "${PACKAGE_EXTRA_ARCHS_tune-armv5eb-vfp} armv6b-vfp"
> -PACKAGE_EXTRA_ARCHS_tune-armv6tb = "${PACKAGE_EXTRA_ARCHS_tune-armv5teb-vfp} armv6b-vfp armv6tb-vfp"
> -PACKAGE_EXTRA_ARCHS_tune-armv6hfb = "${PACKAGE_EXTRA_ARCHS_tune-armv5ehfb-vfp} armv6hfb-vfp"
> -PACKAGE_EXTRA_ARCHS_tune-armv6thfb = "${PACKAGE_EXTRA_ARCHS_tune-armv5tehfb-vfp} armv6hfb-vfp armv6thfb-vfp"
> +PACKAGE_EXTRA_ARCHS_tune-armv6b-novfp = "${PACKAGE_EXTRA_ARCHS_tune-armv5eb} armv6b-novfp"
> +PACKAGE_EXTRA_ARCHS_tune-armv6b = "${PACKAGE_EXTRA_ARCHS_tune-armv5eb-vfp} armv6b"
> +PACKAGE_EXTRA_ARCHS_tune-armv6tb-novfp = "${PACKAGE_EXTRA_ARCHS_tune-armv5eb} armv6b-novfp armv6tb-novfp"
> +PACKAGE_EXTRA_ARCHS_tune-armv6tb = "${PACKAGE_EXTRA_ARCHS_tune-armv5teb-vfp} armv6b-novfp armv6tb-novfp armv6b-vfp armv6tb"
> +PACKAGE_EXTRA_ARCHS_tune-armv6hfb = "${PACKAGE_EXTRA_ARCHS_tune-armv5ehfb-vfp} armv6hfb"
> +PACKAGE_EXTRA_ARCHS_tune-armv6thfb = "${PACKAGE_EXTRA_ARCHS_tune-armv5tehfb-vfp} armv6hfb-vfp armv6thfb"
>
> diff --git a/meta/conf/machine/include/arm/feature-arm-vfp.inc b/meta/conf/machine/include/arm/feature-arm-vfp.inc
> index 29a925c..78f453c 100644
> --- a/meta/conf/machine/include/arm/feature-arm-vfp.inc
> +++ b/meta/conf/machine/include/arm/feature-arm-vfp.inc
> @@ -1,5 +1,7 @@
> TUNEVALID[vfp] = "Enable Vector Floating Point (vfp) unit."
> -ARMPKGSFX_FPU .= "${@bb.utils.contains("TUNE_FEATURES", "vfp", "-vfp", "" ,d)}"
> +TUNE_ARM_VFP = "${@bb.utils.contains("ARMPKGARCH", "armv6", "", "vfp" ,d)}"
> +TUNE_ARM_NOVFP = "${@bb.utils.contains("ARMPKGARCH", "armv6", "-novfp", "" ,d)}"
> +ARMPKGSFX_FPU .= "${@bb.utils.contains("TUNE_FEATURES", "vfp", "${TUNE_ARM_VFP}", "${TUNE_ARM_NOVFP}" ,d)}"
>
> TUNEVALID[callconvention-hard] = "Enable EABI hard float call convention, requires VFP."
> TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "vfp", bb.utils.contains("TUNE_FEATURES", "callconvention-hard", "-mfloat-abi=hard", "-mfloat-abi=softfp", d), "" ,d)}"
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH] conf: machine: includes: add armv6-novfp support
2011-12-21 19:48 ` [PATCH] " vquicksilver
2011-12-21 19:57 ` Mark Hatle
@ 2011-12-21 20:06 ` Otavio Salvador
2011-12-21 20:12 ` Koen Kooi
1 sibling, 1 reply; 30+ messages in thread
From: Otavio Salvador @ 2011-12-21 20:06 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: philb
[-- Attachment #1: Type: text/plain, Size: 641 bytes --]
On Wed, Dec 21, 2011 at 17:48, vquicksilver <victor.quicksilver@gmail.com>wrote:
> This work was made by Victor Enriquez and then modified by
> Denis Carikli who was helped by Mark Hatle comments( who is
> fray on #yocto channel on Freenode ).
>
> The changes are for adding support to armv6-novfp, forbuilding
> binaries for armv6 machines without vfp, for examplethe htcdream.
Some typos on the commit log and missing spaces.
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
[-- Attachment #2: Type: text/html, Size: 1109 bytes --]
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH] conf: machine: includes: add armv6-novfp support
2011-12-21 20:06 ` Otavio Salvador
@ 2011-12-21 20:12 ` Koen Kooi
0 siblings, 0 replies; 30+ messages in thread
From: Koen Kooi @ 2011-12-21 20:12 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
Cc: philb@gnu.org, Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]
and a missing real name for the SOB
Op 21 dec. 2011 om 21:06 heeft Otavio Salvador <otavio@ossystems.com.br> het volgende geschreven:
> On Wed, Dec 21, 2011 at 17:48, vquicksilver <victor.quicksilver@gmail.com> wrote:
> This work was made by Victor Enriquez and then modified by
> Denis Carikli who was helped by Mark Hatle comments( who is
> fray on #yocto channel on Freenode ).
>
> The changes are for adding support to armv6-novfp, forbuilding
> binaries for armv6 machines without vfp, for examplethe htcdream.
>
> Some typos on the commit log and missing spaces.
>
> --
> Otavio Salvador O.S. Systems
> E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
> Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
[-- Attachment #2: Type: text/html, Size: 2005 bytes --]
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2] conf: machine: includes: add armv6-novfp support
2011-10-13 19:42 ` Phil Blundell
2011-12-21 19:48 ` [PATCH] " vquicksilver
@ 2011-12-21 22:16 ` Víctor Enríquez
2011-12-27 19:02 ` Saul Wold
1 sibling, 1 reply; 30+ messages in thread
From: Víctor Enríquez @ 2011-12-21 22:16 UTC (permalink / raw)
To: openembedded-core, philb, GNUtoo
This work was made by Victor Enriquez and then modified by Denis Carikli who was helped by Mark Hatle comments (who is fray on
#yocto channel on Freenode).
The changes are for adding support to armv6-novfp, for building binaries for armv6 machines without vfp, for example the htc
dream.
Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
Signed-off-by: Víctor Enríquez <victor.quicksilver@gmail.com>
---
meta/conf/machine/include/arm/arch-armv6.inc | 28 +++++++++++++-------
meta/conf/machine/include/arm/feature-arm-vfp.inc | 4 ++-
2 files changed, 21 insertions(+), 11 deletions(-)
diff --git a/meta/conf/machine/include/arm/arch-armv6.inc b/meta/conf/machine/include/arm/arch-armv6.inc
index da8274e..f9c112e 100644
--- a/meta/conf/machine/include/arm/arch-armv6.inc
+++ b/meta/conf/machine/include/arm/arch-armv6.inc
@@ -10,24 +10,32 @@ MACHINEOVERRIDES .= "${@bb.utils.contains("TUNE_FEATURES", "armv6", ":armv6", ""
require conf/machine/include/arm/arch-armv5-dsp.inc
# Little Endian
-AVAILTUNES += "armv6 armv6t armv6hf armv6thf"
+AVAILTUNES += "armv6-novfp armv6 armv6t armv6t-novfp armv6hf armv6thf"
+TUNE_FEATURES_tune-armv6-novfp ?= "armv6"
TUNE_FEATURES_tune-armv6 ?= "armv6 vfp"
+TUNE_FEATURES_tune-armv6t-novfp ?= "armv6 thumb"
TUNE_FEATURES_tune-armv6t ?= "armv6 vfp thumb"
TUNE_FEATURES_tune-armv6hf ?= "${TUNE_FEATURES_tune-armv6} callconvention-hard"
TUNE_FEATURES_tune-armv6thf ?= "${TUNE_FEATURES_tune-armv6t} callconvention-hard"
-PACKAGE_EXTRA_ARCHS_tune-armv6 = "${PACKAGE_EXTRA_ARCHS_tune-armv5e-vfp} armv6-vfp"
-PACKAGE_EXTRA_ARCHS_tune-armv6t = "${PACKAGE_EXTRA_ARCHS_tune-armv5te-vfp} armv6-vfp armv6t-vfp"
-PACKAGE_EXTRA_ARCHS_tune-armv6hf = "${PACKAGE_EXTRA_ARCHS_tune-armv5ehf-vfp} armv6hf-vfp"
-PACKAGE_EXTRA_ARCHS_tune-armv6thf = "${PACKAGE_EXTRA_ARCHS_tune-armv5tehf-vfp} armv6hf-vfp armv6thf-vfp"
+PACKAGE_EXTRA_ARCHS_tune-armv6-novfp = "${PACKAGE_EXTRA_ARCHS_tune-armv5e} armv6-novfp"
+PACKAGE_EXTRA_ARCHS_tune-armv6 = "${PACKAGE_EXTRA_ARCHS_tune-armv5e-vfp} armv6-novfp armv6"
+PACKAGE_EXTRA_ARCHS_tune-armv6t-novfp = "${PACKAGE_EXTRA_ARCHS_tune-armv5e} armv6-novfp armv6t-novfp"
+PACKAGE_EXTRA_ARCHS_tune-armv6t = "${PACKAGE_EXTRA_ARCHS_tune-armv5te-vfp} armv6-novfp armv6t-novfp armv6-vfp armv6t"
+PACKAGE_EXTRA_ARCHS_tune-armv6hf = "${PACKAGE_EXTRA_ARCHS_tune-armv5ehf-vfp} armv6hf"
+PACKAGE_EXTRA_ARCHS_tune-armv6thf = "${PACKAGE_EXTRA_ARCHS_tune-armv5tehf-vfp} armv6hf-vfp armv6thf"
# Big Endian
-AVAILTUNES += "armv6b armv6tb armv6hfb armv6thfb"
+AVAILTUNES += "armv6b-novfp armv6b armv6tb-novfp armv6tb armv6hfb armv6thfb"
+TUNE_FEATURES_tune-armv6b-novfp ?= "${TUNE_FEATURES_tune-armv6-novfp} bigendian"
TUNE_FEATURES_tune-armv6b ?= "${TUNE_FEATURES_tune-armv6} bigendian"
+TUNE_FEATURES_tune-armv6tb-novfp ?= "${TUNE_FEATURES_tune-armv6t-novfp} bigendian"
TUNE_FEATURES_tune-armv6tb ?= "${TUNE_FEATURES_tune-armv6t} bigendian"
TUNE_FEATURES_tune-armv6hfb ?= "${TUNE_FEATURES_tune-armv6b} callconvention-hard"
TUNE_FEATURES_tune-armv6thfb ?= "${TUNE_FEATURES_tune-armv6tb} callconvention-hard"
-PACKAGE_EXTRA_ARCHS_tune-armv6b = "${PACKAGE_EXTRA_ARCHS_tune-armv5eb-vfp} armv6b-vfp"
-PACKAGE_EXTRA_ARCHS_tune-armv6tb = "${PACKAGE_EXTRA_ARCHS_tune-armv5teb-vfp} armv6b-vfp armv6tb-vfp"
-PACKAGE_EXTRA_ARCHS_tune-armv6hfb = "${PACKAGE_EXTRA_ARCHS_tune-armv5ehfb-vfp} armv6hfb-vfp"
-PACKAGE_EXTRA_ARCHS_tune-armv6thfb = "${PACKAGE_EXTRA_ARCHS_tune-armv5tehfb-vfp} armv6hfb-vfp armv6thfb-vfp"
+PACKAGE_EXTRA_ARCHS_tune-armv6b-novfp = "${PACKAGE_EXTRA_ARCHS_tune-armv5eb} armv6b-novfp"
+PACKAGE_EXTRA_ARCHS_tune-armv6b = "${PACKAGE_EXTRA_ARCHS_tune-armv5eb-vfp} armv6b"
+PACKAGE_EXTRA_ARCHS_tune-armv6tb-novfp = "${PACKAGE_EXTRA_ARCHS_tune-armv5eb} armv6b-novfp armv6tb-novfp"
+PACKAGE_EXTRA_ARCHS_tune-armv6tb = "${PACKAGE_EXTRA_ARCHS_tune-armv5teb-vfp} armv6b-novfp armv6tb-novfp armv6b-vfp armv6tb"
+PACKAGE_EXTRA_ARCHS_tune-armv6hfb = "${PACKAGE_EXTRA_ARCHS_tune-armv5ehfb-vfp} armv6hfb"
+PACKAGE_EXTRA_ARCHS_tune-armv6thfb = "${PACKAGE_EXTRA_ARCHS_tune-armv5tehfb-vfp} armv6hfb-vfp armv6thfb"
diff --git a/meta/conf/machine/include/arm/feature-arm-vfp.inc b/meta/conf/machine/include/arm/feature-arm-vfp.inc
index 29a925c..78f453c 100644
--- a/meta/conf/machine/include/arm/feature-arm-vfp.inc
+++ b/meta/conf/machine/include/arm/feature-arm-vfp.inc
@@ -1,5 +1,7 @@
TUNEVALID[vfp] = "Enable Vector Floating Point (vfp) unit."
-ARMPKGSFX_FPU .= "${@bb.utils.contains("TUNE_FEATURES", "vfp", "-vfp", "" ,d)}"
+TUNE_ARM_VFP = "${@bb.utils.contains("ARMPKGARCH", "armv6", "", "vfp" ,d)}"
+TUNE_ARM_NOVFP = "${@bb.utils.contains("ARMPKGARCH", "armv6", "-novfp", "" ,d)}"
+ARMPKGSFX_FPU .= "${@bb.utils.contains("TUNE_FEATURES", "vfp", "${TUNE_ARM_VFP}", "${TUNE_ARM_NOVFP}" ,d)}"
TUNEVALID[callconvention-hard] = "Enable EABI hard float call convention, requires VFP."
TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "vfp", bb.utils.contains("TUNE_FEATURES", "callconvention-hard", "-mfloat-abi=hard", "-mfloat-abi=softfp", d), "" ,d)}"
--
1.7.8
^ permalink raw reply related [flat|nested] 30+ messages in thread
* Re: [PATCH v2] conf: machine: includes: add armv6-novfp support
2011-12-21 22:16 ` [PATCH v2] " Víctor Enríquez
@ 2011-12-27 19:02 ` Saul Wold
0 siblings, 0 replies; 30+ messages in thread
From: Saul Wold @ 2011-12-27 19:02 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: philb
On 12/21/2011 02:16 PM, Víctor Enríquez wrote:
> This work was made by Victor Enriquez and then modified by Denis Carikli who was helped by Mark Hatle comments (who is fray on
> #yocto channel on Freenode).
>
> The changes are for adding support to armv6-novfp, for building binaries for armv6 machines without vfp, for example the htc
> dream.
>
> Signed-off-by: Mark Hatle<mark.hatle@windriver.com>
> Signed-off-by: Denis 'GNUtoo' Carikli<GNUtoo@no-log.org>
> Signed-off-by: Víctor Enríquez<victor.quicksilver@gmail.com>
> ---
> meta/conf/machine/include/arm/arch-armv6.inc | 28 +++++++++++++-------
> meta/conf/machine/include/arm/feature-arm-vfp.inc | 4 ++-
> 2 files changed, 21 insertions(+), 11 deletions(-)
>
> diff --git a/meta/conf/machine/include/arm/arch-armv6.inc b/meta/conf/machine/include/arm/arch-armv6.inc
> index da8274e..f9c112e 100644
> --- a/meta/conf/machine/include/arm/arch-armv6.inc
> +++ b/meta/conf/machine/include/arm/arch-armv6.inc
> @@ -10,24 +10,32 @@ MACHINEOVERRIDES .= "${@bb.utils.contains("TUNE_FEATURES", "armv6", ":armv6", ""
> require conf/machine/include/arm/arch-armv5-dsp.inc
>
> # Little Endian
> -AVAILTUNES += "armv6 armv6t armv6hf armv6thf"
> +AVAILTUNES += "armv6-novfp armv6 armv6t armv6t-novfp armv6hf armv6thf"
> +TUNE_FEATURES_tune-armv6-novfp ?= "armv6"
> TUNE_FEATURES_tune-armv6 ?= "armv6 vfp"
> +TUNE_FEATURES_tune-armv6t-novfp ?= "armv6 thumb"
> TUNE_FEATURES_tune-armv6t ?= "armv6 vfp thumb"
> TUNE_FEATURES_tune-armv6hf ?= "${TUNE_FEATURES_tune-armv6} callconvention-hard"
> TUNE_FEATURES_tune-armv6thf ?= "${TUNE_FEATURES_tune-armv6t} callconvention-hard"
> -PACKAGE_EXTRA_ARCHS_tune-armv6 = "${PACKAGE_EXTRA_ARCHS_tune-armv5e-vfp} armv6-vfp"
> -PACKAGE_EXTRA_ARCHS_tune-armv6t = "${PACKAGE_EXTRA_ARCHS_tune-armv5te-vfp} armv6-vfp armv6t-vfp"
> -PACKAGE_EXTRA_ARCHS_tune-armv6hf = "${PACKAGE_EXTRA_ARCHS_tune-armv5ehf-vfp} armv6hf-vfp"
> -PACKAGE_EXTRA_ARCHS_tune-armv6thf = "${PACKAGE_EXTRA_ARCHS_tune-armv5tehf-vfp} armv6hf-vfp armv6thf-vfp"
> +PACKAGE_EXTRA_ARCHS_tune-armv6-novfp = "${PACKAGE_EXTRA_ARCHS_tune-armv5e} armv6-novfp"
> +PACKAGE_EXTRA_ARCHS_tune-armv6 = "${PACKAGE_EXTRA_ARCHS_tune-armv5e-vfp} armv6-novfp armv6"
> +PACKAGE_EXTRA_ARCHS_tune-armv6t-novfp = "${PACKAGE_EXTRA_ARCHS_tune-armv5e} armv6-novfp armv6t-novfp"
> +PACKAGE_EXTRA_ARCHS_tune-armv6t = "${PACKAGE_EXTRA_ARCHS_tune-armv5te-vfp} armv6-novfp armv6t-novfp armv6-vfp armv6t"
I am not sure I fully understand the changes here, so this might be a
mis-understanding on my part, but should this and the tune-armv6 have
both -vfp and -novfp in it?
> +PACKAGE_EXTRA_ARCHS_tune-armv6hf = "${PACKAGE_EXTRA_ARCHS_tune-armv5ehf-vfp} armv6hf"
> +PACKAGE_EXTRA_ARCHS_tune-armv6thf = "${PACKAGE_EXTRA_ARCHS_tune-armv5tehf-vfp} armv6hf-vfp armv6thf"
>
> # Big Endian
> -AVAILTUNES += "armv6b armv6tb armv6hfb armv6thfb"
> +AVAILTUNES += "armv6b-novfp armv6b armv6tb-novfp armv6tb armv6hfb armv6thfb"
> +TUNE_FEATURES_tune-armv6b-novfp ?= "${TUNE_FEATURES_tune-armv6-novfp} bigendian"
> TUNE_FEATURES_tune-armv6b ?= "${TUNE_FEATURES_tune-armv6} bigendian"
> +TUNE_FEATURES_tune-armv6tb-novfp ?= "${TUNE_FEATURES_tune-armv6t-novfp} bigendian"
> TUNE_FEATURES_tune-armv6tb ?= "${TUNE_FEATURES_tune-armv6t} bigendian"
> TUNE_FEATURES_tune-armv6hfb ?= "${TUNE_FEATURES_tune-armv6b} callconvention-hard"
> TUNE_FEATURES_tune-armv6thfb ?= "${TUNE_FEATURES_tune-armv6tb} callconvention-hard"
> -PACKAGE_EXTRA_ARCHS_tune-armv6b = "${PACKAGE_EXTRA_ARCHS_tune-armv5eb-vfp} armv6b-vfp"
> -PACKAGE_EXTRA_ARCHS_tune-armv6tb = "${PACKAGE_EXTRA_ARCHS_tune-armv5teb-vfp} armv6b-vfp armv6tb-vfp"
> -PACKAGE_EXTRA_ARCHS_tune-armv6hfb = "${PACKAGE_EXTRA_ARCHS_tune-armv5ehfb-vfp} armv6hfb-vfp"
> -PACKAGE_EXTRA_ARCHS_tune-armv6thfb = "${PACKAGE_EXTRA_ARCHS_tune-armv5tehfb-vfp} armv6hfb-vfp armv6thfb-vfp"
> +PACKAGE_EXTRA_ARCHS_tune-armv6b-novfp = "${PACKAGE_EXTRA_ARCHS_tune-armv5eb} armv6b-novfp"
> +PACKAGE_EXTRA_ARCHS_tune-armv6b = "${PACKAGE_EXTRA_ARCHS_tune-armv5eb-vfp} armv6b"
Why not like the armv6 above with -novfp (again, maybe my misunderstanding
> +PACKAGE_EXTRA_ARCHS_tune-armv6tb-novfp = "${PACKAGE_EXTRA_ARCHS_tune-armv5eb} armv6b-novfp armv6tb-novfp"
> +PACKAGE_EXTRA_ARCHS_tune-armv6tb = "${PACKAGE_EXTRA_ARCHS_tune-armv5teb-vfp} armv6b-novfp armv6tb-novfp armv6b-vfp armv6tb"
This seems to match armv6t above.
> +PACKAGE_EXTRA_ARCHS_tune-armv6hfb = "${PACKAGE_EXTRA_ARCHS_tune-armv5ehfb-vfp} armv6hfb"
> +PACKAGE_EXTRA_ARCHS_tune-armv6thfb = "${PACKAGE_EXTRA_ARCHS_tune-armv5tehfb-vfp} armv6hfb-vfp armv6thfb"
>
> diff --git a/meta/conf/machine/include/arm/feature-arm-vfp.inc b/meta/conf/machine/include/arm/feature-arm-vfp.inc
> index 29a925c..78f453c 100644
> --- a/meta/conf/machine/include/arm/feature-arm-vfp.inc
> +++ b/meta/conf/machine/include/arm/feature-arm-vfp.inc
> @@ -1,5 +1,7 @@
> TUNEVALID[vfp] = "Enable Vector Floating Point (vfp) unit."
> -ARMPKGSFX_FPU .= "${@bb.utils.contains("TUNE_FEATURES", "vfp", "-vfp", "" ,d)}"
> +TUNE_ARM_VFP = "${@bb.utils.contains("ARMPKGARCH", "armv6", "", "vfp" ,d)}"
should this be -vfp?
> +TUNE_ARM_NOVFP = "${@bb.utils.contains("ARMPKGARCH", "armv6", "-novfp", "" ,d)}"
> +ARMPKGSFX_FPU .= "${@bb.utils.contains("TUNE_FEATURES", "vfp", "${TUNE_ARM_VFP}", "${TUNE_ARM_NOVFP}" ,d)}"
>
> TUNEVALID[callconvention-hard] = "Enable EABI hard float call convention, requires VFP."
> TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "vfp", bb.utils.contains("TUNE_FEATURES", "callconvention-hard", "-mfloat-abi=hard", "-mfloat-abi=softfp", d), "" ,d)}"
^ permalink raw reply [flat|nested] 30+ messages in thread
end of thread, other threads:[~2011-12-27 19:10 UTC | newest]
Thread overview: 30+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-12 7:44 [oe-core 0/4] Qt4, armv6, xserver-xorg changes Martin Jansa
2011-10-12 7:45 ` [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input Martin Jansa
2011-10-12 8:02 ` Eric Bénard
2011-10-12 9:20 ` Koen Kooi
2011-10-12 19:04 ` Chris Larson
2011-10-12 18:10 ` Simon Busch
2011-10-12 18:14 ` Koen Kooi
2011-10-12 18:34 ` Simon Busch
2011-10-12 19:09 ` Koen Kooi
2011-10-12 19:24 ` Simon Busch
2011-10-12 19:29 ` Simon Busch
2011-10-12 19:52 ` Simon Busch
2011-10-12 20:09 ` Eric Bénard
2011-10-12 19:41 ` Chris Larson
2011-10-12 19:22 ` Eric Bénard
2011-10-12 7:45 ` [oe-core 2/4] qt4-x11-free: bring back pkg-config fixups Martin Jansa
2011-10-12 9:23 ` Paul Eggleton
2011-10-12 18:05 ` Simon Busch
2011-10-19 19:02 ` Simon Busch
2011-10-12 7:45 ` [oe-core 3/4] conf: machine: includes: add armv6-novfp support Martin Jansa
2011-10-12 21:26 ` Phil Blundell
2011-10-13 10:49 ` Denis 'GNUtoo' Carikli
2011-10-13 19:42 ` Phil Blundell
2011-12-21 19:48 ` [PATCH] " vquicksilver
2011-12-21 19:57 ` Mark Hatle
2011-12-21 20:06 ` Otavio Salvador
2011-12-21 20:12 ` Koen Kooi
2011-12-21 22:16 ` [PATCH v2] " Víctor Enríquez
2011-12-27 19:02 ` Saul Wold
2011-10-12 7:45 ` [oe-core 4/4] xserver-xorg: drop xorg-minimal-fonts from RDEPENDS Martin Jansa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox