* [PATCH oe-core v4] linux-dtb: add multi-dtb build support and keep dtb in deploy cache package
@ 2012-01-06 5:57 b19537
2012-01-06 6:08 ` McClintock Matthew-B29882
2012-01-06 7:06 ` Saul Wold
0 siblings, 2 replies; 4+ messages in thread
From: b19537 @ 2012-01-06 5:57 UTC (permalink / raw)
To: openembedded-core
From: Zhenhua Luo <b19537@freescale.com>
Signed-off-by: Zhenhua Luo <b19537@freescale.com>
---
meta/recipes-kernel/linux/linux-dtb.inc | 30 +++++++++++++++++++++---------
1 files changed, 21 insertions(+), 9 deletions(-)
diff --git a/meta/recipes-kernel/linux/linux-dtb.inc b/meta/recipes-kernel/linux/linux-dtb.inc
index 7ec7584..5439810 100644
--- a/meta/recipes-kernel/linux/linux-dtb.inc
+++ b/meta/recipes-kernel/linux/linux-dtb.inc
@@ -13,15 +13,27 @@ python __anonymous () {
d.setVar("PACKAGES", "%s kernel-devicetree" % packages)
}
-do_install_append() {
+kernel_do_deploy_append() {
if test -n "${KERNEL_DEVICETREE}"; then
- dtc -I dts -O dtb ${KERNEL_DEVICETREE_FLAGS} -o devicetree ${KERNEL_DEVICETREE}
- install -m 0644 devicetree ${D}/boot/devicetree-${KERNEL_VERSION}
- install -d ${DEPLOY_DIR_IMAGE}
- install -m 0644 devicetree ${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGE_BASE_NAME}.dtb
- cd ${DEPLOY_DIR_IMAGE}
- rm -f ${KERNEL_IMAGE_SYMLINK_NAME}.dtb
- ln -sf ${KERNEL_IMAGE_BASE_NAME}.dtb ${KERNEL_IMAGE_SYMLINK_NAME}.dtb
+ for DTS_FILE in ${KERNEL_DEVICETREE}; do
+ DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "." '{print $1}'`
+ DTB_NAME=`echo ${KERNEL_IMAGE_BASE_NAME} | sed "s/${MACHINE}/${DTS_BASE_NAME}/g"`
+ DTB_SYMLINK_NAME=`echo ${KERNEL_IMAGE_SYMLINK_NAME} | sed "s/${MACHINE}/${DTS_BASE_NAME}/g"`
+ dtc -I dts -O dtb ${KERNEL_DEVICETREE_FLAGS} -o devicetree ${DTS_FILE}
+ install -m 0644 devicetree ${D}/boot/devicetree-${DTS_BASE_NAME}-${KERNEL_VERSION}
+ install -d ${DEPLOY_DIR_IMAGE}
+ install -m 0644 devicetree ${DEPLOY_DIR_IMAGE}/${DTB_NAME}.dtb
+ rm -f devicetree
+ cd ${DEPLOY_DIR_IMAGE}
+ rm -f ${DTB_SYMLINK_NAME}.dtb
+ ln -sf ${DTB_NAME}.dtb ${DTB_SYMLINK_NAME}.dtb
+ cd -
+
+ install -d ${DEPLOYDIR}
+ install -m 0644 ${DEPLOY_DIR_IMAGE}/${DTB_NAME}.dtb ${DEPLOYDIR}/${DTB_NAME}.dtb
+ cd ${DEPLOYDIR}
+ ln -sf ${DTB_NAME}.dtb ${DTB_SYMLINK_NAME=}.dtb
+ cd -
+ done
fi
}
-
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH oe-core v4] linux-dtb: add multi-dtb build support and keep dtb in deploy cache package
2012-01-06 5:57 [PATCH oe-core v4] linux-dtb: add multi-dtb build support and keep dtb in deploy cache package b19537
@ 2012-01-06 6:08 ` McClintock Matthew-B29882
2012-01-06 7:06 ` Saul Wold
1 sibling, 0 replies; 4+ messages in thread
From: McClintock Matthew-B29882 @ 2012-01-06 6:08 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Thu, Jan 5, 2012 at 11:57 PM, <b19537@freescale.com> wrote:
> + ln -sf ${DTB_NAME}.dtb ${DTB_SYMLINK_NAME}.dtb
> + cd -
> +
> + install -d ${DEPLOYDIR}
> + install -m 0644 ${DEPLOY_DIR_IMAGE}/${DTB_NAME}.dtb ${DEPLOYDIR}/${DTB_NAME}.dtb
> + cd ${DEPLOYDIR}
> + ln -sf ${DTB_NAME}.dtb ${DTB_SYMLINK_NAME=}.dtb
Can you elaborate why we are doing these things twice? Is on for the
cache and one for the current deploy dir or something?
-M
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH oe-core v4] linux-dtb: add multi-dtb build support and keep dtb in deploy cache package
2012-01-06 5:57 [PATCH oe-core v4] linux-dtb: add multi-dtb build support and keep dtb in deploy cache package b19537
2012-01-06 6:08 ` McClintock Matthew-B29882
@ 2012-01-06 7:06 ` Saul Wold
2012-01-06 7:29 ` Luo Zhenhua-B19537
1 sibling, 1 reply; 4+ messages in thread
From: Saul Wold @ 2012-01-06 7:06 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 01/05/2012 09:57 PM, b19537@freescale.com wrote:
> From: Zhenhua Luo<b19537@freescale.com>
>
> Signed-off-by: Zhenhua Luo<b19537@freescale.com>
> ---
> meta/recipes-kernel/linux/linux-dtb.inc | 30 +++++++++++++++++++++---------
> 1 files changed, 21 insertions(+), 9 deletions(-)
>
> diff --git a/meta/recipes-kernel/linux/linux-dtb.inc b/meta/recipes-kernel/linux/linux-dtb.inc
> index 7ec7584..5439810 100644
> --- a/meta/recipes-kernel/linux/linux-dtb.inc
> +++ b/meta/recipes-kernel/linux/linux-dtb.inc
> @@ -13,15 +13,27 @@ python __anonymous () {
> d.setVar("PACKAGES", "%s kernel-devicetree" % packages)
> }
>
> -do_install_append() {
> +kernel_do_deploy_append() {
> if test -n "${KERNEL_DEVICETREE}"; then
> - dtc -I dts -O dtb ${KERNEL_DEVICETREE_FLAGS} -o devicetree ${KERNEL_DEVICETREE}
> - install -m 0644 devicetree ${D}/boot/devicetree-${KERNEL_VERSION}
> - install -d ${DEPLOY_DIR_IMAGE}
> - install -m 0644 devicetree ${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGE_BASE_NAME}.dtb
> - cd ${DEPLOY_DIR_IMAGE}
> - rm -f ${KERNEL_IMAGE_SYMLINK_NAME}.dtb
> - ln -sf ${KERNEL_IMAGE_BASE_NAME}.dtb ${KERNEL_IMAGE_SYMLINK_NAME}.dtb
> + for DTS_FILE in ${KERNEL_DEVICETREE}; do
> + DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "." '{print $1}'`
> + DTB_NAME=`echo ${KERNEL_IMAGE_BASE_NAME} | sed "s/${MACHINE}/${DTS_BASE_NAME}/g"`
> + DTB_SYMLINK_NAME=`echo ${KERNEL_IMAGE_SYMLINK_NAME} | sed "s/${MACHINE}/${DTS_BASE_NAME}/g"`
> + dtc -I dts -O dtb ${KERNEL_DEVICETREE_FLAGS} -o devicetree ${DTS_FILE}
> + install -m 0644 devicetree ${D}/boot/devicetree-${DTS_BASE_NAME}-${KERNEL_VERSION}
> + install -d ${DEPLOY_DIR_IMAGE}
> + install -m 0644 devicetree ${DEPLOY_DIR_IMAGE}/${DTB_NAME}.dtb
> + rm -f devicetree
> + cd ${DEPLOY_DIR_IMAGE}
> + rm -f ${DTB_SYMLINK_NAME}.dtb
> + ln -sf ${DTB_NAME}.dtb ${DTB_SYMLINK_NAME}.dtb
> + cd -
> +
> + install -d ${DEPLOYDIR}
> + install -m 0644 ${DEPLOY_DIR_IMAGE}/${DTB_NAME}.dtb ${DEPLOYDIR}/${DTB_NAME}.dtb
> + cd ${DEPLOYDIR}
> + ln -sf ${DTB_NAME}.dtb ${DTB_SYMLINK_NAME=}.dtb
Should there be an '=' at the end of this?
Sau!
> + cd -
> + done
> fi
> }
> -
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH oe-core v4] linux-dtb: add multi-dtb build support and keep dtb in deploy cache package
2012-01-06 7:06 ` Saul Wold
@ 2012-01-06 7:29 ` Luo Zhenhua-B19537
0 siblings, 0 replies; 4+ messages in thread
From: Luo Zhenhua-B19537 @ 2012-01-06 7:29 UTC (permalink / raw)
To: Saul Wold; +Cc: Patches and discussions about the oe-core layer
"=" is needless, I will fix the error. Seems it doesn't impact the result. :)
Best Regards,
Zhenhua
> -----Original Message-----
> From: Saul Wold [mailto:sgw@linux.intel.com]
> Sent: Friday, January 06, 2012 3:06 PM
> To: Patches and discussions about the oe-core layer
> Cc: Luo Zhenhua-B19537
> Subject: Re: [OE-core] [PATCH oe-core v4] linux-dtb: add multi-dtb build support
> and keep dtb in deploy cache package
>
> On 01/05/2012 09:57 PM, b19537@freescale.com wrote:
> > From: Zhenhua Luo<b19537@freescale.com>
> >
> > Signed-off-by: Zhenhua Luo<b19537@freescale.com>
> > ---
> > meta/recipes-kernel/linux/linux-dtb.inc | 30 +++++++++++++++++++++--------
> -
> > 1 files changed, 21 insertions(+), 9 deletions(-)
> >
> > diff --git a/meta/recipes-kernel/linux/linux-dtb.inc b/meta/recipes-
> kernel/linux/linux-dtb.inc
> > index 7ec7584..5439810 100644
> > --- a/meta/recipes-kernel/linux/linux-dtb.inc
> > +++ b/meta/recipes-kernel/linux/linux-dtb.inc
> > @@ -13,15 +13,27 @@ python __anonymous () {
> > d.setVar("PACKAGES", "%s kernel-devicetree" % packages)
> > }
> >
> > -do_install_append() {
> > +kernel_do_deploy_append() {
> > if test -n "${KERNEL_DEVICETREE}"; then
> > - dtc -I dts -O dtb ${KERNEL_DEVICETREE_FLAGS} -o devicetree
> ${KERNEL_DEVICETREE}
> > - install -m 0644 devicetree ${D}/boot/devicetree-${KERNEL_VERSION}
> > - install -d ${DEPLOY_DIR_IMAGE}
> > - install -m 0644 devicetree
> ${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGE_BASE_NAME}.dtb
> > - cd ${DEPLOY_DIR_IMAGE}
> > - rm -f ${KERNEL_IMAGE_SYMLINK_NAME}.dtb
> > - ln -sf ${KERNEL_IMAGE_BASE_NAME}.dtb ${KERNEL_IMAGE_SYMLINK_NAME}.dtb
> > + for DTS_FILE in ${KERNEL_DEVICETREE}; do
> > + DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "." '{print $1}'`
> > + DTB_NAME=`echo ${KERNEL_IMAGE_BASE_NAME} | sed
> "s/${MACHINE}/${DTS_BASE_NAME}/g"`
> > + DTB_SYMLINK_NAME=`echo ${KERNEL_IMAGE_SYMLINK_NAME} | sed
> "s/${MACHINE}/${DTS_BASE_NAME}/g"`
> > + dtc -I dts -O dtb ${KERNEL_DEVICETREE_FLAGS} -o devicetree
> ${DTS_FILE}
> > + install -m 0644 devicetree ${D}/boot/devicetree-${DTS_BASE_NAME}-
> ${KERNEL_VERSION}
> > + install -d ${DEPLOY_DIR_IMAGE}
> > + install -m 0644 devicetree ${DEPLOY_DIR_IMAGE}/${DTB_NAME}.dtb
> > + rm -f devicetree
> > + cd ${DEPLOY_DIR_IMAGE}
> > + rm -f ${DTB_SYMLINK_NAME}.dtb
> > + ln -sf ${DTB_NAME}.dtb ${DTB_SYMLINK_NAME}.dtb
> > + cd -
> > +
> > + install -d ${DEPLOYDIR}
> > + install -m 0644 ${DEPLOY_DIR_IMAGE}/${DTB_NAME}.dtb
> ${DEPLOYDIR}/${DTB_NAME}.dtb
> > + cd ${DEPLOYDIR}
> > + ln -sf ${DTB_NAME}.dtb ${DTB_SYMLINK_NAME=}.dtb
> Should there be an '=' at the end of this?
>
> Sau!
>
> > + cd -
> > + done
> > fi
> > }
> > -
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-06 7:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-06 5:57 [PATCH oe-core v4] linux-dtb: add multi-dtb build support and keep dtb in deploy cache package b19537
2012-01-06 6:08 ` McClintock Matthew-B29882
2012-01-06 7:06 ` Saul Wold
2012-01-06 7:29 ` Luo Zhenhua-B19537
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox