Openembedded Core Discussions
 help / color / mirror / Atom feed
From: wenzong fan <wenzong.fan@windriver.com>
To: <philb@gnu.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] archive.bbclass: archive work directoryDistribution
Date: Mon, 9 Jan 2012 11:31:38 +0800	[thread overview]
Message-ID: <4F0A5F9A.9050408@windriver.com> (raw)
In-Reply-To: <1325871597.12160.13.camel@phil-desktop>

On 01/07/2012 01:39 AM, Phil Blundell wrote:
> On Fri, 2012-01-06 at 16:20 +0800, wenzong.fan@windriver.com wrote:
>    
>> +    if [[ -d ${S}&&  ${S} != ${WORKDIR} ]]; then
>> +        if [[ ${S} =~ "/work-shared/gcc" ]]; then
>> +            # Create temporary sources directory for gcc
>> +            mkdir -p ${PF}/temp
>> +            cp -r ${S} ${PF}
>> +            cp -r ${S}/../temp/* ${PF}/temp
>> +            cp -r ${WORKDIR}/temp/* ${PF}/temp
>> +            tarbase=`pwd`
>>      
> Special-casing gcc like this seems a bit lame.  Is that check really
> needed?
>    

Oh, we might have other packages under this dir, so I'll remove the 
special-casing 'gcc' here.
> Also, will the above code work with all shells?  It looks a bit
> bash-specific to me.
>    
I assume that the bitbake have to run with 'bash', looks like this is 
not right on all distributions.

I'll update this.

Thanks
Wenzong

> p.
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>    




      reply	other threads:[~2012-01-09  3:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-06  8:20 [PATCH 0/1] archive.bbclass: archive work directory wenzong.fan
2012-01-06  8:20 ` [PATCH 1/1] " wenzong.fan
2012-01-06  8:46   ` Saul Wold
2012-01-09  2:20     ` wenzong fan
2012-01-06 17:39   ` Phil Blundell
2012-01-09  3:31     ` wenzong fan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F0A5F9A.9050408@windriver.com \
    --to=wenzong.fan@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=philb@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox