* [PATCH] e2fsprogs_1.42.bb: Fix build fallout for uclibc
@ 2012-01-18 3:01 Khem Raj
2012-01-18 9:51 ` Koen Kooi
2012-01-19 19:56 ` Saul Wold
0 siblings, 2 replies; 5+ messages in thread
From: Khem Raj @ 2012-01-18 3:01 UTC (permalink / raw)
To: openembedded-core
e2fsprogs 1.42 onwards uses fallocate() which uclibc
does not implement(yet). In most of places its use
is controlled and it only used when configure detects
fallocate being present but in this one case it missed
to check for fallocate being available so here we
add the check
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
.../e2fsprogs/e2fsprogs-1.42/fallocate.patch | 22 ++++++++++++++++++++
meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.bb | 3 +-
2 files changed, 24 insertions(+), 1 deletions(-)
create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42/fallocate.patch
diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42/fallocate.patch b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42/fallocate.patch
new file mode 100644
index 0000000..4d952a5
--- /dev/null
+++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42/fallocate.patch
@@ -0,0 +1,22 @@
+We assume that fallocate is supported somehow
+but we need to check if we have fallocate()
+this problem shows up on uclibc systems since
+uclibc does not have fallocate() implemented
+
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+
+Upstream-Status: Pending
+
+Index: e2fsprogs-1.42/lib/ext2fs/unix_io.c
+===================================================================
+--- e2fsprogs-1.42.orig/lib/ext2fs/unix_io.c 2012-01-17 17:24:34.290780625 -0800
++++ e2fsprogs-1.42/lib/ext2fs/unix_io.c 2012-01-17 17:25:37.338783680 -0800
+@@ -895,7 +895,7 @@
+ goto unimplemented;
+ #endif
+ } else {
+-#ifdef FALLOC_FL_PUNCH_HOLE
++#if defined FALLOC_FL_PUNCH_HOLE && defined HAVE_FALLOCATE
+ /*
+ * If we are not on block device, try to use punch hole
+ * to reclaim free space.
diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.bb b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.bb
index 9ff85a2..f6759aa7 100644
--- a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.bb
+++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.bb
@@ -1,8 +1,9 @@
require e2fsprogs.inc
-PR = "r0"
+PR = "r1"
SRC_URI += "file://quotefix.patch \
+ file://fallocate.patch \
file://acinclude.m4"
SRC_URI[md5sum] = "a3c4ffd7352310ab5e9412965d575610"
--
1.7.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] e2fsprogs_1.42.bb: Fix build fallout for uclibc
2012-01-18 3:01 [PATCH] e2fsprogs_1.42.bb: Fix build fallout for uclibc Khem Raj
@ 2012-01-18 9:51 ` Koen Kooi
2012-01-18 13:34 ` Koen Kooi
2012-01-19 19:56 ` Saul Wold
1 sibling, 1 reply; 5+ messages in thread
From: Koen Kooi @ 2012-01-18 9:51 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
Op 18 jan. 2012, om 04:01 heeft Khem Raj het volgende geschreven:
> e2fsprogs 1.42 onwards uses fallocate() which uclibc
> does not implement(yet). In most of places its use
> is controlled and it only used when configure detects
> fallocate being present but in this one case it missed
> to check for fallocate being available so here we
> add the check
FWIW, e2fsprogs(-native) also has problems with ASNEEDED:
| tune2fs: symbol lookup error: tune2fs: undefined symbol: ext2fs_group_desc
regards,
Koen
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> .../e2fsprogs/e2fsprogs-1.42/fallocate.patch | 22 ++++++++++++++++++++
> meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.bb | 3 +-
> 2 files changed, 24 insertions(+), 1 deletions(-)
> create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42/fallocate.patch
>
> diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42/fallocate.patch b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42/fallocate.patch
> new file mode 100644
> index 0000000..4d952a5
> --- /dev/null
> +++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42/fallocate.patch
> @@ -0,0 +1,22 @@
> +We assume that fallocate is supported somehow
> +but we need to check if we have fallocate()
> +this problem shows up on uclibc systems since
> +uclibc does not have fallocate() implemented
> +
> +Signed-off-by: Khem Raj <raj.khem@gmail.com>
> +
> +Upstream-Status: Pending
> +
> +Index: e2fsprogs-1.42/lib/ext2fs/unix_io.c
> +===================================================================
> +--- e2fsprogs-1.42.orig/lib/ext2fs/unix_io.c 2012-01-17 17:24:34.290780625 -0800
> ++++ e2fsprogs-1.42/lib/ext2fs/unix_io.c 2012-01-17 17:25:37.338783680 -0800
> +@@ -895,7 +895,7 @@
> + goto unimplemented;
> + #endif
> + } else {
> +-#ifdef FALLOC_FL_PUNCH_HOLE
> ++#if defined FALLOC_FL_PUNCH_HOLE && defined HAVE_FALLOCATE
> + /*
> + * If we are not on block device, try to use punch hole
> + * to reclaim free space.
> diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.bb b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.bb
> index 9ff85a2..f6759aa7 100644
> --- a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.bb
> +++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.bb
> @@ -1,8 +1,9 @@
> require e2fsprogs.inc
>
> -PR = "r0"
> +PR = "r1"
>
> SRC_URI += "file://quotefix.patch \
> + file://fallocate.patch \
> file://acinclude.m4"
>
> SRC_URI[md5sum] = "a3c4ffd7352310ab5e9412965d575610"
> --
> 1.7.5.4
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] e2fsprogs_1.42.bb: Fix build fallout for uclibc
2012-01-18 9:51 ` Koen Kooi
@ 2012-01-18 13:34 ` Koen Kooi
2012-01-19 16:42 ` Scott Garman
0 siblings, 1 reply; 5+ messages in thread
From: Koen Kooi @ 2012-01-18 13:34 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
Op 18 jan. 2012, om 10:51 heeft Koen Kooi het volgende geschreven:
>
> Op 18 jan. 2012, om 04:01 heeft Khem Raj het volgende geschreven:
>
>> e2fsprogs 1.42 onwards uses fallocate() which uclibc
>> does not implement(yet). In most of places its use
>> is controlled and it only used when configure detects
>> fallocate being present but in this one case it missed
>> to check for fallocate being available so here we
>> add the check
>
> FWIW, e2fsprogs(-native) also has problems with ASNEEDED:
>
> | tune2fs: symbol lookup error: tune2fs: undefined symbol: ext2fs_group_desc
And that one suddenly went away!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] e2fsprogs_1.42.bb: Fix build fallout for uclibc
2012-01-18 13:34 ` Koen Kooi
@ 2012-01-19 16:42 ` Scott Garman
0 siblings, 0 replies; 5+ messages in thread
From: Scott Garman @ 2012-01-19 16:42 UTC (permalink / raw)
To: openembedded-core
On 01/18/2012 05:34 AM, Koen Kooi wrote:
>
> Op 18 jan. 2012, om 10:51 heeft Koen Kooi het volgende geschreven:
>
>>
>> Op 18 jan. 2012, om 04:01 heeft Khem Raj het volgende geschreven:
>>
>>> e2fsprogs 1.42 onwards uses fallocate() which uclibc
>>> does not implement(yet). In most of places its use
>>> is controlled and it only used when configure detects
>>> fallocate being present but in this one case it missed
>>> to check for fallocate being available so here we
>>> add the check
>>
>> FWIW, e2fsprogs(-native) also has problems with ASNEEDED:
>>
>> | tune2fs: symbol lookup error: tune2fs: undefined symbol: ext2fs_group_desc
>
> And that one suddenly went away!
That was fixed when the bitbake.conf change made it into master which
now adds base_libdir_native to the RPATH for native compiled binaries.
http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=35759f977eec6ef81e125a509a7148d7e53a6515
Scott
--
Scott Garman
Embedded Linux Engineer - Yocto Project
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] e2fsprogs_1.42.bb: Fix build fallout for uclibc
2012-01-18 3:01 [PATCH] e2fsprogs_1.42.bb: Fix build fallout for uclibc Khem Raj
2012-01-18 9:51 ` Koen Kooi
@ 2012-01-19 19:56 ` Saul Wold
1 sibling, 0 replies; 5+ messages in thread
From: Saul Wold @ 2012-01-19 19:56 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 01/17/2012 07:01 PM, Khem Raj wrote:
> e2fsprogs 1.42 onwards uses fallocate() which uclibc
> does not implement(yet). In most of places its use
> is controlled and it only used when configure detects
> fallocate being present but in this one case it missed
> to check for fallocate being available so here we
> add the check
>
> Signed-off-by: Khem Raj<raj.khem@gmail.com>
> ---
> .../e2fsprogs/e2fsprogs-1.42/fallocate.patch | 22 ++++++++++++++++++++
> meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.bb | 3 +-
> 2 files changed, 24 insertions(+), 1 deletions(-)
> create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42/fallocate.patch
>
> diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42/fallocate.patch b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42/fallocate.patch
> new file mode 100644
> index 0000000..4d952a5
> --- /dev/null
> +++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42/fallocate.patch
> @@ -0,0 +1,22 @@
> +We assume that fallocate is supported somehow
> +but we need to check if we have fallocate()
> +this problem shows up on uclibc systems since
> +uclibc does not have fallocate() implemented
> +
> +Signed-off-by: Khem Raj<raj.khem@gmail.com>
> +
> +Upstream-Status: Pending
> +
> +Index: e2fsprogs-1.42/lib/ext2fs/unix_io.c
> +===================================================================
> +--- e2fsprogs-1.42.orig/lib/ext2fs/unix_io.c 2012-01-17 17:24:34.290780625 -0800
> ++++ e2fsprogs-1.42/lib/ext2fs/unix_io.c 2012-01-17 17:25:37.338783680 -0800
> +@@ -895,7 +895,7 @@
> + goto unimplemented;
> + #endif
> + } else {
> +-#ifdef FALLOC_FL_PUNCH_HOLE
> ++#if defined FALLOC_FL_PUNCH_HOLE&& defined HAVE_FALLOCATE
> + /*
> + * If we are not on block device, try to use punch hole
> + * to reclaim free space.
> diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.bb b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.bb
> index 9ff85a2..f6759aa7 100644
> --- a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.bb
> +++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.bb
> @@ -1,8 +1,9 @@
> require e2fsprogs.inc
>
> -PR = "r0"
> +PR = "r1"
>
> SRC_URI += "file://quotefix.patch \
> + file://fallocate.patch \
> file://acinclude.m4"
>
> SRC_URI[md5sum] = "a3c4ffd7352310ab5e9412965d575610"
Merged into OE-Core
Thanks
Sau!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-01-19 20:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-18 3:01 [PATCH] e2fsprogs_1.42.bb: Fix build fallout for uclibc Khem Raj
2012-01-18 9:51 ` Koen Kooi
2012-01-18 13:34 ` Koen Kooi
2012-01-19 16:42 ` Scott Garman
2012-01-19 19:56 ` Saul Wold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox