* [PATCH 1/2] alsa-state: fix RDEPENDS assignment
@ 2012-01-30 16:49 Koen Kooi
2012-01-30 16:49 ` [PATCH 2/2] alsa-utils: make alsa-utils-alsactl recommend alsa-states Koen Kooi
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Koen Kooi @ 2012-01-30 16:49 UTC (permalink / raw)
To: openembedded-core; +Cc: Koen Kooi
Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
meta/recipes-bsp/alsa-state/alsa-state.bb | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/meta/recipes-bsp/alsa-state/alsa-state.bb b/meta/recipes-bsp/alsa-state/alsa-state.bb
index bc17b25..83c9faa 100644
--- a/meta/recipes-bsp/alsa-state/alsa-state.bb
+++ b/meta/recipes-bsp/alsa-state/alsa-state.bb
@@ -10,7 +10,7 @@ sound state at system boot and save it at system shut down."
LICENSE = "MIT"
LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
PV = "0.2.0"
-PR = "r0"
+PR = "r2"
SRC_URI = "\
file://asound.conf \
@@ -18,8 +18,6 @@ SRC_URI = "\
file://alsa-state \
"
-RDEPENDS = "alsa-utils-alsactl"
-
inherit update-rc.d
INITSCRIPT_NAME = "alsa-state"
@@ -39,6 +37,7 @@ PACKAGES += "alsa-states"
RRECOMMENDS_alsa-state = "alsa-states"
+RDEPENDS_${PN} = "alsa-utils-alsactl"
FILES_${PN} = "${sysconfdir}/init.d ${sysconfdir}/asound.conf"
CONFFILES_${PN} = "${sysconfdir}/asound.conf"
--
1.7.2.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 2/2] alsa-utils: make alsa-utils-alsactl recommend alsa-states
2012-01-30 16:49 [PATCH 1/2] alsa-state: fix RDEPENDS assignment Koen Kooi
@ 2012-01-30 16:49 ` Koen Kooi
2012-01-30 17:51 ` Joshua Lock
2012-01-30 17:50 ` [PATCH 1/2] alsa-state: fix RDEPENDS assignment Joshua Lock
2012-02-02 17:57 ` Saul Wold
2 siblings, 1 reply; 9+ messages in thread
From: Koen Kooi @ 2012-01-30 16:49 UTC (permalink / raw)
To: openembedded-core; +Cc: Koen Kooi
This will drag in the asound.state from the BSP that alsactl uses.
Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
.../recipes-multimedia/alsa/alsa-utils_1.0.24.2.bb | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/meta/recipes-multimedia/alsa/alsa-utils_1.0.24.2.bb b/meta/recipes-multimedia/alsa/alsa-utils_1.0.24.2.bb
index 196128e..e62a0f3 100644
--- a/meta/recipes-multimedia/alsa/alsa-utils_1.0.24.2.bb
+++ b/meta/recipes-multimedia/alsa/alsa-utils_1.0.24.2.bb
@@ -6,7 +6,7 @@ LICENSE = "GPLv2+"
LIC_FILES_CHKSUM = "file://COPYING;md5=393a5ca445f6965873eca0259a17f833 \
file://alsactl/utils.c;beginline=1;endline=20;md5=fe9526b055e246b5558809a5ae25c0b9"
DEPENDS = "alsa-lib ncurses libsamplerate0"
-PR = "r4"
+PR = "r5"
SRC_URI = "ftp://ftp.alsa-project.org/pub/utils/alsa-utils-${PV}.tar.bz2 \
file://ncursesfix.patch \
@@ -79,4 +79,6 @@ DESCRIPTION_alsa-utils-alsactl = "saves/restores ALSA-settings in /etc/asou
DESCRIPTION_alsa-utils-alsaconf = "a bash script that creates ALSA configuration files"
DESCRIPTION_alsa-utils-alsaucm = "ALSA Use Case Manager"
+RRECOMMENDS_alsa-utils-alsactl = "alsa-states"
+
ALLOW_EMPTY_alsa-utils = "1"
--
1.7.2.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 2/2] alsa-utils: make alsa-utils-alsactl recommend alsa-states
2012-01-30 16:49 ` [PATCH 2/2] alsa-utils: make alsa-utils-alsactl recommend alsa-states Koen Kooi
@ 2012-01-30 17:51 ` Joshua Lock
0 siblings, 0 replies; 9+ messages in thread
From: Joshua Lock @ 2012-01-30 17:51 UTC (permalink / raw)
To: Koen Kooi; +Cc: openembedded-core
On 30/01/12 08:49, Koen Kooi wrote:
> This will drag in the asound.state from the BSP that alsactl uses.
>
> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net>
Signed-off-by: Joshua Lock <josh@linux.intel.com>
> ---
> .../recipes-multimedia/alsa/alsa-utils_1.0.24.2.bb | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-multimedia/alsa/alsa-utils_1.0.24.2.bb b/meta/recipes-multimedia/alsa/alsa-utils_1.0.24.2.bb
> index 196128e..e62a0f3 100644
> --- a/meta/recipes-multimedia/alsa/alsa-utils_1.0.24.2.bb
> +++ b/meta/recipes-multimedia/alsa/alsa-utils_1.0.24.2.bb
> @@ -6,7 +6,7 @@ LICENSE = "GPLv2+"
> LIC_FILES_CHKSUM = "file://COPYING;md5=393a5ca445f6965873eca0259a17f833 \
> file://alsactl/utils.c;beginline=1;endline=20;md5=fe9526b055e246b5558809a5ae25c0b9"
> DEPENDS = "alsa-lib ncurses libsamplerate0"
> -PR = "r4"
> +PR = "r5"
>
> SRC_URI = "ftp://ftp.alsa-project.org/pub/utils/alsa-utils-${PV}.tar.bz2 \
> file://ncursesfix.patch \
> @@ -79,4 +79,6 @@ DESCRIPTION_alsa-utils-alsactl = "saves/restores ALSA-settings in /etc/asou
> DESCRIPTION_alsa-utils-alsaconf = "a bash script that creates ALSA configuration files"
> DESCRIPTION_alsa-utils-alsaucm = "ALSA Use Case Manager"
>
> +RRECOMMENDS_alsa-utils-alsactl = "alsa-states"
> +
> ALLOW_EMPTY_alsa-utils = "1"
--
Joshua Lock
Yocto Project "Johannes factotum"
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] alsa-state: fix RDEPENDS assignment
2012-01-30 16:49 [PATCH 1/2] alsa-state: fix RDEPENDS assignment Koen Kooi
2012-01-30 16:49 ` [PATCH 2/2] alsa-utils: make alsa-utils-alsactl recommend alsa-states Koen Kooi
@ 2012-01-30 17:50 ` Joshua Lock
2012-01-30 17:56 ` Phil Blundell
2012-01-30 18:39 ` Koen Kooi
2012-02-02 17:57 ` Saul Wold
2 siblings, 2 replies; 9+ messages in thread
From: Joshua Lock @ 2012-01-30 17:50 UTC (permalink / raw)
To: Koen Kooi; +Cc: openembedded-core
Yikes, I don't know why I keep making this mistake. Thanks for catching
it Koen.
I thought we caught this in a QA error but I definitely didn't see it,
best investigate.
On 30/01/12 08:49, Koen Kooi wrote:
> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net>
Signed-off-by: Joshua Lock<josh@linux.intel.com>
Joshua
> ---
> meta/recipes-bsp/alsa-state/alsa-state.bb | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-bsp/alsa-state/alsa-state.bb b/meta/recipes-bsp/alsa-state/alsa-state.bb
> index bc17b25..83c9faa 100644
> --- a/meta/recipes-bsp/alsa-state/alsa-state.bb
> +++ b/meta/recipes-bsp/alsa-state/alsa-state.bb
> @@ -10,7 +10,7 @@ sound state at system boot and save it at system shut down."
> LICENSE = "MIT"
> LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> PV = "0.2.0"
> -PR = "r0"
> +PR = "r2"
>
> SRC_URI = "\
> file://asound.conf \
> @@ -18,8 +18,6 @@ SRC_URI = "\
> file://alsa-state \
> "
>
> -RDEPENDS = "alsa-utils-alsactl"
> -
> inherit update-rc.d
>
> INITSCRIPT_NAME = "alsa-state"
> @@ -39,6 +37,7 @@ PACKAGES += "alsa-states"
>
> RRECOMMENDS_alsa-state = "alsa-states"
>
> +RDEPENDS_${PN} = "alsa-utils-alsactl"
> FILES_${PN} = "${sysconfdir}/init.d ${sysconfdir}/asound.conf"
> CONFFILES_${PN} = "${sysconfdir}/asound.conf"
>
--
Joshua Lock
Yocto Project "Johannes factotum"
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/2] alsa-state: fix RDEPENDS assignment
2012-01-30 17:50 ` [PATCH 1/2] alsa-state: fix RDEPENDS assignment Joshua Lock
@ 2012-01-30 17:56 ` Phil Blundell
2012-01-30 18:17 ` Joshua Lock
2012-01-30 18:39 ` Koen Kooi
1 sibling, 1 reply; 9+ messages in thread
From: Phil Blundell @ 2012-01-30 17:56 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Mon, 2012-01-30 at 09:50 -0800, Joshua Lock wrote:
> Yikes, I don't know why I keep making this mistake. Thanks for catching
> it Koen.
>
> I thought we caught this in a QA error but I definitely didn't see it,
> best investigate.
It seems that Yocto doesn't enable those checks. Possibly it should, or
maybe we should just turn them on by default for everybody.
p.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] alsa-state: fix RDEPENDS assignment
2012-01-30 17:56 ` Phil Blundell
@ 2012-01-30 18:17 ` Joshua Lock
0 siblings, 0 replies; 9+ messages in thread
From: Joshua Lock @ 2012-01-30 18:17 UTC (permalink / raw)
To: openembedded-core
On 30/01/12 09:56, Phil Blundell wrote:
> On Mon, 2012-01-30 at 09:50 -0800, Joshua Lock wrote:
>> Yikes, I don't know why I keep making this mistake. Thanks for catching
>> it Koen.
>>
>> I thought we caught this in a QA error but I definitely didn't see it,
>> best investigate.
>
> It seems that Yocto doesn't enable those checks. Possibly it should, or
> maybe we should just turn them on by default for everybody.
Personally, I feel that this check is useful enough to be turned on by
default.
Cheers,
Joshua
--
Joshua Lock
Yocto Project "Johannes factotum"
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] alsa-state: fix RDEPENDS assignment
2012-01-30 17:50 ` [PATCH 1/2] alsa-state: fix RDEPENDS assignment Joshua Lock
2012-01-30 17:56 ` Phil Blundell
@ 2012-01-30 18:39 ` Koen Kooi
2012-01-30 20:09 ` Saul Wold
1 sibling, 1 reply; 9+ messages in thread
From: Koen Kooi @ 2012-01-30 18:39 UTC (permalink / raw)
To: Joshua Lock; +Cc: openembedded-core
Op 30 jan. 2012, om 18:50 heeft Joshua Lock het volgende geschreven:
> Yikes, I don't know why I keep making this mistake. Thanks for catching it Koen.
I'm still finding recipes that I wrote that have that mistake :)
> I thought we caught this in a QA error but I definitely didn't see it, best investigate.
it's part of recipe-sanity, which you need to call manually.
regards,
Koen
>
> On 30/01/12 08:49, Koen Kooi wrote:
>> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net>
> Signed-off-by: Joshua Lock<josh@linux.intel.com>
>
> Joshua
>
>> ---
>> meta/recipes-bsp/alsa-state/alsa-state.bb | 5 ++---
>> 1 files changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta/recipes-bsp/alsa-state/alsa-state.bb b/meta/recipes-bsp/alsa-state/alsa-state.bb
>> index bc17b25..83c9faa 100644
>> --- a/meta/recipes-bsp/alsa-state/alsa-state.bb
>> +++ b/meta/recipes-bsp/alsa-state/alsa-state.bb
>> @@ -10,7 +10,7 @@ sound state at system boot and save it at system shut down."
>> LICENSE = "MIT"
>> LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
>> PV = "0.2.0"
>> -PR = "r0"
>> +PR = "r2"
>>
>> SRC_URI = "\
>> file://asound.conf \
>> @@ -18,8 +18,6 @@ SRC_URI = "\
>> file://alsa-state \
>> "
>>
>> -RDEPENDS = "alsa-utils-alsactl"
>> -
>> inherit update-rc.d
>>
>> INITSCRIPT_NAME = "alsa-state"
>> @@ -39,6 +37,7 @@ PACKAGES += "alsa-states"
>>
>> RRECOMMENDS_alsa-state = "alsa-states"
>>
>> +RDEPENDS_${PN} = "alsa-utils-alsactl"
>> FILES_${PN} = "${sysconfdir}/init.d ${sysconfdir}/asound.conf"
>> CONFFILES_${PN} = "${sysconfdir}/asound.conf"
>>
>
> --
> Joshua Lock
> Yocto Project "Johannes factotum"
> Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/2] alsa-state: fix RDEPENDS assignment
2012-01-30 18:39 ` Koen Kooi
@ 2012-01-30 20:09 ` Saul Wold
0 siblings, 0 replies; 9+ messages in thread
From: Saul Wold @ 2012-01-30 20:09 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: Koen Kooi
On 01/30/2012 10:39 AM, Koen Kooi wrote:
> Op 30 jan. 2012, om 18:50 heeft Joshua Lock het volgende geschreven:
>
>> Yikes, I don't know why I keep making this mistake. Thanks for catching it Koen.
>
> I'm still finding recipes that I wrote that have that mistake :)
>
>> I thought we caught this in a QA error but I definitely didn't see it, best investigate.
>
> it's part of recipe-sanity, which you need to call manually.
>
Time to add that to my checklist! I have a set of things I am trying to
remember to do (they don't always get done, but I try) to validate recipes.
Sau!
> regards,
>
> Koen
>
>
>>
>> On 30/01/12 08:49, Koen Kooi wrote:
>>> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net>
>> Signed-off-by: Joshua Lock<josh@linux.intel.com>
>>
>> Joshua
>>
>>> ---
>>> meta/recipes-bsp/alsa-state/alsa-state.bb | 5 ++---
>>> 1 files changed, 2 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/meta/recipes-bsp/alsa-state/alsa-state.bb b/meta/recipes-bsp/alsa-state/alsa-state.bb
>>> index bc17b25..83c9faa 100644
>>> --- a/meta/recipes-bsp/alsa-state/alsa-state.bb
>>> +++ b/meta/recipes-bsp/alsa-state/alsa-state.bb
>>> @@ -10,7 +10,7 @@ sound state at system boot and save it at system shut down."
>>> LICENSE = "MIT"
>>> LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
>>> PV = "0.2.0"
>>> -PR = "r0"
>>> +PR = "r2"
>>>
>>> SRC_URI = "\
>>> file://asound.conf \
>>> @@ -18,8 +18,6 @@ SRC_URI = "\
>>> file://alsa-state \
>>> "
>>>
>>> -RDEPENDS = "alsa-utils-alsactl"
>>> -
>>> inherit update-rc.d
>>>
>>> INITSCRIPT_NAME = "alsa-state"
>>> @@ -39,6 +37,7 @@ PACKAGES += "alsa-states"
>>>
>>> RRECOMMENDS_alsa-state = "alsa-states"
>>>
>>> +RDEPENDS_${PN} = "alsa-utils-alsactl"
>>> FILES_${PN} = "${sysconfdir}/init.d ${sysconfdir}/asound.conf"
>>> CONFFILES_${PN} = "${sysconfdir}/asound.conf"
>>>
>>
>> --
>> Joshua Lock
>> Yocto Project "Johannes factotum"
>> Intel Open Source Technology Centre
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] alsa-state: fix RDEPENDS assignment
2012-01-30 16:49 [PATCH 1/2] alsa-state: fix RDEPENDS assignment Koen Kooi
2012-01-30 16:49 ` [PATCH 2/2] alsa-utils: make alsa-utils-alsactl recommend alsa-states Koen Kooi
2012-01-30 17:50 ` [PATCH 1/2] alsa-state: fix RDEPENDS assignment Joshua Lock
@ 2012-02-02 17:57 ` Saul Wold
2 siblings, 0 replies; 9+ messages in thread
From: Saul Wold @ 2012-02-02 17:57 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: Koen Kooi
On 01/30/2012 08:49 AM, Koen Kooi wrote:
> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net>
> ---
> meta/recipes-bsp/alsa-state/alsa-state.bb | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-bsp/alsa-state/alsa-state.bb b/meta/recipes-bsp/alsa-state/alsa-state.bb
> index bc17b25..83c9faa 100644
> --- a/meta/recipes-bsp/alsa-state/alsa-state.bb
> +++ b/meta/recipes-bsp/alsa-state/alsa-state.bb
> @@ -10,7 +10,7 @@ sound state at system boot and save it at system shut down."
> LICENSE = "MIT"
> LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> PV = "0.2.0"
> -PR = "r0"
> +PR = "r2"
>
> SRC_URI = "\
> file://asound.conf \
> @@ -18,8 +18,6 @@ SRC_URI = "\
> file://alsa-state \
> "
>
> -RDEPENDS = "alsa-utils-alsactl"
> -
> inherit update-rc.d
>
> INITSCRIPT_NAME = "alsa-state"
> @@ -39,6 +37,7 @@ PACKAGES += "alsa-states"
>
> RRECOMMENDS_alsa-state = "alsa-states"
>
> +RDEPENDS_${PN} = "alsa-utils-alsactl"
> FILES_${PN} = "${sysconfdir}/init.d ${sysconfdir}/asound.conf"
> CONFFILES_${PN} = "${sysconfdir}/asound.conf"
>
Merged this along with the alsa-utils to OE-core
Thanks
Sau!
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-02-02 18:05 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-30 16:49 [PATCH 1/2] alsa-state: fix RDEPENDS assignment Koen Kooi
2012-01-30 16:49 ` [PATCH 2/2] alsa-utils: make alsa-utils-alsactl recommend alsa-states Koen Kooi
2012-01-30 17:51 ` Joshua Lock
2012-01-30 17:50 ` [PATCH 1/2] alsa-state: fix RDEPENDS assignment Joshua Lock
2012-01-30 17:56 ` Phil Blundell
2012-01-30 18:17 ` Joshua Lock
2012-01-30 18:39 ` Koen Kooi
2012-01-30 20:09 ` Saul Wold
2012-02-02 17:57 ` Saul Wold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox