Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] wireless-tools: remove ldconfig call from install-libs
@ 2012-02-15 19:59 Martin Jansa
  2012-02-24 18:17 ` Saul Wold
  0 siblings, 1 reply; 2+ messages in thread
From: Martin Jansa @ 2012-02-15 19:59 UTC (permalink / raw)
  To: openembedded-core

* and drop apply=yes param as it's not needed

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 .../wireless-tools/remove.ldconfig.call.patch      |   19 +++++++++++++++++++
 .../wireless-tools/wireless-tools_29.bb            |    5 +++--
 2 files changed, 22 insertions(+), 2 deletions(-)
 create mode 100644 meta/recipes-connectivity/wireless-tools/wireless-tools/remove.ldconfig.call.patch

diff --git a/meta/recipes-connectivity/wireless-tools/wireless-tools/remove.ldconfig.call.patch b/meta/recipes-connectivity/wireless-tools/wireless-tools/remove.ldconfig.call.patch
new file mode 100644
index 0000000..3a22c3f
--- /dev/null
+++ b/meta/recipes-connectivity/wireless-tools/wireless-tools/remove.ldconfig.call.patch
@@ -0,0 +1,19 @@
+When /etc/ld.so.cache is writeable by user running bitbake then it creates invalid cache 
+(in my case libstdc++.so cannot be found after building zlib(-native) and I have to call 
+touch */libstdc++.so && /sbin/ldconfig to fix it.
+
+So remove ldconfig call from make install-libs
+
+Upstream-Status: Inappropriate [disable feature]
+
+diff -uNr wireless_tools.29.orig/Makefile wireless_tools.29/Makefile
+--- wireless_tools.29.orig/Makefile	2007-09-18 01:56:46.000000000 +0200
++++ wireless_tools.29/Makefile	2012-02-15 20:46:41.780763514 +0100
+@@ -163,7 +163,6 @@
+ 	install -m 755 $(DYNAMIC) $(INSTALL_LIB)
+ 	ln -sfn $(DYNAMIC) $(INSTALL_LIB)/$(DYNAMIC_LINK)
+ 	@echo "*** Don't forget to add $(INSTALL_LIB) to /etc/ld.so.conf, and run ldconfig as root. ***"
+-	@$(LDCONFIG) || echo "*** Could not run ldconfig ! ***"
+ 
+ # Install the static library
+ install-static:: $(STATIC)
diff --git a/meta/recipes-connectivity/wireless-tools/wireless-tools_29.bb b/meta/recipes-connectivity/wireless-tools/wireless-tools_29.bb
index cc51dec..c6235d6 100644
--- a/meta/recipes-connectivity/wireless-tools/wireless-tools_29.bb
+++ b/meta/recipes-connectivity/wireless-tools/wireless-tools_29.bb
@@ -7,10 +7,11 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
 			file://sample_enc.c;beginline=1;endline=4;md5=838372be07874260b566bae2f6ed33b6"
 SECTION = "base"
 PE = "1"
-PR = "r2"
+PR = "r3"
 
 SRC_URI = "http://www.hpl.hp.com/personal/Jean_Tourrilhes/Linux/wireless_tools.29.tar.gz \
-           file://man.patch;apply=yes \
+	   file://remove.ldconfig.call.patch \
+	   file://man.patch \
 	   file://wireless-tools.if-pre-up \
 	   file://zzz-wireless.if-pre-up \
 	   file://avoid_strip.patch"
-- 
1.7.8.4




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] wireless-tools: remove ldconfig call from install-libs
  2012-02-15 19:59 [PATCH] wireless-tools: remove ldconfig call from install-libs Martin Jansa
@ 2012-02-24 18:17 ` Saul Wold
  0 siblings, 0 replies; 2+ messages in thread
From: Saul Wold @ 2012-02-24 18:17 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer; +Cc: Martin Jansa

On 02/15/2012 11:59 AM, Martin Jansa wrote:
> * and drop apply=yes param as it's not needed
>
> Signed-off-by: Martin Jansa<Martin.Jansa@gmail.com>
> ---
>   .../wireless-tools/remove.ldconfig.call.patch      |   19 +++++++++++++++++++
>   .../wireless-tools/wireless-tools_29.bb            |    5 +++--
>   2 files changed, 22 insertions(+), 2 deletions(-)
>   create mode 100644 meta/recipes-connectivity/wireless-tools/wireless-tools/remove.ldconfig.call.patch
>
> diff --git a/meta/recipes-connectivity/wireless-tools/wireless-tools/remove.ldconfig.call.patch b/meta/recipes-connectivity/wireless-tools/wireless-tools/remove.ldconfig.call.patch
> new file mode 100644
> index 0000000..3a22c3f
> --- /dev/null
> +++ b/meta/recipes-connectivity/wireless-tools/wireless-tools/remove.ldconfig.call.patch
> @@ -0,0 +1,19 @@
> +When /etc/ld.so.cache is writeable by user running bitbake then it creates invalid cache
> +(in my case libstdc++.so cannot be found after building zlib(-native) and I have to call
> +touch */libstdc++.so&&  /sbin/ldconfig to fix it.
> +
> +So remove ldconfig call from make install-libs
> +
> +Upstream-Status: Inappropriate [disable feature]
> +
> +diff -uNr wireless_tools.29.orig/Makefile wireless_tools.29/Makefile
> +--- wireless_tools.29.orig/Makefile	2007-09-18 01:56:46.000000000 +0200
> ++++ wireless_tools.29/Makefile	2012-02-15 20:46:41.780763514 +0100
> +@@ -163,7 +163,6 @@
> + 	install -m 755 $(DYNAMIC) $(INSTALL_LIB)
> + 	ln -sfn $(DYNAMIC) $(INSTALL_LIB)/$(DYNAMIC_LINK)
> + 	@echo "*** Don't forget to add $(INSTALL_LIB) to /etc/ld.so.conf, and run ldconfig as root. ***"
> +-	@$(LDCONFIG) || echo "*** Could not run ldconfig ! ***"
> +
> + # Install the static library
> + install-static:: $(STATIC)
> diff --git a/meta/recipes-connectivity/wireless-tools/wireless-tools_29.bb b/meta/recipes-connectivity/wireless-tools/wireless-tools_29.bb
> index cc51dec..c6235d6 100644
> --- a/meta/recipes-connectivity/wireless-tools/wireless-tools_29.bb
> +++ b/meta/recipes-connectivity/wireless-tools/wireless-tools_29.bb
> @@ -7,10 +7,11 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
>   			file://sample_enc.c;beginline=1;endline=4;md5=838372be07874260b566bae2f6ed33b6"
>   SECTION = "base"
>   PE = "1"
> -PR = "r2"
> +PR = "r3"
>
>   SRC_URI = "http://www.hpl.hp.com/personal/Jean_Tourrilhes/Linux/wireless_tools.29.tar.gz \
> -           file://man.patch;apply=yes \
> +	   file://remove.ldconfig.call.patch \
> +	   file://man.patch \
>   	   file://wireless-tools.if-pre-up \
>   	   file://zzz-wireless.if-pre-up \
>   	   file://avoid_strip.patch"

Merged into OE-core

Thanks
	Sau!



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-02-24 18:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-15 19:59 [PATCH] wireless-tools: remove ldconfig call from install-libs Martin Jansa
2012-02-24 18:17 ` Saul Wold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox