* [PATCH] bootimg bbclass: quoting fixes
@ 2012-02-28 15:50 Koen Kooi
2012-02-28 16:48 ` Saul Wold
0 siblings, 1 reply; 3+ messages in thread
From: Koen Kooi @ 2012-02-28 15:50 UTC (permalink / raw)
To: openembedded-core; +Cc: Koen Kooi
Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
meta/classes/bootimg.bbclass | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/classes/bootimg.bbclass b/meta/classes/bootimg.bbclass
index 1d1a3d0..c4a4c2a 100644
--- a/meta/classes/bootimg.bbclass
+++ b/meta/classes/bootimg.bbclass
@@ -35,8 +35,8 @@ ISODIR = "${S}/iso"
BOOTIMG_VOLUME_ID ?= "boot"
BOOTIMG_EXTRA_SPACE ?= "512"
-EFI = ${@base_contains("MACHINE_FEATURES", "efi", "1", "0", d)}
-EFI_CLASS = ${@base_contains("MACHINE_FEATURES", "efi", "grub-efi", "dummy", d)}
+EFI = '${@base_contains("MACHINE_FEATURES", "efi", "1", "0", d)}'
+EFI_CLASS = '${@base_contains("MACHINE_FEATURES", "efi", "grub-efi", "dummy", d)}'
# Include legacy boot if MACHINE_FEATURES includes "pcbios" or if it does not
# contain "efi". This way legacy is supported by default if neither is
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bootimg bbclass: quoting fixes
2012-02-28 15:50 [PATCH] bootimg bbclass: quoting fixes Koen Kooi
@ 2012-02-28 16:48 ` Saul Wold
2012-02-28 17:04 ` Koen Kooi
0 siblings, 1 reply; 3+ messages in thread
From: Saul Wold @ 2012-02-28 16:48 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: Koen Kooi
On 02/28/2012 07:50 AM, Koen Kooi wrote:
> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net>
> ---
> meta/classes/bootimg.bbclass | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/bootimg.bbclass b/meta/classes/bootimg.bbclass
> index 1d1a3d0..c4a4c2a 100644
> --- a/meta/classes/bootimg.bbclass
> +++ b/meta/classes/bootimg.bbclass
> @@ -35,8 +35,8 @@ ISODIR = "${S}/iso"
> BOOTIMG_VOLUME_ID ?= "boot"
> BOOTIMG_EXTRA_SPACE ?= "512"
>
> -EFI = ${@base_contains("MACHINE_FEATURES", "efi", "1", "0", d)}
> -EFI_CLASS = ${@base_contains("MACHINE_FEATURES", "efi", "grub-efi", "dummy", d)}
> +EFI = '${@base_contains("MACHINE_FEATURES", "efi", "1", "0", d)}'
> +EFI_CLASS = '${@base_contains("MACHINE_FEATURES", "efi", "grub-efi", "dummy", d)}'
>
> # Include legacy boot if MACHINE_FEATURES includes "pcbios" or if it does not
> # contain "efi". This way legacy is supported by default if neither is
This actually needs more changes, see my patch.
Sau!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bootimg bbclass: quoting fixes
2012-02-28 16:48 ` Saul Wold
@ 2012-02-28 17:04 ` Koen Kooi
0 siblings, 0 replies; 3+ messages in thread
From: Koen Kooi @ 2012-02-28 17:04 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
Op 28 feb. 2012, om 17:48 heeft Saul Wold het volgende geschreven:
> On 02/28/2012 07:50 AM, Koen Kooi wrote:
>> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net>
>> ---
>> meta/classes/bootimg.bbclass | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/classes/bootimg.bbclass b/meta/classes/bootimg.bbclass
>> index 1d1a3d0..c4a4c2a 100644
>> --- a/meta/classes/bootimg.bbclass
>> +++ b/meta/classes/bootimg.bbclass
>> @@ -35,8 +35,8 @@ ISODIR = "${S}/iso"
>> BOOTIMG_VOLUME_ID ?= "boot"
>> BOOTIMG_EXTRA_SPACE ?= "512"
>>
>> -EFI = ${@base_contains("MACHINE_FEATURES", "efi", "1", "0", d)}
>> -EFI_CLASS = ${@base_contains("MACHINE_FEATURES", "efi", "grub-efi", "dummy", d)}
>> +EFI = '${@base_contains("MACHINE_FEATURES", "efi", "1", "0", d)}'
>> +EFI_CLASS = '${@base_contains("MACHINE_FEATURES", "efi", "grub-efi", "dummy", d)}'
>>
>> # Include legacy boot if MACHINE_FEATURES includes "pcbios" or if it does not
>> # contain "efi". This way legacy is supported by default if neither is
> This actually needs more changes, see my patch.
Indeed, I resorted to using 'rm' for fix quoting issues :)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-28 17:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-28 15:50 [PATCH] bootimg bbclass: quoting fixes Koen Kooi
2012-02-28 16:48 ` Saul Wold
2012-02-28 17:04 ` Koen Kooi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox