Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] mtd-utils: Don't use host 'ranlib' or 'ar'.
@ 2012-02-28  3:49 James Limbouris
  2012-02-28 18:46 ` Saul Wold
  0 siblings, 1 reply; 2+ messages in thread
From: James Limbouris @ 2012-02-28  3:49 UTC (permalink / raw)
  To: openembedded-core

If ranlib, ar, or cc are not supplied to make, it attempts to use ${CROSS}xxx.
Since ${CROSS} is not set, host ranlib may run, producing an unusable .a file on some platforms.

Signed-off-by: James Limbouris <james@digitalmatter.com.au>
---
 meta/recipes-devtools/mtd/mtd-utils_1.4.9.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-devtools/mtd/mtd-utils_1.4.9.bb b/meta/recipes-devtools/mtd/mtd-utils_1.4.9.bb
index 519472c..4228b51 100644
--- a/meta/recipes-devtools/mtd/mtd-utils_1.4.9.bb
+++ b/meta/recipes-devtools/mtd/mtd-utils_1.4.9.bb
@@ -11,9 +11,9 @@ SRC_URI = "git://git.infradead.org/mtd-utils.git;protocol=git;tag=995cfe51b0a3cf
 
 S = "${WORKDIR}/git/"
 
-PR = "r0"
+PR = "r1"
 
-EXTRA_OEMAKE = "'CC=${CC}' 'CFLAGS=${CFLAGS} -I${S}/include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
+EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}/include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
 
 do_install () {
 	oe_runmake install DESTDIR=${D} SBINDIR=${sbindir} MANDIR=${mandir} INCLUDEDIR=${includedir}
-- 
1.7.3.4




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mtd-utils: Don't use host 'ranlib' or 'ar'.
  2012-02-28  3:49 [PATCH] mtd-utils: Don't use host 'ranlib' or 'ar' James Limbouris
@ 2012-02-28 18:46 ` Saul Wold
  0 siblings, 0 replies; 2+ messages in thread
From: Saul Wold @ 2012-02-28 18:46 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

On 02/27/2012 07:49 PM, James Limbouris wrote:
> If ranlib, ar, or cc are not supplied to make, it attempts to use ${CROSS}xxx.
> Since ${CROSS} is not set, host ranlib may run, producing an unusable .a file on some platforms.
>
> Signed-off-by: James Limbouris<james@digitalmatter.com.au>
> ---
>   meta/recipes-devtools/mtd/mtd-utils_1.4.9.bb |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-devtools/mtd/mtd-utils_1.4.9.bb b/meta/recipes-devtools/mtd/mtd-utils_1.4.9.bb
> index 519472c..4228b51 100644
> --- a/meta/recipes-devtools/mtd/mtd-utils_1.4.9.bb
> +++ b/meta/recipes-devtools/mtd/mtd-utils_1.4.9.bb
> @@ -11,9 +11,9 @@ SRC_URI = "git://git.infradead.org/mtd-utils.git;protocol=git;tag=995cfe51b0a3cf
>
>   S = "${WORKDIR}/git/"
>
> -PR = "r0"
> +PR = "r1"
>
> -EXTRA_OEMAKE = "'CC=${CC}' 'CFLAGS=${CFLAGS} -I${S}/include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
> +EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}/include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
>
>   do_install () {
>   	oe_runmake install DESTDIR=${D} SBINDIR=${sbindir} MANDIR=${mandir} INCLUDEDIR=${includedir}

Merged into OE-core

Thanks
	Sau!



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-02-28 18:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-28  3:49 [PATCH] mtd-utils: Don't use host 'ranlib' or 'ar' James Limbouris
2012-02-28 18:46 ` Saul Wold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox