* [PATCH] qt4.inc: depend on tiff @ 2012-02-27 17:10 Andreas Oberritter 2012-02-27 17:20 ` Otavio Salvador 0 siblings, 1 reply; 9+ messages in thread From: Andreas Oberritter @ 2012-02-27 17:10 UTC (permalink / raw) To: openembedded-core * Fixes the following error with qt4-embedded-4.8.0 and possibly others: | ../../../gui/image/qtiffhandler.cpp:48:20: fatal error: tiffio.h: No such file or directory Signed-off-by: Andreas Oberritter <obi@opendreambox.org> --- meta/recipes-qt/qt4/qt4.inc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/meta/recipes-qt/qt4/qt4.inc b/meta/recipes-qt/qt4/qt4.inc index ea868ff..a16a475 100644 --- a/meta/recipes-qt/qt4/qt4.inc +++ b/meta/recipes-qt/qt4/qt4.inc @@ -1,6 +1,6 @@ inherit qmake_base -DEPENDS += "qt4-tools-native freetype jpeg libpng zlib dbus openssl glib-2.0 gstreamer gst-plugins-base sqlite3" +DEPENDS += "qt4-tools-native freetype jpeg libpng zlib dbus openssl glib-2.0 gstreamer gst-plugins-base sqlite3 tiff" require qt4_arch.inc QT_ARCH := "${@qt_arch(d)}" -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] qt4.inc: depend on tiff 2012-02-27 17:10 [PATCH] qt4.inc: depend on tiff Andreas Oberritter @ 2012-02-27 17:20 ` Otavio Salvador 2012-02-27 17:24 ` Paul Eggleton 0 siblings, 1 reply; 9+ messages in thread From: Otavio Salvador @ 2012-02-27 17:20 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On Mon, Feb 27, 2012 at 14:10, Andreas Oberritter <obi@opendreambox.org> wrote: > * Fixes the following error with qt4-embedded-4.8.0 and possibly others: > > | ../../../gui/image/qtiffhandler.cpp:48:20: fatal error: tiffio.h: No such file or directory Please bump INC_PR. -- Otavio Salvador O.S. Systems E-mail: otavio@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] qt4.inc: depend on tiff 2012-02-27 17:20 ` Otavio Salvador @ 2012-02-27 17:24 ` Paul Eggleton 2012-02-28 1:02 ` [PATCH v2] " Andreas Oberritter 0 siblings, 1 reply; 9+ messages in thread From: Paul Eggleton @ 2012-02-27 17:24 UTC (permalink / raw) To: openembedded-core On Monday 27 February 2012 14:20:15 Otavio Salvador wrote: > On Mon, Feb 27, 2012 at 14:10, Andreas Oberritter <obi@opendreambox.org> wrote: > > * Fixes the following error with qt4-embedded-4.8.0 and possibly others: > > | ../../../gui/image/qtiffhandler.cpp:48:20: fatal error: tiffio.h: No > > | such file or directory > Please bump INC_PR. FYI, there's no INC_PR in qt4.inc but you can bump INC_PR in qt4-embedded.inc and qt4-x11-free.inc since those are the only places that include qt4.inc. Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] qt4.inc: depend on tiff 2012-02-27 17:24 ` Paul Eggleton @ 2012-02-28 1:02 ` Andreas Oberritter 2012-02-28 1:46 ` Otavio Salvador 2012-02-28 18:55 ` Saul Wold 0 siblings, 2 replies; 9+ messages in thread From: Andreas Oberritter @ 2012-02-28 1:02 UTC (permalink / raw) To: openembedded-core On 27.02.2012 18:24, Paul Eggleton wrote: > On Monday 27 February 2012 14:20:15 Otavio Salvador wrote: >> On Mon, Feb 27, 2012 at 14:10, Andreas Oberritter <obi@opendreambox.org> > wrote: >>> * Fixes the following error with qt4-embedded-4.8.0 and possibly others: >>> | ../../../gui/image/qtiffhandler.cpp:48:20: fatal error: tiffio.h: No >>> | such file or directory >> Please bump INC_PR. > > FYI, there's no INC_PR in qt4.inc but you can bump INC_PR in qt4-embedded.inc > and qt4-x11-free.inc since those are the only places that include qt4.inc. In this case, bumping PR just wastes everybody's CPU cycles for no gain. Anyway, here's an updated patch: From fdececee9146f4d23494361d29a34877d67b879b Mon Sep 17 00:00:00 2001 From: Andreas Oberritter <obi@opendreambox.org> Date: Mon, 27 Feb 2012 18:03:22 +0100 Subject: [PATCH] qt4.inc: depend on tiff * Fixes the following error with qt4-embedded-4.8.0 and possibly others: | ../../../gui/image/qtiffhandler.cpp:48:20: fatal error: tiffio.h: No such file or directory Signed-off-by: Andreas Oberritter <obi@opendreambox.org> --- meta/recipes-qt/qt4/qt4-embedded.inc | 2 +- meta/recipes-qt/qt4/qt4-x11-free.inc | 2 +- meta/recipes-qt/qt4/qt4.inc | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/meta/recipes-qt/qt4/qt4-embedded.inc b/meta/recipes-qt/qt4/qt4-embedded.inc index e472af5..80948f3 100644 --- a/meta/recipes-qt/qt4/qt4-embedded.inc +++ b/meta/recipes-qt/qt4/qt4-embedded.inc @@ -2,7 +2,7 @@ DESCRIPTION = "Qt is a versatile cross-platform application framework -- this is SECTION = "libs" HOMEPAGE = "http://qt.nokia.com" DEPENDS += "directfb tslib" -INC_PR = "r40" +INC_PR = "r41" QT_BASE_LIB ?= "libqt-embedded" diff --git a/meta/recipes-qt/qt4/qt4-x11-free.inc b/meta/recipes-qt/qt4/qt4-x11-free.inc index 40939de..75487f7 100644 --- a/meta/recipes-qt/qt4/qt4-x11-free.inc +++ b/meta/recipes-qt/qt4/qt4-x11-free.inc @@ -5,7 +5,7 @@ HOMEPAGE = "http://qt.nokia.com" SECTION = "x11/libs" DEPENDS += "virtual/libgl virtual/libx11 fontconfig libxft libxext libxrender libxrandr libxcursor" -INC_PR = "r37" +INC_PR = "r38" QT_GLFLAGS ?= "${@base_contains('DISTRO_FEATURES', 'opengl', '-opengl', '-no-opengl', d)} " QT_GLFLAGS_qemux86 = "-opengl" diff --git a/meta/recipes-qt/qt4/qt4.inc b/meta/recipes-qt/qt4/qt4.inc index ea868ff..161daa3 100644 --- a/meta/recipes-qt/qt4/qt4.inc +++ b/meta/recipes-qt/qt4/qt4.inc @@ -1,6 +1,6 @@ inherit qmake_base -DEPENDS += "qt4-tools-native freetype jpeg libpng zlib dbus openssl glib-2.0 gstreamer gst-plugins-base sqlite3" +DEPENDS += "qt4-tools-native freetype jpeg libpng zlib dbus openssl glib-2.0 gstreamer gst-plugins-base sqlite3 tiff" require qt4_arch.inc QT_ARCH := "${@qt_arch(d)}" @@ -15,7 +15,7 @@ QT_GLFLAGS ?= "" QT_CONFIG_FLAGS += "-release -no-cups -reduce-relocations \ -shared -no-nas-sound -no-nis \ - -system-libjpeg -system-libpng -system-zlib \ + -system-libjpeg -system-libpng -system-libtiff -system-zlib \ -no-pch -qdbus -stl -glib -phonon -webkit \ -xmlpatterns -no-rpath -qt3support -silent \ ${QT_SQL_DRIVER_FLAGS} \ -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2] qt4.inc: depend on tiff 2012-02-28 1:02 ` [PATCH v2] " Andreas Oberritter @ 2012-02-28 1:46 ` Otavio Salvador 2012-02-28 6:50 ` Martin Jansa 2012-02-28 18:55 ` Saul Wold 1 sibling, 1 reply; 9+ messages in thread From: Otavio Salvador @ 2012-02-28 1:46 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On Mon, Feb 27, 2012 at 22:02, Andreas Oberritter <obi@opendreambox.org> wrote: > In this case, bumping PR just wastes everybody's CPU cycles for no gain. > Anyway, here's an updated patch: Not really; let's say if you had done a typo on the depends list it would be unnoticed in autobuilders and commited onto master. -- Otavio Salvador O.S. Systems E-mail: otavio@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] qt4.inc: depend on tiff 2012-02-28 1:46 ` Otavio Salvador @ 2012-02-28 6:50 ` Martin Jansa 2012-02-28 12:16 ` Otavio Salvador 0 siblings, 1 reply; 9+ messages in thread From: Martin Jansa @ 2012-02-28 6:50 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On Tue, Feb 28, 2012 at 2:46 AM, Otavio Salvador <otavio@ossystems.com.br> wrote: > On Mon, Feb 27, 2012 at 22:02, Andreas Oberritter <obi@opendreambox.org> wrote: >> In this case, bumping PR just wastes everybody's CPU cycles for no gain. >> Anyway, here's an updated patch: > > Not really; let's say if you had done a typo on the depends list it > would be unnoticed in autobuilders and commited onto master. I see your point, but OEBasicHash will notice new dependency and then it will be rebuild at least by poky autobuilders (if they are building qt4). ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] qt4.inc: depend on tiff 2012-02-28 6:50 ` Martin Jansa @ 2012-02-28 12:16 ` Otavio Salvador 2012-02-28 12:25 ` Martin Jansa 0 siblings, 1 reply; 9+ messages in thread From: Otavio Salvador @ 2012-02-28 12:16 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On Tue, Feb 28, 2012 at 03:50, Martin Jansa <martin.jansa@gmail.com> wrote: >> Not really; let's say if you had done a typo on the depends list it >> would be unnoticed in autobuilders and commited onto master. > > I see your point, but OEBasicHash will notice new dependency and then > it will be rebuild > at least by poky autobuilders (if they are building qt4). We're not using auto PR yet so let's keep the regular flow for now. -- Otavio Salvador O.S. Systems E-mail: otavio@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] qt4.inc: depend on tiff 2012-02-28 12:16 ` Otavio Salvador @ 2012-02-28 12:25 ` Martin Jansa 0 siblings, 0 replies; 9+ messages in thread From: Martin Jansa @ 2012-02-28 12:25 UTC (permalink / raw) To: Patches and discussions about the oe-core layer [-- Attachment #1: Type: text/plain, Size: 713 bytes --] On Tue, Feb 28, 2012 at 09:16:51AM -0300, Otavio Salvador wrote: > On Tue, Feb 28, 2012 at 03:50, Martin Jansa <martin.jansa@gmail.com> wrote: > >> Not really; let's say if you had done a typo on the depends list it > >> would be unnoticed in autobuilders and commited onto master. > > > > I see your point, but OEBasicHash will notice new dependency and then > > it will be rebuild > > at least by poky autobuilders (if they are building qt4). > > We're not using auto PR yet so let's keep the regular flow for now. I'm not agains PR bump I'm just saying it would be rebuilt with OEBasicHash even without PR bump.. and without PRSERV -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] qt4.inc: depend on tiff 2012-02-28 1:02 ` [PATCH v2] " Andreas Oberritter 2012-02-28 1:46 ` Otavio Salvador @ 2012-02-28 18:55 ` Saul Wold 1 sibling, 0 replies; 9+ messages in thread From: Saul Wold @ 2012-02-28 18:55 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On 02/27/2012 05:02 PM, Andreas Oberritter wrote: > From fdececee9146f4d23494361d29a34877d67b879b Mon Sep 17 00:00:00 2001 > From: Andreas Oberritter<obi@opendreambox.org> > Date: Mon, 27 Feb 2012 18:03:22 +0100 > Subject: [PATCH] qt4.inc: depend on tiff > > * Fixes the following error with qt4-embedded-4.8.0 and possibly others: > > | ../../../gui/image/qtiffhandler.cpp:48:20: fatal error: tiffio.h: No such file or directory > > Signed-off-by: Andreas Oberritter<obi@opendreambox.org> > --- > meta/recipes-qt/qt4/qt4-embedded.inc | 2 +- > meta/recipes-qt/qt4/qt4-x11-free.inc | 2 +- > meta/recipes-qt/qt4/qt4.inc | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/meta/recipes-qt/qt4/qt4-embedded.inc b/meta/recipes-qt/qt4/qt4-embedded.inc > index e472af5..80948f3 100644 > --- a/meta/recipes-qt/qt4/qt4-embedded.inc > +++ b/meta/recipes-qt/qt4/qt4-embedded.inc > @@ -2,7 +2,7 @@ DESCRIPTION = "Qt is a versatile cross-platform application framework -- this is > SECTION = "libs" > HOMEPAGE ="http://qt.nokia.com" > DEPENDS += "directfb tslib" > -INC_PR = "r40" > +INC_PR = "r41" > > QT_BASE_LIB ?= "libqt-embedded" > > diff --git a/meta/recipes-qt/qt4/qt4-x11-free.inc b/meta/recipes-qt/qt4/qt4-x11-free.inc > index 40939de..75487f7 100644 > --- a/meta/recipes-qt/qt4/qt4-x11-free.inc > +++ b/meta/recipes-qt/qt4/qt4-x11-free.inc > @@ -5,7 +5,7 @@ HOMEPAGE ="http://qt.nokia.com" > SECTION = "x11/libs" > DEPENDS += "virtual/libgl virtual/libx11 fontconfig libxft libxext libxrender libxrandr libxcursor" > > -INC_PR = "r37" > +INC_PR = "r38" > > QT_GLFLAGS ?= "${@base_contains('DISTRO_FEATURES', 'opengl', '-opengl', '-no-opengl', d)} " > QT_GLFLAGS_qemux86 = "-opengl" > diff --git a/meta/recipes-qt/qt4/qt4.inc b/meta/recipes-qt/qt4/qt4.inc > index ea868ff..161daa3 100644 > --- a/meta/recipes-qt/qt4/qt4.inc > +++ b/meta/recipes-qt/qt4/qt4.inc > @@ -1,6 +1,6 @@ > inherit qmake_base > > -DEPENDS += "qt4-tools-native freetype jpeg libpng zlib dbus openssl glib-2.0 gstreamer gst-plugins-base sqlite3" > +DEPENDS += "qt4-tools-native freetype jpeg libpng zlib dbus openssl glib-2.0 gstreamer gst-plugins-base sqlite3 tiff" > > require qt4_arch.inc > QT_ARCH := "${@qt_arch(d)}" > @@ -15,7 +15,7 @@ QT_GLFLAGS ?= "" > > QT_CONFIG_FLAGS += "-release -no-cups -reduce-relocations \ > -shared -no-nas-sound -no-nis \ > - -system-libjpeg -system-libpng -system-zlib \ > + -system-libjpeg -system-libpng -system-libtiff -system-zlib \ > -no-pch -qdbus -stl -glib -phonon -webkit \ > -xmlpatterns -no-rpath -qt3support -silent \ > ${QT_SQL_DRIVER_FLAGS} \ > -- 1.7.5.4 Merged into OE-core Thanks Sau! ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-02-28 19:03 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-02-27 17:10 [PATCH] qt4.inc: depend on tiff Andreas Oberritter 2012-02-27 17:20 ` Otavio Salvador 2012-02-27 17:24 ` Paul Eggleton 2012-02-28 1:02 ` [PATCH v2] " Andreas Oberritter 2012-02-28 1:46 ` Otavio Salvador 2012-02-28 6:50 ` Martin Jansa 2012-02-28 12:16 ` Otavio Salvador 2012-02-28 12:25 ` Martin Jansa 2012-02-28 18:55 ` Saul Wold
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox