[image_types_uboot] getdepends for ext2.gz.u-boot

[image_types_uboot] getdepends for ext2.gz.u-boot

[Ni Qingliang]

Hello,

when using ext2.gz.u-boot as IMAGE_FSTYPES, I got error when doing
rootfs with error info:
genext2fs: command not found

after checked fuction imagetypes_getdepends, I guess the ext2's
dependency is not considered. maybe we should assign 'ext2' to
'basetype', but not 'type' directly.

Any idea?

def imagetypes_getdepends(d):
    ...
    for type in (d.getVar('IMAGE_FSTYPES', True) or "").split():
        ...
        basetype = type		# ??????????????????
        for ctype in ctypes:
            if type.endswith("." + ctype):
                basetype = type.rsplit(".", 1)[0]
                adddep(d.getVar("COMPRESS_DEPENDS_%s" % ctype, True),
deps)
                break
        adddep(d.getVar('IMAGE_DEPENDS_%s' % basetype, True) , deps)

    depstr = ""
    for dep in deps:
        depstr += " " + dep + ":do_populate_sysroot"
    return depstr


-- 
Yi Qingliang
niqingliang@insigma.com.cn
https://niqingliang2003.wordpress.com

Re: [image_types_uboot] getdepends for ext2.gz.u-boot

[Richard Purdie]

On Fri, 2012-03-02 at 16:08 +0800, Ni Qingliang wrote:
> Hello,
> 
> when using ext2.gz.u-boot as IMAGE_FSTYPES, I got error when doing
> rootfs with error info:
> genext2fs: command not found
> 
> after checked fuction imagetypes_getdepends, I guess the ext2's
> dependency is not considered. maybe we should assign 'ext2' to
> 'basetype', but not 'type' directly.
> 
> Any idea?

Does
http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=78ae63423f123f89a5c72c85539e6ed71bd2653d fix the problem for you?

Cheers,

Richard

Re: [image_types_uboot] getdepends for ext2.gz.u-boot

[Gary Thomas]

On 2012-03-02 05:34, Richard Purdie wrote:
> On Fri, 2012-03-02 at 16:08 +0800, Ni Qingliang wrote:
>> Hello,
>>
>> when using ext2.gz.u-boot as IMAGE_FSTYPES, I got error when doing
>> rootfs with error info:
>> genext2fs: command not found
>>
>> after checked fuction imagetypes_getdepends, I guess the ext2's
>> dependency is not considered. maybe we should assign 'ext2' to
>> 'basetype', but not 'type' directly.
>>
>> Any idea?
>
> Does
> http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=78ae63423f123f89a5c72c85539e6ed71bd2653d fix the problem for you?

This looks like what I'm doing with my own generator.  I tried
it, with & without this patch, and I don't get a ext2.gz.u-boot
image, only a broken link.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Re: [image_types_uboot] getdepends for ext2.gz.u-boot

[Richard Purdie]

On Fri, 2012-03-02 at 06:39 -0700, Gary Thomas wrote:
> On 2012-03-02 05:34, Richard Purdie wrote:
> > On Fri, 2012-03-02 at 16:08 +0800, Ni Qingliang wrote:
> >> Hello,
> >>
> >> when using ext2.gz.u-boot as IMAGE_FSTYPES, I got error when doing
> >> rootfs with error info:
> >> genext2fs: command not found
> >>
> >> after checked fuction imagetypes_getdepends, I guess the ext2's
> >> dependency is not considered. maybe we should assign 'ext2' to
> >> 'basetype', but not 'type' directly.
> >>
> >> Any idea?
> >
> > Does
> > http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=78ae63423f123f89a5c72c85539e6ed71bd2653d fix the problem for you?
> 
> This looks like what I'm doing with my own generator.  I tried
> it, with & without this patch, and I don't get a ext2.gz.u-boot
> image, only a broken link.

That sounds like what happens if you don't inherit image_types_uboot

Cheers,

Richard

Re: [image_types_uboot] getdepends for ext2.gz.u-boot

[Gary Thomas]

On 2012-03-02 06:53, Richard Purdie wrote:
> On Fri, 2012-03-02 at 06:39 -0700, Gary Thomas wrote:
>> On 2012-03-02 05:34, Richard Purdie wrote:
>>> On Fri, 2012-03-02 at 16:08 +0800, Ni Qingliang wrote:
>>>> Hello,
>>>>
>>>> when using ext2.gz.u-boot as IMAGE_FSTYPES, I got error when doing
>>>> rootfs with error info:
>>>> genext2fs: command not found
>>>>
>>>> after checked fuction imagetypes_getdepends, I guess the ext2's
>>>> dependency is not considered. maybe we should assign 'ext2' to
>>>> 'basetype', but not 'type' directly.
>>>>
>>>> Any idea?
>>>
>>> Does
>>> http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=78ae63423f123f89a5c72c85539e6ed71bd2653d fix the problem for you?
>>
>> This looks like what I'm doing with my own generator.  I tried
>> it, with&  without this patch, and I don't get a ext2.gz.u-boot
>> image, only a broken link.
>
> That sounds like what happens if you don't inherit image_types_uboot

Indeed.  This method also works perfectly, thanks!

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------