From: Andreas Oberritter <obi@opendreambox.org>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] gst-plugins-bad: add curl as build dependency
Date: Mon, 16 Apr 2012 16:40:52 +0200 [thread overview]
Message-ID: <4F8C2F74.9010903@opendreambox.org> (raw)
In-Reply-To: <1334447226.27917.42.camel@dongxiao-osel>
On 15.04.2012 01:47, Xu, Dongxiao wrote:
> On Sat, 2012-04-14 at 13:23 +0200, Koen Kooi wrote:
>> Op 14 apr. 2012, om 12:44 heeft Dongxiao Xu het volgende geschreven:
>>
>>> gst-plugins-bad needs curl.h to finish its build, so add curl as its
>>> dependency.
>>
>> I can't be sure without the exact failure log, but: missing PR bump
>
> Add a dependency here doesn't impact the original build. If the original
> build is successful, it means curl has already been built by chance. Do
> we still need to bump PR in this case?
>
> Besides, this is the detailed log:
>
> i586-poky-linux-libtool: compile: i586-poky-linux-gcc -m32 -march=i586
> --sysroot=/distro/sdb/build-master/tmp/sysroots/qemux86 -std=gnu99
> -DHAVE_CONFIG_H -I. -I../.. -pthread
> -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -pthread -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -DG_THREADS_MANDATORY -DG_DISABLE_CAST_CHECKS -DG_DISABLE_ASSERT -Wall -Wdeclaration-after-statement -Wvla -Wpointer-arith -Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wwrite-strings -Wformat-security -Wold-style-definition -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -Wnested-externs -O2 -pipe -g -feliminate-unused-debug-types -c gstcurlsink.c -fPIC -DPIC -o .libs/libgstc
ur
> l_la-gstcurlsink.o
> i586-poky-linux-libtool: compile: i586-poky-linux-gcc -m32 -march=i586
> --sysroot=/distro/sdb/build-master/tmp/sysroots/qemux86 -std=gnu99
> -DHAVE_CONFIG_H -I. -I../.. -pthread
> -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -pthread -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -DG_THREADS_MANDATORY -DG_DISABLE_CAST_CHECKS -DG_DISABLE_ASSERT -Wall -Wdeclaration-after-statement -Wvla -Wpointer-arith -Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wwrite-strings -Wformat-security -Wold-style-definition -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -Wnested-externs -O2 -pipe -g -feliminate-unused-debug-types -c gstcurl.c -fPIC -DPIC -o .libs/libgstcurl_
la
> -gstcurl.o
> gstcurlsink.c:45:23: fatal error: curl/curl.h: No such file or directory
> compilation terminated.
> make[3]: *** [libgstcurl_la-gstcurlsink.lo] Error 1
> make[3]: *** Waiting for unfinished jobs....
That's certainly wrong, because for me curl is a new dependency, i.e. it
didn't need to be built before this patch went in.
The error above is probably the symptom of a race condition, where curl
was rebuilt and thus removed from the sysroot after gst-plugins-bad was
configured.
So either a PR bump is required or --disable-curl (or such) should have
been used instead.
Regards,
Andreas
next prev parent reply other threads:[~2012-04-16 14:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-14 10:44 [PATCH 0/1][PULL] gst-plugins-bad: dependency fix Dongxiao Xu
2012-04-14 10:44 ` [PATCH 1/1] gst-plugins-bad: add curl as build dependency Dongxiao Xu
2012-04-14 11:23 ` Koen Kooi
2012-04-14 23:47 ` Xu, Dongxiao
2012-04-16 14:40 ` Andreas Oberritter [this message]
2012-04-17 11:34 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8C2F74.9010903@opendreambox.org \
--to=obi@opendreambox.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox