* [PATCH 0/1][PULL] gst-plugins-bad: dependency fix
@ 2012-04-14 10:44 Dongxiao Xu
2012-04-14 10:44 ` [PATCH 1/1] gst-plugins-bad: add curl as build dependency Dongxiao Xu
0 siblings, 1 reply; 6+ messages in thread
From: Dongxiao Xu @ 2012-04-14 10:44 UTC (permalink / raw)
To: openembedded-core
Hi Richard and Saul,
This pull request adds curl as gst-plugins-bad's dependency.
Please help to review and pull.
Thanks,
Dongxiao
The following changes since commit be298b6f0168bbd6baf90602da35904c441deade:
nspr: fix package spliting (2012-04-14 09:33:54 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib dxu4/hob-bugfix-oecore
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/hob-bugfix-oecore
Dongxiao Xu (1):
gst-plugins-bad: add curl as build dependency
.../gstreamer/gst-plugins-bad_0.10.23.bb | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--
1.7.4.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] gst-plugins-bad: add curl as build dependency
2012-04-14 10:44 [PATCH 0/1][PULL] gst-plugins-bad: dependency fix Dongxiao Xu
@ 2012-04-14 10:44 ` Dongxiao Xu
2012-04-14 11:23 ` Koen Kooi
0 siblings, 1 reply; 6+ messages in thread
From: Dongxiao Xu @ 2012-04-14 10:44 UTC (permalink / raw)
To: openembedded-core
gst-plugins-bad needs curl.h to finish its build, so add curl as its
dependency.
Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
---
.../gstreamer/gst-plugins-bad_0.10.23.bb | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/meta/recipes-multimedia/gstreamer/gst-plugins-bad_0.10.23.bb b/meta/recipes-multimedia/gstreamer/gst-plugins-bad_0.10.23.bb
index 656b61e..fbe1709 100644
--- a/meta/recipes-multimedia/gstreamer/gst-plugins-bad_0.10.23.bb
+++ b/meta/recipes-multimedia/gstreamer/gst-plugins-bad_0.10.23.bb
@@ -6,7 +6,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
file://COPYING.LIB;md5=55ca817ccb7d5b5b66355690e9abc605 \
file://gst/tta/crc32.h;beginline=12;endline=29;md5=71a904d99ce7ae0c1cf129891b98145c"
-DEPENDS += "gst-plugins-base libmusicbrainz tremor librsvg"
+DEPENDS += "gst-plugins-base libmusicbrainz tremor librsvg curl"
PR = "r1"
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] gst-plugins-bad: add curl as build dependency
2012-04-14 10:44 ` [PATCH 1/1] gst-plugins-bad: add curl as build dependency Dongxiao Xu
@ 2012-04-14 11:23 ` Koen Kooi
2012-04-14 23:47 ` Xu, Dongxiao
0 siblings, 1 reply; 6+ messages in thread
From: Koen Kooi @ 2012-04-14 11:23 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
Op 14 apr. 2012, om 12:44 heeft Dongxiao Xu het volgende geschreven:
> gst-plugins-bad needs curl.h to finish its build, so add curl as its
> dependency.
I can't be sure without the exact failure log, but: missing PR bump
regards,
Koen
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] gst-plugins-bad: add curl as build dependency
2012-04-14 11:23 ` Koen Kooi
@ 2012-04-14 23:47 ` Xu, Dongxiao
2012-04-16 14:40 ` Andreas Oberritter
0 siblings, 1 reply; 6+ messages in thread
From: Xu, Dongxiao @ 2012-04-14 23:47 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Sat, 2012-04-14 at 13:23 +0200, Koen Kooi wrote:
> Op 14 apr. 2012, om 12:44 heeft Dongxiao Xu het volgende geschreven:
>
> > gst-plugins-bad needs curl.h to finish its build, so add curl as its
> > dependency.
>
> I can't be sure without the exact failure log, but: missing PR bump
Add a dependency here doesn't impact the original build. If the original
build is successful, it means curl has already been built by chance. Do
we still need to bump PR in this case?
Besides, this is the detailed log:
i586-poky-linux-libtool: compile: i586-poky-linux-gcc -m32 -march=i586
--sysroot=/distro/sdb/build-master/tmp/sysroots/qemux86 -std=gnu99
-DHAVE_CONFIG_H -I. -I../.. -pthread
-I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -pthread -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -DG_THREADS_MANDATORY -DG_DISABLE_CAST_CHECKS -DG_DISABLE_ASSERT -Wall -Wdeclaration-after-statement -Wvla -Wpointer-arith -Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wwrite-strings -Wformat-security -Wold-style-definition -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -Wnested-externs -O2 -pipe -g -feliminate-unused-debug-types -c gstcurlsink.c -fPIC -DPIC -o .libs/libgstcurl_la-gstcurlsink.o
i586-poky-linux-libtool: compile: i586-poky-linux-gcc -m32 -march=i586
--sysroot=/distro/sdb/build-master/tmp/sysroots/qemux86 -std=gnu99
-DHAVE_CONFIG_H -I. -I../.. -pthread
-I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -pthread -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -DG_THREADS_MANDATORY -DG_DISABLE_CAST_CHECKS -DG_DISABLE_ASSERT -Wall -Wdeclaration-after-statement -Wvla -Wpointer-arith -Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wwrite-strings -Wformat-security -Wold-style-definition -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -Wnested-externs -O2 -pipe -g -feliminate-unused-debug-types -c gstcurl.c -fPIC -DPIC -o .libs/libgstcurl_la-gstcurl.o
gstcurlsink.c:45:23: fatal error: curl/curl.h: No such file or directory
compilation terminated.
make[3]: *** [libgstcurl_la-gstcurlsink.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
Thanks,
Dongxiao
>
> regards,
>
> Koen
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] gst-plugins-bad: add curl as build dependency
2012-04-14 23:47 ` Xu, Dongxiao
@ 2012-04-16 14:40 ` Andreas Oberritter
2012-04-17 11:34 ` Richard Purdie
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Oberritter @ 2012-04-16 14:40 UTC (permalink / raw)
To: openembedded-core
On 15.04.2012 01:47, Xu, Dongxiao wrote:
> On Sat, 2012-04-14 at 13:23 +0200, Koen Kooi wrote:
>> Op 14 apr. 2012, om 12:44 heeft Dongxiao Xu het volgende geschreven:
>>
>>> gst-plugins-bad needs curl.h to finish its build, so add curl as its
>>> dependency.
>>
>> I can't be sure without the exact failure log, but: missing PR bump
>
> Add a dependency here doesn't impact the original build. If the original
> build is successful, it means curl has already been built by chance. Do
> we still need to bump PR in this case?
>
> Besides, this is the detailed log:
>
> i586-poky-linux-libtool: compile: i586-poky-linux-gcc -m32 -march=i586
> --sysroot=/distro/sdb/build-master/tmp/sysroots/qemux86 -std=gnu99
> -DHAVE_CONFIG_H -I. -I../.. -pthread
> -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -pthread -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -DG_THREADS_MANDATORY -DG_DISABLE_CAST_CHECKS -DG_DISABLE_ASSERT -Wall -Wdeclaration-after-statement -Wvla -Wpointer-arith -Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wwrite-strings -Wformat-security -Wold-style-definition -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -Wnested-externs -O2 -pipe -g -feliminate-unused-debug-types -c gstcurlsink.c -fPIC -DPIC -o .libs/libgstc
ur
> l_la-gstcurlsink.o
> i586-poky-linux-libtool: compile: i586-poky-linux-gcc -m32 -march=i586
> --sysroot=/distro/sdb/build-master/tmp/sysroots/qemux86 -std=gnu99
> -DHAVE_CONFIG_H -I. -I../.. -pthread
> -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -pthread -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -DG_THREADS_MANDATORY -DG_DISABLE_CAST_CHECKS -DG_DISABLE_ASSERT -Wall -Wdeclaration-after-statement -Wvla -Wpointer-arith -Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wwrite-strings -Wformat-security -Wold-style-definition -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -Wnested-externs -O2 -pipe -g -feliminate-unused-debug-types -c gstcurl.c -fPIC -DPIC -o .libs/libgstcurl_
la
> -gstcurl.o
> gstcurlsink.c:45:23: fatal error: curl/curl.h: No such file or directory
> compilation terminated.
> make[3]: *** [libgstcurl_la-gstcurlsink.lo] Error 1
> make[3]: *** Waiting for unfinished jobs....
That's certainly wrong, because for me curl is a new dependency, i.e. it
didn't need to be built before this patch went in.
The error above is probably the symptom of a race condition, where curl
was rebuilt and thus removed from the sysroot after gst-plugins-bad was
configured.
So either a PR bump is required or --disable-curl (or such) should have
been used instead.
Regards,
Andreas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] gst-plugins-bad: add curl as build dependency
2012-04-16 14:40 ` Andreas Oberritter
@ 2012-04-17 11:34 ` Richard Purdie
0 siblings, 0 replies; 6+ messages in thread
From: Richard Purdie @ 2012-04-17 11:34 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Mon, 2012-04-16 at 16:40 +0200, Andreas Oberritter wrote:
> On 15.04.2012 01:47, Xu, Dongxiao wrote:
> > On Sat, 2012-04-14 at 13:23 +0200, Koen Kooi wrote:
> >> Op 14 apr. 2012, om 12:44 heeft Dongxiao Xu het volgende geschreven:
> >>
> >>> gst-plugins-bad needs curl.h to finish its build, so add curl as its
> >>> dependency.
> >>
> >> I can't be sure without the exact failure log, but: missing PR bump
> >
> > Add a dependency here doesn't impact the original build. If the original
> > build is successful, it means curl has already been built by chance. Do
> > we still need to bump PR in this case?
> >
> > Besides, this is the detailed log:
> >
> > i586-poky-linux-libtool: compile: i586-poky-linux-gcc -m32 -march=i586
> > --sysroot=/distro/sdb/build-master/tmp/sysroots/qemux86 -std=gnu99
> > -DHAVE_CONFIG_H -I. -I../.. -pthread
> > -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -pthread -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -DG_THREADS_MANDATORY -DG_DISABLE_CAST_CHECKS -DG_DISABLE_ASSERT -Wall -Wdeclaration-after-statement -Wvla -Wpointer-arith -Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wwrite-strings -Wformat-security -Wold-style-definition -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -Wnested-externs -O2 -pipe -g -feliminate-unused-debug-types -c gstcurlsink.c -fPIC -DPIC -o .libs/libg!
stc
> ur
> > l_la-gstcurlsink.o
> > i586-poky-linux-libtool: compile: i586-poky-linux-gcc -m32 -march=i586
> > --sysroot=/distro/sdb/build-master/tmp/sysroots/qemux86 -std=gnu99
> > -DHAVE_CONFIG_H -I. -I../.. -pthread
> > -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -pthread -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -DG_THREADS_MANDATORY -DG_DISABLE_CAST_CHECKS -DG_DISABLE_ASSERT -Wall -Wdeclaration-after-statement -Wvla -Wpointer-arith -Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wwrite-strings -Wformat-security -Wold-style-definition -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -Wnested-externs -O2 -pipe -g -feliminate-unused-debug-types -c gstcurl.c -fPIC -DPIC -o .libs/libgstcu!
rl_
> la
> > -gstcurl.o
> > gstcurlsink.c:45:23: fatal error: curl/curl.h: No such file or directory
> > compilation terminated.
> > make[3]: *** [libgstcurl_la-gstcurlsink.lo] Error 1
> > make[3]: *** Waiting for unfinished jobs....
>
> That's certainly wrong, because for me curl is a new dependency, i.e. it
> didn't need to be built before this patch went in.
>
> The error above is probably the symptom of a race condition, where curl
> was rebuilt and thus removed from the sysroot after gst-plugins-bad was
> configured.
>
> So either a PR bump is required or --disable-curl (or such) should have
> been used instead.
I want the builds to be deterministic so either enabling curl (via
DEPENDS) or disabling it through the configure option would be fine. I
went with adding curl since gst-plugins-bad is one of the last packages
to build on the autobuilder and hence it would usually have had curl
built so that is the most tested configuration I'm aware of.
I've pushed a PR bump.
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-04-17 11:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-14 10:44 [PATCH 0/1][PULL] gst-plugins-bad: dependency fix Dongxiao Xu
2012-04-14 10:44 ` [PATCH 1/1] gst-plugins-bad: add curl as build dependency Dongxiao Xu
2012-04-14 11:23 ` Koen Kooi
2012-04-14 23:47 ` Xu, Dongxiao
2012-04-16 14:40 ` Andreas Oberritter
2012-04-17 11:34 ` Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox