* [PATCH 0/2] Bug fixes
@ 2012-06-12 15:17 Laurentiu Palcu
2012-06-12 15:17 ` [PATCH 1/2] sanity.bbclass: warn the user if BBPATH contains wrong entries Laurentiu Palcu
2012-06-12 15:17 ` [PATCH 2/2] connman: make useradd parameters consistent with rootless X Laurentiu Palcu
0 siblings, 2 replies; 6+ messages in thread
From: Laurentiu Palcu @ 2012-06-12 15:17 UTC (permalink / raw)
To: openembedded-core
This patchset contains two bug fixes for:
- Yocto #2467
- Yocto #1465
Laurentiu Palcu (2):
sanity.bbclass: warn the user if BBPATH contains wrong entries
connman: make useradd parameters consistent with rootless X
meta/classes/sanity.bbclass | 11 +++++++++++
meta/recipes-connectivity/connman/connman.inc | 4 ++--
2 files changed, 13 insertions(+), 2 deletions(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] sanity.bbclass: warn the user if BBPATH contains wrong entries
2012-06-12 15:17 [PATCH 0/2] Bug fixes Laurentiu Palcu
@ 2012-06-12 15:17 ` Laurentiu Palcu
2012-06-14 4:27 ` Saul Wold
2012-06-12 15:17 ` [PATCH 2/2] connman: make useradd parameters consistent with rootless X Laurentiu Palcu
1 sibling, 1 reply; 6+ messages in thread
From: Laurentiu Palcu @ 2012-06-12 15:17 UTC (permalink / raw)
To: openembedded-core
If BBPATH references the working directory, the user is warned and asked
to fix the problem.
[Yocto #1465]
Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
---
meta/classes/sanity.bbclass | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index f79fc3f..6ed1e6f 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -387,6 +387,17 @@ def check_sanity(sanity_data):
if "." in paths or "" in paths:
messages = messages + "PATH contains '.' or '', which will break the build, please remove this."
+ bbpaths = sanity_data.getVar('BBPATH', True).split(":")
+ if "." in bbpaths or "" in bbpaths:
+ # TODO: change the following message to fatal when all BBPATH issues
+ # are fixed
+ bb.warn("BBPATH references the current directory, either through " \
+ "an empty entry, or a '.'.\n\t This is unsafe and means your "\
+ "layer configuration is adding empty elements to BBPATH.\n\t "\
+ "Please check your layer.conf files and other BBPATH " \
+ "settings to remove the current working directory " \
+ "references.");
+
if sanity_data.getVar('TARGET_ARCH', True) == "arm":
# This path is no longer user-readable in modern (very recent) Linux
try:
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] connman: make useradd parameters consistent with rootless X
2012-06-12 15:17 [PATCH 0/2] Bug fixes Laurentiu Palcu
2012-06-12 15:17 ` [PATCH 1/2] sanity.bbclass: warn the user if BBPATH contains wrong entries Laurentiu Palcu
@ 2012-06-12 15:17 ` Laurentiu Palcu
2012-06-12 15:30 ` Burton, Ross
1 sibling, 1 reply; 6+ messages in thread
From: Laurentiu Palcu @ 2012-06-12 15:17 UTC (permalink / raw)
To: openembedded-core
Both connman and rootless X share the same xuser. However, useradd
parameters are not consistent and if connman runs useradd first,
rootless X will be broken.
[Yocto #2467]
Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
---
meta/recipes-connectivity/connman/connman.inc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
index 4fb7b43..eb174c5 100644
--- a/meta/recipes-connectivity/connman/connman.inc
+++ b/meta/recipes-connectivity/connman/connman.inc
@@ -47,8 +47,8 @@ INITSCRIPT_NAME = "connman"
INITSCRIPT_PARAMS = "start 05 5 2 3 . stop 22 0 1 6 ."
USERADD_PACKAGES = "${PN}"
-USERADD_PARAM_${PN} = "--system --no-create-home \
- --shell /bin/false --groups video,tty,audio \
+USERADD_PARAM_${PN} = "--create-home \
+ --groups video,tty,audio \
--user-group xuser"
inherit autotools pkgconfig update-rc.d useradd
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] connman: make useradd parameters consistent with rootless X
2012-06-12 15:17 ` [PATCH 2/2] connman: make useradd parameters consistent with rootless X Laurentiu Palcu
@ 2012-06-12 15:30 ` Burton, Ross
0 siblings, 0 replies; 6+ messages in thread
From: Burton, Ross @ 2012-06-12 15:30 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 12 June 2012 16:17, Laurentiu Palcu <laurentiu.palcu@intel.com> wrote:
> Both connman and rootless X share the same xuser. However, useradd
> parameters are not consistent and if connman runs useradd first,
> rootless X will be broken.
It's probably a good idea to put a comment in X package where the
xuser is also created saying that any changes should be mirrored to
the connman package to avoid this happening again.
Ross
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] sanity.bbclass: warn the user if BBPATH contains wrong entries
2012-06-12 15:17 ` [PATCH 1/2] sanity.bbclass: warn the user if BBPATH contains wrong entries Laurentiu Palcu
@ 2012-06-14 4:27 ` Saul Wold
2012-06-14 12:06 ` Laurentiu Palcu
0 siblings, 1 reply; 6+ messages in thread
From: Saul Wold @ 2012-06-14 4:27 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 06/12/2012 08:17 AM, Laurentiu Palcu wrote:
> If BBPATH references the working directory, the user is warned and asked
> to fix the problem.
>
> [Yocto #1465]
>
> Signed-off-by: Laurentiu Palcu<laurentiu.palcu@intel.com>
> ---
> meta/classes/sanity.bbclass | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index f79fc3f..6ed1e6f 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -387,6 +387,17 @@ def check_sanity(sanity_data):
> if "." in paths or "" in paths:
> messages = messages + "PATH contains '.' or '', which will break the build, please remove this."
>
> + bbpaths = sanity_data.getVar('BBPATH', True).split(":")
> + if "." in bbpaths or "" in bbpaths:
> + # TODO: change the following message to fatal when all BBPATH issues
> + # are fixed
> + bb.warn("BBPATH references the current directory, either through " \
> + "an empty entry, or a '.'.\n\t This is unsafe and means your "\
> + "layer configuration is adding empty elements to BBPATH.\n\t "\
> + "Please check your layer.conf files and other BBPATH " \
> + "settings to remove the current working directory " \
> + "references.");
> +
This change seems to trigger in the default case of the standard
bblayers.conf file included in meta-yocto. Is there a fix for this? Do
we need to uprev the bblayers file?
Sau!
> if sanity_data.getVar('TARGET_ARCH', True) == "arm":
> # This path is no longer user-readable in modern (very recent) Linux
> try:
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] sanity.bbclass: warn the user if BBPATH contains wrong entries
2012-06-14 4:27 ` Saul Wold
@ 2012-06-14 12:06 ` Laurentiu Palcu
0 siblings, 0 replies; 6+ messages in thread
From: Laurentiu Palcu @ 2012-06-14 12:06 UTC (permalink / raw)
To: Saul Wold; +Cc: Patches and discussions about the oe-core layer
On 06/14/2012 07:27 AM, Saul Wold wrote:
> On 06/12/2012 08:17 AM, Laurentiu Palcu wrote:
>> If BBPATH references the working directory, the user is warned and asked
>> to fix the problem.
>>
>> [Yocto #1465]
>>
>> Signed-off-by: Laurentiu Palcu<laurentiu.palcu@intel.com>
>> ---
>> meta/classes/sanity.bbclass | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
>> index f79fc3f..6ed1e6f 100644
>> --- a/meta/classes/sanity.bbclass
>> +++ b/meta/classes/sanity.bbclass
>> @@ -387,6 +387,17 @@ def check_sanity(sanity_data):
>> if "." in paths or "" in paths:
>> messages = messages + "PATH contains '.' or '', which will break the build, please remove this."
>>
>> + bbpaths = sanity_data.getVar('BBPATH', True).split(":")
>> + if "." in bbpaths or "" in bbpaths:
>> + # TODO: change the following message to fatal when all BBPATH issues
>> + # are fixed
>> + bb.warn("BBPATH references the current directory, either through " \
>> + "an empty entry, or a '.'.\n\t This is unsafe and means your "\
>> + "layer configuration is adding empty elements to BBPATH.\n\t "\
>> + "Please check your layer.conf files and other BBPATH " \
>> + "settings to remove the current working directory " \
>> + "references.");
>> +
> This change seems to trigger in the default case of the standard
> bblayers.conf file included in meta-yocto. Is there a fix for this? Do
> we need to uprev the bblayers file?
There's no fix yet. I will take a look and come with a fix. That's the
reason I avoided throwing a fatal error and print just a warning. So we
have time to fix these existing BBPATH issues without affecting everybody.
Thanks,
Laurentiu
>
> Sau!
>
>> if sanity_data.getVar('TARGET_ARCH', True) == "arm":
>> # This path is no longer user-readable in modern (very recent) Linux
>> try:
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-06-14 12:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-12 15:17 [PATCH 0/2] Bug fixes Laurentiu Palcu
2012-06-12 15:17 ` [PATCH 1/2] sanity.bbclass: warn the user if BBPATH contains wrong entries Laurentiu Palcu
2012-06-14 4:27 ` Saul Wold
2012-06-14 12:06 ` Laurentiu Palcu
2012-06-12 15:17 ` [PATCH 2/2] connman: make useradd parameters consistent with rootless X Laurentiu Palcu
2012-06-12 15:30 ` Burton, Ross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox