openssl does not build on recent distributions with perl-5.16.0

openssl does not build on recent distributions with perl-5.16.0

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]

Hi,

openembedded-core/meta/recipes-connectivity/openssl/openssl.inc

is using perlpath.pl:

  do_configure () {
          cd util
          perl perlpath.pl ${STAGING_BINDIR_NATIVE}
  ...

and perlpath.pl is using find.pl:
openssl-1.0.0i/util/perlpath.pl:
  #!/usr/local/bin/perl
  #
  # modify the '#!/usr/local/bin/perl'
  # line in all scripts that rely on perl.
  #

  require "find.pl";
  ...

which was removed in perl-5.16.0 and marked as deprecated and
unmaintained in 5.14 and older: 
/tmp/usr/lib/perl5/5.14.2/find.pl:
  warn "Legacy library @{[(caller(0))[6]]} will be removed from the Perl
  core distribution in the next major release. Please install it from the
  CPAN distribution Perl4::CoreLibs. It is being used at @{[(caller)[1]]},
  line @{[(caller)[2]]}.\n";

  # This library is deprecated and unmaintained. It is included for
  # compatibility with Perl 4 scripts which may use it, but it will be
  # removed in a future version of Perl. Please use the File::Find module
  # instead.

Cheers,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: openssl does not build on recent distributions with perl-5.16.0

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]

On Thursday, June 14, 2012, Martin Jansa wrote:

> Hi,
>
> openembedded-core/meta/recipes-connectivity/openssl/openssl.inc
>
> is using perlpath.pl:
>
>  do_configure () {
>          cd util
>          perl perlpath.pl ${STAGING_BINDIR_NATIVE}


I wonder why it's using host perl and not staged perl-native
May be missing inherit perlnative

>  ...
>
> and perlpath.pl is using find.pl:
> openssl-1.0.0i/util/perlpath.pl:
>  #!/usr/local/bin/perl
>  #
>  # modify the '#!/usr/local/bin/perl'
>  # line in all scripts that rely on perl.
>  #
>
>  require "find.pl";
>  ...
>
> which was removed in perl-5.16.0 and marked as deprecated and
> unmaintained in 5.14 and older:
> /tmp/usr/lib/perl5/5.14.2/find.pl:
>  warn "Legacy library @{[(caller(0))[6]]} will be removed from the Perl
>  core distribution in the next major release. Please install it from the
>  CPAN distribution Perl4::CoreLibs. It is being used at @{[(caller)[1]]},
>  line @{[(caller)[2]]}.\n";
>
>  # This library is deprecated and unmaintained. It is included for
>  # compatibility with Perl 4 scripts which may use it, but it will be
>  # removed in a future version of Perl. Please use the File::Find module
>  # instead.
>
> Cheers,
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com <javascript:;>
>

[-- Attachment #2: Type: text/html, Size: 2202 bytes --]

Re: openssl does not build on recent distributions with perl-5.16.0

[Jack Mitchell]

[-- Attachment #1: Type: text/plain, Size: 2145 bytes --]

On 15/06/12 15:15, Khem Raj wrote:
>
>
> On Thursday, June 14, 2012, Martin Jansa wrote:
>
>     Hi,
>
>     openembedded-core/meta/recipes-connectivity/openssl/openssl.inc
>
>     is using perlpath.pl <http://perlpath.pl>:
>
>      do_configure () {
>              cd util
>              perl perlpath.pl <http://perlpath.pl>
>     ${STAGING_BINDIR_NATIVE}
>
>
> I wonder why it's using host perl and not staged perl-native
> May be missing inherit perlnative
>
>      ...
>
>     and perlpath.pl <http://perlpath.pl> is using find.pl
>     <http://find.pl>:
>     openssl-1.0.0i/util/perlpath.pl <http://perlpath.pl>:
>      #!/usr/local/bin/perl
>      #
>      # modify the '#!/usr/local/bin/perl'
>      # line in all scripts that rely on perl.
>      #
>
>      require "find.pl <http://find.pl>";
>      ...
>
>     which was removed in perl-5.16.0 and marked as deprecated and
>     unmaintained in 5.14 and older:
>     /tmp/usr/lib/perl5/5.14.2/find.pl <http://find.pl>:
>      warn "Legacy library @{[(caller(0))[6]]} will be removed from the
>     Perl
>      core distribution in the next major release. Please install it
>     from the
>      CPAN distribution Perl4::CoreLibs. It is being used at
>     @{[(caller)[1]]},
>      line @{[(caller)[2]]}.\n";
>
>      # This library is deprecated and unmaintained. It is included for
>      # compatibility with Perl 4 scripts which may use it, but it will be
>      # removed in a future version of Perl. Please use the File::Find
>     module
>      # instead.
>
>     Cheers,
>
>     --
>     Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com <javascript:;>
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

I can confirm I also ran into this issue using Archlinux, I thought it 
was an issue with my Perl install but obviously not!

Regards,

-- 

   Jack Mitchell (jack@embed.me.uk)
   Embedded Systems Engineer
   http://www.embed.me.uk

--


[-- Attachment #2: Type: text/html, Size: 4378 bytes --]

Re: openssl does not build on recent distributions with perl-5.16.0

[Jack Mitchell]

[-- Attachment #1: Type: text/plain, Size: 2719 bytes --]

On 15/06/12 15:19, Jack Mitchell wrote:
> On 15/06/12 15:15, Khem Raj wrote:
>>
>>
>> On Thursday, June 14, 2012, Martin Jansa wrote:
>>
>>     Hi,
>>
>>     openembedded-core/meta/recipes-connectivity/openssl/openssl.inc
>>
>>     is using perlpath.pl <http://perlpath.pl>:
>>
>>      do_configure () {
>>              cd util
>>              perl perlpath.pl <http://perlpath.pl>
>>     ${STAGING_BINDIR_NATIVE}
>>
>>
>> I wonder why it's using host perl and not staged perl-native
>> May be missing inherit perlnative
>>
>>      ...
>>
>>     and perlpath.pl <http://perlpath.pl> is using find.pl
>>     <http://find.pl>:
>>     openssl-1.0.0i/util/perlpath.pl <http://perlpath.pl>:
>>      #!/usr/local/bin/perl
>>      #
>>      # modify the '#!/usr/local/bin/perl'
>>      # line in all scripts that rely on perl.
>>      #
>>
>>      require "find.pl <http://find.pl>";
>>      ...
>>
>>     which was removed in perl-5.16.0 and marked as deprecated and
>>     unmaintained in 5.14 and older:
>>     /tmp/usr/lib/perl5/5.14.2/find.pl <http://find.pl>:
>>      warn "Legacy library @{[(caller(0))[6]]} will be removed from
>>     the Perl
>>      core distribution in the next major release. Please install it
>>     from the
>>      CPAN distribution Perl4::CoreLibs. It is being used at
>>     @{[(caller)[1]]},
>>      line @{[(caller)[2]]}.\n";
>>
>>      # This library is deprecated and unmaintained. It is included for
>>      # compatibility with Perl 4 scripts which may use it, but it will be
>>      # removed in a future version of Perl. Please use the File::Find
>>     module
>>      # instead.
>>
>>     Cheers,
>>
>>     --
>>     Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com <javascript:;>
>>
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
> I can confirm I also ran into this issue using Archlinux, I thought it 
> was an issue with my Perl install but obviously not!
>
> Regards,
> -- 
>
>    Jack Mitchell (jack@embed.me.uk)
>    Embedded Systems Engineer
>    http://www.embed.me.uk
>
> --
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Also, from a quick check adding perlnative to openssl.inc allows it to 
build, now fighting with sgml-common-native :/

Regards,

-- 

   Jack Mitchell (jack@embed.me.uk)
   Embedded Systems Engineer
   http://www.embed.me.uk

--


[-- Attachment #2: Type: text/html, Size: 5915 bytes --]

Re: openssl does not build on recent distributions with perl-5.16.0

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2563 bytes --]

On Fri, Jun 15, 2012 at 03:19:34PM +0100, Jack Mitchell wrote:
> On 15/06/12 15:15, Khem Raj wrote:
> >
> >
> > On Thursday, June 14, 2012, Martin Jansa wrote:
> >
> >     Hi,
> >
> >     openembedded-core/meta/recipes-connectivity/openssl/openssl.inc
> >
> >     is using perlpath.pl <http://perlpath.pl>:
> >
> >      do_configure () {
> >              cd util
> >              perl perlpath.pl <http://perlpath.pl>
> >     ${STAGING_BINDIR_NATIVE}
> >
> >
> > I wonder why it's using host perl and not staged perl-native
> > May be missing inherit perlnative
> >
> >      ...
> >
> >     and perlpath.pl <http://perlpath.pl> is using find.pl
> >     <http://find.pl>:
> >     openssl-1.0.0i/util/perlpath.pl <http://perlpath.pl>:
> >      #!/usr/local/bin/perl
> >      #
> >      # modify the '#!/usr/local/bin/perl'
> >      # line in all scripts that rely on perl.
> >      #
> >
> >      require "find.pl <http://find.pl>";
> >      ...
> >
> >     which was removed in perl-5.16.0 and marked as deprecated and
> >     unmaintained in 5.14 and older:
> >     /tmp/usr/lib/perl5/5.14.2/find.pl <http://find.pl>:
> >      warn "Legacy library @{[(caller(0))[6]]} will be removed from the
> >     Perl
> >      core distribution in the next major release. Please install it
> >     from the
> >      CPAN distribution Perl4::CoreLibs. It is being used at
> >     @{[(caller)[1]]},
> >      line @{[(caller)[2]]}.\n";
> >
> >      # This library is deprecated and unmaintained. It is included for
> >      # compatibility with Perl 4 scripts which may use it, but it will be
> >      # removed in a future version of Perl. Please use the File::Find
> >     module
> >      # instead.
> >
> >     Cheers,
> >
> >     --
> >     Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com <javascript:;>
> >
> >
> >
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
> 
> I can confirm I also ran into this issue using Archlinux, I thought it 
> was an issue with my Perl install but obviously not!
> 
> Regards,

You can use this patch as work around
http://git.openembedded.org/openembedded-core-contrib/commit/?h=shr&id=376acaea6856b4d7da35c61332d67e919d8c5736
but I guess that it should be fixed better for oe-core (preferably in
openssl perlpath.pl directly).

Cheers,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: openssl does not build on recent distributions with perl-5.16.0

[Richard Purdie]

On Fri, 2012-06-15 at 07:15 -0700, Khem Raj wrote:
> On Thursday, June 14, 2012, Martin Jansa wrote:
>         Hi,
>
>         openembedded-core/meta/recipes-connectivity/openssl/openssl.inc
>
>         is using perlpath.pl:
>
>          do_configure () {
>                  cd util
>                  perl perlpath.pl ${STAGING_BINDIR_NATIVE}
>
> I wonder why it's using host perl and not staged perl-native
> May be missing inherit perlnative 

perlnative is not meant to be used as a replacement for the host
system's perl, its meant for building target modules and target perl
itself. 

We require perl to be on the host system. We're not meant to be using
anything outside the standard perl install though. The alternative means
effectively totally cratering build time as we'd have to build
perl-native before pretty much anything else.

So the best solution is likely to have something that adds find.pl to
the native sysroot and have these recipes depend on it, at least short
term. I'm extremely reluctant to start adding perl-native dependencies
throughout the system due to performance considerations.

Cheers,

Richard

Re: openssl does not build on recent distributions with perl-5.16.0

[Khem Raj]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 6/15/2012 7:36 AM, Richard Purdie wrote:
> On Fri, 2012-06-15 at 07:15 -0700, Khem Raj wrote:
>> On Thursday, June 14, 2012, Martin Jansa wrote: Hi,
>> 
>> openembedded-core/meta/recipes-connectivity/openssl/openssl.inc
>> 
>> is using perlpath.pl:
>> 
>> do_configure () { cd util perl perlpath.pl
>> ${STAGING_BINDIR_NATIVE}
>> 
>> I wonder why it's using host perl and not staged perl-native May
>> be missing inherit perlnative
> 
> perlnative is not meant to be used as a replacement for the host 
> system's perl, its meant for building target modules and target
> perl itself.
> 

ah yes I was thinking of openssl and not openssl-native when replying

> We require perl to be on the host system. We're not meant to be
> using anything outside the standard perl install though. The
> alternative means effectively totally cratering build time as we'd
> have to build perl-native before pretty much anything else.
> 
> So the best solution is likely to have something that adds find.pl
> to the native sysroot and have these recipes depend on it, at least
> short term. I'm extremely reluctant to start adding perl-native
> dependencies throughout the system due to performance
> considerations.
> 

may be right fix should be fix openssl itself to not ask for obsolete
perl feature.


> Cheers,
> 
> Richard
> 
> 
> 
> 
> 
> 
> 
> _______________________________________________ Openembedded-core
> mailing list Openembedded-core@lists.openembedded.org 
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk/bW9IACgkQuwUzVZGdMxSdLACeOs47dlvb7HSwaRYf9dimuKl1
dfAAn0B52pE7ozkC+umlRloUsCZ8GZvW
=s8Bs
-----END PGP SIGNATURE-----

Re: openssl does not build on recent distributions with perl-5.16.0

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1693 bytes --]

On Fri, Jun 15, 2012 at 03:36:50PM +0100, Richard Purdie wrote:
> On Fri, 2012-06-15 at 07:15 -0700, Khem Raj wrote:
> > On Thursday, June 14, 2012, Martin Jansa wrote:
> >         Hi,
> >
> >         openembedded-core/meta/recipes-connectivity/openssl/openssl.inc
> >
> >         is using perlpath.pl:
> >
> >          do_configure () {
> >                  cd util
> >                  perl perlpath.pl ${STAGING_BINDIR_NATIVE}
> >
> > I wonder why it's using host perl and not staged perl-native
> > May be missing inherit perlnative 
> 
> perlnative is not meant to be used as a replacement for the host
> system's perl, its meant for building target modules and target perl
> itself. 
> 
> We require perl to be on the host system. We're not meant to be using
> anything outside the standard perl install though. The alternative means
> effectively totally cratering build time as we'd have to build
> perl-native before pretty much anything else.
> 
> So the best solution is likely to have something that adds find.pl to
> the native sysroot and have these recipes depend on it, at least short
> term. I'm extremely reluctant to start adding perl-native dependencies
> throughout the system due to performance considerations.

is there any other recipe depending on find.pl? (I've tried only minimal
image with perl-5.16), maybe sgml-common-native as Jack reported, 
here it's used only in do_configure, that's why I added find.pl only to 
openssl and better fix would be to send patch to use File::Find in 
perlpath.pl to openssl upstream IMHO then adding find.pl to sysroot.

Cheers,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: openssl does not build on recent distributions with perl-5.16.0

[Richard Purdie]

On Fri, 2012-06-15 at 22:39 +0200, Martin Jansa wrote:
> On Fri, Jun 15, 2012 at 03:36:50PM +0100, Richard Purdie wrote:
> > On Fri, 2012-06-15 at 07:15 -0700, Khem Raj wrote:
> > > On Thursday, June 14, 2012, Martin Jansa wrote:
> > >         Hi,
> > >
> > >         openembedded-core/meta/recipes-connectivity/openssl/openssl.inc
> > >
> > >         is using perlpath.pl:
> > >
> > >          do_configure () {
> > >                  cd util
> > >                  perl perlpath.pl ${STAGING_BINDIR_NATIVE}
> > >
> > > I wonder why it's using host perl and not staged perl-native
> > > May be missing inherit perlnative 
> > 
> > perlnative is not meant to be used as a replacement for the host
> > system's perl, its meant for building target modules and target perl
> > itself. 
> > 
> > We require perl to be on the host system. We're not meant to be using
> > anything outside the standard perl install though. The alternative means
> > effectively totally cratering build time as we'd have to build
> > perl-native before pretty much anything else.
> > 
> > So the best solution is likely to have something that adds find.pl to
> > the native sysroot and have these recipes depend on it, at least short
> > term. I'm extremely reluctant to start adding perl-native dependencies
> > throughout the system due to performance considerations.
> 
> is there any other recipe depending on find.pl? (I've tried only minimal
> image with perl-5.16), maybe sgml-common-native as Jack reported, 
> here it's used only in do_configure, that's why I added find.pl only to 
> openssl and better fix would be to send patch to use File::Find in 
> perlpath.pl to openssl upstream IMHO then adding find.pl to sysroot.

Agreed, I've not looked into the details of this but that sounds
reasonable...

Cheers,

Richard

[PATCH] openssl: add deprecated and unmaintained find.pl from perl-5.14 to fix perlpath.pl

[Martin Jansa]

* openembedded-core/meta/recipes-connectivity/openssl/openssl.inc
*
* is using perlpath.pl:
*
*   do_configure () {
*           cd util
*           perl perlpath.pl ${STAGING_BINDIR_NATIVE}
*   ...
*
* and perlpath.pl is using find.pl:
* openssl-1.0.0i/util/perlpath.pl:
*   #!/usr/local/bin/perl
*   #
*   # modify the '#!/usr/local/bin/perl'
*   # line in all scripts that rely on perl.
*   #
*
*   require "find.pl";
*   ...
*
* which was removed in perl-5.16.0 and marked as deprecated and
* unmaintained in 5.14 and older:
* /tmp/usr/lib/perl5/5.14.2/find.pl:
*   warn "Legacy library @{[(caller(0))[6]]} will be removed from the Perl
*   core distribution in the next major release. Please install it from the
*   CPAN distribution Perl4::CoreLibs. It is being used at @{[(caller)[1]]},
*   line @{[(caller)[2]]}.\n";
*
*   # This library is deprecated and unmaintained. It is included for
*   # compatibility with Perl 4 scripts which may use it, but it will be
*   # removed in a future version of Perl. Please use the File::Find module
*   # instead.

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 .../openssl/openssl-1.0.0i/find.pl                 |   54 ++++++++++++++++++++
 .../recipes-connectivity/openssl/openssl_1.0.0i.bb |    7 ++-
 2 files changed, 60 insertions(+), 1 deletions(-)
 create mode 100644 meta/recipes-connectivity/openssl/openssl-1.0.0i/find.pl

diff --git a/meta/recipes-connectivity/openssl/openssl-1.0.0i/find.pl b/meta/recipes-connectivity/openssl/openssl-1.0.0i/find.pl
new file mode 100644
index 0000000..8e1b42c
--- /dev/null
+++ b/meta/recipes-connectivity/openssl/openssl-1.0.0i/find.pl
@@ -0,0 +1,54 @@
+warn "Legacy library @{[(caller(0))[6]]} will be removed from the Perl core distribution in the next major release. Please install it from the CPAN distribution Perl4::CoreLibs. It is being used at @{[(caller)[1]]}, line @{[(caller)[2]]}.\n";
+
+# This library is deprecated and unmaintained. It is included for
+# compatibility with Perl 4 scripts which may use it, but it will be
+# removed in a future version of Perl. Please use the File::Find module
+# instead.
+
+# Usage:
+#	require "find.pl";
+#
+#	&find('/foo','/bar');
+#
+#	sub wanted { ... }
+#		where wanted does whatever you want.  $dir contains the
+#		current directory name, and $_ the current filename within
+#		that directory.  $name contains "$dir/$_".  You are cd'ed
+#		to $dir when the function is called.  The function may
+#		set $prune to prune the tree.
+#
+# For example,
+#
+#   find / -name .nfs\* -mtime +7 -exec rm -f {} \; -o -fstype nfs -prune
+#
+# corresponds to this
+#
+#	sub wanted {
+#	    /^\.nfs.*$/ &&
+#	    (($dev,$ino,$mode,$nlink,$uid,$gid) = lstat($_)) &&
+#	    int(-M _) > 7 &&
+#	    unlink($_)
+#	    ||
+#	    ($nlink || (($dev,$ino,$mode,$nlink,$uid,$gid) = lstat($_))) &&
+#	    $dev < 0 &&
+#	    ($prune = 1);
+#	}
+#
+# Set the variable $dont_use_nlink if you're using AFS, since AFS cheats.
+
+use File::Find ();
+
+*name		= *File::Find::name;
+*prune		= *File::Find::prune;
+*dir		= *File::Find::dir;
+*topdir		= *File::Find::topdir;
+*topdev		= *File::Find::topdev;
+*topino		= *File::Find::topino;
+*topmode	= *File::Find::topmode;
+*topnlink	= *File::Find::topnlink;
+
+sub find {
+    &File::Find::find(\&wanted, @_);
+}
+
+1;
diff --git a/meta/recipes-connectivity/openssl/openssl_1.0.0i.bb b/meta/recipes-connectivity/openssl/openssl_1.0.0i.bb
index ca15a38..c233ba1 100644
--- a/meta/recipes-connectivity/openssl/openssl_1.0.0i.bb
+++ b/meta/recipes-connectivity/openssl/openssl_1.0.0i.bb
@@ -6,7 +6,7 @@ DEPENDS += "ocf-linux"
 
 CFLAG += "-DHAVE_CRYPTODEV -DUSE_CRYPTODEV_DIGESTS"
 
-PR = "${INC_PR}.2"
+PR = "${INC_PR}.3"
 
 LIC_FILES_CHKSUM = "file://LICENSE;md5=f9a8f968107345e0b75aa8c2ecaa7ec8"
 
@@ -29,6 +29,7 @@ SRC_URI += "file://configure-targets.patch \
             file://debian/no-symbolic.patch \
             file://debian/debian-targets.patch \
             file://openssl_fix_for_x32.patch \
+            file://find.pl \
            "
 
 SRC_URI[md5sum] = "b4df9c11af454fd68178c85a1d5f328f"
@@ -43,3 +44,7 @@ FILES_${PN}-engines = "${libdir}/ssl/engines/*.so ${libdir}/engines"
 FILES_${PN}-engines-dbg = "${libdir}/ssl/engines/.debug"
 
 PARALLEL_MAKEINST = ""
+
+do_configure_prepend() {
+  cp ${WORKDIR}/find.pl ${S}/util/find.pl
+}
-- 
1.7.8.6