* [PATCH] mtd-utils: do not stage headers in sysroot
@ 2012-06-21 22:57 Andrea Adami
2012-06-24 17:35 ` Saul Wold
2012-06-28 17:10 ` Saul Wold
0 siblings, 2 replies; 6+ messages in thread
From: Andrea Adami @ 2012-06-21 22:57 UTC (permalink / raw)
To: openembedded-core
* Headers are included in the package for compatibility
* but have not yet been synched with linux 3.0
* The actual issue was that ubi-user.h in sysroot
* was overwritten by the older version.
* Unfortunately one ioctl was renamed:
* http://lists.infradead.org/pipermail/linux-mtd/
* 2011-March/034419.html
* Note: the recipe will still use its own older header,
* following upstream.
Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
---
meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb b/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb
index daa3554..1a9d4d3 100644
--- a/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb
+++ b/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb
@@ -11,16 +11,12 @@ SRC_URI = "git://git.infradead.org/mtd-utils.git;protocol=git;tag=ca39eb1d98e736
S = "${WORKDIR}/git/"
-PR = "r0"
+PR = "r1"
EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}/include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
do_install () {
oe_runmake install DESTDIR=${D} SBINDIR=${sbindir} MANDIR=${mandir} INCLUDEDIR=${includedir}
- install -d ${D}${includedir}/mtd/
- for f in ${S}/include/mtd/*.h; do
- install -m 0644 $f ${D}${includedir}/mtd/
- done
}
PARALLEL_MAKE = ""
--
1.7.3.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd-utils: do not stage headers in sysroot
2012-06-21 22:57 [PATCH] mtd-utils: do not stage headers in sysroot Andrea Adami
@ 2012-06-24 17:35 ` Saul Wold
2012-06-24 21:52 ` Andrea Adami
2012-06-28 17:10 ` Saul Wold
1 sibling, 1 reply; 6+ messages in thread
From: Saul Wold @ 2012-06-24 17:35 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 06/21/2012 03:57 PM, Andrea Adami wrote:
> * Headers are included in the package for compatibility
> * but have not yet been synched with linux 3.0
> * The actual issue was that ubi-user.h in sysroot
> * was overwritten by the older version.
> * Unfortunately one ioctl was renamed:
> * http://lists.infradead.org/pipermail/linux-mtd/
> * 2011-March/034419.html
> * Note: the recipe will still use its own older header,
> * following upstream.
>
> Signed-off-by: Andrea Adami<andrea.adami@gmail.com>
> ---
> meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb | 6 +-----
> 1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb b/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb
> index daa3554..1a9d4d3 100644
> --- a/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb
> +++ b/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb
> @@ -11,16 +11,12 @@ SRC_URI = "git://git.infradead.org/mtd-utils.git;protocol=git;tag=ca39eb1d98e736
>
> S = "${WORKDIR}/git/"
>
> -PR = "r0"
> +PR = "r1"
>
> EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}/include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
>
> do_install () {
> oe_runmake install DESTDIR=${D} SBINDIR=${sbindir} MANDIR=${mandir} INCLUDEDIR=${includedir}
> - install -d ${D}${includedir}/mtd/
> - for f in ${S}/include/mtd/*.h; do
> - install -m 0644 $f ${D}${includedir}/mtd/
> - done
> }
Just curious how this was tested?
I did a couple of different builds and on one clean rebuild, I found
that udev failed because it could not find mtd/mtd-user.h
Thanks
Sau!
>
> PARALLEL_MAKE = ""
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd-utils: do not stage headers in sysroot
2012-06-24 17:35 ` Saul Wold
@ 2012-06-24 21:52 ` Andrea Adami
2012-06-25 5:29 ` Saul Wold
0 siblings, 1 reply; 6+ messages in thread
From: Andrea Adami @ 2012-06-24 21:52 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Sun, Jun 24, 2012 at 7:35 PM, Saul Wold <sgw@linux.intel.com> wrote:
> On 06/21/2012 03:57 PM, Andrea Adami wrote:
>>
>> * Headers are included in the package for compatibility
>> * but have not yet been synched with linux 3.0
>> * The actual issue was that ubi-user.h in sysroot
>> * was overwritten by the older version.
>> * Unfortunately one ioctl was renamed:
>> * http://lists.infradead.org/pipermail/linux-mtd/
>> * 2011-March/034419.html
>> * Note: the recipe will still use its own older header,
>> * following upstream.
>>
>> Signed-off-by: Andrea Adami<andrea.adami@gmail.com>
>> ---
>> meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb | 6 +-----
>> 1 files changed, 1 insertions(+), 5 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb
>> b/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb
>> index daa3554..1a9d4d3 100644
>> --- a/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb
>> +++ b/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb
>> @@ -11,16 +11,12 @@ SRC_URI =
>> "git://git.infradead.org/mtd-utils.git;protocol=git;tag=ca39eb1d98e736
>>
>> S = "${WORKDIR}/git/"
>>
>> -PR = "r0"
>> +PR = "r1"
>>
>> EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}'
>> 'CFLAGS=${CFLAGS} -I${S}/include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
>>
>> do_install () {
>> oe_runmake install DESTDIR=${D} SBINDIR=${sbindir} MANDIR=${mandir}
>> INCLUDEDIR=${includedir}
>> - install -d ${D}${includedir}/mtd/
>> - for f in ${S}/include/mtd/*.h; do
>> - install -m 0644 $f ${D}${includedir}/mtd/
>> - done
>> }
>
> Just curious how this was tested?
>
> I did a couple of different builds and on one clean rebuild, I found that
> udev failed because it could not find mtd/mtd-user.h
>
> Thanks
> Sau!
>
>
>>
>> PARALLEL_MAKE = ""
Strange...
I've done build from scratch of core-image-base to test and all was
built just fine, included udev_164.
It would be indeed bizarre if udev would depend on headers provided by
mtd-utils, though.
Finally, mtd-user.h belongs to linux-libc-headers(-dev) package.
Regards
Andrea
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd-utils: do not stage headers in sysroot
2012-06-24 21:52 ` Andrea Adami
@ 2012-06-25 5:29 ` Saul Wold
2012-06-25 5:31 ` Khem Raj
0 siblings, 1 reply; 6+ messages in thread
From: Saul Wold @ 2012-06-25 5:29 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 06/24/2012 02:52 PM, Andrea Adami wrote:
> On Sun, Jun 24, 2012 at 7:35 PM, Saul Wold<sgw@linux.intel.com> wrote:
>> On 06/21/2012 03:57 PM, Andrea Adami wrote:
>>>
>>> * Headers are included in the package for compatibility
>>> * but have not yet been synched with linux 3.0
>>> * The actual issue was that ubi-user.h in sysroot
>>> * was overwritten by the older version.
>>> * Unfortunately one ioctl was renamed:
>>> * http://lists.infradead.org/pipermail/linux-mtd/
>>> * 2011-March/034419.html
>>> * Note: the recipe will still use its own older header,
>>> * following upstream.
>>>
>>> Signed-off-by: Andrea Adami<andrea.adami@gmail.com>
>>> ---
>>> meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb | 6 +-----
>>> 1 files changed, 1 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb
>>> b/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb
>>> index daa3554..1a9d4d3 100644
>>> --- a/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb
>>> +++ b/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb
>>> @@ -11,16 +11,12 @@ SRC_URI =
>>> "git://git.infradead.org/mtd-utils.git;protocol=git;tag=ca39eb1d98e736
>>>
>>> S = "${WORKDIR}/git/"
>>>
>>> -PR = "r0"
>>> +PR = "r1"
>>>
>>> EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}'
>>> 'CFLAGS=${CFLAGS} -I${S}/include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
>>>
>>> do_install () {
>>> oe_runmake install DESTDIR=${D} SBINDIR=${sbindir} MANDIR=${mandir}
>>> INCLUDEDIR=${includedir}
>>> - install -d ${D}${includedir}/mtd/
>>> - for f in ${S}/include/mtd/*.h; do
>>> - install -m 0644 $f ${D}${includedir}/mtd/
>>> - done
>>> }
>>
>> Just curious how this was tested?
>>
>> I did a couple of different builds and on one clean rebuild, I found that
>> udev failed because it could not find mtd/mtd-user.h
>>
>> Thanks
>> Sau!
>>
>>
>>>
>>> PARALLEL_MAKE = ""
>
> Strange...
> I've done build from scratch of core-image-base to test and all was
> built just fine, included udev_164.
> It would be indeed bizarre if udev would depend on headers provided by
> mtd-utils, though.
>
> Finally, mtd-user.h belongs to linux-libc-headers(-dev) package.
>
If that's the case, then maybe there's a race condition as to or we need
to also add linux-libc-headers to the udev package to ensure they are
installed correctly before udev is built.
Sau!
> Regards
>
> Andrea
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd-utils: do not stage headers in sysroot
2012-06-25 5:29 ` Saul Wold
@ 2012-06-25 5:31 ` Khem Raj
0 siblings, 0 replies; 6+ messages in thread
From: Khem Raj @ 2012-06-25 5:31 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Sun, Jun 24, 2012 at 10:29 PM, Saul Wold <sgw@linux.intel.com> wrote:
> On 06/24/2012 02:52 PM, Andrea Adami wrote:
>>
>> On Sun, Jun 24, 2012 at 7:35 PM, Saul Wold<sgw@linux.intel.com> wrote:
>>>
>>> On 06/21/2012 03:57 PM, Andrea Adami wrote:
>>>>
>>>>
>>>> * Headers are included in the package for compatibility
>>>> * but have not yet been synched with linux 3.0
>>>> * The actual issue was that ubi-user.h in sysroot
>>>> * was overwritten by the older version.
>>>> * Unfortunately one ioctl was renamed:
>>>> * http://lists.infradead.org/pipermail/linux-mtd/
>>>> * 2011-March/034419.html
>>>> * Note: the recipe will still use its own older header,
>>>> * following upstream.
>>>>
>>>> Signed-off-by: Andrea Adami<andrea.adami@gmail.com>
>>>> ---
>>>> meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb | 6 +-----
>>>> 1 files changed, 1 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb
>>>> b/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb
>>>> index daa3554..1a9d4d3 100644
>>>> --- a/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb
>>>> +++ b/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb
>>>> @@ -11,16 +11,12 @@ SRC_URI =
>>>> "git://git.infradead.org/mtd-utils.git;protocol=git;tag=ca39eb1d98e736
>>>>
>>>> S = "${WORKDIR}/git/"
>>>>
>>>> -PR = "r0"
>>>> +PR = "r1"
>>>>
>>>> EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}'
>>>> 'CFLAGS=${CFLAGS} -I${S}/include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
>>>>
>>>> do_install () {
>>>> oe_runmake install DESTDIR=${D} SBINDIR=${sbindir}
>>>> MANDIR=${mandir}
>>>> INCLUDEDIR=${includedir}
>>>> - install -d ${D}${includedir}/mtd/
>>>> - for f in ${S}/include/mtd/*.h; do
>>>> - install -m 0644 $f ${D}${includedir}/mtd/
>>>> - done
>>>> }
>>>
>>>
>>> Just curious how this was tested?
>>>
>>> I did a couple of different builds and on one clean rebuild, I found that
>>> udev failed because it could not find mtd/mtd-user.h
>>>
>>> Thanks
>>> Sau!
>>>
>>>
>>>>
>>>> PARALLEL_MAKE = ""
>>
>>
>> Strange...
>> I've done build from scratch of core-image-base to test and all was
>> built just fine, included udev_164.
>> It would be indeed bizarre if udev would depend on headers provided by
>> mtd-utils, though.
>>
>> Finally, mtd-user.h belongs to linux-libc-headers(-dev) package.
>>
> If that's the case, then maybe there's a race condition as to or we need to
> also add linux-libc-headers to the udev package to ensure they are installed
> correctly before udev is built.
kernel-headers are installed very eary on even before toolchain or
libc are built
udev can only be compiled after libc is built. So there is something
else going on here
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd-utils: do not stage headers in sysroot
2012-06-21 22:57 [PATCH] mtd-utils: do not stage headers in sysroot Andrea Adami
2012-06-24 17:35 ` Saul Wold
@ 2012-06-28 17:10 ` Saul Wold
1 sibling, 0 replies; 6+ messages in thread
From: Saul Wold @ 2012-06-28 17:10 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 06/21/2012 03:57 PM, Andrea Adami wrote:
> * Headers are included in the package for compatibility
> * but have not yet been synched with linux 3.0
> * The actual issue was that ubi-user.h in sysroot
> * was overwritten by the older version.
> * Unfortunately one ioctl was renamed:
> * http://lists.infradead.org/pipermail/linux-mtd/
> * 2011-March/034419.html
> * Note: the recipe will still use its own older header,
> * following upstream.
>
> Signed-off-by: Andrea Adami<andrea.adami@gmail.com>
> ---
> meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb | 6 +-----
> 1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb b/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb
> index daa3554..1a9d4d3 100644
> --- a/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb
> +++ b/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb
> @@ -11,16 +11,12 @@ SRC_URI = "git://git.infradead.org/mtd-utils.git;protocol=git;tag=ca39eb1d98e736
>
> S = "${WORKDIR}/git/"
>
> -PR = "r0"
> +PR = "r1"
>
> EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}/include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
>
> do_install () {
> oe_runmake install DESTDIR=${D} SBINDIR=${sbindir} MANDIR=${mandir} INCLUDEDIR=${includedir}
> - install -d ${D}${includedir}/mtd/
> - for f in ${S}/include/mtd/*.h; do
> - install -m 0644 $f ${D}${includedir}/mtd/
> - done
> }
>
> PARALLEL_MAKE = ""
Merged into OE-Core
Thanks
Sau!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-06-28 17:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-21 22:57 [PATCH] mtd-utils: do not stage headers in sysroot Andrea Adami
2012-06-24 17:35 ` Saul Wold
2012-06-24 21:52 ` Andrea Adami
2012-06-25 5:29 ` Saul Wold
2012-06-25 5:31 ` Khem Raj
2012-06-28 17:10 ` Saul Wold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox