* [PATCH] udev: don't mount with -o sync
@ 2012-07-03 8:49 Jesse Zhang
2012-07-03 10:41 ` Koen Kooi
2012-07-17 16:53 ` [PATCH] " Saul Wold
0 siblings, 2 replies; 5+ messages in thread
From: Jesse Zhang @ 2012-07-03 8:49 UTC (permalink / raw)
To: openembedded-core
mount.sh mounts all partitions with -o sync, which is bad for system
performance.
Signed-off-by: Jesse Zhang <sen.zhang@windriver.com>
---
meta/recipes-core/udev/udev/mount.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-core/udev/udev/mount.sh b/meta/recipes-core/udev/udev/mount.sh
index 53fefa3..c13b8bb 100644
--- a/meta/recipes-core/udev/udev/mount.sh
+++ b/meta/recipes-core/udev/udev/mount.sh
@@ -23,7 +23,7 @@ automount() {
! test -d "/media/$name" && mkdir -p "/media/$name"
- if ! $MOUNT -t auto -o sync $DEVNAME "/media/$name"
+ if ! $MOUNT -t auto $DEVNAME "/media/$name"
then
#logger "mount.sh/automount" "$MOUNT -t auto $DEVNAME \"/media/$name\" failed!"
rm_dir "/media/$name"
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] udev: don't mount with -o sync
2012-07-03 8:49 [PATCH] udev: don't mount with -o sync Jesse Zhang
@ 2012-07-03 10:41 ` Koen Kooi
2012-07-04 2:00 ` Jesse Zhang
2012-07-04 2:03 ` [PATCH v2] " Jesse Zhang
2012-07-17 16:53 ` [PATCH] " Saul Wold
1 sibling, 2 replies; 5+ messages in thread
From: Koen Kooi @ 2012-07-03 10:41 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
Op 3 jul. 2012, om 10:49 heeft Jesse Zhang het volgende geschreven:
> mount.sh mounts all partitions with -o sync, which is bad for system
> performance.
But good for data integrity :)
> Signed-off-by: Jesse Zhang <sen.zhang@windriver.com>
> ---
> meta/recipes-core/udev/udev/mount.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/udev/udev/mount.sh b/meta/recipes-core/udev/udev/mount.sh
> index 53fefa3..c13b8bb 100644
> --- a/meta/recipes-core/udev/udev/mount.sh
> +++ b/meta/recipes-core/udev/udev/mount.sh
> @@ -23,7 +23,7 @@ automount() {
>
> ! test -d "/media/$name" && mkdir -p "/media/$name"
>
> - if ! $MOUNT -t auto -o sync $DEVNAME "/media/$name"
> + if ! $MOUNT -t auto $DEVNAME "/media/$name"
> then
> #logger "mount.sh/automount" "$MOUNT -t auto $DEVNAME \"/media/$name\" failed!"
> rm_dir "/media/$name"
Missing PR bump
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] udev: don't mount with -o sync
2012-07-03 10:41 ` Koen Kooi
@ 2012-07-04 2:00 ` Jesse Zhang
2012-07-04 2:03 ` [PATCH v2] " Jesse Zhang
1 sibling, 0 replies; 5+ messages in thread
From: Jesse Zhang @ 2012-07-04 2:00 UTC (permalink / raw)
To: Koen Kooi; +Cc: Patches and discussions about the oe-core layer
On 07/03/2012 06:41 PM, Koen Kooi wrote:
>
> Op 3 jul. 2012, om 10:49 heeft Jesse Zhang het volgende geschreven:
>
>> mount.sh mounts all partitions with -o sync, which is bad for system
>> performance.
>
> But good for data integrity :)
Who cares about integrity as long as it's blazing fast :P
But I see the same was done for meta-openembedded.
commit 88295fc7dd7bf79b6eb2decfc64467defe829df8
Author: Koen Kooi <koen@dominion.thruhere.net>
Date: Mon May 16 15:37:36 2011 +0200
udev: update to 168
- if ! $MOUNT -t auto -o sync $DEVNAME "/media/$name"
+ if ! $MOUNT -t auto -o async,relatime $DEVNAME "/media/$name"
I omitted async,relatime since I think they are the default.
>> Signed-off-by: Jesse Zhang <sen.zhang@windriver.com>
>> ---
>> meta/recipes-core/udev/udev/mount.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/udev/udev/mount.sh b/meta/recipes-core/udev/udev/mount.sh
>> index 53fefa3..c13b8bb 100644
>> --- a/meta/recipes-core/udev/udev/mount.sh
>> +++ b/meta/recipes-core/udev/udev/mount.sh
>> @@ -23,7 +23,7 @@ automount() {
>>
>> ! test -d "/media/$name" && mkdir -p "/media/$name"
>>
>> - if ! $MOUNT -t auto -o sync $DEVNAME "/media/$name"
>> + if ! $MOUNT -t auto $DEVNAME "/media/$name"
>> then
>> #logger "mount.sh/automount" "$MOUNT -t auto $DEVNAME \"/media/$name\" failed!"
>> rm_dir "/media/$name"
>
> Missing PR bump
Oh. Sorry I didn't realized about that.
jesse
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2] udev: don't mount with -o sync
2012-07-03 10:41 ` Koen Kooi
2012-07-04 2:00 ` Jesse Zhang
@ 2012-07-04 2:03 ` Jesse Zhang
1 sibling, 0 replies; 5+ messages in thread
From: Jesse Zhang @ 2012-07-04 2:03 UTC (permalink / raw)
To: openembedded-core; +Cc: koen
mount.sh mounts all partitions with -o sync, which is bad for system
performance.
Signed-off-by: Jesse Zhang <sen.zhang@windriver.com>
---
Bump PR.
meta/recipes-core/udev/udev/mount.sh | 2 +-
meta/recipes-core/udev/udev_164.bb | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-core/udev/udev/mount.sh b/meta/recipes-core/udev/udev/mount.sh
index 53fefa3..c13b8bb 100644
--- a/meta/recipes-core/udev/udev/mount.sh
+++ b/meta/recipes-core/udev/udev/mount.sh
@@ -23,7 +23,7 @@ automount() {
! test -d "/media/$name" && mkdir -p "/media/$name"
- if ! $MOUNT -t auto -o sync $DEVNAME "/media/$name"
+ if ! $MOUNT -t auto $DEVNAME "/media/$name"
then
#logger "mount.sh/automount" "$MOUNT -t auto $DEVNAME \"/media/$name\" failed!"
rm_dir "/media/$name"
diff --git a/meta/recipes-core/udev/udev_164.bb b/meta/recipes-core/udev/udev_164.bb
index c5813ec..0462ff2 100644
--- a/meta/recipes-core/udev/udev_164.bb
+++ b/meta/recipes-core/udev/udev_164.bb
@@ -1,6 +1,6 @@
include udev.inc
-PR = "r13"
+PR = "r14"
SRC_URI += "file://udev-166-v4l1-1.patch"
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] udev: don't mount with -o sync
2012-07-03 8:49 [PATCH] udev: don't mount with -o sync Jesse Zhang
2012-07-03 10:41 ` Koen Kooi
@ 2012-07-17 16:53 ` Saul Wold
1 sibling, 0 replies; 5+ messages in thread
From: Saul Wold @ 2012-07-17 16:53 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 07/03/2012 01:49 AM, Jesse Zhang wrote:
> mount.sh mounts all partitions with -o sync, which is bad for system
> performance.
>
> Signed-off-by: Jesse Zhang <sen.zhang@windriver.com>
> ---
> meta/recipes-core/udev/udev/mount.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/udev/udev/mount.sh b/meta/recipes-core/udev/udev/mount.sh
> index 53fefa3..c13b8bb 100644
> --- a/meta/recipes-core/udev/udev/mount.sh
> +++ b/meta/recipes-core/udev/udev/mount.sh
> @@ -23,7 +23,7 @@ automount() {
>
> ! test -d "/media/$name" && mkdir -p "/media/$name"
>
> - if ! $MOUNT -t auto -o sync $DEVNAME "/media/$name"
> + if ! $MOUNT -t auto $DEVNAME "/media/$name"
> then
> #logger "mount.sh/automount" "$MOUNT -t auto $DEVNAME \"/media/$name\" failed!"
> rm_dir "/media/$name"
>
Merged into OE-Core
Thanks
Sau!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-07-17 17:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-03 8:49 [PATCH] udev: don't mount with -o sync Jesse Zhang
2012-07-03 10:41 ` Koen Kooi
2012-07-04 2:00 ` Jesse Zhang
2012-07-04 2:03 ` [PATCH v2] " Jesse Zhang
2012-07-17 16:53 ` [PATCH] " Saul Wold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox