Re: [PATCH] cpan.bbclass: Fix CCFLAGS.

[Pascal Ouyang <xin.ouyang@windriver.com>]

On 2012年06月29日 00:04, Khem Raj wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 6/28/2012 12:59 AM, Pascal Ouyang wrote:
>> On 2012年06月21日 23:47, Khem Raj wrote:
>>> On Thu, Jun 21, 2012 at 12:13 AM,  <xin.ouyang@windriver.com>
>>> wrote:
>>>> From: Xin Ouyang <Xin.Ouyang@windriver.com>
>>>>
>>>> We should not just replace CCFLAGS with CFLAGS while compiling,
>>>> because this may cause run-time errors with perl's
>>>> DynaLoader.pm.
>>>>
>>>> Tested on qemux86 with new libnet-libidn-perl bb recipe:
>>>
>>> can you instead try the patch from
>>>
>>> http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=19;bug=628522
>>>
>> This debian patch takes no effect.
>>
>> Actually it try to fix this:
>>
>> Some packages which has those lines in Makefile.PL: WriteMakefile(
>> ... 'CCFLAGS'    => 'some cflags', ... ); While run perl
>> Makefile.PL to configure, there are CCFLAGS="some cflags" to
>> override the original CCFLAGS=$Config{ccflags} in generated
>> Makefiles.
>>
>>
>> In Poky, CCFLAGS in our generated Makefiles are all right. But when
>> we run oe_runmake CCFLAGS="${CFLAGS}" to do_compile, this will
>> override our right CCFLAGS.
>
> but thats what assign operator is meant to do isnt it ?
>

Hi Raj,

This is indeed a bug, because all non-pure perl modules(with C codes, 
tested libtext-iconv-perl and libnet-libidn-perl) would fail in running 
time on the 32bit X86 machines with current cpan.bbclass.
And the root cause is CCFLAGS="${CFLAGS}" passed to oe_runmake has 
overrided the CCFLAGS in Makefile.

So, I still don't know what is your opinion of this patch.
Thanks.

- Pascal

>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.12 (MingW32)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAk/sgHwACgkQuwUzVZGdMxSvoACdHtcMLShjJIglhq/KXuE73QIW
> 7FsAoI/IFxzDXZWX/xLj3tNkDDzdUM++
> =MWVl
> -----END PGP SIGNATURE-----
>


-- 
- Pascal