From: Pascal Ouyang <xin.ouyang@windriver.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] cpan.bbclass: Fix CCFLAGS.
Date: Fri, 6 Jul 2012 13:33:20 +0800 [thread overview]
Message-ID: <4FF678A0.4040200@windriver.com> (raw)
In-Reply-To: <CAMKF1sqqiaXyxxzrreU2+00mmdCAmtpSNXnrXVgF1F5a4b07_g@mail.gmail.com>
On 2012年07月05日 22:57, Khem Raj wrote:
> On Thu, Jul 5, 2012 at 4:17 AM, Pascal Ouyang <xin.ouyang@windriver.com> wrote:
>>
>> So, I still don't know what is your opinion of this patch.
>
> I think we still need the CC and CFLAGS to appear in CCFLAGS since
> they sometimes decide ABI etc. that we use and without that
> the modules will be incompatible. So may be
> appending to CCFLAGS would work instead
>
Exactly in my patch, this just appends CFLAGS to CCFLAGS.
@@ -26,13 +26,14 @@ cpan_do_configure () {
test -f $f2 || continue
sed -i -e "s:\(PERL_ARCHLIB = \).*:\1${PERL_ARCHLIB}:" \
-e 's/perl.real/perl/' \
+ -e "s/^\(CCFLAGS =.*\)/\1 ${CFLAGS}/" \
$f2
done
fi
}
Thanks.
--
- Pascal
next prev parent reply other threads:[~2012-07-06 5:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 7:13 [PATCH] cpan.bbclass: Fix CCFLAGS xin.ouyang
2012-06-21 15:47 ` Khem Raj
2012-06-28 7:59 ` Pascal Ouyang
2012-06-28 16:04 ` Khem Raj
2012-07-02 7:54 ` Pascal Ouyang
2012-07-05 11:17 ` Pascal Ouyang
2012-07-05 14:57 ` Khem Raj
2012-07-06 5:33 ` Pascal Ouyang [this message]
2012-07-06 5:39 ` Khem Raj
2012-07-12 6:46 ` Pascal Ouyang
2012-07-17 16:16 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF678A0.4040200@windriver.com \
--to=xin.ouyang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox