[PATCH v2 1/8] gstreamer1.0-plugins-bad: v4l2codecs fix typo

[PATCH v2 1/8] gstreamer1.0-plugins-bad: v4l2codecs fix typo

[Jose Quaresma]

Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
---
 .../gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb                | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
index f70437ccd3..f2b8a21abc 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
@@ -72,6 +72,7 @@ PACKAGECONFIG[srtp]            = "-Dsrtp=enabled,-Dsrtp=disabled,libsrtp"
 PACKAGECONFIG[tinyalsa]        = "-Dtinyalsa=enabled,-Dtinyalsa=disabled,tinyalsa"
 PACKAGECONFIG[ttml]            = "-Dttml=enabled,-Dttml=disabled,libxml2 pango cairo"
 PACKAGECONFIG[uvch264]         = "-Duvch264=enabled,-Duvch264=disabled,libusb1 libgudev"
+PACKAGECONFIG[v4l2codecs]      = "-Dv4l2codecs=enabled,-Dv4l2codecs=disabled,libgudev"
 PACKAGECONFIG[va]              = "-Dva=enabled,-Dva=disabled,libva"
 PACKAGECONFIG[voaacenc]        = "-Dvoaacenc=enabled,-Dvoaacenc=disabled,vo-aacenc"
 PACKAGECONFIG[voamrwbenc]      = "-Dvoamrwbenc=enabled,-Dvoamrwbenc=disabled,vo-amrwbenc"
@@ -81,7 +82,6 @@ PACKAGECONFIG[webp]            = "-Dwebp=enabled,-Dwebp=disabled,libwebp"
 PACKAGECONFIG[webrtc]          = "-Dwebrtc=enabled,-Dwebrtc=disabled,libnice"
 PACKAGECONFIG[webrtcdsp]       = "-Dwebrtcdsp=enabled,-Dwebrtcdsp=disabled,webrtc-audio-processing"
 PACKAGECONFIG[zbar]            = "-Dzbar=enabled,-Dzbar=disabled,zbar"
-PACKAGECONFIG[v4l2codecs]      = "-D-Dv4l2codecs=enabled,-Dv4l2codecs=disabled,libgudev"
 
 # these plugins currently have no corresponding library in OE-core or meta-openembedded:
 #   aom androidmedia applemedia bs2b chromaprint d3dvideosink
-- 
2.29.2

[PATCH v2 2/8] gstreamer1.0-plugins-bad: add support for aom plugin

[Jose Quaresma]

Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
---
 .../gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb              | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
index f2b8a21abc..9de99f60e6 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
@@ -27,6 +27,7 @@ PACKAGECONFIG ??= " \
     ttml uvch264 webp \
 "
 
+PACKAGECONFIG[aom]             = "-Daom=enabled,-Daom=disabled,aom"
 PACKAGECONFIG[assrender]       = "-Dassrender=enabled,-Dassrender=disabled,libass"
 PACKAGECONFIG[bluez]           = "-Dbluez=enabled,-Dbluez=disabled,bluez5"
 PACKAGECONFIG[bz2]             = "-Dbz2=enabled,-Dbz2=disabled,bzip2"
@@ -84,7 +85,7 @@ PACKAGECONFIG[webrtcdsp]       = "-Dwebrtcdsp=enabled,-Dwebrtcdsp=disabled,webrt
 PACKAGECONFIG[zbar]            = "-Dzbar=enabled,-Dzbar=disabled,zbar"
 
 # these plugins currently have no corresponding library in OE-core or meta-openembedded:
-#   aom androidmedia applemedia bs2b chromaprint d3dvideosink
+#   androidmedia applemedia bs2b chromaprint d3dvideosink
 #   directsound dts fdkaac gme gsm iq kate ladspa lv2 mpeg2enc
 #   mplex musepack nvdec nvenc ofa openexr openni2 opensles
 #   soundtouch spandsp teletext wasapi wildmidi winks
@@ -98,7 +99,6 @@ EXTRA_OEMESON += " \
     -Dipcpipeline=enabled \
     -Dnetsim=enabled \
     -Dshm=enabled \
-    -Daom=disabled \
     -Dandroidmedia=disabled \
     -Dapplemedia=disabled \
     -Davtp=disabled \
-- 
2.29.2

[PATCH v2 3/8] gstreamer1.0-plugins-bad: add support for x265 plugin

[Jose Quaresma]

Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
---
 .../gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb              | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
index 9de99f60e6..7016f73c92 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
@@ -83,13 +83,14 @@ PACKAGECONFIG[webp]            = "-Dwebp=enabled,-Dwebp=disabled,libwebp"
 PACKAGECONFIG[webrtc]          = "-Dwebrtc=enabled,-Dwebrtc=disabled,libnice"
 PACKAGECONFIG[webrtcdsp]       = "-Dwebrtcdsp=enabled,-Dwebrtcdsp=disabled,webrtc-audio-processing"
 PACKAGECONFIG[zbar]            = "-Dzbar=enabled,-Dzbar=disabled,zbar"
+PACKAGECONFIG[x265]            = "-Dx265=enabled,-Dx265=disabled,x265"
 
 # these plugins currently have no corresponding library in OE-core or meta-openembedded:
 #   androidmedia applemedia bs2b chromaprint d3dvideosink
 #   directsound dts fdkaac gme gsm iq kate ladspa lv2 mpeg2enc
 #   mplex musepack nvdec nvenc ofa openexr openni2 opensles
 #   soundtouch spandsp teletext wasapi wildmidi winks
-#   winscreencap wpe x265
+#   winscreencap wpe
 
 EXTRA_OEMESON += " \
     -Ddoc=disabled \
@@ -137,7 +138,6 @@ EXTRA_OEMESON += " \
     -Dwinks=disabled \
     -Dwinscreencap=disabled \
     -Dwpe=disabled \
-    -Dx265=disabled \
     -Dzxing=disabled \
 "
 
-- 
2.29.2

[PATCH v2 4/8] gstreamer1.0-plugins-bad: sctp plugin uses the internal usrsctp static lib

[Jose Quaresma]

usrsctp lib source code is provided in gstreamer plugins bad source tree
and it is builded staticaly for the sctp plugin.

Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
---
 .../gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb                | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
index 7016f73c92..dbc9360e1c 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
@@ -65,7 +65,7 @@ PACKAGECONFIG[resindvd]        = "-Dresindvd=enabled,-Dresindvd=disabled,libdvdr
 PACKAGECONFIG[rsvg]            = "-Drsvg=enabled,-Drsvg=disabled,librsvg"
 PACKAGECONFIG[rtmp]            = "-Drtmp=enabled,-Drtmp=disabled,rtmpdump"
 PACKAGECONFIG[sbc]             = "-Dsbc=enabled,-Dsbc=disabled,sbc"
-PACKAGECONFIG[sctp]            = "-Dsctp=enabled,-Dsctp=disabled,usrsctp"
+PACKAGECONFIG[sctp]            = "-Dsctp=enabled,-Dsctp=disabled"
 PACKAGECONFIG[smoothstreaming] = "-Dsmoothstreaming=enabled,-Dsmoothstreaming=disabled,libxml2"
 PACKAGECONFIG[sndfile]         = "-Dsndfile=enabled,-Dsndfile=disabled,libsndfile1"
 PACKAGECONFIG[srt]             = "-Dsrt=enabled,-Dsrt=disabled,srt"
-- 
2.29.2

[PATCH v2 5/8] gstreamer1.0-plugins-bad: remove unsupported plugins comment

[Jose Quaresma]

- all of the unsupported plugins are explicitly disabled on EXTRA_OEMESON

Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
---
 .../gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb           | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
index dbc9360e1c..adddceb799 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
@@ -85,13 +85,6 @@ PACKAGECONFIG[webrtcdsp]       = "-Dwebrtcdsp=enabled,-Dwebrtcdsp=disabled,webrt
 PACKAGECONFIG[zbar]            = "-Dzbar=enabled,-Dzbar=disabled,zbar"
 PACKAGECONFIG[x265]            = "-Dx265=enabled,-Dx265=disabled,x265"
 
-# these plugins currently have no corresponding library in OE-core or meta-openembedded:
-#   androidmedia applemedia bs2b chromaprint d3dvideosink
-#   directsound dts fdkaac gme gsm iq kate ladspa lv2 mpeg2enc
-#   mplex musepack nvdec nvenc ofa openexr openni2 opensles
-#   soundtouch spandsp teletext wasapi wildmidi winks
-#   winscreencap wpe
-
 EXTRA_OEMESON += " \
     -Ddoc=disabled \
     -Ddecklink=enabled \
-- 
2.29.2

[PATCH v2 6/8] gstreamer1.0-plugins-bad: netsim plugin don't have external deps

[Jose Quaresma]

Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
---
 .../gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb                 | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
index adddceb799..9c8fea1f41 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
@@ -91,7 +91,6 @@ EXTRA_OEMESON += " \
     -Ddvb=enabled \
     -Dfbdev=enabled \
     -Dipcpipeline=enabled \
-    -Dnetsim=enabled \
     -Dshm=enabled \
     -Dandroidmedia=disabled \
     -Dapplemedia=disabled \
-- 
2.29.2

[PATCH v2 7/8] gstreamer1.0-plugins-bad: transcode plugin external deps is always present

[Jose Quaresma]

it only needs gstreamer-pbutils-1.0 from gst-plugins-base

Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
---
 .../gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb                 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
index 9c8fea1f41..d37a223254 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
@@ -92,6 +92,7 @@ EXTRA_OEMESON += " \
     -Dfbdev=enabled \
     -Dipcpipeline=enabled \
     -Dshm=enabled \
+    -Dtranscode=enabled \
     -Dandroidmedia=disabled \
     -Dapplemedia=disabled \
     -Davtp=disabled \
-- 
2.29.2

[PATCH v2 8/8] gstreamer1.0-plugins-bad: remove meson option for plugins with dependencies always present

[Jose Quaresma]

decklink: libdl (glibc)
dvbk: kernel headers
fbdev: kernel headers
ipcpipeline: gst-plugins-base
shm: librt (glibc)
transcode: gst-plugins-base

Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
---
 .../gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb            | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
index d37a223254..a43261b704 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
@@ -87,12 +87,6 @@ PACKAGECONFIG[x265]            = "-Dx265=enabled,-Dx265=disabled,x265"
 
 EXTRA_OEMESON += " \
     -Ddoc=disabled \
-    -Ddecklink=enabled \
-    -Ddvb=enabled \
-    -Dfbdev=enabled \
-    -Dipcpipeline=enabled \
-    -Dshm=enabled \
-    -Dtranscode=enabled \
     -Dandroidmedia=disabled \
     -Dapplemedia=disabled \
     -Davtp=disabled \
-- 
2.29.2

Re: [OE-core] [PATCH v2 8/8] gstreamer1.0-plugins-bad: remove meson option for plugins with dependencies always present

[Jose Quaresma]

[-- Attachment #1: Type: text/plain, Size: 1630 bytes --]

Hi Richard,

I have think about this patch and probably is better to drop it.
It is now on master-next

Without this we have meson options for all the gstreamer plugins that have
external dependencies.

Probably its better to have it explicity enabled than don't have this
options at all and falback to meson auto discovery dependencies.

Jose

A terça, 8/12/2020, 16:13, Jose Quaresma via lists.openembedded.org
<quaresma.jose=gmail.com@lists.openembedded.org> escreveu:

> decklink: libdl (glibc)
> dvbk: kernel headers
> fbdev: kernel headers
> ipcpipeline: gst-plugins-base
> shm: librt (glibc)
> transcode: gst-plugins-base
>
> Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
> ---
>  .../gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb            | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-bad_1.18.2.bb b/meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-bad_1.18.2.bb
> index d37a223254..a43261b704 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.2.bb
> @@ -87,12 +87,6 @@ PACKAGECONFIG[x265]            =
> "-Dx265=enabled,-Dx265=disabled,x265"
>
>  EXTRA_OEMESON += " \
>      -Ddoc=disabled \
> -    -Ddecklink=enabled \
> -    -Ddvb=enabled \
> -    -Dfbdev=enabled \
> -    -Dipcpipeline=enabled \
> -    -Dshm=enabled \
> -    -Dtranscode=enabled \
>      -Dandroidmedia=disabled \
>      -Dapplemedia=disabled \
>      -Davtp=disabled \
> --
> 2.29.2
>
>
> 
>
>

[-- Attachment #2: Type: text/html, Size: 2835 bytes --]

Re: [OE-core] [PATCH v2 8/8] gstreamer1.0-plugins-bad: remove meson option for plugins with dependencies always present

[Richard Purdie]

Hi Jose,

On Fri, 2020-12-11 at 21:13 +0000, Jose Quaresma wrote:
> I have think about this patch and probably is better to drop it.
> It is now on master-next
> 
> Without this we have meson options for all the gstreamer plugins that
> have external dependencies.
> 
> Probably its better to have it explicity enabled than don't have this
> options at all and falback to meson auto discovery dependencies.

FWIW, I agree. I put things in master-next to run through the
autobuilder in parallel with other review so just because something
makes it there, it doesn't mean its definitely going to be merged. I've
dropped this one, thanks for highlighting!

Cheers,

Richard

Re: [OE-core] [PATCH v2 8/8] gstreamer1.0-plugins-bad: remove meson option for plugins with dependencies always present

[Jose Quaresma]

[-- Attachment #1: Type: text/plain, Size: 941 bytes --]

Hi Richard,

Thanks for overview of the merge process.

Jose

Richard Purdie <richard.purdie@linuxfoundation.org> escreveu no dia terça,
15/12/2020 à(s) 23:02:

> Hi Jose,
>
> On Fri, 2020-12-11 at 21:13 +0000, Jose Quaresma wrote:
> > I have think about this patch and probably is better to drop it.
> > It is now on master-next
> >
> > Without this we have meson options for all the gstreamer plugins that
> > have external dependencies.
> >
> > Probably its better to have it explicity enabled than don't have this
> > options at all and falback to meson auto discovery dependencies.
>
> FWIW, I agree. I put things in master-next to run through the
> autobuilder in parallel with other review so just because something
> makes it there, it doesn't mean its definitely going to be merged. I've
> dropped this one, thanks for highlighting!
>
> Cheers,
>
> Richard
>
>

-- 
best regards,
José Quaresma

[-- Attachment #2: Type: text/html, Size: 1568 bytes --]