public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Joseph Reynolds" <jrey@linux.ibm.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
	OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] add new extrausers command passwd-expire - moved to PR 63
Date: Tue, 27 Oct 2020 18:19:53 -0500	[thread overview]
Message-ID: <4fb6f623-c811-0593-dc89-877f128439a3@linux.ibm.com> (raw)
In-Reply-To: <f154c498c88dfc436d4b9547b889e3aa8436fc41.camel@linuxfoundation.org>

On 10/27/20 2:41 PM, Richard Purdie wrote:
> Hi Joseph,
>
> On Mon, 2020-10-26 at 15:41 -0500, Joseph Reynolds wrote:
>> This enhances extrausers with a new passwd-expire command that causes
>> a local user's password to be expired as if the `passwd --expire`
>> command was run, so the password needs to be changed on initial
>> login.
>>
>> Example: EXTRA_USERS_PARAMS += " useradd ... sofia; passwd-expire
>> sofia;"
>>
>> Tested: on useradd accounts
>> When configured with Linux-PAM, console login prompts for and can
>> successfully change the password.  OpenSSH server works.  Dropbear
>> SSH server notes the password must be changed but does not offer a
>> password change dialog and rejects the login request.
>>
>> Signed-off-by: Joseph Reynolds <joseph-reynolds@charter.net>
>> ---
>>    meta/classes/extrausers.bbclass   |  3 +++
>>    meta/classes/useradd_base.bbclass | 18 ++++++++++++++++++
>>    2 files changed, 21 insertions(+)
>>
>> diff --git a/meta/classes/extrausers.bbclass
>> b/meta/classes/extrausers.bbclass
>> index 32569e9..90811bf 100644
>> --- a/meta/classes/extrausers.bbclass
>> +++ b/meta/classes/extrausers.bbclass
>> @@ -46,6 +46,9 @@ set_user_group () {
>>                usermod)
>>                    perform_usermod "${IMAGE_ROOTFS}" "-R
>> ${IMAGE_ROOTFS}
>> $opts"
> Unfortunately this patch is coming through line wrapped which makes it
> hard to apply. Can you resend it without the line wrapping, or point at
> a git tree with the patch in please?

Thanks.  The PR work flow is much easier for me.  I didn't realize OE 
was on github.com.
I hereby withdraw & abandon my email patch request and replace it with:
https://github.com/openembedded/openembedded-core/pull/63

- Joseph

>
> I do remember the patch from the last time around and I think this was
> the issue last time as well, I couldn't get it to apply. It does seem
> like a reasonable addition and it would be good to work with openBMC on
> common issues like this!
>
> Cheers,
>
> Richard
>


  reply	other threads:[~2020-10-27 23:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26 20:41 [PATCH] add new extrausers command passwd-expire Joseph Reynolds
2020-10-27 19:41 ` [OE-core] " Richard Purdie
2020-10-27 23:19   ` Joseph Reynolds [this message]
2020-10-27 23:40     ` [OE-core] [PATCH] add new extrausers command passwd-expire - moved to PR 63 Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4fb6f623-c811-0593-dc89-877f128439a3@linux.ibm.com \
    --to=jrey@linux.ibm.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox