Re: [OE-core] [PATCH] add new extrausers command passwd-expire - moved to PR 63

["Richard Purdie" <richard.purdie@linuxfoundation.org>]

On Tue, 2020-10-27 at 18:19 -0500, Joseph Reynolds wrote:
> On 10/27/20 2:41 PM, Richard Purdie wrote:
> > Hi Joseph,
> > 
> > On Mon, 2020-10-26 at 15:41 -0500, Joseph Reynolds wrote:
> > > This enhances extrausers with a new passwd-expire command that
> > > causes
> > > a local user's password to be expired as if the `passwd --expire`
> > > command was run, so the password needs to be changed on initial
> > > login.
> > > 
> > > Example: EXTRA_USERS_PARAMS += " useradd ... sofia; passwd-expire
> > > sofia;"
> > > 
> > > Tested: on useradd accounts
> > > When configured with Linux-PAM, console login prompts for and can
> > > successfully change the password.  OpenSSH server
> > > works.  Dropbear
> > > SSH server notes the password must be changed but does not offer
> > > a
> > > password change dialog and rejects the login request.
> > > 
> > > Signed-off-by: Joseph Reynolds <joseph-reynolds@charter.net>
> > > ---
> > >    meta/classes/extrausers.bbclass   |  3 +++
> > >    meta/classes/useradd_base.bbclass | 18 ++++++++++++++++++
> > >    2 files changed, 21 insertions(+)
> > > 
> > > diff --git a/meta/classes/extrausers.bbclass
> > > b/meta/classes/extrausers.bbclass
> > > index 32569e9..90811bf 100644
> > > --- a/meta/classes/extrausers.bbclass
> > > +++ b/meta/classes/extrausers.bbclass
> > > @@ -46,6 +46,9 @@ set_user_group () {
> > >                usermod)
> > >                    perform_usermod "${IMAGE_ROOTFS}" "-R
> > > ${IMAGE_ROOTFS}
> > > $opts"
> > Unfortunately this patch is coming through line wrapped which makes
> > it
> > hard to apply. Can you resend it without the line wrapping, or
> > point at
> > a git tree with the patch in please?
> 
> Thanks.  The PR work flow is much easier for me.  I didn't realize
> OE 
> was on github.com.
> I hereby withdraw & abandon my email patch request and replace it
> with:
> https://github.com/openembedded/openembedded-core/pull/63

We don't. In this case since its mangled, I'm willing to pull from
somewhere. We do need patches on the mailing list for review since that
is where people look to review them. github works fine for a single
maintainer, I can't merge pretty much anything without public peer
review though.

Cheers,

Richard