Openembedded Core Discussions
 help / color / mirror / Atom feed
* xinit_1.3.2: Remove broken, superfluous 'FILES_${PN} += "${libdir}X11/xinit"'
@ 2012-07-24 10:39 Robert P. J. Day
  2012-07-26 19:19 ` Saul Wold
  0 siblings, 1 reply; 2+ messages in thread
From: Robert P. J. Day @ 2012-07-24 10:39 UTC (permalink / raw)
  To: OE Core mailing list


Besides being clearly broken, that line is unnecessary as that file is
already being picked up from this line in xorg-app-common.inc:

FILES_${PN} += " ${libdir}/X11/${BPN} ${datadir}/X11/app-defaults/"

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

diff --git a/meta/recipes-graphics/xorg-app/xinit_1.3.2.bb b/meta/recipes-graphics/xorg-app/xinit_1.3.2.bb
index 2008e79..5a97c3b 100644
--- a/meta/recipes-graphics/xorg-app/xinit_1.3.2.bb
+++ b/meta/recipes-graphics/xorg-app/xinit_1.3.2.bb
@@ -19,5 +19,3 @@ SRC_URI[sha256sum] = "a1867fdaa83f68750b12ba4305c3c62f5992d0f52cfeb98e96c27a8e69
 EXTRA_OECONF = "ac_cv_path_MCOOKIE=${bindir}/mcookie"

 RDEPENDS_${PN} += "util-linux-mcookie"
-
-FILES_${PN} += "${libdir}X11/xinit"

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: xinit_1.3.2: Remove broken, superfluous 'FILES_${PN} += "${libdir}X11/xinit"'
  2012-07-24 10:39 xinit_1.3.2: Remove broken, superfluous 'FILES_${PN} += "${libdir}X11/xinit"' Robert P. J. Day
@ 2012-07-26 19:19 ` Saul Wold
  0 siblings, 0 replies; 2+ messages in thread
From: Saul Wold @ 2012-07-26 19:19 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

On 07/24/2012 03:39 AM, Robert P. J. Day wrote:
>
> Besides being clearly broken, that line is unnecessary as that file is
> already being picked up from this line in xorg-app-common.inc:
>
> FILES_${PN} += " ${libdir}/X11/${BPN} ${datadir}/X11/app-defaults/"
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---
>
> diff --git a/meta/recipes-graphics/xorg-app/xinit_1.3.2.bb b/meta/recipes-graphics/xorg-app/xinit_1.3.2.bb
> index 2008e79..5a97c3b 100644
> --- a/meta/recipes-graphics/xorg-app/xinit_1.3.2.bb
> +++ b/meta/recipes-graphics/xorg-app/xinit_1.3.2.bb
> @@ -19,5 +19,3 @@ SRC_URI[sha256sum] = "a1867fdaa83f68750b12ba4305c3c62f5992d0f52cfeb98e96c27a8e69
>   EXTRA_OECONF = "ac_cv_path_MCOOKIE=${bindir}/mcookie"
>
>   RDEPENDS_${PN} += "util-linux-mcookie"
> -
> -FILES_${PN} += "${libdir}X11/xinit"
>
Nice catch!

Merged into OE-Core

Thanks
	Sau!



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-07-26 19:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-24 10:39 xinit_1.3.2: Remove broken, superfluous 'FILES_${PN} += "${libdir}X11/xinit"' Robert P. J. Day
2012-07-26 19:19 ` Saul Wold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox