* libxp: Change superfluous "+=" to simple "=" when using _append
@ 2012-07-23 9:59 Robert P. J. Day
2012-07-26 19:27 ` Saul Wold
0 siblings, 1 reply; 4+ messages in thread
From: Robert P. J. Day @ 2012-07-23 9:59 UTC (permalink / raw)
To: OE Core mailing list
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
---
diff --git a/meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb b/meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb
index 349dad1..dbd4609 100644
--- a/meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb
+++ b/meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb
@@ -15,7 +15,7 @@ PE = "1"
XORG_PN = "libXp"
-CFLAGS_append += " -I ${S}/include/X11/XprintUtil -I ${S}/include/X11/extensions"
+CFLAGS_append = " -I ${S}/include/X11/XprintUtil -I ${S}/include/X11/extensions"
SRC_URI += "file://fix-cast-error.patch"
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: libxp: Change superfluous "+=" to simple "=" when using _append
2012-07-23 9:59 libxp: Change superfluous "+=" to simple "=" when using _append Robert P. J. Day
@ 2012-07-26 19:27 ` Saul Wold
2012-07-26 19:34 ` Chris Larson
0 siblings, 1 reply; 4+ messages in thread
From: Saul Wold @ 2012-07-26 19:27 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 07/23/2012 02:59 AM, Robert P. J. Day wrote:
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---
>
> diff --git a/meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb b/meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb
> index 349dad1..dbd4609 100644
> --- a/meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb
> +++ b/meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb
> @@ -15,7 +15,7 @@ PE = "1"
>
> XORG_PN = "libXp"
>
> -CFLAGS_append += " -I ${S}/include/X11/XprintUtil -I ${S}/include/X11/extensions"
> +CFLAGS_append = " -I ${S}/include/X11/XprintUtil -I ${S}/include/X11/extensions"
>
> SRC_URI += "file://fix-cast-error.patch"
>
>
Merged into OE-Core
Thanks
Sau!
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: libxp: Change superfluous "+=" to simple "=" when using _append
2012-07-26 19:27 ` Saul Wold
@ 2012-07-26 19:34 ` Chris Larson
2012-07-26 19:41 ` Saul Wold
0 siblings, 1 reply; 4+ messages in thread
From: Chris Larson @ 2012-07-26 19:34 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Thu, Jul 26, 2012 at 12:27 PM, Saul Wold <sgw@linux.intel.com> wrote:
> On 07/23/2012 02:59 AM, Robert P. J. Day wrote:
>>
>>
>> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>>
>> ---
>>
>> diff --git a/meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb
>> b/meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb
>> index 349dad1..dbd4609 100644
>> --- a/meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb
>> +++ b/meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb
>> @@ -15,7 +15,7 @@ PE = "1"
>>
>> XORG_PN = "libXp"
>>
>> -CFLAGS_append += " -I ${S}/include/X11/XprintUtil -I
>> ${S}/include/X11/extensions"
>> +CFLAGS_append = " -I ${S}/include/X11/XprintUtil -I
>> ${S}/include/X11/extensions"
>>
>> SRC_URI += "file://fix-cast-error.patch"
>>
>>
> Merged into OE-Core
A second janitorial-type task would be to find and remove unnecessary
uses of _append entirely. This one for example, it's highly unlikely a
+= wouldn't do the job here. :)
--
Christopher Larson
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: libxp: Change superfluous "+=" to simple "=" when using _append
2012-07-26 19:34 ` Chris Larson
@ 2012-07-26 19:41 ` Saul Wold
0 siblings, 0 replies; 4+ messages in thread
From: Saul Wold @ 2012-07-26 19:41 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: Chris Larson
On 07/26/2012 12:34 PM, Chris Larson wrote:
> On Thu, Jul 26, 2012 at 12:27 PM, Saul Wold <sgw@linux.intel.com> wrote:
>> On 07/23/2012 02:59 AM, Robert P. J. Day wrote:
>>>
>>>
>>> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>>>
>>> ---
>>>
>>> diff --git a/meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb
>>> b/meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb
>>> index 349dad1..dbd4609 100644
>>> --- a/meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb
>>> +++ b/meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb
>>> @@ -15,7 +15,7 @@ PE = "1"
>>>
>>> XORG_PN = "libXp"
>>>
>>> -CFLAGS_append += " -I ${S}/include/X11/XprintUtil -I
>>> ${S}/include/X11/extensions"
>>> +CFLAGS_append = " -I ${S}/include/X11/XprintUtil -I
>>> ${S}/include/X11/extensions"
>>>
>>> SRC_URI += "file://fix-cast-error.patch"
>>>
>>>
>> Merged into OE-Core
>
> A second janitorial-type task would be to find and remove unnecessary
> uses of _append entirely. This one for example, it's highly unlikely a
> += wouldn't do the job here. :)
Mind filing that as a Janitor bug?
Sau!
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-26 19:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-23 9:59 libxp: Change superfluous "+=" to simple "=" when using _append Robert P. J. Day
2012-07-26 19:27 ` Saul Wold
2012-07-26 19:34 ` Chris Larson
2012-07-26 19:41 ` Saul Wold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox