[RFC] bitbake.conf: store cooker logs in TMPDIR subdirectory

[RFC] bitbake.conf: store cooker logs in TMPDIR subdirectory

[Martin Jansa]

* we should probably wait until
  http://git.openembedded.org/bitbake/commit/?id=1e06d8012868ba5a31503dc99cbf18570be629d9
  is in next required bitbake version, but error message if the directory doesn't exist is quite clear
* people with new enough bitbake could just change this in their local.conf

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/conf/bitbake.conf |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index d5a43e9..ff1cbd6 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -754,7 +754,7 @@ DISTRO[unexport] = "1"
 TRANSLATED_TARGET_ARCH ??= "${@d.getVar('TARGET_ARCH', True).replace("_", "-")}"
 
 # Complete output from bitbake, if you're changing it, make sure to use existing directory
-BB_CONSOLELOG ?= "${TMPDIR}/cooker.log.${DATETIME}"
+BB_CONSOLELOG ?= "${TMPDIR}/cooker/${MACHINE}/${DATETIME}"
 
 # Setup our default hash policy
 BB_SIGNATURE_HANDLER ?= "OEBasicHash"
-- 
1.7.8.6

Re: [RFC] bitbake.conf: store cooker logs in TMPDIR subdirectory

[Paul Eggleton]

On Thursday 02 August 2012 18:24:43 Martin Jansa wrote:
> * we should probably wait until
>  
> http://git.openembedded.org/bitbake/commit/?id=1e06d8012868ba5a31503dc99cbf
> 18570be629d9 is in next required bitbake version, but error message if the
> directory doesn't exist is quite clear * people with new enough bitbake
> could just change this in their local.conf
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta/conf/bitbake.conf |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index d5a43e9..ff1cbd6 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -754,7 +754,7 @@ DISTRO[unexport] = "1"
>  TRANSLATED_TARGET_ARCH ??= "${@d.getVar('TARGET_ARCH', True).replace("_",
> "-")}"
> 
>  # Complete output from bitbake, if you're changing it, make sure to use
> existing directory -BB_CONSOLELOG ?= "${TMPDIR}/cooker.log.${DATETIME}"
> +BB_CONSOLELOG ?= "${TMPDIR}/cooker/${MACHINE}/${DATETIME}"

I was thinking about this the other day - shouldn't we be using LOG_DIR for 
this?

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [RFC] bitbake.conf: store cooker logs in TMPDIR subdirectory

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1500 bytes --]

On Thu, Aug 02, 2012 at 05:27:38PM +0100, Paul Eggleton wrote:
> On Thursday 02 August 2012 18:24:43 Martin Jansa wrote:
> > * we should probably wait until
> >  
> > http://git.openembedded.org/bitbake/commit/?id=1e06d8012868ba5a31503dc99cbf
> > 18570be629d9 is in next required bitbake version, but error message if the
> > directory doesn't exist is quite clear * people with new enough bitbake
> > could just change this in their local.conf
> > 
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> >  meta/conf/bitbake.conf |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> > index d5a43e9..ff1cbd6 100644
> > --- a/meta/conf/bitbake.conf
> > +++ b/meta/conf/bitbake.conf
> > @@ -754,7 +754,7 @@ DISTRO[unexport] = "1"
> >  TRANSLATED_TARGET_ARCH ??= "${@d.getVar('TARGET_ARCH', True).replace("_",
> > "-")}"
> > 
> >  # Complete output from bitbake, if you're changing it, make sure to use
> > existing directory -BB_CONSOLELOG ?= "${TMPDIR}/cooker.log.${DATETIME}"
> > +BB_CONSOLELOG ?= "${TMPDIR}/cooker/${MACHINE}/${DATETIME}"
> 
> I was thinking about this the other day - shouldn't we be using LOG_DIR for 
> this?

Yes, makes sense. And I've also forgot to remove that comment above
BB_CONSOLELOG"

> 
> Cheers,
> Paul
> 
> -- 
> 
> Paul Eggleton
> Intel Open Source Technology Centre

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

[RFCv2] bitbake.conf: store cooker logs in TMPDIR subdirectory

[Martin Jansa]

* we should probably wait until
  http://git.openembedded.org/bitbake/commit/?id=1e06d8012868ba5a31503dc99cbf18570be629d9
  is in next required bitbake version, but error message if the directory doesn't exist is quite clear
* people with new enough bitbake could just change this in their local.conf

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/conf/bitbake.conf |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index d5a43e9..8074684 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -753,8 +753,8 @@ DISTRO[unexport] = "1"
 # Used by canadian-cross to handle string conversions on TARGET_ARCH where needed
 TRANSLATED_TARGET_ARCH ??= "${@d.getVar('TARGET_ARCH', True).replace("_", "-")}"
 
-# Complete output from bitbake, if you're changing it, make sure to use existing directory
-BB_CONSOLELOG ?= "${TMPDIR}/cooker.log.${DATETIME}"
+# Complete output from bitbake
+BB_CONSOLELOG ?= "${LOG_DIR}/cooker/${MACHINE}/${DATETIME}.log"
 
 # Setup our default hash policy
 BB_SIGNATURE_HANDLER ?= "OEBasicHash"
-- 
1.7.8.6

Re: [RFCv2] bitbake.conf: store cooker logs in TMPDIR subdirectory

[Chris Larson]

On Thu, Aug 2, 2012 at 9:31 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> * we should probably wait until
>   http://git.openembedded.org/bitbake/commit/?id=1e06d8012868ba5a31503dc99cbf18570be629d9
>   is in next required bitbake version, but error message if the directory doesn't exist is quite clear
> * people with new enough bitbake could just change this in their local.conf
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta/conf/bitbake.conf |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index d5a43e9..8074684 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -753,8 +753,8 @@ DISTRO[unexport] = "1"
>  # Used by canadian-cross to handle string conversions on TARGET_ARCH where needed
>  TRANSLATED_TARGET_ARCH ??= "${@d.getVar('TARGET_ARCH', True).replace("_", "-")}"
>
> -# Complete output from bitbake, if you're changing it, make sure to use existing directory
> -BB_CONSOLELOG ?= "${TMPDIR}/cooker.log.${DATETIME}"
> +# Complete output from bitbake
> +BB_CONSOLELOG ?= "${LOG_DIR}/cooker/${MACHINE}/${DATETIME}.log"

I'd recommend rewording the commit subject. It's not 100% clear that
it refers to 'the tmpdir subdir' or 'a subdir of tmpdir', until you
read the patch :)
-- 
Christopher Larson

[RFCv3] bitbake.conf: store cooker logs in subdirectory of LOG_DIR

[Martin Jansa]

* we should probably wait until
  http://git.openembedded.org/bitbake/commit/?id=1e06d8012868ba5a31503dc99cbf18570be629d9
  is in next required bitbake version, but error message if the directory doesn't exist is quite clear
* people with new enough bitbake could just change this in their local.conf

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/conf/bitbake.conf |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index d5a43e9..8074684 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -753,8 +753,8 @@ DISTRO[unexport] = "1"
 # Used by canadian-cross to handle string conversions on TARGET_ARCH where needed
 TRANSLATED_TARGET_ARCH ??= "${@d.getVar('TARGET_ARCH', True).replace("_", "-")}"
 
-# Complete output from bitbake, if you're changing it, make sure to use existing directory
-BB_CONSOLELOG ?= "${TMPDIR}/cooker.log.${DATETIME}"
+# Complete output from bitbake
+BB_CONSOLELOG ?= "${LOG_DIR}/cooker/${MACHINE}/${DATETIME}.log"
 
 # Setup our default hash policy
 BB_SIGNATURE_HANDLER ?= "OEBasicHash"
-- 
1.7.8.6

Re: [RFCv3] bitbake.conf: store cooker logs in subdirectory of LOG_DIR

[Saul Wold]

On 08/02/2012 09:45 AM, Martin Jansa wrote:
> * we should probably wait until
>    http://git.openembedded.org/bitbake/commit/?id=1e06d8012868ba5a31503dc99cbf18570be629d9
>    is in next required bitbake version, but error message if the directory doesn't exist is quite clear
> * people with new enough bitbake could just change this in their local.conf
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>   meta/conf/bitbake.conf |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index d5a43e9..8074684 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -753,8 +753,8 @@ DISTRO[unexport] = "1"
>   # Used by canadian-cross to handle string conversions on TARGET_ARCH where needed
>   TRANSLATED_TARGET_ARCH ??= "${@d.getVar('TARGET_ARCH', True).replace("_", "-")}"
>
> -# Complete output from bitbake, if you're changing it, make sure to use existing directory
> -BB_CONSOLELOG ?= "${TMPDIR}/cooker.log.${DATETIME}"
> +# Complete output from bitbake
> +BB_CONSOLELOG ?= "${LOG_DIR}/cooker/${MACHINE}/${DATETIME}.log"
>
>   # Setup our default hash policy
>   BB_SIGNATURE_HANDLER ?= "OEBasicHash"
>
Merged into OE-Core

Thanks
	Sau!