Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] perf_3.4.bb: update to build against older kernels
@ 2012-08-17  2:54 Matthew McClintock
  2012-08-20 16:57 ` Saul Wold
  0 siblings, 1 reply; 2+ messages in thread
From: Matthew McClintock @ 2012-08-17  2:54 UTC (permalink / raw)
  To: openembedded-core

Removes a make install-python_ext when not present since
older versions of perf lack this install rule

This also fixes a library issue on older kernels building with
a newer toolchain where libaries that would previously be pulled
in are no longer. So we add them manually.

Signed-off-by: Matthew McClintock <msm@freescale.com>
---
 meta/recipes-kernel/perf/perf_3.4.bb |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-kernel/perf/perf_3.4.bb b/meta/recipes-kernel/perf/perf_3.4.bb
index 505c7b8..5fb38e6 100644
--- a/meta/recipes-kernel/perf/perf_3.4.bb
+++ b/meta/recipes-kernel/perf/perf_3.4.bb
@@ -54,6 +54,7 @@ B = "${WORKDIR}/${BPN}-${PV}"
 SCRIPTING_DEFINES = "${@perf_feature_enabled('perf-scripting', '', 'NO_LIBPERL=1 NO_LIBPYTHON=1',d)}"
 TUI_DEFINES = "${@perf_feature_enabled('perf-tui', '', 'NO_NEWT=1',d)}"
 
+export LDFLAGS = "-ldl -lutil"
 EXTRA_OEMAKE = \
 		'-C ${S}/tools/perf \
 		O=${B} \
@@ -71,7 +72,8 @@ do_compile() {
 
 do_install() {
 	oe_runmake DESTDIR=${D} install
-	if [ "${@perf_feature_enabled('perf-scripting', 1, 0, d)}" = "1" ]; then
+	# we are checking for this make target to be compatible with older perf versions
+	if [ "${@perf_feature_enabled('perf-scripting', 1, 0, d)}" = "1" -a $(grep install-python_ext ${S}/tools/perf/Makefile) = "0"]; then
 		oe_runmake DESTDIR=${D} install-python_ext
 	fi
 }
-- 
1.7.9.7





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] perf_3.4.bb: update to build against older kernels
  2012-08-17  2:54 [PATCH] perf_3.4.bb: update to build against older kernels Matthew McClintock
@ 2012-08-20 16:57 ` Saul Wold
  0 siblings, 0 replies; 2+ messages in thread
From: Saul Wold @ 2012-08-20 16:57 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer; +Cc: Matthew McClintock

On 08/16/2012 07:54 PM, Matthew McClintock wrote:
> Removes a make install-python_ext when not present since
> older versions of perf lack this install rule
>
> This also fixes a library issue on older kernels building with
> a newer toolchain where libaries that would previously be pulled
> in are no longer. So we add them manually.
>
> Signed-off-by: Matthew McClintock <msm@freescale.com>
> ---
>   meta/recipes-kernel/perf/perf_3.4.bb |    4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-kernel/perf/perf_3.4.bb b/meta/recipes-kernel/perf/perf_3.4.bb
> index 505c7b8..5fb38e6 100644
> --- a/meta/recipes-kernel/perf/perf_3.4.bb
> +++ b/meta/recipes-kernel/perf/perf_3.4.bb
> @@ -54,6 +54,7 @@ B = "${WORKDIR}/${BPN}-${PV}"
>   SCRIPTING_DEFINES = "${@perf_feature_enabled('perf-scripting', '', 'NO_LIBPERL=1 NO_LIBPYTHON=1',d)}"
>   TUI_DEFINES = "${@perf_feature_enabled('perf-tui', '', 'NO_NEWT=1',d)}"
>
> +export LDFLAGS = "-ldl -lutil"
>   EXTRA_OEMAKE = \
>   		'-C ${S}/tools/perf \
>   		O=${B} \
> @@ -71,7 +72,8 @@ do_compile() {
>
>   do_install() {
>   	oe_runmake DESTDIR=${D} install
> -	if [ "${@perf_feature_enabled('perf-scripting', 1, 0, d)}" = "1" ]; then
> +	# we are checking for this make target to be compatible with older perf versions
> +	if [ "${@perf_feature_enabled('perf-scripting', 1, 0, d)}" = "1" -a $(grep install-python_ext ${S}/tools/perf/Makefile) = "0"]; then
>   		oe_runmake DESTDIR=${D} install-python_ext
>   	fi
>   }
>

Merged into OE-Core

Thanks
	Sau!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-08-20 17:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-17  2:54 [PATCH] perf_3.4.bb: update to build against older kernels Matthew McClintock
2012-08-20 16:57 ` Saul Wold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox