Re: [PATCH] libxpm-native: add dependency on gettext-native

[Saul Wold <sgw@linux.intel.com>]

On 08/02/2012 06:57 PM, Jesse Zhang wrote:
> libxpm needs xgettext to build po files. Add explicit dependency on
> gettext-native.
>
> Signed-off-by: Jesse Zhang <sen.zhang@windriver.com>
> ---
>   meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb b/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb
> index 9eaa212..6830216 100644
> --- a/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb
> +++ b/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb
> @@ -10,7 +10,8 @@ protocol."
>   LICENSE = "BSD"
>   LIC_FILES_CHKSUM = "file://COPYING;md5=3e07763d16963c3af12db271a31abaa5"
>   DEPENDS += "libxext libsm libxt"
> -PR = "r0"
> +DEPENDS_virtclass-native = "gettext-native"

Is there a reason you don't do an inherit gettext here to ensure other 
bits are set?  Also for the native, you maybe able to use the 
gettext-minimal-native if there is reason you can't use the inherit.

Sau!

> +PR = "r1"
>   PE = "1"
>
>   XORG_PN = "libXpm"
>