Re: [PATCH] libxpm-native: add dependency on gettext-native

[Jesse Zhang <sen.zhang@windriver.com>]

Hi Saul,

On 08/21/2012 05:16 AM, Saul Wold wrote:
> On 08/02/2012 06:57 PM, Jesse Zhang wrote:
>> libxpm needs xgettext to build po files. Add explicit dependency on
>> gettext-native.
>>
>> Signed-off-by: Jesse Zhang <sen.zhang@windriver.com>
>> ---
>>   meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb |    3 ++-
>>   1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb b/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb
>> index 9eaa212..6830216 100644
>> --- a/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb
>> +++ b/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb
>> @@ -10,7 +10,8 @@ protocol."
>>   LICENSE = "BSD"
>>   LIC_FILES_CHKSUM = "file://COPYING;md5=3e07763d16963c3af12db271a31abaa5"
>>   DEPENDS += "libxext libsm libxt"
>> -PR = "r0"
>> +DEPENDS_virtclass-native = "gettext-native"
> 
> Is there a reason you don't do an inherit gettext here to ensure other bits are set?

Actually I don't know what's the preferred way to do this. What is
required by libxpm is the xgettext command; using DEPENDS will be enough
to make it available, but I didn't know the other solution.

> Also for the native, you maybe able to use the gettext-minimal-native if there is reason you can't use the inherit.

gettext-minimal-native is already pulled in through the implicit
dependency chain. But clearly it doesn't provide xgettext?

jesse

> 
>> +PR = "r1"
>>   PE = "1"
>>
>>   XORG_PN = "libXpm"
>>
> 
>