From: Radu Moisan <radu.moisan@intel.com>
To: Chris Larson <clarson@kergoth.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] coreutils: Upgrade to upstream version 8.17
Date: Wed, 22 Aug 2012 17:24:51 +0300 [thread overview]
Message-ID: <5034EBB3.3010906@intel.com> (raw)
In-Reply-To: <CABcZANn8tSTrfwbOCi6WoiURVRcG3w_dF5-nnwMC+7Pz=aK01w@mail.gmail.com>
On 08/22/2012 05:08 PM, Chris Larson wrote:
> On Wed, Aug 22, 2012 at 3:43 AM, Radu Moisan <radu.moisan@intel.com> wrote:
>> diff --git a/meta/recipes-core/coreutils/coreutils-8.17/realpath-works-yes.patch b/meta/recipes-core/coreutils/coreutils-8.17/realpath-works-yes.patch
>> new file mode 100644
>> index 0000000..e32f612
>> --- /dev/null
>> +++ b/meta/recipes-core/coreutils/coreutils-8.17/realpath-works-yes.patch
>> @@ -0,0 +1,21 @@
>> +Signed-off-by: Radu Moisan <radu.moisan@intel.com>
>> +Upstream status: pending
>> +
>> +The new version of coreutils, adds use of canonicalize_file_name() function defined in canonicalize.h
>> +The problem: the function is redefined to rpl_canonicalize_file_name by means of a macro,which gives
>> +an undefined reference error at compile time. Macro definition depends in the end on
>> +gl_cv_func_realpath_works but assumed true only when set to "yes"
>> +
>> +Index: coreutils-8.17/m4/canonicalize.m4
>> +===================================================================
>> +--- coreutils-8.17.orig/m4/canonicalize.m4 2012-05-08 12:05:23.000000000 +0300
>> ++++ coreutils-8.17/m4/canonicalize.m4 2012-08-17 14:20:22.000000000 +0300
>> +@@ -95,7 +95,7 @@
>> + [gl_cv_func_realpath_works=no],
>> + [case "$host_os" in
>> + # Guess yes on glibc systems.
>> +- *-gnu*) gl_cv_func_realpath_works="guessing yes" ;;
>> ++ *-gnu*) gl_cv_func_realpath_works="yes" ;;
>> + # If we don't know, assume the worst.
>> + *) gl_cv_func_realpath_works="guessing no" ;;
>> + esac
> Wouldn't it be better to provide a cached test result in the site
> files for this test, rather than relying on a host_os based guess?
I really don't know the answer to your question. The patch was intended
to provide minimally invasive change to the original file. If you
elaborate more on your proposal, I would gladly take into consideration
a future patch to address this issue.
radu
next prev parent reply other threads:[~2012-08-22 14:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 10:43 [PATCH] coreutils: Upgrade to upstream version 8.17 Radu Moisan
2012-08-22 14:08 ` Chris Larson
2012-08-22 14:24 ` Radu Moisan [this message]
2012-08-22 14:26 ` Khem Raj
2012-08-22 14:30 ` Chris Larson
2012-08-22 16:36 ` Mark Hatle
2012-09-03 8:52 ` Radu Moisan
2012-09-03 15:28 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5034EBB3.3010906@intel.com \
--to=radu.moisan@intel.com \
--cc=clarson@kergoth.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox