* [PATCH] perf: Refactor code so it is easier to read
@ 2012-09-13 20:32 Otavio Salvador
2012-09-13 20:38 ` Otavio Salvador
2012-09-13 20:40 ` Saul Wold
0 siblings, 2 replies; 4+ messages in thread
From: Otavio Salvador @ 2012-09-13 20:32 UTC (permalink / raw)
To: openembedded-core
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
meta/recipes-kernel/perf/perf_3.4.bb | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/meta/recipes-kernel/perf/perf_3.4.bb b/meta/recipes-kernel/perf/perf_3.4.bb
index decc911..6e1c746 100644
--- a/meta/recipes-kernel/perf/perf_3.4.bb
+++ b/meta/recipes-kernel/perf/perf_3.4.bb
@@ -74,7 +74,7 @@ do_compile() {
do_install() {
oe_runmake DESTDIR=${D} install
# we are checking for this make target to be compatible with older perf versions
- if [ "${@perf_feature_enabled('perf-scripting', 1, 0, d)}" = "1" -a $(grep install-python_ext ${S}/tools/perf/Makefile) = "0"]; then
+ if [ "${@perf_feature_enabled('perf-scripting', 1, 0, d)}" = "1" ] && ! grep -q install-python_ext ${S}/tools/perf/Makefile ]; then
oe_runmake DESTDIR=${D} install-python_ext
fi
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] perf: Refactor code so it is easier to read
2012-09-13 20:32 [PATCH] perf: Refactor code so it is easier to read Otavio Salvador
@ 2012-09-13 20:38 ` Otavio Salvador
2012-09-13 20:40 ` Saul Wold
2012-09-13 20:40 ` Saul Wold
1 sibling, 1 reply; 4+ messages in thread
From: Otavio Salvador @ 2012-09-13 20:38 UTC (permalink / raw)
To: openembedded-core
On Thu, Sep 13, 2012 at 5:32 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> meta/recipes-kernel/perf/perf_3.4.bb | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Please ignore this patch ...
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] perf: Refactor code so it is easier to read
2012-09-13 20:32 [PATCH] perf: Refactor code so it is easier to read Otavio Salvador
2012-09-13 20:38 ` Otavio Salvador
@ 2012-09-13 20:40 ` Saul Wold
1 sibling, 0 replies; 4+ messages in thread
From: Saul Wold @ 2012-09-13 20:40 UTC (permalink / raw)
To: openembedded-core
On 09/13/2012 01:32 PM, Otavio Salvador wrote:
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> meta/recipes-kernel/perf/perf_3.4.bb | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-kernel/perf/perf_3.4.bb b/meta/recipes-kernel/perf/perf_3.4.bb
> index decc911..6e1c746 100644
> --- a/meta/recipes-kernel/perf/perf_3.4.bb
> +++ b/meta/recipes-kernel/perf/perf_3.4.bb
> @@ -74,7 +74,7 @@ do_compile() {
> do_install() {
> oe_runmake DESTDIR=${D} install
> # we are checking for this make target to be compatible with older perf versions
> - if [ "${@perf_feature_enabled('perf-scripting', 1, 0, d)}" = "1" -a $(grep install-python_ext ${S}/tools/perf/Makefile) = "0"]; then
> + if [ "${@perf_feature_enabled('perf-scripting', 1, 0, d)}" = "1" ] && ! grep -q install-python_ext ${S}/tools/perf/Makefile ]; then
Is this missing a [ or is there an extra ]?
Also is that dash compliant?
And of course you need a PR bump (well maybe not in this case)
Sau!
> oe_runmake DESTDIR=${D} install-python_ext
> fi
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-13 20:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-13 20:32 [PATCH] perf: Refactor code so it is easier to read Otavio Salvador
2012-09-13 20:38 ` Otavio Salvador
2012-09-13 20:40 ` Saul Wold
2012-09-13 20:40 ` Saul Wold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox