Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] local.conf.sample: change valgrind support architecture comment
@ 2012-09-13 11:20 Jack Mitchell
  2012-09-13 12:21 ` Paul Eggleton
  0 siblings, 1 reply; 4+ messages in thread
From: Jack Mitchell @ 2012-09-13 11:20 UTC (permalink / raw)
  To: openembedded-core; +Cc: Jack Mitchell

From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>

The comment for debug-tools states valgrind will only be installed for x86
targets. This is not true as valgrind now supports x86*, PPC* and ARMv7a;
alter the comment to reflect this.

Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
---
 meta/conf/local.conf.sample | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/conf/local.conf.sample b/meta/conf/local.conf.sample
index 5679c03..cf35310 100644
--- a/meta/conf/local.conf.sample
+++ b/meta/conf/local.conf.sample
@@ -119,7 +119,7 @@ PACKAGE_CLASSES ?= "package_ipk"
 #                     (useful if you want to develop against libs in the image)
 #  "tools-sdk"      - add development tools (gcc, make, pkgconfig etc.)
 #  "tools-debug"    - add debugging tools (gdb, strace)
-#  "tools-profile"  - add profiling tools (oprofile, exmap, lttng valgrind (x86 only))
+#  "tools-profile"  - add profiling tools (oprofile, exmap, lttng, valgrind(x86*, armv7a, ppc*))
 #  "tools-testapps" - add useful testing tools (ts_print, aplay, arecord etc.)
 #  "debug-tweaks"   - make an image suitable for development
 #                     e.g. ssh root access has a blank password
-- 
1.7.12




^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] local.conf.sample: change valgrind support architecture comment
  2012-09-13 11:20 [PATCH] local.conf.sample: change valgrind support architecture comment Jack Mitchell
@ 2012-09-13 12:21 ` Paul Eggleton
  2012-09-13 12:27   ` [PATCHv2] " Jack Mitchell
  0 siblings, 1 reply; 4+ messages in thread
From: Paul Eggleton @ 2012-09-13 12:21 UTC (permalink / raw)
  To: Jack Mitchell; +Cc: Jack Mitchell, openembedded-core

On Thursday 13 September 2012 12:20:04 Jack Mitchell wrote:
> From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
> 
> The comment for debug-tools states valgrind will only be installed for x86
> targets. This is not true as valgrind now supports x86*, PPC* and ARMv7a;
> alter the comment to reflect this.

I have to say I think we can just drop this part of the comment entirely given 
how wide the support is now.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCHv2] local.conf.sample: change valgrind support architecture comment
  2012-09-13 12:21 ` Paul Eggleton
@ 2012-09-13 12:27   ` Jack Mitchell
  2012-09-19 17:39     ` Saul Wold
  0 siblings, 1 reply; 4+ messages in thread
From: Jack Mitchell @ 2012-09-13 12:27 UTC (permalink / raw)
  To: openembedded-core; +Cc: Jack Mitchell

From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>

The comment for debug-tools states valgrind will only be installed for x86
targets. This is not true as valgrind now supports x86*, PPC* and ARMv7a;
delete the comment as the architecture support is now so varied.

Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
---
 meta/conf/local.conf.sample | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/conf/local.conf.sample b/meta/conf/local.conf.sample
index 5679c03..04d947f 100644
--- a/meta/conf/local.conf.sample
+++ b/meta/conf/local.conf.sample
@@ -119,7 +119,7 @@ PACKAGE_CLASSES ?= "package_ipk"
 #                     (useful if you want to develop against libs in the image)
 #  "tools-sdk"      - add development tools (gcc, make, pkgconfig etc.)
 #  "tools-debug"    - add debugging tools (gdb, strace)
-#  "tools-profile"  - add profiling tools (oprofile, exmap, lttng valgrind (x86 only))
+#  "tools-profile"  - add profiling tools (oprofile, exmap, lttng, valgrind)
 #  "tools-testapps" - add useful testing tools (ts_print, aplay, arecord etc.)
 #  "debug-tweaks"   - make an image suitable for development
 #                     e.g. ssh root access has a blank password
-- 
1.7.12




^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCHv2] local.conf.sample: change valgrind support architecture comment
  2012-09-13 12:27   ` [PATCHv2] " Jack Mitchell
@ 2012-09-19 17:39     ` Saul Wold
  0 siblings, 0 replies; 4+ messages in thread
From: Saul Wold @ 2012-09-19 17:39 UTC (permalink / raw)
  To: Jack Mitchell; +Cc: Jack Mitchell, openembedded-core

On 09/13/2012 05:27 AM, Jack Mitchell wrote:
> From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
>
> The comment for debug-tools states valgrind will only be installed for x86
> targets. This is not true as valgrind now supports x86*, PPC* and ARMv7a;
> delete the comment as the architecture support is now so varied.
>
> Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
> ---
>   meta/conf/local.conf.sample | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/conf/local.conf.sample b/meta/conf/local.conf.sample
> index 5679c03..04d947f 100644
> --- a/meta/conf/local.conf.sample
> +++ b/meta/conf/local.conf.sample
> @@ -119,7 +119,7 @@ PACKAGE_CLASSES ?= "package_ipk"
>   #                     (useful if you want to develop against libs in the image)
>   #  "tools-sdk"      - add development tools (gcc, make, pkgconfig etc.)
>   #  "tools-debug"    - add debugging tools (gdb, strace)
> -#  "tools-profile"  - add profiling tools (oprofile, exmap, lttng valgrind (x86 only))
> +#  "tools-profile"  - add profiling tools (oprofile, exmap, lttng, valgrind)
>   #  "tools-testapps" - add useful testing tools (ts_print, aplay, arecord etc.)
>   #  "debug-tweaks"   - make an image suitable for development
>   #                     e.g. ssh root access has a blank password
>

Merged into OE-Core

Thanks
	Sau!




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-09-19 17:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-13 11:20 [PATCH] local.conf.sample: change valgrind support architecture comment Jack Mitchell
2012-09-13 12:21 ` Paul Eggleton
2012-09-13 12:27   ` [PATCHv2] " Jack Mitchell
2012-09-19 17:39     ` Saul Wold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox