Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH v2] sanity.bbclass: Fix invalid test for network error
@ 2012-10-02  9:52 Bogdan Marinescu
  2012-10-02 15:29 ` Saul Wold
  0 siblings, 1 reply; 2+ messages in thread
From: Bogdan Marinescu @ 2012-10-02  9:52 UTC (permalink / raw)
  To: openembedded-core

The test for network error in sanity.bbclass was negated.

Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
---
 meta/classes/sanity.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index e2095dd..f2e9a74 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -174,7 +174,7 @@ def check_sanity_tmpdir_change(tmpdir, data):
     # Check that we can fetch from various network transports
     errmsg = check_connectivity(data)
     testmsg = testmsg + check_connectivity(data)
-    return testmsg, errmsg == ""
+    return testmsg, errmsg != ""
         
 def check_sanity_version_change(data):
     # Sanity checks to be done when SANITY_VERSION changes
-- 
1.7.9.5




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] sanity.bbclass: Fix invalid test for network error
  2012-10-02  9:52 [PATCH v2] sanity.bbclass: Fix invalid test for network error Bogdan Marinescu
@ 2012-10-02 15:29 ` Saul Wold
  0 siblings, 0 replies; 2+ messages in thread
From: Saul Wold @ 2012-10-02 15:29 UTC (permalink / raw)
  To: Bogdan Marinescu; +Cc: openembedded-core

On 10/02/2012 02:52 AM, Bogdan Marinescu wrote:
> The test for network error in sanity.bbclass was negated.
>
> Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
> ---
>   meta/classes/sanity.bbclass |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index e2095dd..f2e9a74 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -174,7 +174,7 @@ def check_sanity_tmpdir_change(tmpdir, data):
>       # Check that we can fetch from various network transports
>       errmsg = check_connectivity(data)
>       testmsg = testmsg + check_connectivity(data)
> -    return testmsg, errmsg == ""
> +    return testmsg, errmsg != ""
>
>   def check_sanity_version_change(data):
>       # Sanity checks to be done when SANITY_VERSION changes
>
Merged into OE-Core

Thanks
	Sau!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-10-02 15:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-02  9:52 [PATCH v2] sanity.bbclass: Fix invalid test for network error Bogdan Marinescu
2012-10-02 15:29 ` Saul Wold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox