* [PATCH] chkconfig: pass CFLAGS to Makefile
@ 2012-10-09 20:53 Joe Slater
2012-10-09 21:05 ` Mark Hatle
0 siblings, 1 reply; 2+ messages in thread
From: Joe Slater @ 2012-10-09 20:53 UTC (permalink / raw)
To: openembedded-core
The environment CFLAGS is not used by the chkconfig
Makefile, so debug and optimization options are ignored.
So, we use RPM_OPT_FLAGS to pass CFLAGS into Makefile.
Upstream-Status: Inappropriate [configuration]
Signed-off-by: Joe Slater <jslater@windriver.com>
---
.../recipes-extended/chkconfig/chkconfig_1.3.58.bb | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/meta/recipes-extended/chkconfig/chkconfig_1.3.58.bb b/meta/recipes-extended/chkconfig/chkconfig_1.3.58.bb
index 17987a6..a9cf268 100644
--- a/meta/recipes-extended/chkconfig/chkconfig_1.3.58.bb
+++ b/meta/recipes-extended/chkconfig/chkconfig_1.3.58.bb
@@ -21,7 +21,10 @@ SRC_URI[sha256sum] = "18b497d25b2cada955c72810e45fcad8280d105f17cf45e2970f182712
inherit autotools gettext
-EXTRA_OEMAKE += 'MANDIR="${mandir}" BINDIR="${base_sbindir}" SBINDIR="${sbindir}"'
+# Makefile uses RPM_OPT_fLAGS to construct CFLAGS
+#
+EXTRA_OEMAKE += 'RPM_OPT_FLAGS="${CFLAGS}" MANDIR="${mandir}" \
+ BINDIR="${base_sbindir}" SBINDIR="${sbindir}"'
do_install_append() {
mkdir -p ${D}/etc/chkconfig.d
--
1.7.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] chkconfig: pass CFLAGS to Makefile
2012-10-09 20:53 [PATCH] chkconfig: pass CFLAGS to Makefile Joe Slater
@ 2012-10-09 21:05 ` Mark Hatle
0 siblings, 0 replies; 2+ messages in thread
From: Mark Hatle @ 2012-10-09 21:05 UTC (permalink / raw)
To: openembedded-core
On 10/9/12 3:53 PM, Joe Slater wrote:
> The environment CFLAGS is not used by the chkconfig
> Makefile, so debug and optimization options are ignored.
> So, we use RPM_OPT_FLAGS to pass CFLAGS into Makefile.
>
> Upstream-Status: Inappropriate [configuration]
>
> Signed-off-by: Joe Slater <jslater@windriver.com>
> ---
> .../recipes-extended/chkconfig/chkconfig_1.3.58.bb | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-extended/chkconfig/chkconfig_1.3.58.bb b/meta/recipes-extended/chkconfig/chkconfig_1.3.58.bb
> index 17987a6..a9cf268 100644
> --- a/meta/recipes-extended/chkconfig/chkconfig_1.3.58.bb
> +++ b/meta/recipes-extended/chkconfig/chkconfig_1.3.58.bb
> @@ -21,7 +21,10 @@ SRC_URI[sha256sum] = "18b497d25b2cada955c72810e45fcad8280d105f17cf45e2970f182712
>
> inherit autotools gettext
>
> -EXTRA_OEMAKE += 'MANDIR="${mandir}" BINDIR="${base_sbindir}" SBINDIR="${sbindir}"'
> +# Makefile uses RPM_OPT_fLAGS to construct CFLAGS
> +#
> +EXTRA_OEMAKE += 'RPM_OPT_FLAGS="${CFLAGS}" MANDIR="${mandir}" \
> + BINDIR="${base_sbindir}" SBINDIR="${sbindir}"'
>
> do_install_append() {
> mkdir -p ${D}/etc/chkconfig.d
>
This can potentially impact what was built, so you need to update the PR.
Otherwise looks find.
--Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-09 21:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-09 20:53 [PATCH] chkconfig: pass CFLAGS to Makefile Joe Slater
2012-10-09 21:05 ` Mark Hatle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox