Openembedded Core Discussions
 help / color / mirror / Atom feed
* [RFC PATCH] gettext: Remove spurious-looking dependencies on libxml2-native
@ 2012-09-26 10:30 Phil Blundell
  2012-10-18 19:57 ` Saul Wold
  0 siblings, 1 reply; 2+ messages in thread
From: Phil Blundell @ 2012-09-26 10:30 UTC (permalink / raw)
  To: OE-core

These were added in aae5021101224344a2b1a3af5becf74291fbbfe5, ostensibly to resolve
some sort of "host contamination" issue.  However, that commit contains no information
about what contamination was being observed or how the dependencies help.

gettext-native is being configured --with-included-libxml so it shouldn't be using
libxml2 from either the host or the sysroot, in which case the dependency would seem
to be useless.  Using the included copy of libxml2 is in any case preferable to adding 
a dependency on libxml2-native because the latter brings quite a large stack of other 
dependencies with it.

Signed-off-by: Phil Blundell <pb@pbcl.net>
---
 meta/recipes-core/gettext/gettext_0.18.1.1.bb |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-core/gettext/gettext_0.18.1.1.bb b/meta/recipes-core/gettext/gettext_0.18.1.1.bb
index a159405..96859aa 100644
--- a/meta/recipes-core/gettext/gettext_0.18.1.1.bb
+++ b/meta/recipes-core/gettext/gettext_0.18.1.1.bb
@@ -5,9 +5,9 @@ SECTION = "libs"
 LICENSE = "GPLv3+ & LGPL-2.1+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
 
-PR = "r17"
-DEPENDS = "libxml2-native gettext-native virtual/libiconv ncurses expat"
-DEPENDS_virtclass-native = "libxml2-native gettext-minimal-native"
+PR = "r18"
+DEPENDS = "gettext-native virtual/libiconv ncurses expat"
+DEPENDS_virtclass-native = "gettext-minimal-native"
 PROVIDES = "virtual/libintl virtual/gettext"
 PROVIDES_virtclass-native = "virtual/gettext-native"
 RCONFLICTS_${PN} = "proxy-libintl"
-- 
1.7.10.4






^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [RFC PATCH] gettext: Remove spurious-looking dependencies on libxml2-native
  2012-09-26 10:30 [RFC PATCH] gettext: Remove spurious-looking dependencies on libxml2-native Phil Blundell
@ 2012-10-18 19:57 ` Saul Wold
  0 siblings, 0 replies; 2+ messages in thread
From: Saul Wold @ 2012-10-18 19:57 UTC (permalink / raw)
  To: Phil Blundell; +Cc: OE-core

On 09/26/2012 03:30 AM, Phil Blundell wrote:
> These were added in aae5021101224344a2b1a3af5becf74291fbbfe5, ostensibly to resolve
> some sort of "host contamination" issue.  However, that commit contains no information
> about what contamination was being observed or how the dependencies help.
>
> gettext-native is being configured --with-included-libxml so it shouldn't be using
> libxml2 from either the host or the sysroot, in which case the dependency would seem
> to be useless.  Using the included copy of libxml2 is in any case preferable to adding
> a dependency on libxml2-native because the latter brings quite a large stack of other
> dependencies with it.
>
> Signed-off-by: Phil Blundell <pb@pbcl.net>
> ---
>   meta/recipes-core/gettext/gettext_0.18.1.1.bb |    6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-core/gettext/gettext_0.18.1.1.bb b/meta/recipes-core/gettext/gettext_0.18.1.1.bb
> index a159405..96859aa 100644
> --- a/meta/recipes-core/gettext/gettext_0.18.1.1.bb
> +++ b/meta/recipes-core/gettext/gettext_0.18.1.1.bb
> @@ -5,9 +5,9 @@ SECTION = "libs"
>   LICENSE = "GPLv3+ & LGPL-2.1+"
>   LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
>
> -PR = "r17"
> -DEPENDS = "libxml2-native gettext-native virtual/libiconv ncurses expat"
> -DEPENDS_virtclass-native = "libxml2-native gettext-minimal-native"
> +PR = "r18"
> +DEPENDS = "gettext-native virtual/libiconv ncurses expat"
> +DEPENDS_virtclass-native = "gettext-minimal-native"
>   PROVIDES = "virtual/libintl virtual/gettext"
>   PROVIDES_virtclass-native = "virtual/gettext-native"
>   RCONFLICTS_${PN} = "proxy-libintl"
>
Merged into OE-Core

Thanks
	Sau!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-10-18 20:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-26 10:30 [RFC PATCH] gettext: Remove spurious-looking dependencies on libxml2-native Phil Blundell
2012-10-18 19:57 ` Saul Wold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox