* [PATCH] cpan-base: Add more debug paths to FILES
@ 2012-10-18 22:19 Phil Blundell
2012-10-18 22:28 ` Martin Jansa
2012-10-23 19:02 ` Saul Wold
0 siblings, 2 replies; 3+ messages in thread
From: Phil Blundell @ 2012-10-18 22:19 UTC (permalink / raw)
To: oe-core
We seem to be mostly installing modules into vendor_perl nowadays.
Make sure that the .debug data from there is captured appropriately.
Also, expand ${PERLLIBDIRS} at the point of assignment so we don't
call the python again and again.
Signed-off-by: Phil Blundell <pb@pbcl.net>
---
meta/classes/cpan-base.bbclass | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/meta/classes/cpan-base.bbclass b/meta/classes/cpan-base.bbclass
index 660c15f..cf697f1 100644
--- a/meta/classes/cpan-base.bbclass
+++ b/meta/classes/cpan-base.bbclass
@@ -39,8 +39,13 @@ def is_target(d):
return "yes"
return "no"
-PERLLIBDIRS = "${@perl_get_libdirs(d)}"
+PERLLIBDIRS := "${@perl_get_libdirs(d)}"
+PERLVERSION := "${@get_perl_version(d)}"
FILES_${PN}-dbg += "${PERLLIBDIRS}/auto/*/.debug \
${PERLLIBDIRS}/auto/*/*/.debug \
- ${PERLLIBDIRS}/auto/*/*/*/.debug"
+ ${PERLLIBDIRS}/auto/*/*/*/.debug \
+ ${PERLLIBDIRS}/vendor_perl/${PERLVERSION}/auto/*/.debug \
+ ${PERLLIBDIRS}/vendor_perl/${PERLVERSION}/auto/*/*/.debug \
+ ${PERLLIBDIRS}/vendor_perl/${PERLVERSION}/auto/*/*/*/.debug \
+ "
--
1.7.9
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cpan-base: Add more debug paths to FILES
2012-10-18 22:19 [PATCH] cpan-base: Add more debug paths to FILES Phil Blundell
@ 2012-10-18 22:28 ` Martin Jansa
2012-10-23 19:02 ` Saul Wold
1 sibling, 0 replies; 3+ messages in thread
From: Martin Jansa @ 2012-10-18 22:28 UTC (permalink / raw)
To: Phil Blundell; +Cc: oe-core
[-- Attachment #1: Type: text/plain, Size: 1471 bytes --]
On Thu, Oct 18, 2012 at 11:19:27PM +0100, Phil Blundell wrote:
> We seem to be mostly installing modules into vendor_perl nowadays.
> Make sure that the .debug data from there is captured appropriately.
>
> Also, expand ${PERLLIBDIRS} at the point of assignment so we don't
> call the python again and again.
>
> Signed-off-by: Phil Blundell <pb@pbcl.net>
> ---
> meta/classes/cpan-base.bbclass | 9 +++++++--
> 1 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/cpan-base.bbclass b/meta/classes/cpan-base.bbclass
> index 660c15f..cf697f1 100644
> --- a/meta/classes/cpan-base.bbclass
> +++ b/meta/classes/cpan-base.bbclass
> @@ -39,8 +39,13 @@ def is_target(d):
> return "yes"
> return "no"
>
> -PERLLIBDIRS = "${@perl_get_libdirs(d)}"
> +PERLLIBDIRS := "${@perl_get_libdirs(d)}"
> +PERLVERSION := "${@get_perl_version(d)}"
>
> FILES_${PN}-dbg += "${PERLLIBDIRS}/auto/*/.debug \
> ${PERLLIBDIRS}/auto/*/*/.debug \
> - ${PERLLIBDIRS}/auto/*/*/*/.debug"
> + ${PERLLIBDIRS}/auto/*/*/*/.debug \
> + ${PERLLIBDIRS}/vendor_perl/${PERLVERSION}/auto/*/.debug \
> + ${PERLLIBDIRS}/vendor_perl/${PERLVERSION}/auto/*/*/.debug \
> + ${PERLLIBDIRS}/vendor_perl/${PERLVERSION}/auto/*/*/*/.debug \
> + "
Please don't mix tabs and spaces for indentation.
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpan-base: Add more debug paths to FILES
2012-10-18 22:19 [PATCH] cpan-base: Add more debug paths to FILES Phil Blundell
2012-10-18 22:28 ` Martin Jansa
@ 2012-10-23 19:02 ` Saul Wold
1 sibling, 0 replies; 3+ messages in thread
From: Saul Wold @ 2012-10-23 19:02 UTC (permalink / raw)
To: Phil Blundell; +Cc: oe-core
On 10/18/2012 03:19 PM, Phil Blundell wrote:
> We seem to be mostly installing modules into vendor_perl nowadays.
> Make sure that the .debug data from there is captured appropriately.
>
> Also, expand ${PERLLIBDIRS} at the point of assignment so we don't
> call the python again and again.
>
> Signed-off-by: Phil Blundell <pb@pbcl.net>
> ---
> meta/classes/cpan-base.bbclass | 9 +++++++--
> 1 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/cpan-base.bbclass b/meta/classes/cpan-base.bbclass
> index 660c15f..cf697f1 100644
> --- a/meta/classes/cpan-base.bbclass
> +++ b/meta/classes/cpan-base.bbclass
> @@ -39,8 +39,13 @@ def is_target(d):
> return "yes"
> return "no"
>
> -PERLLIBDIRS = "${@perl_get_libdirs(d)}"
> +PERLLIBDIRS := "${@perl_get_libdirs(d)}"
> +PERLVERSION := "${@get_perl_version(d)}"
>
> FILES_${PN}-dbg += "${PERLLIBDIRS}/auto/*/.debug \
> ${PERLLIBDIRS}/auto/*/*/.debug \
> - ${PERLLIBDIRS}/auto/*/*/*/.debug"
> + ${PERLLIBDIRS}/auto/*/*/*/.debug \
> + ${PERLLIBDIRS}/vendor_perl/${PERLVERSION}/auto/*/.debug \
> + ${PERLLIBDIRS}/vendor_perl/${PERLVERSION}/auto/*/*/.debug \
> + ${PERLLIBDIRS}/vendor_perl/${PERLVERSION}/auto/*/*/*/.debug \
> + "
>
Merged into OE-Core (with whitespaces fixed)
Thanks
Sau!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-23 19:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-18 22:19 [PATCH] cpan-base: Add more debug paths to FILES Phil Blundell
2012-10-18 22:28 ` Martin Jansa
2012-10-23 19:02 ` Saul Wold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox