Re: [PATCH 1/2] pulseaudio: fix compilation on RHEL-5.8 64bit machine

[jhuang0 <jackie.huang@windriver.com>]

On 11/22/2012 4:55 PM, Burton, Ross wrote:
> Hi,
>
> This patch is too hacky to go in at the moment.

Hi Ross,

Thanks for your comments, in fact the patch was for a weird edge case in 
the old version, I looked for the history and it seemed to be added as a 
workaround. And I tried some days but couldn't reproduce the issue
in current pulseaudio 2.1, so I shouldn't have send this, sorry about that.

Aws, please correct me if I'm wrong, thanks!

Thanks,
Jackie

>
> On 22 November 2012 06:46,  <jackie.huang@windriver.com> wrote:
>> ../bitbake_build/tmp/sysroots/qemux86-64/usr/lib64/libgdk-x11-2.0.so: undefined reference to `XRRGetOutputInfo'
>
> Which means your GTK+ linkage is broken, because libgdk should be
> linking to libXrandr.  Mine is, can you verify that yours is too?
>
>> +-AM_LDADD = $(PTHREAD_LIBS) $(INTLLIBS)
>> ++AM_LDADD = $(PTHREAD_LIBS) $(INTLLIBS) -lXrandr
>
> You're adding linkage to libXrandr to every part of PulseAudio.  What
> binary in pulseaudio is failing to compile with this error?
>
>> -DEPENDS += "libjson gdbm speex libxml-parser-perl-native"
>> +DEPENDS += "libjson gdbm speex libxml-parser-perl-native \
>> +  ${@base_contains('DISTRO_FEATURES', 'x11', 'libxrandr', '', d)}"
>
> pulseaudio.inc has:
>
> DEPENDS = "libatomics-ops liboil avahi libsamplerate0 libsndfile1 libtool \
>             ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11
> libxtst libice libsm libxcb gtk+', '', d)}"
>
> As gtk+ pulls in libxrandr, this is redundant.
>
> Ross
>
>

-- 
Jackie Huang
WIND RIVER | China Development Center
MSN:jackielily@hotmail.com
Tel: +86 8477 8594
Mobile: +86 138 1027 4745