From: Aws Ismail <aws.ismail@windriver.com>
To: jhuang0 <jackie.huang@windriver.com>
Cc: saul.wold@intel.com, Shiqun.Lin@windriver.com,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] pulseaudio: fix compilation on RHEL-5.8 64bit machine
Date: Tue, 27 Nov 2012 17:00:47 -0500 [thread overview]
Message-ID: <50B5380F.4030401@windriver.com> (raw)
In-Reply-To: <50B426C4.3020108@windriver.com>
On 11/26/2012 09:34 PM, jhuang0 wrote:
>
>
> On 11/22/2012 4:55 PM, Burton, Ross wrote:
>> Hi,
>>
>> This patch is too hacky to go in at the moment.
>
> Hi Ross,
>
> Thanks for your comments, in fact the patch was for a weird edge case
> in the old version, I looked for the history and it seemed to be added
> as a workaround. And I tried some days but couldn't reproduce the issue
> in current pulseaudio 2.1, so I shouldn't have send this, sorry about
> that.
>
> Aws, please correct me if I'm wrong, thanks!
Agreed. This was a quick fix for a very specific case. If you can
confirm that it is not there anymore, which, by the looks of it, seems
that you have done; then let's get rid of it.
Thanks Jackie.
Aws\
>
> Thanks,
> Jackie
>
>>
>> On 22 November 2012 06:46, <jackie.huang@windriver.com> wrote:
>>> ../bitbake_build/tmp/sysroots/qemux86-64/usr/lib64/libgdk-x11-2.0.so: undefined
>>> reference to `XRRGetOutputInfo'
>>
>> Which means your GTK+ linkage is broken, because libgdk should be
>> linking to libXrandr. Mine is, can you verify that yours is too?
>>
>>> +-AM_LDADD = $(PTHREAD_LIBS) $(INTLLIBS)
>>> ++AM_LDADD = $(PTHREAD_LIBS) $(INTLLIBS) -lXrandr
>>
>> You're adding linkage to libXrandr to every part of PulseAudio. What
>> binary in pulseaudio is failing to compile with this error?
>>
>>> -DEPENDS += "libjson gdbm speex libxml-parser-perl-native"
>>> +DEPENDS += "libjson gdbm speex libxml-parser-perl-native \
>>> + ${@base_contains('DISTRO_FEATURES', 'x11', 'libxrandr', '', d)}"
>>
>> pulseaudio.inc has:
>>
>> DEPENDS = "libatomics-ops liboil avahi libsamplerate0 libsndfile1
>> libtool \
>> ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11
>> libxtst libice libsm libxcb gtk+', '', d)}"
>>
>> As gtk+ pulls in libxrandr, this is redundant.
>>
>> Ross
>>
>>
>
--
next prev parent reply other threads:[~2012-11-28 0:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 6:46 [PATCH 0/2] pulseaudio: fix tow issues jackie.huang
2012-11-22 6:46 ` [PATCH 1/2] pulseaudio: fix compilation on RHEL-5.8 64bit machine jackie.huang
2012-11-22 8:55 ` Burton, Ross
2012-11-27 2:34 ` jhuang0
2012-11-27 22:00 ` Aws Ismail [this message]
2012-11-22 6:46 ` [PATCH 2/2] pulseaudio: The audio over Adipts ALC888 audio effect chip on Sabino does not work jackie.huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B5380F.4030401@windriver.com \
--to=aws.ismail@windriver.com \
--cc=Shiqun.Lin@windriver.com \
--cc=jackie.huang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=saul.wold@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox