* alsaconf and bash @ 2013-01-07 21:36 Florin Sarbu 2013-01-08 0:44 ` Chris Larson 0 siblings, 1 reply; 6+ messages in thread From: Florin Sarbu @ 2013-01-07 21:36 UTC (permalink / raw) To: Patches and discussions about the oe-core layer Hi all, in alsa-utils_1.0.25.bb, I see this comment: # We omit alsaconf, because # a) this is a bash script # b) it creates config files not suitable for OE-based distros Trying out on master, I get a do_rootfs error because bash is not a rundep of alsa-utils, and there is nothing in the alsa-utils recipe that actually does the above mentioned removal of the alsaconf script. Looking in the git log, I only see that the comment has suddenly appeared in an older alsa-utils recipe and has been carried along since with every update to the recipe, and not left over there as an artifact of some older commit as I expected. Can anyone shed some light on this? Thanks, Florin ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: alsaconf and bash 2013-01-07 21:36 alsaconf and bash Florin Sarbu @ 2013-01-08 0:44 ` Chris Larson 2013-01-08 6:09 ` Florin Sarbu 0 siblings, 1 reply; 6+ messages in thread From: Chris Larson @ 2013-01-08 0:44 UTC (permalink / raw) To: Florin Sarbu; +Cc: Patches and discussions about the oe-core layer [-- Attachment #1: Type: text/plain, Size: 1116 bytes --] On Mon, Jan 7, 2013 at 2:36 PM, Florin Sarbu <florin.sarbu@windriver.com>wrote: > in alsa-utils_1.0.25.bb, I see this comment: > > # We omit alsaconf, because > # a) this is a bash script > # b) it creates config files not suitable for OE-based distros > > Trying out on master, I get a do_rootfs error because bash is not a rundep > of alsa-utils, and there is nothing in the alsa-utils recipe that actually > does the above mentioned removal of the alsaconf script. Looking in the git > log, I only see that the comment has suddenly appeared in an older > alsa-utils recipe and has been carried along since with every update to the > recipe, and not left over there as an artifact of some older commit as I > expected. > Can anyone shed some light on this? > From some quick git log -S commands in the old openembedded classic repository, it seems to have originated with 7653e980f66b4bd147df308f9b04d6b197382d6a from 2005, and the line below the comment was 'FILES_${PN} = ""', so presumably that was what left it out — none of the files patterns matched it. -- Christopher Larson [-- Attachment #2: Type: text/html, Size: 1607 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: alsaconf and bash 2013-01-08 0:44 ` Chris Larson @ 2013-01-08 6:09 ` Florin Sarbu 2013-01-08 14:15 ` Florin Sarbu 0 siblings, 1 reply; 6+ messages in thread From: Florin Sarbu @ 2013-01-08 6:09 UTC (permalink / raw) To: Patches and discussions about the oe-core layer [-- Attachment #1: Type: text/plain, Size: 2133 bytes --] On 01/08/2013 02:44 AM, Chris Larson wrote: > On Mon, Jan 7, 2013 at 2:36 PM, Florin Sarbu > <florin.sarbu@windriver.com <mailto:florin.sarbu@windriver.com>> wrote: > > in alsa-utils_1.0.25.bb <http://alsa-utils_1.0.25.bb>, I see this > comment: > > # We omit alsaconf, because > # a) this is a bash script > # b) it creates config files not suitable for OE-based distros > > Trying out on master, I get a do_rootfs error because bash is not > a rundep of alsa-utils, and there is nothing in the alsa-utils > recipe that actually does the above mentioned removal of the > alsaconf script. Looking in the git log, I only see that the > comment has suddenly appeared in an older alsa-utils recipe and > has been carried along since with every update to the recipe, and > not left over there as an artifact of some older commit as I expected. > Can anyone shed some light on this? > > > > From some quick git log -S commands in the old openembedded classic > repository, it seems to have originated > with 7653e980f66b4bd147df308f9b04d6b197382d6a from 2005, and the line > below the comment was 'FILES_${PN} = ""', so presumably that was what > left it out — none of the files patterns matched it. Okay, so it seems that the comment actually said at that time that the alsa-utils generated rpm won't contain alsaconf. And bellow, this bash script gets into the alsa-utils-alsaconf rpm. Unfortunately, even though there is this separation, the alsa-utils rpm depends on the alsa-utils-alsaconf rpm so it's pretty much the same thing as do_rootfs is concerned. (missing bash dependency). How would you guys see this resolved upstream? Add bash as a dep, remove alsa-utils-alsaconf as a dep or alsa-utils (as the comment says the script is not suitable for OE-based distros) or check the alsaconf script for bashisms and fix if any and make alsa-utils rely on a busybox shell interpreter if possible (with the modification of the !/bin/bash shabang from the alsaconf script to /bin/sh)? Florin > -- > Christopher Larson [-- Attachment #2: Type: text/html, Size: 3789 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: alsaconf and bash 2013-01-08 6:09 ` Florin Sarbu @ 2013-01-08 14:15 ` Florin Sarbu 2013-01-08 16:27 ` Andrei Gherzan 0 siblings, 1 reply; 6+ messages in thread From: Florin Sarbu @ 2013-01-08 14:15 UTC (permalink / raw) To: openembedded-core [-- Attachment #1: Type: text/plain, Size: 2525 bytes --] Would you guys suggest we add bash as a dependency for alsa-utils? On 01/08/2013 08:09 AM, Florin Sarbu wrote: > On 01/08/2013 02:44 AM, Chris Larson wrote: >> On Mon, Jan 7, 2013 at 2:36 PM, Florin Sarbu >> <florin.sarbu@windriver.com <mailto:florin.sarbu@windriver.com>> wrote: >> >> in alsa-utils_1.0.25.bb <http://alsa-utils_1.0.25.bb>, I see this >> comment: >> >> # We omit alsaconf, because >> # a) this is a bash script >> # b) it creates config files not suitable for OE-based distros >> >> Trying out on master, I get a do_rootfs error because bash is not >> a rundep of alsa-utils, and there is nothing in the alsa-utils >> recipe that actually does the above mentioned removal of the >> alsaconf script. Looking in the git log, I only see that the >> comment has suddenly appeared in an older alsa-utils recipe and >> has been carried along since with every update to the recipe, and >> not left over there as an artifact of some older commit as I >> expected. >> Can anyone shed some light on this? >> >> >> >> From some quick git log -S commands in the old openembedded classic >> repository, it seems to have originated >> with 7653e980f66b4bd147df308f9b04d6b197382d6a from 2005, and the line >> below the comment was 'FILES_${PN} = ""', so presumably that was what >> left it out --- none of the files patterns matched it. > Okay, so it seems that the comment actually said at that time that the > alsa-utils generated rpm won't contain alsaconf. And bellow, this bash > script gets into the alsa-utils-alsaconf rpm. Unfortunately, even > though there is this separation, the alsa-utils rpm depends on the > alsa-utils-alsaconf rpm so it's pretty much the same thing as > do_rootfs is concerned. (missing bash dependency). How would you guys > see this resolved upstream? Add bash as a dep, remove > alsa-utils-alsaconf as a dep or alsa-utils (as the comment says the > script is not suitable for OE-based distros) or check the alsaconf > script for bashisms and fix if any and make alsa-utils rely on a > busybox shell interpreter if possible (with the modification of the > !/bin/bash shabang from the alsaconf script to /bin/sh)? > > Florin > >> -- >> Christopher Larson > > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core [-- Attachment #2: Type: text/html, Size: 4759 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: alsaconf and bash 2013-01-08 14:15 ` Florin Sarbu @ 2013-01-08 16:27 ` Andrei Gherzan 2013-01-08 17:15 ` Florin Sarbu 0 siblings, 1 reply; 6+ messages in thread From: Andrei Gherzan @ 2013-01-08 16:27 UTC (permalink / raw) To: Florin Sarbu; +Cc: openembedded [-- Attachment #1: Type: text/plain, Size: 228 bytes --] On Tue, Jan 8, 2013 at 4:15 PM, Florin Sarbu <florin.sarbu@windriver.com>wrote: > Would you guys suggest we add bash as a dependency for alsa-utils? > Alsaconf is a bash script - obviously add a RDEPENDS to bash. ag [-- Attachment #2: Type: text/html, Size: 666 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: alsaconf and bash 2013-01-08 16:27 ` Andrei Gherzan @ 2013-01-08 17:15 ` Florin Sarbu 0 siblings, 0 replies; 6+ messages in thread From: Florin Sarbu @ 2013-01-08 17:15 UTC (permalink / raw) To: openembedded [-- Attachment #1: Type: text/plain, Size: 487 bytes --] But on the other hand, if the comment says the script is not suited for OE-core, then why have the alsa-utils rpm depend on the alsaconf rpm? Florin On 01/08/2013 06:27 PM, Andrei Gherzan wrote: > On Tue, Jan 8, 2013 at 4:15 PM, Florin Sarbu > <florin.sarbu@windriver.com <mailto:florin.sarbu@windriver.com>> wrote: > > Would you guys suggest we add bash as a dependency for alsa-utils? > > > Alsaconf is a bash script - obviously add a RDEPENDS to bash. > > ag [-- Attachment #2: Type: text/html, Size: 1681 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-01-08 17:31 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-01-07 21:36 alsaconf and bash Florin Sarbu 2013-01-08 0:44 ` Chris Larson 2013-01-08 6:09 ` Florin Sarbu 2013-01-08 14:15 ` Florin Sarbu 2013-01-08 16:27 ` Andrei Gherzan 2013-01-08 17:15 ` Florin Sarbu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox