[PATCH 0/1] glib-2.0-native:add option march to BUILD_CFLAGS

[PATCH 0/1] glib-2.0-native:add option march to BUILD_CFLAGS

[Hongxu Jia]

The following changes since commit 09359e6ec00901abfe49157f1f9730117b4d284b:

  freetype: update to 2.4.11 which includes fixes for CVE-2012-{5668, 5669, 5670} (2012-12-31 09:43:27 +0000)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib hongxu/glib-2.0-native
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/glib-2.0-native

Hongxu Jia (1):
  glib-2.0-native:add option march to BUILD_CFLAGS

 meta/recipes-core/glib-2.0/glib-2.0_2.34.3.bb |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

-- 
1.7.10.4

[PATCH 1/1] glib-2.0-native:add option march to BUILD_CFLAGS

[Hongxu Jia]

Add option -march to BUILD_CFLAGS in order to let the atomic operations
("lock free") be available while using old version GCC (4.3.4 for example)
on x86 host to compile glib-2.0-native.

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 meta/recipes-core/glib-2.0/glib-2.0_2.34.3.bb |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-core/glib-2.0/glib-2.0_2.34.3.bb b/meta/recipes-core/glib-2.0/glib-2.0_2.34.3.bb
index 9854585..07d16bd 100644
--- a/meta/recipes-core/glib-2.0/glib-2.0_2.34.3.bb
+++ b/meta/recipes-core/glib-2.0/glib-2.0_2.34.3.bb
@@ -1,6 +1,6 @@
 require glib.inc
 
-PR = "r0"
+PR = "r1"
 PE = "1"
 
 DEPENDS += "libffi python-argparse-native zlib"
@@ -38,6 +38,10 @@ RDEPENDS_${PN}-ptest += "\
             python-pygobject \
             python-dbus \
            "
+# Add option -march to BUILD_CFLAGS in order to let the atomic operations
+# ("lock free") be available while using old version GCC on x86 host to
+# compile glib-2.0-native
+BUILD_CFLAGS += "-march=${@'${BUILD_ARCH}'.replace('_','-')}"
 
 do_configure_prepend() {
 	sed -i -e '1s,#!.*,#!${USRBINPATH}/env python,' ${S}/gio/gdbus-2.0/codegen/gdbus-codegen.in
-- 
1.7.10.4

Re: [PATCH 1/1] glib-2.0-native:add option march to BUILD_CFLAGS

[Colin Walters]

On Sun, 2013-01-06 at 16:34 +0800, Hongxu Jia wrote:

> +# Add option -march to BUILD_CFLAGS in order to let the atomic operations
> +# ("lock free") be available while using old version GCC on x86 host to
> +# compile glib-2.0-native
> +BUILD_CFLAGS += "-march=${@'${BUILD_ARCH}'.replace('_','-')}"

Shouldn't this be handled more generically for all native recipes?

Re: [PATCH 1/1] glib-2.0-native:add option march to BUILD_CFLAGS

[Hongxu Jia]

On 01/07/2013 02:28 AM, Colin Walters wrote:
> On Sun, 2013-01-06 at 16:34 +0800, Hongxu Jia wrote:
>
>> +# Add option -march to BUILD_CFLAGS in order to let the atomic operations
>> +# ("lock free") be available while using old version GCC on x86 host to
>> +# compile glib-2.0-native
>> +BUILD_CFLAGS += "-march=${@'${BUILD_ARCH}'.replace('_','-')}"
> Shouldn't this be handled more generically for all native recipes?
>
>
Hi Colin,

I have a fully test and the qemu-native has the similar problem, and I will
resend the patch.

It's a bad idea to modify bitbake.conf to add option -march to BUILD_CFLAGS,
because it's global and its side effect is unknown, such as beecrypt-native
do_compile will fail if we do that.

So it's best to test most of the native recipes to have a check about 
the similar
problem and fix them separately, and the packagegroup-toolset-native.bb
could work for that.

Regards,
Hongxu

[PATCH 0/1]glib-2.0-native:add option march to BUILD_CFLAGS

[Hongxu Jia]

The following changes since commit 90c0eb29f0b41e4ac2d3d17ebad7295c2ebdc02a:

  rootfs_rpm.bbclass: remove debug code (2012-12-19 21:43:55 +0000)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib hongxu/glib-2.0-native
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/glib-2.0-native

Hongxu Jia (1):
  glib-2.0-native:add option march to BUILD_CFLAGS

 meta/recipes-core/glib-2.0/glib-2.0_2.34.3.bb |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

-- 
1.7.10.4

[PATCH 1/1] glib-2.0-native:add option march to BUILD_CFLAGS

[Hongxu Jia]

Add option -march to BUILD_CFLAGS in order to let the atomic operations
("lock free") be available while using old version GCC (4.3.4 for example)
on x86 host to compile glib-2.0-native.

[YOCTO #3563]

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 meta/recipes-core/glib-2.0/glib-2.0_2.34.3.bb |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-core/glib-2.0/glib-2.0_2.34.3.bb b/meta/recipes-core/glib-2.0/glib-2.0_2.34.3.bb
index 966a851..7c0a2cb 100644
--- a/meta/recipes-core/glib-2.0/glib-2.0_2.34.3.bb
+++ b/meta/recipes-core/glib-2.0/glib-2.0_2.34.3.bb
@@ -1,6 +1,6 @@
 require glib.inc
 
-PR = "r0"
+PR = "r1"
 PE = "1"
 
 DEPENDS += "libffi python-argparse-native zlib"
@@ -19,6 +19,11 @@ SRC_URI[sha256sum] = "855fcbf87cb93065b488358e351774d8a39177281023bae58c286f4161
 SRC_URI_append_class-native = " file://glib-gettextize-dir.patch"
 BBCLASSEXTEND = "native nativesdk"
 
+# Add option -march to BUILD_CFLAGS in order to let the atomic operations
+# ("lock free") be available while using old version GCC on x86 host to
+# compile glib-2.0-native
+BUILD_CFLAGS += "-march=`echo ${BUILD_ARCH} | sed 's/_/-/'`"
+
 do_configure_prepend() {
 	sed -i -e '1s,#!.*,#!${USRBINPATH}/env python,' ${S}/gio/gdbus-2.0/codegen/gdbus-codegen.in
 }
-- 
1.7.10.4

Re: [PATCH 1/1] glib-2.0-native:add option march to BUILD_CFLAGS

[Burton, Ross]

On 20 December 2012 08:10, Hongxu Jia <hongxu.jia@windriver.com> wrote:
> +# Add option -march to BUILD_CFLAGS in order to let the atomic operations
> +# ("lock free") be available while using old version GCC on x86 host to
> +# compile glib-2.0-native
> +BUILD_CFLAGS += "-march=`echo ${BUILD_ARCH} | sed 's/_/-/'`"

Should we do this inside bitbake.conf instead of just in glib?

Ross

Re: [PATCH 1/1] glib-2.0-native:add option march to BUILD_CFLAGS

[Hongxu Jia]

On 12/20/2012 06:05 PM, Burton, Ross wrote:
> On 20 December 2012 08:10, Hongxu Jia <hongxu.jia@windriver.com> wrote:
>> +# Add option -march to BUILD_CFLAGS in order to let the atomic operations
>> +# ("lock free") be available while using old version GCC on x86 host to
>> +# compile glib-2.0-native
>> +BUILD_CFLAGS += "-march=`echo ${BUILD_ARCH} | sed 's/_/-/'`"
> Should we do this inside bitbake.conf instead of just in glib?
>
> Ross

This is only needed by glib-2.0-native, and didn't notice
this error for other recipes, so I just added it for glib-2.0-native.

Hongxu