* [PATCH] eglibc: fix as and ld check in libc dir
@ 2013-01-16 14:14 Giuseppe CONDORELLI
2013-01-16 15:02 ` Martin Jansa
2013-01-18 17:12 ` Khem Raj
0 siblings, 2 replies; 12+ messages in thread
From: Giuseppe CONDORELLI @ 2013-01-16 14:14 UTC (permalink / raw)
To: openembedded-core
Fix routine to check as and ld version check in the configure, to allow system
to correctly check for version 2.1x.
Signed-off-by: Giuseppe Condorelli <giuseppe.condorelli@st.com>
---
.../eglibc-2.16_fix_as_ld_ver_check.patch | 23 ++++++++++++++++++++
meta/recipes-core/eglibc/eglibc_2.16.bb | 3 +-
2 files changed, 25 insertions(+), 1 deletions(-)
create mode 100644 meta/recipes-core/eglibc/eglibc-2.16/eglibc-2.16_fix_as_ld_ver_check.patch
diff --git a/meta/recipes-core/eglibc/eglibc-2.16/eglibc-2.16_fix_as_ld_ver_check.patch b/meta/recipes-core/eglibc/eglibc-2.16/eglibc-2.16_fix_as_ld_ver_check.patch
new file mode 100644
index 0000000..a8a2344
--- /dev/null
+++ b/meta/recipes-core/eglibc/eglibc-2.16/eglibc-2.16_fix_as_ld_ver_check.patch
@@ -0,0 +1,23 @@
+Fix as and ld checking steps to allow system to correctly check 2.1x versions.
+
+Signed-off-by: Giuseppe Condorelli <giuseppe.condorelli@st.com>
+--- libc.orig/configure 2013-01-16 12:07:18.146902148 +0100
++++ libc/configure 2013-01-16 12:08:10.598911559 +0100
+@@ -4757,7 +4757,7 @@ $as_echo_n "checking version of $AS... "
+ ac_prog_version=`$AS --version 2>&1 | sed -n 's/^.*GNU assembler.* \([0-9]*\.[0-9.]*\).*$/\1/p'`
+ case $ac_prog_version in
+ '') ac_prog_version="v. ?.??, bad"; ac_verc_fail=yes;;
+- 2.1[0-9][0-9]*|2.[2-9][0-9]*|[3-9].*|[1-9][0-9]*)
++ 2.1[0-9]*|2.[2-9][0-9]*|[3-9].*|[1-9][0-9]*)
+ ac_prog_version="$ac_prog_version, ok"; ac_verc_fail=no;;
+ *) ac_prog_version="$ac_prog_version, bad"; ac_verc_fail=yes;;
+
+@@ -4820,7 +4820,7 @@ $as_echo_n "checking version of $LD... "
+ ac_prog_version=`$LD --version 2>&1 | sed -n 's/^.*GNU ld.* \([0-9][0-9]*\.[0-9.]*\).*$/\1/p'`
+ case $ac_prog_version in
+ '') ac_prog_version="v. ?.??, bad"; ac_verc_fail=yes;;
+- 2.1[0-9][0-9]*|2.[2-9][0-9]*|[3-9].*|[1-9][0-9]*)
++ 2.1[0-9]*|2.[2-9][0-9]*|[3-9].*|[1-9][0-9]*)
+ ac_prog_version="$ac_prog_version, ok"; ac_verc_fail=no;;
+ *) ac_prog_version="$ac_prog_version, bad"; ac_verc_fail=yes;;
+
diff --git a/meta/recipes-core/eglibc/eglibc_2.16.bb b/meta/recipes-core/eglibc/eglibc_2.16.bb
index 2dcaceb..fbc1499 100644
--- a/meta/recipes-core/eglibc/eglibc_2.16.bb
+++ b/meta/recipes-core/eglibc/eglibc_2.16.bb
@@ -33,6 +33,7 @@ SRC_URI = "http://downloads.yoctoproject.org/releases/eglibc/eglibc-${PV}-svnr21
file://tzselect-sh.patch \
file://tzselect-awk.patch \
file://0001-eglibc-run-libm-err-tab.pl-with-specific-dirs-in-S.patch \
+ file://eglibc-2.16_fix_as_ld_ver_check.patch \
"
SRC_URI[tarball.md5sum] = "88894fa6e10e58e85fbd8134b8e486a8"
@@ -69,7 +70,7 @@ TARGET_CPPFLAGS = "-I${STAGING_DIR_TARGET}${includedir}"
GLIBC_BROKEN_LOCALES = " _ER _ET so_ET yn_ER sid_ET tr_TR mn_MN gez_ET gez_ER bn_BD te_IN es_CR.ISO-8859-1"
-FILESPATH = "${@base_set_filespath([ '${FILE_DIRNAME}/eglibc-${PV}', '${FILE_DIRNAME}/eglibc', '${FILE_DIRNAME}/files', '${FILE_DIRNAME}' ], d)}"
+#FILESPATH = "${@base_set_filespath([ '${FILE_DIRNAME}/eglibc-${PV}', '${FILE_DIRNAME}/eglibc', '${FILE_DIRNAME}/files', '${FILE_DIRNAME}' ], d)}"
#
# For now, we will skip building of a gcc package if it is a uclibc one
--
1.7.7.6
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH] eglibc: fix as and ld check in libc dir
2013-01-16 14:14 [PATCH] eglibc: fix as and ld check in libc dir Giuseppe CONDORELLI
@ 2013-01-16 15:02 ` Martin Jansa
2013-01-16 15:07 ` Giuseppe Condorelli
2013-01-18 17:12 ` Khem Raj
1 sibling, 1 reply; 12+ messages in thread
From: Martin Jansa @ 2013-01-16 15:02 UTC (permalink / raw)
To: Giuseppe CONDORELLI; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 3630 bytes --]
On Wed, Jan 16, 2013 at 03:14:07PM +0100, Giuseppe CONDORELLI wrote:
> Fix routine to check as and ld version check in the configure, to allow system
> to correctly check for version 2.1x.
Does it build with gold now?
http://lists.linuxtogo.org/pipermail/openembedded-core/2012-March/020310.html
>
> Signed-off-by: Giuseppe Condorelli <giuseppe.condorelli@st.com>
> ---
> .../eglibc-2.16_fix_as_ld_ver_check.patch | 23 ++++++++++++++++++++
> meta/recipes-core/eglibc/eglibc_2.16.bb | 3 +-
> 2 files changed, 25 insertions(+), 1 deletions(-)
> create mode 100644 meta/recipes-core/eglibc/eglibc-2.16/eglibc-2.16_fix_as_ld_ver_check.patch
>
> diff --git a/meta/recipes-core/eglibc/eglibc-2.16/eglibc-2.16_fix_as_ld_ver_check.patch b/meta/recipes-core/eglibc/eglibc-2.16/eglibc-2.16_fix_as_ld_ver_check.patch
> new file mode 100644
> index 0000000..a8a2344
> --- /dev/null
> +++ b/meta/recipes-core/eglibc/eglibc-2.16/eglibc-2.16_fix_as_ld_ver_check.patch
> @@ -0,0 +1,23 @@
> +Fix as and ld checking steps to allow system to correctly check 2.1x versions.
> +
> +Signed-off-by: Giuseppe Condorelli <giuseppe.condorelli@st.com>
> +--- libc.orig/configure 2013-01-16 12:07:18.146902148 +0100
> ++++ libc/configure 2013-01-16 12:08:10.598911559 +0100
> +@@ -4757,7 +4757,7 @@ $as_echo_n "checking version of $AS... "
> + ac_prog_version=`$AS --version 2>&1 | sed -n 's/^.*GNU assembler.* \([0-9]*\.[0-9.]*\).*$/\1/p'`
> + case $ac_prog_version in
> + '') ac_prog_version="v. ?.??, bad"; ac_verc_fail=yes;;
> +- 2.1[0-9][0-9]*|2.[2-9][0-9]*|[3-9].*|[1-9][0-9]*)
> ++ 2.1[0-9]*|2.[2-9][0-9]*|[3-9].*|[1-9][0-9]*)
> + ac_prog_version="$ac_prog_version, ok"; ac_verc_fail=no;;
> + *) ac_prog_version="$ac_prog_version, bad"; ac_verc_fail=yes;;
> +
> +@@ -4820,7 +4820,7 @@ $as_echo_n "checking version of $LD... "
> + ac_prog_version=`$LD --version 2>&1 | sed -n 's/^.*GNU ld.* \([0-9][0-9]*\.[0-9.]*\).*$/\1/p'`
> + case $ac_prog_version in
> + '') ac_prog_version="v. ?.??, bad"; ac_verc_fail=yes;;
> +- 2.1[0-9][0-9]*|2.[2-9][0-9]*|[3-9].*|[1-9][0-9]*)
> ++ 2.1[0-9]*|2.[2-9][0-9]*|[3-9].*|[1-9][0-9]*)
> + ac_prog_version="$ac_prog_version, ok"; ac_verc_fail=no;;
> + *) ac_prog_version="$ac_prog_version, bad"; ac_verc_fail=yes;;
> +
> diff --git a/meta/recipes-core/eglibc/eglibc_2.16.bb b/meta/recipes-core/eglibc/eglibc_2.16.bb
> index 2dcaceb..fbc1499 100644
> --- a/meta/recipes-core/eglibc/eglibc_2.16.bb
> +++ b/meta/recipes-core/eglibc/eglibc_2.16.bb
> @@ -33,6 +33,7 @@ SRC_URI = "http://downloads.yoctoproject.org/releases/eglibc/eglibc-${PV}-svnr21
> file://tzselect-sh.patch \
> file://tzselect-awk.patch \
> file://0001-eglibc-run-libm-err-tab.pl-with-specific-dirs-in-S.patch \
> + file://eglibc-2.16_fix_as_ld_ver_check.patch \
wrong indentation
> "
>
> SRC_URI[tarball.md5sum] = "88894fa6e10e58e85fbd8134b8e486a8"
> @@ -69,7 +70,7 @@ TARGET_CPPFLAGS = "-I${STAGING_DIR_TARGET}${includedir}"
>
> GLIBC_BROKEN_LOCALES = " _ER _ET so_ET yn_ER sid_ET tr_TR mn_MN gez_ET gez_ER bn_BD te_IN es_CR.ISO-8859-1"
>
> -FILESPATH = "${@base_set_filespath([ '${FILE_DIRNAME}/eglibc-${PV}', '${FILE_DIRNAME}/eglibc', '${FILE_DIRNAME}/files', '${FILE_DIRNAME}' ], d)}"
> +#FILESPATH = "${@base_set_filespath([ '${FILE_DIRNAME}/eglibc-${PV}', '${FILE_DIRNAME}/eglibc', '${FILE_DIRNAME}/files', '${FILE_DIRNAME}' ], d)}"
this does not belong here
Cheers,
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] eglibc: fix as and ld check in libc dir
2013-01-16 15:02 ` Martin Jansa
@ 2013-01-16 15:07 ` Giuseppe Condorelli
2013-01-17 12:42 ` Martin Jansa
0 siblings, 1 reply; 12+ messages in thread
From: Giuseppe Condorelli @ 2013-01-16 15:07 UTC (permalink / raw)
To: Martin Jansa; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 4119 bytes --]
2013/1/16 Martin Jansa <martin.jansa@gmail.com>
> On Wed, Jan 16, 2013 at 03:14:07PM +0100, Giuseppe CONDORELLI wrote:
> > Fix routine to check as and ld version check in the configure, to allow
> system
> > to correctly check for version 2.1x.
>
> Does it build with gold now?
>
> http://lists.linuxtogo.org/pipermail/openembedded-core/2012-March/020310.html
>
> >
> > Signed-off-by: Giuseppe Condorelli <giuseppe.condorelli@st.com>
> > ---
> > .../eglibc-2.16_fix_as_ld_ver_check.patch | 23
> ++++++++++++++++++++
> > meta/recipes-core/eglibc/eglibc_2.16.bb | 3 +-
> > 2 files changed, 25 insertions(+), 1 deletions(-)
> > create mode 100644
> meta/recipes-core/eglibc/eglibc-2.16/eglibc-2.16_fix_as_ld_ver_check.patch
> >
> > diff --git
> a/meta/recipes-core/eglibc/eglibc-2.16/eglibc-2.16_fix_as_ld_ver_check.patch
> b/meta/recipes-core/eglibc/eglibc-2.16/eglibc-2.16_fix_as_ld_ver_check.patch
> > new file mode 100644
> > index 0000000..a8a2344
> > --- /dev/null
> > +++
> b/meta/recipes-core/eglibc/eglibc-2.16/eglibc-2.16_fix_as_ld_ver_check.patch
> > @@ -0,0 +1,23 @@
> > +Fix as and ld checking steps to allow system to correctly check 2.1x
> versions.
> > +
> > +Signed-off-by: Giuseppe Condorelli <giuseppe.condorelli@st.com>
> > +--- libc.orig/configure 2013-01-16 12:07:18.146902148 +0100
> > ++++ libc/configure 2013-01-16 12:08:10.598911559 +0100
> > +@@ -4757,7 +4757,7 @@ $as_echo_n "checking version of $AS... "
> > + ac_prog_version=`$AS --version 2>&1 | sed -n 's/^.*GNU assembler.*
> \([0-9]*\.[0-9.]*\).*$/\1/p'`
> > + case $ac_prog_version in
> > + '') ac_prog_version="v. ?.??, bad"; ac_verc_fail=yes;;
> > +- 2.1[0-9][0-9]*|2.[2-9][0-9]*|[3-9].*|[1-9][0-9]*)
> > ++ 2.1[0-9]*|2.[2-9][0-9]*|[3-9].*|[1-9][0-9]*)
> > + ac_prog_version="$ac_prog_version, ok"; ac_verc_fail=no;;
> > + *) ac_prog_version="$ac_prog_version, bad"; ac_verc_fail=yes;;
> > +
> > +@@ -4820,7 +4820,7 @@ $as_echo_n "checking version of $LD... "
> > + ac_prog_version=`$LD --version 2>&1 | sed -n 's/^.*GNU ld.*
> \([0-9][0-9]*\.[0-9.]*\).*$/\1/p'`
> > + case $ac_prog_version in
> > + '') ac_prog_version="v. ?.??, bad"; ac_verc_fail=yes;;
> > +- 2.1[0-9][0-9]*|2.[2-9][0-9]*|[3-9].*|[1-9][0-9]*)
> > ++ 2.1[0-9]*|2.[2-9][0-9]*|[3-9].*|[1-9][0-9]*)
> > + ac_prog_version="$ac_prog_version, ok"; ac_verc_fail=no;;
> > + *) ac_prog_version="$ac_prog_version, bad"; ac_verc_fail=yes;;
> > +
> > diff --git a/meta/recipes-core/eglibc/eglibc_2.16.bbb/meta/recipes-core/eglibc/
> eglibc_2.16.bb
> > index 2dcaceb..fbc1499 100644
> > --- a/meta/recipes-core/eglibc/eglibc_2.16.bb
> > +++ b/meta/recipes-core/eglibc/eglibc_2.16.bb
> > @@ -33,6 +33,7 @@ SRC_URI = "
> http://downloads.yoctoproject.org/releases/eglibc/eglibc-${PV}-svnr21
> > file://tzselect-sh.patch \
> > file://tzselect-awk.patch \
> >
> file://0001-eglibc-run-libm-err-tab.pl-with-specific-dirs-in-S.patch \
> > + file://eglibc-2.16_fix_as_ld_ver_check.patch \
>
> wrong indentation
>
> > "
> >
> > SRC_URI[tarball.md5sum] = "88894fa6e10e58e85fbd8134b8e486a8"
> > @@ -69,7 +70,7 @@ TARGET_CPPFLAGS =
> "-I${STAGING_DIR_TARGET}${includedir}"
> >
> > GLIBC_BROKEN_LOCALES = " _ER _ET so_ET yn_ER sid_ET tr_TR mn_MN gez_ET
> gez_ER bn_BD te_IN es_CR.ISO-8859-1"
> >
> > -FILESPATH = "${@base_set_filespath([ '${FILE_DIRNAME}/eglibc-${PV}',
> '${FILE_DIRNAME}/eglibc', '${FILE_DIRNAME}/files', '${FILE_DIRNAME}' ], d)}"
> > +#FILESPATH = "${@base_set_filespath([ '${FILE_DIRNAME}/eglibc-${PV}',
> '${FILE_DIRNAME}/eglibc', '${FILE_DIRNAME}/files', '${FILE_DIRNAME}' ], d)}"
>
> this does not belong here
>
Sorry, my fault! I'll fix and resend!!! :)
>
> Cheers,
>
> --
> Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
[-- Attachment #2: Type: text/html, Size: 6143 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] eglibc: fix as and ld check in libc dir
2013-01-16 15:07 ` Giuseppe Condorelli
@ 2013-01-17 12:42 ` Martin Jansa
2013-01-17 13:30 ` Giuseppe CONDORELLI
0 siblings, 1 reply; 12+ messages in thread
From: Martin Jansa @ 2013-01-17 12:42 UTC (permalink / raw)
To: Giuseppe Condorelli; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 536 bytes --]
On Wed, Jan 16, 2013 at 04:07:39PM +0100, Giuseppe Condorelli wrote:
> 2013/1/16 Martin Jansa <martin.jansa@gmail.com>
>
> > On Wed, Jan 16, 2013 at 03:14:07PM +0100, Giuseppe CONDORELLI wrote:
> > > Fix routine to check as and ld version check in the configure, to allow
> > system
> > > to correctly check for version 2.1x.
> >
> > Does it build with gold now?
> >
> > http://lists.linuxtogo.org/pipermail/openembedded-core/2012-March/020310.html
does it?
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] eglibc: fix as and ld check in libc dir
2013-01-17 12:42 ` Martin Jansa
@ 2013-01-17 13:30 ` Giuseppe CONDORELLI
2013-01-17 13:46 ` Martin Jansa
0 siblings, 1 reply; 12+ messages in thread
From: Giuseppe CONDORELLI @ 2013-01-17 13:30 UTC (permalink / raw)
To: 'Martin Jansa', 'Giuseppe Condorelli'; +Cc: openembedded-core
Hi Martin,
Do you mean applying the patch you highlighted in libc/configure?
Cheers,
Giuseppe
>-----Original Message-----
>From: Martin Jansa [mailto:martin.jansa@gmail.com]
>Sent: giovedì 17 gennaio 2013 13:42
>To: Giuseppe Condorelli
>Cc: Giuseppe CONDORELLI; openembedded-core@lists.openembedded.org
>Subject: Re: [OE-core] [PATCH] eglibc: fix as and ld check in libc dir
>
>On Wed, Jan 16, 2013 at 04:07:39PM +0100, Giuseppe Condorelli wrote:
>> 2013/1/16 Martin Jansa <martin.jansa@gmail.com>
>>
>> > On Wed, Jan 16, 2013 at 03:14:07PM +0100, Giuseppe CONDORELLI wrote:
>> > > Fix routine to check as and ld version check in the configure, to
allow
>> > system
>> > > to correctly check for version 2.1x.
>> >
>> > Does it build with gold now?
>> >
>> > http://lists.linuxtogo.org/pipermail/openembedded-core/2012-
>March/020310.html
>
>does it?
>
>--
>Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] eglibc: fix as and ld check in libc dir
2013-01-17 13:30 ` Giuseppe CONDORELLI
@ 2013-01-17 13:46 ` Martin Jansa
2013-01-17 16:59 ` Giuseppe CONDORELLI
0 siblings, 1 reply; 12+ messages in thread
From: Martin Jansa @ 2013-01-17 13:46 UTC (permalink / raw)
To: Giuseppe CONDORELLI; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 2333 bytes --]
On Thu, Jan 17, 2013 at 02:30:55PM +0100, Giuseppe CONDORELLI wrote:
> Hi Martin,
>
> Do you mean applying the patch you highlighted in libc/configure?
I was expecting you're trying to fix ld --version detection when ld is
gold. But after few experiments I don't see what you're trying to fix:
martin@jama ~ $ ld.bfd --version 2>&1 | sed -n 's/^.*GNU ld.* \([0-9][0-9]*\.[0-9.]*\).*$/\1/p'
2.23.1
martin@jama ~ $ ld.gold --version 2>&1 | sed -n 's/^.*GNU ld.* \([0-9][0-9]*\.[0-9.]*\).*$/\1/p'
nothing -> ld.gold still unsupported
old:
martin@jama ~ $ echo 2.23.1 | egrep "2.1[0-9][0-9]*|2.[2-9][0-9]*|[3-9].*|[1-9][0-9]*"
2.23.1
martin@jama ~ $ echo 2.19.1 | egrep "2.1[0-9][0-9]*|2.[2-9][0-9]*|[3-9].*|[1-9][0-9]*"
2.19.1
martin@jama ~ $ echo 2.19 | egrep "2.1[0-9][0-9]*|2.[2-9][0-9]*|[3-9].*|[1-9][0-9]*"
2.19
martin@jama ~ $ echo 2.1 | egrep "2.1[0-9][0-9]*|2.[2-9][0-9]*|[3-9].*|[1-9][0-9]*"
2.1
new:
martin@jama ~ $ echo 2.19.1 | egrep "2.1[0-9]*|2.[2-9][0-9]*|[3-9].*|[1-9][0-9]*"
2.19.1
martin@jama ~ $ echo 2.23.1 | egrep "2.1[0-9]*|2.[2-9][0-9]*|[3-9].*|[1-9][0-9]*"
2.23.1
martin@jama ~ $ echo 2.19 | egrep "2.1[0-9]*|2.[2-9][0-9]*|[3-9].*|[1-9][0-9]*"
2.19
martin@jama ~ $ echo 2.1 | egrep "2.1[0-9]*|2.[2-9][0-9]*|[3-9].*|[1-9][0-9]*"
2.1
Can you show some example version your patch is fixing?
Cheers,
> >-----Original Message-----
> >From: Martin Jansa [mailto:martin.jansa@gmail.com]
> >Sent: giovedì 17 gennaio 2013 13:42
> >To: Giuseppe Condorelli
> >Cc: Giuseppe CONDORELLI; openembedded-core@lists.openembedded.org
> >Subject: Re: [OE-core] [PATCH] eglibc: fix as and ld check in libc dir
> >
> >On Wed, Jan 16, 2013 at 04:07:39PM +0100, Giuseppe Condorelli wrote:
> >> 2013/1/16 Martin Jansa <martin.jansa@gmail.com>
> >>
> >> > On Wed, Jan 16, 2013 at 03:14:07PM +0100, Giuseppe CONDORELLI wrote:
> >> > > Fix routine to check as and ld version check in the configure, to
> allow
> >> > system
> >> > > to correctly check for version 2.1x.
> >> >
> >> > Does it build with gold now?
> >> >
> >> > http://lists.linuxtogo.org/pipermail/openembedded-core/2012-
> >March/020310.html
> >
> >does it?
> >
> >--
> >Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
>
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] eglibc: fix as and ld check in libc dir
2013-01-17 13:46 ` Martin Jansa
@ 2013-01-17 16:59 ` Giuseppe CONDORELLI
2013-01-17 17:28 ` Martin Jansa
0 siblings, 1 reply; 12+ messages in thread
From: Giuseppe CONDORELLI @ 2013-01-17 16:59 UTC (permalink / raw)
To: 'Martin Jansa'; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 2918 bytes --]
>-----Original Message-----
>From: Martin Jansa [mailto:martin.jansa@gmail.com]
>Sent: giovedì 17 gennaio 2013 14:46
>To: Giuseppe CONDORELLI
>Cc: 'Giuseppe Condorelli'; openembedded-core@lists.openembedded.org
>Subject: Re: [OE-core] [PATCH] eglibc: fix as and ld check in libc dir
>
>On Thu, Jan 17, 2013 at 02:30:55PM +0100, Giuseppe CONDORELLI wrote:
>> Hi Martin,
>>
>> Do you mean applying the patch you highlighted in libc/configure?
>
>I was expecting you're trying to fix ld --version detection when ld is
gold. But
>after few experiments I don't see what you're trying to fix:
>
>martin@jama ~ $ ld.bfd --version 2>&1 | sed -n 's/^.*GNU ld.* \([0-9][0-
>9]*\.[0-9.]*\).*$/\1/p'
>2.23.1
>martin@jama ~ $ ld.gold --version 2>&1 | sed -n 's/^.*GNU ld.* \([0-9][0-
>9]*\.[0-9.]*\).*$/\1/p'
>nothing -> ld.gold still unsupported
>
>old:
>martin@jama ~ $ echo 2.23.1 | egrep
"2.1[0-9][0-9]*|2.[2-9][0-9]*|[3-9].*|[1-
>9][0-9]*"
>2.23.1
>martin@jama ~ $ echo 2.19.1 | egrep
"2.1[0-9][0-9]*|2.[2-9][0-9]*|[3-9].*|[1-
>9][0-9]*"
>2.19.1
>martin@jama ~ $ echo 2.19 | egrep
"2.1[0-9][0-9]*|2.[2-9][0-9]*|[3-9].*|[1-
>9][0-9]*"
>2.19
>martin@jama ~ $ echo 2.1 | egrep
"2.1[0-9][0-9]*|2.[2-9][0-9]*|[3-9].*|[1-
>9][0-9]*"
>2.1
>
>new:
>martin@jama ~ $ echo 2.19.1 | egrep
"2.1[0-9]*|2.[2-9][0-9]*|[3-9].*|[1-9][0-
>9]*"
>2.19.1
>martin@jama ~ $ echo 2.23.1 | egrep
"2.1[0-9]*|2.[2-9][0-9]*|[3-9].*|[1-9][0-
>9]*"
>2.23.1
>martin@jama ~ $ echo 2.19 | egrep
"2.1[0-9]*|2.[2-9][0-9]*|[3-9].*|[1-9][0-
>9]*"
>2.19
>martin@jama ~ $ echo 2.1 | egrep
"2.1[0-9]*|2.[2-9][0-9]*|[3-9].*|[1-9][0-
>9]*"
>2.1
>
>Can you show some example version your patch is fixing?
>
Hi Martin,
Please untar the attachment and run the test I sent you.
It reproduces the same scenario as in the libc/configure eglibc file.
Cheers,
Giuseppe
>Cheers,
>
>> >-----Original Message-----
>> >From: Martin Jansa [mailto:martin.jansa@gmail.com]
>> >Sent: giovedì 17 gennaio 2013 13:42
>> >To: Giuseppe Condorelli
>> >Cc: Giuseppe CONDORELLI; openembedded-
>core@lists.openembedded.org
>> >Subject: Re: [OE-core] [PATCH] eglibc: fix as and ld check in libc
>> >dir
>> >
>> >On Wed, Jan 16, 2013 at 04:07:39PM +0100, Giuseppe Condorelli wrote:
>> >> 2013/1/16 Martin Jansa <martin.jansa@gmail.com>
>> >>
>> >> > On Wed, Jan 16, 2013 at 03:14:07PM +0100, Giuseppe CONDORELLI
>wrote:
>> >> > > Fix routine to check as and ld version check in the configure,
>> >> > > to
>> allow
>> >> > system
>> >> > > to correctly check for version 2.1x.
>> >> >
>> >> > Does it build with gold now?
>> >> >
>> >> > http://lists.linuxtogo.org/pipermail/openembedded-core/2012-
>> >March/020310.html
>> >
>> >does it?
>> >
>> >--
>> >Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
>>
>
>--
>Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: test_for_Martin.tgz --]
[-- Type: application/x-compressed, Size: 311 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] eglibc: fix as and ld check in libc dir
2013-01-17 16:59 ` Giuseppe CONDORELLI
@ 2013-01-17 17:28 ` Martin Jansa
2013-01-18 8:32 ` Giuseppe CONDORELLI
0 siblings, 1 reply; 12+ messages in thread
From: Martin Jansa @ 2013-01-17 17:28 UTC (permalink / raw)
To: Giuseppe CONDORELLI; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 2097 bytes --]
On Thu, Jan 17, 2013 at 05:59:00PM +0100, Giuseppe CONDORELLI wrote:
>
> >-----Original Message-----
> >From: Martin Jansa [mailto:martin.jansa@gmail.com]
> >Sent: giovedì 17 gennaio 2013 14:46
> >To: Giuseppe CONDORELLI
> >Cc: 'Giuseppe Condorelli'; openembedded-core@lists.openembedded.org
> >Subject: Re: [OE-core] [PATCH] eglibc: fix as and ld check in libc dir
> >
> >On Thu, Jan 17, 2013 at 02:30:55PM +0100, Giuseppe CONDORELLI wrote:
> >> Hi Martin,
> >>
> >> Do you mean applying the patch you highlighted in libc/configure?
>
> Hi Martin,
>
> Please untar the attachment and run the test I sent you.
> It reproduces the same scenario as in the libc/configure eglibc file.
Ah I see it's not used as regexp.
But doesn't upstream have some good reason to require 2.20 and newer?
It was incremented from 1.17+ to 2.20+ in
http://www.eglibc.org/cgi-bin/viewvc.cgi/trunk/libc/configure.in?r1=17195&r2=17385
Cheers,
> >> >-----Original Message-----
> >> >From: Martin Jansa [mailto:martin.jansa@gmail.com]
> >> >Sent: giovedì 17 gennaio 2013 13:42
> >> >To: Giuseppe Condorelli
> >> >Cc: Giuseppe CONDORELLI; openembedded-
> >core@lists.openembedded.org
> >> >Subject: Re: [OE-core] [PATCH] eglibc: fix as and ld check in libc
> >> >dir
> >> >
> >> >On Wed, Jan 16, 2013 at 04:07:39PM +0100, Giuseppe Condorelli wrote:
> >> >> 2013/1/16 Martin Jansa <martin.jansa@gmail.com>
> >> >>
> >> >> > On Wed, Jan 16, 2013 at 03:14:07PM +0100, Giuseppe CONDORELLI
> >wrote:
> >> >> > > Fix routine to check as and ld version check in the configure,
> >> >> > > to
> >> allow
> >> >> > system
> >> >> > > to correctly check for version 2.1x.
> >> >> >
> >> >> > Does it build with gold now?
> >> >> >
> >> >> > http://lists.linuxtogo.org/pipermail/openembedded-core/2012-
> >> >March/020310.html
> >> >
> >> >does it?
> >> >
> >> >--
> >> >Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
> >>
> >
> >--
> >Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] eglibc: fix as and ld check in libc dir
2013-01-17 17:28 ` Martin Jansa
@ 2013-01-18 8:32 ` Giuseppe CONDORELLI
2013-01-18 8:55 ` Martin Jansa
0 siblings, 1 reply; 12+ messages in thread
From: Giuseppe CONDORELLI @ 2013-01-18 8:32 UTC (permalink / raw)
To: 'Martin Jansa'; +Cc: openembedded-core
Yes Martin,
but I discovered the issue building (erroneously because eglibc was actually
not required at all) an external-toolchain a little bit old (gcc and
binutils) against the master oe-core repository,
which contains eglic-2.16 as you know. And libc/configure comes with the
issue I highlighted.
So, please, think to my patch as a nice to have and not as a mandatory one.
I don't know if other people will fall in my same condition.
Thanks so much for your support.
Giuseppe
>-----Original Message-----
>From: Martin Jansa [mailto:martin.jansa@gmail.com]
>Sent: giovedì 17 gennaio 2013 18:28
>To: Giuseppe CONDORELLI
>Cc: 'Giuseppe Condorelli'; openembedded-core@lists.openembedded.org
>Subject: Re: [OE-core] [PATCH] eglibc: fix as and ld check in libc dir
>
>On Thu, Jan 17, 2013 at 05:59:00PM +0100, Giuseppe CONDORELLI wrote:
>>
>> >-----Original Message-----
>> >From: Martin Jansa [mailto:martin.jansa@gmail.com]
>> >Sent: giovedì 17 gennaio 2013 14:46
>> >To: Giuseppe CONDORELLI
>> >Cc: 'Giuseppe Condorelli'; openembedded-core@lists.openembedded.org
>> >Subject: Re: [OE-core] [PATCH] eglibc: fix as and ld check in libc
>> >dir
>> >
>> >On Thu, Jan 17, 2013 at 02:30:55PM +0100, Giuseppe CONDORELLI wrote:
>> >> Hi Martin,
>> >>
>> >> Do you mean applying the patch you highlighted in libc/configure?
>>
>> Hi Martin,
>>
>> Please untar the attachment and run the test I sent you.
>> It reproduces the same scenario as in the libc/configure eglibc file.
>
>Ah I see it's not used as regexp.
>
>But doesn't upstream have some good reason to require 2.20 and newer?
>
>It was incremented from 1.17+ to 2.20+ in
>http://www.eglibc.org/cgi-
>bin/viewvc.cgi/trunk/libc/configure.in?r1=17195&r2=17385
>
>Cheers,
>
>> >> >-----Original Message-----
>> >> >From: Martin Jansa [mailto:martin.jansa@gmail.com]
>> >> >Sent: giovedì 17 gennaio 2013 13:42
>> >> >To: Giuseppe Condorelli
>> >> >Cc: Giuseppe CONDORELLI; openembedded-
>> >core@lists.openembedded.org
>> >> >Subject: Re: [OE-core] [PATCH] eglibc: fix as and ld check in libc
>> >> >dir
>> >> >
>> >> >On Wed, Jan 16, 2013 at 04:07:39PM +0100, Giuseppe Condorelli wrote:
>> >> >> 2013/1/16 Martin Jansa <martin.jansa@gmail.com>
>> >> >>
>> >> >> > On Wed, Jan 16, 2013 at 03:14:07PM +0100, Giuseppe CONDORELLI
>> >wrote:
>> >> >> > > Fix routine to check as and ld version check in the
>> >> >> > > configure, to
>> >> allow
>> >> >> > system
>> >> >> > > to correctly check for version 2.1x.
>> >> >> >
>> >> >> > Does it build with gold now?
>> >> >> >
>> >> >> > http://lists.linuxtogo.org/pipermail/openembedded-core/2012-
>> >> >March/020310.html
>> >> >
>> >> >does it?
>> >> >
>> >> >--
>> >> >Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
>> >>
>> >
>> >--
>> >Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
>
>
>
>--
>Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] eglibc: fix as and ld check in libc dir
2013-01-18 8:32 ` Giuseppe CONDORELLI
@ 2013-01-18 8:55 ` Martin Jansa
2013-01-18 9:01 ` Giuseppe CONDORELLI
0 siblings, 1 reply; 12+ messages in thread
From: Martin Jansa @ 2013-01-18 8:55 UTC (permalink / raw)
To: Giuseppe CONDORELLI; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]
On Fri, Jan 18, 2013 at 9:32 AM, Giuseppe CONDORELLI <
giuseppe.condorelli@st.com> wrote:
> Yes Martin,
>
> but I discovered the issue building (erroneously because eglibc was
> actually
> not required at all) an external-toolchain a little bit old (gcc and
> binutils) against the master oe-core repository,
> which contains eglic-2.16 as you know. And libc/configure comes with the
> issue I highlighted.
> So, please, think to my patch as a nice to have and not as a mandatory one.
> I don't know if other people will fall in my same condition.
>
> Thanks so much for your support.
> Giuseppe
>
And are you using eglibc-2.16 built with binutils-2.19 in runtime on some
targets?
My point is that if upstream developers decided to support binutils-2.20+
only, they probably had some reason to do it and failing configure check is
better way to show you're building unsupported combination then something
failing badly in runtime on target.
http://sourceware.org/git/?p=glibc.git;a=commit;f=configure.in;h=bec039bcefe6a0494a249e2b78e112a0ab60893b
This commit also doesn't say why..
Cheers,
[-- Attachment #2: Type: text/html, Size: 1903 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] eglibc: fix as and ld check in libc dir
2013-01-18 8:55 ` Martin Jansa
@ 2013-01-18 9:01 ` Giuseppe CONDORELLI
0 siblings, 0 replies; 12+ messages in thread
From: Giuseppe CONDORELLI @ 2013-01-18 9:01 UTC (permalink / raw)
To: 'Martin Jansa'
Cc: 'Patches and discussions about the oe-core layer'
[-- Attachment #1: Type: text/plain, Size: 1789 bytes --]
From: Martin Jansa [mailto:martin.jansa@gmail.com]
Sent: venerdì 18 gennaio 2013 09:55
To: Giuseppe CONDORELLI
Cc: Giuseppe Condorelli; Patches and discussions about the oe-core layer
Subject: Re: [OE-core] [PATCH] eglibc: fix as and ld check in libc dir
On Fri, Jan 18, 2013 at 9:32 AM, Giuseppe CONDORELLI <giuseppe.condorelli@st.com> wrote:
Yes Martin,
but I discovered the issue building (erroneously because eglibc was actually
not required at all) an external-toolchain a little bit old (gcc and
binutils) against the master oe-core repository,
which contains eglic-2.16 as you know. And libc/configure comes with the
issue I highlighted.
So, please, think to my patch as a nice to have and not as a mandatory one.
I don't know if other people will fall in my same condition.
Thanks so much for your support.
Giuseppe
And are you using eglibc-2.16 built with binutils-2.19 in runtime on some targets?
In fact I wrote it was my fault, indeed eglibc has not to be built at all given my external toolchain fully provides all the infrastructure.
However this mistake highlighted the possible issue
My point is that if upstream developers decided to support binutils-2.20+ only, they probably had some reason to do it and failing configure check is better way to show you're building unsupported combination then something failing badly in runtime on target.
http://sourceware.org/git/?p=glibc.git;a=commit;f=configure.in;h=bec039bcefe6a0494a249e2b78e112a0ab60893b
This commit also doesn't say why..
Ok, no problem. The patch can remain unapplied if you think it could be useless. At any rate it will remain as document if other people will fall in that for any reason.
Cheers,
Cheers,
[-- Attachment #2: Type: text/html, Size: 5466 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] eglibc: fix as and ld check in libc dir
2013-01-16 14:14 [PATCH] eglibc: fix as and ld check in libc dir Giuseppe CONDORELLI
2013-01-16 15:02 ` Martin Jansa
@ 2013-01-18 17:12 ` Khem Raj
1 sibling, 0 replies; 12+ messages in thread
From: Khem Raj @ 2013-01-18 17:12 UTC (permalink / raw)
To: openembedded-core
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 01/16/2013 06:14 AM, Giuseppe CONDORELLI wrote:
> Fix routine to check as and ld version check in the configure, to
> allow system to correctly check for version 2.1x.
Giuseppe
This demotion of letting older binutils will not be accepted since
there is reason to demand 2.20 minimum see
http://sourceware.org/ml/libc-alpha/2012-02/msg00605.html
Now you might have backported needed functionality into your local
copy of binutils but having this patch local to your layer is best
approach here.
- -Khem
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlD5gmAACgkQuwUzVZGdMxQrBQCggIutiKGvZYlfQimMO+2gEu6S
ZcUAnjQynyJrIQTfIJWw/Jqt7ZyzJ0Xl
=7E9N
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2013-01-18 17:27 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-16 14:14 [PATCH] eglibc: fix as and ld check in libc dir Giuseppe CONDORELLI
2013-01-16 15:02 ` Martin Jansa
2013-01-16 15:07 ` Giuseppe Condorelli
2013-01-17 12:42 ` Martin Jansa
2013-01-17 13:30 ` Giuseppe CONDORELLI
2013-01-17 13:46 ` Martin Jansa
2013-01-17 16:59 ` Giuseppe CONDORELLI
2013-01-17 17:28 ` Martin Jansa
2013-01-18 8:32 ` Giuseppe CONDORELLI
2013-01-18 8:55 ` Martin Jansa
2013-01-18 9:01 ` Giuseppe CONDORELLI
2013-01-18 17:12 ` Khem Raj
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox