* [PATCH 0/2] define and use tcp-wrappers DISTRO_FEATURE @ 2013-01-18 2:56 rongqing.li 2013-01-18 2:56 ` [PATCH 1/2] xinetd: enable tcp-wrappers support by DISTRO_FEATURE rongqing.li 2013-01-18 2:56 ` [PATCH 2/2] default-distrovars: add tcp-wrappers to default DISTRO_FEATURES rongqing.li 0 siblings, 2 replies; 9+ messages in thread From: rongqing.li @ 2013-01-18 2:56 UTC (permalink / raw) To: randy.macleod, joe.macdonald, openembedded-core From: "Roy.Li" <rongqing.li@windriver.com> *** BLURB HERE *** The following changes since commit 98f17da7ccc1bf79fc5894f90e52769bdbcf89df: update-rc.d: fix failure on target (2013-01-17 20:16:38 +0000) are available in the git repository at: git://git.pokylinux.org/poky-contrib roy/enable_tcp_wrapper_xinetd http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=roy/enable_tcp_wrapper_xinetd Roy.Li (2): xinetd: enable tcp-wrappers support by DISTRO_FEATURE default-distrovars: add tcp-wrappers to default DISTRO_FEATURES meta/conf/distro/include/default-distrovars.inc | 3 ++- meta/recipes-extended/xinetd/xinetd_2.3.15.bb | 5 ++++- 2 files changed, 6 insertions(+), 2 deletions(-) -- 1.7.10.4 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] xinetd: enable tcp-wrappers support by DISTRO_FEATURE 2013-01-18 2:56 [PATCH 0/2] define and use tcp-wrappers DISTRO_FEATURE rongqing.li @ 2013-01-18 2:56 ` rongqing.li 2013-01-18 8:26 ` Martin Jansa 2013-01-18 2:56 ` [PATCH 2/2] default-distrovars: add tcp-wrappers to default DISTRO_FEATURES rongqing.li 1 sibling, 1 reply; 9+ messages in thread From: rongqing.li @ 2013-01-18 2:56 UTC (permalink / raw) To: randy.macleod, joe.macdonald, openembedded-core From: "Roy.Li" <rongqing.li@windriver.com> Signed-off-by: Roy.Li <rongqing.li@windriver.com> --- meta/recipes-extended/xinetd/xinetd_2.3.15.bb | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/meta/recipes-extended/xinetd/xinetd_2.3.15.bb b/meta/recipes-extended/xinetd/xinetd_2.3.15.bb index 3bde512..9278cc2 100644 --- a/meta/recipes-extended/xinetd/xinetd_2.3.15.bb +++ b/meta/recipes-extended/xinetd/xinetd_2.3.15.bb @@ -7,7 +7,7 @@ LICENSE = "BSD" LIC_FILES_CHKSUM = "file://COPYRIGHT;md5=8ad8615198542444f84d28a6cf226dd8" DEPENDS = "" -PR = "r1" +PR = "r2" SRC_URI = "http://www.xinetd.org/xinetd-${PV}.tar.gz \ file://xinetd.init \ @@ -28,6 +28,9 @@ INITSCRIPT_PARAMS = "defaults" EXTRA_OECONF="--disable-nls" +DEPENDS += "${@base_contains('DISTRO_FEATURES', 'tcp-wrappers', 'tcp-wrappers', '', d)}" +EXTRA_OECONF += "${@base_contains('DISTRO_FEATURES', 'tcp-wrappers', '--with-libwrap', '', d)}" + do_configure() { # Looks like configure.in is broken, so we are skipping # rebuilding configure and are just using the shipped one -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] xinetd: enable tcp-wrappers support by DISTRO_FEATURE 2013-01-18 2:56 ` [PATCH 1/2] xinetd: enable tcp-wrappers support by DISTRO_FEATURE rongqing.li @ 2013-01-18 8:26 ` Martin Jansa 2013-01-19 4:37 ` Rongqing Li 0 siblings, 1 reply; 9+ messages in thread From: Martin Jansa @ 2013-01-18 8:26 UTC (permalink / raw) To: rongqing.li; +Cc: openembedded-core, joe.macdonald [-- Attachment #1: Type: text/plain, Size: 1594 bytes --] On Fri, Jan 18, 2013 at 10:56:22AM +0800, rongqing.li@windriver.com wrote: > From: "Roy.Li" <rongqing.li@windriver.com> > > Signed-off-by: Roy.Li <rongqing.li@windriver.com> > --- > meta/recipes-extended/xinetd/xinetd_2.3.15.bb | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/meta/recipes-extended/xinetd/xinetd_2.3.15.bb b/meta/recipes-extended/xinetd/xinetd_2.3.15.bb > index 3bde512..9278cc2 100644 > --- a/meta/recipes-extended/xinetd/xinetd_2.3.15.bb > +++ b/meta/recipes-extended/xinetd/xinetd_2.3.15.bb > @@ -7,7 +7,7 @@ LICENSE = "BSD" > LIC_FILES_CHKSUM = "file://COPYRIGHT;md5=8ad8615198542444f84d28a6cf226dd8" > > DEPENDS = "" > -PR = "r1" > +PR = "r2" > > SRC_URI = "http://www.xinetd.org/xinetd-${PV}.tar.gz \ > file://xinetd.init \ > @@ -28,6 +28,9 @@ INITSCRIPT_PARAMS = "defaults" > > EXTRA_OECONF="--disable-nls" > > +DEPENDS += "${@base_contains('DISTRO_FEATURES', 'tcp-wrappers', 'tcp-wrappers', '', d)}" > +EXTRA_OECONF += "${@base_contains('DISTRO_FEATURES', 'tcp-wrappers', '--with-libwrap', '', d)}" > + Why not use PACKAGECONFIG here? Cheers, > do_configure() { > # Looks like configure.in is broken, so we are skipping > # rebuilding configure and are just using the shipped one > -- > 1.7.10.4 > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] xinetd: enable tcp-wrappers support by DISTRO_FEATURE 2013-01-18 8:26 ` Martin Jansa @ 2013-01-19 4:37 ` Rongqing Li 2013-01-19 4:45 ` Saul Wold 0 siblings, 1 reply; 9+ messages in thread From: Rongqing Li @ 2013-01-19 4:37 UTC (permalink / raw) To: Martin Jansa; +Cc: openembedded-core, joe.macdonald On 01/18/2013 04:26 PM, Martin Jansa wrote: > On Fri, Jan 18, 2013 at 10:56:22AM +0800, rongqing.li@windriver.com wrote: >> From: "Roy.Li" <rongqing.li@windriver.com> >> >> Signed-off-by: Roy.Li <rongqing.li@windriver.com> >> --- >> meta/recipes-extended/xinetd/xinetd_2.3.15.bb | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/meta/recipes-extended/xinetd/xinetd_2.3.15.bb b/meta/recipes-extended/xinetd/xinetd_2.3.15.bb >> index 3bde512..9278cc2 100644 >> --- a/meta/recipes-extended/xinetd/xinetd_2.3.15.bb >> +++ b/meta/recipes-extended/xinetd/xinetd_2.3.15.bb >> @@ -7,7 +7,7 @@ LICENSE = "BSD" >> LIC_FILES_CHKSUM = "file://COPYRIGHT;md5=8ad8615198542444f84d28a6cf226dd8" >> >> DEPENDS = "" >> -PR = "r1" >> +PR = "r2" >> >> SRC_URI = "http://www.xinetd.org/xinetd-${PV}.tar.gz \ >> file://xinetd.init \ >> @@ -28,6 +28,9 @@ INITSCRIPT_PARAMS = "defaults" >> >> EXTRA_OECONF="--disable-nls" >> >> +DEPENDS += "${@base_contains('DISTRO_FEATURES', 'tcp-wrappers', 'tcp-wrappers', '', d)}" >> +EXTRA_OECONF += "${@base_contains('DISTRO_FEATURES', 'tcp-wrappers', '--with-libwrap', '', d)}" >> + > > Why not use PACKAGECONFIG here? > Enabling tcp-wrapper is not a random thing for some customer, it is a must. So I think feature is more suitable -Roy > Cheers, > >> do_configure() { >> # Looks like configure.in is broken, so we are skipping >> # rebuilding configure and are just using the shipped one >> -- >> 1.7.10.4 >> >> >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > -- Best Reagrds, Roy | RongQing Li ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] xinetd: enable tcp-wrappers support by DISTRO_FEATURE 2013-01-19 4:37 ` Rongqing Li @ 2013-01-19 4:45 ` Saul Wold 2013-01-19 4:53 ` Rongqing Li 0 siblings, 1 reply; 9+ messages in thread From: Saul Wold @ 2013-01-19 4:45 UTC (permalink / raw) To: Rongqing Li; +Cc: joe.macdonald, Martin Jansa, openembedded-core On 01/18/2013 08:37 PM, Rongqing Li wrote: > > > On 01/18/2013 04:26 PM, Martin Jansa wrote: >> On Fri, Jan 18, 2013 at 10:56:22AM +0800, rongqing.li@windriver.com >> wrote: >>> From: "Roy.Li" <rongqing.li@windriver.com> >>> >>> Signed-off-by: Roy.Li <rongqing.li@windriver.com> >>> --- >>> meta/recipes-extended/xinetd/xinetd_2.3.15.bb | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/meta/recipes-extended/xinetd/xinetd_2.3.15.bb >>> b/meta/recipes-extended/xinetd/xinetd_2.3.15.bb >>> index 3bde512..9278cc2 100644 >>> --- a/meta/recipes-extended/xinetd/xinetd_2.3.15.bb >>> +++ b/meta/recipes-extended/xinetd/xinetd_2.3.15.bb >>> @@ -7,7 +7,7 @@ LICENSE = "BSD" >>> LIC_FILES_CHKSUM = >>> "file://COPYRIGHT;md5=8ad8615198542444f84d28a6cf226dd8" >>> >>> DEPENDS = "" >>> -PR = "r1" >>> +PR = "r2" >>> >>> SRC_URI = "http://www.xinetd.org/xinetd-${PV}.tar.gz \ >>> file://xinetd.init \ >>> @@ -28,6 +28,9 @@ INITSCRIPT_PARAMS = "defaults" >>> >>> EXTRA_OECONF="--disable-nls" >>> >>> +DEPENDS += "${@base_contains('DISTRO_FEATURES', 'tcp-wrappers', >>> 'tcp-wrappers', '', d)}" >>> +EXTRA_OECONF += "${@base_contains('DISTRO_FEATURES', 'tcp-wrappers', >>> '--with-libwrap', '', d)}" >>> + >> >> Why not use PACKAGECONFIG here? >> > > Enabling tcp-wrapper is not a random thing for some customer, > it is a must. So I think feature is more suitable > Martin's point is you can use the PACKAGECONFIG syntax here instead of 2 base_contains. for example: PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'tcp_wrappers', 'tcp_wrappers', '', d)}" PACKAGECONFIG[tcp_wrappers] = "--with-libwrap,--without-libwrap, tcp_wrappers" See docs for more information. Sau! > -Roy > >> Cheers, >> >>> do_configure() { >>> # Looks like configure.in is broken, so we are skipping >>> # rebuilding configure and are just using the shipped one >>> -- >>> 1.7.10.4 >>> >>> >>> _______________________________________________ >>> Openembedded-core mailing list >>> Openembedded-core@lists.openembedded.org >>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >> > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] xinetd: enable tcp-wrappers support by DISTRO_FEATURE 2013-01-19 4:45 ` Saul Wold @ 2013-01-19 4:53 ` Rongqing Li 0 siblings, 0 replies; 9+ messages in thread From: Rongqing Li @ 2013-01-19 4:53 UTC (permalink / raw) To: Saul Wold; +Cc: joe.macdonald, Martin Jansa, openembedded-core On 01/19/2013 12:45 PM, Saul Wold wrote: >>>> +EXTRA_OECONF += "${@base_contains('DISTRO_FEATURES', 'tcp-wrappers', >>>> '--with-libwrap', '', d)}" >>>> + >>> >>> Why not use PACKAGECONFIG here? >>> >> >> Enabling tcp-wrapper is not a random thing for some customer, >> it is a must. So I think feature is more suitable >> > Martin's point is you can use the PACKAGECONFIG syntax here instead of 2 > base_contains. > > for example: > PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'tcp_wrappers', > 'tcp_wrappers', '', d)}" > PACKAGECONFIG[tcp_wrappers] = "--with-libwrap,--without-libwrap, > tcp_wrappers" > > See docs for more information. > > Sau! I see, thanks -Roy -- Best Reagrds, Roy | RongQing Li ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/2] default-distrovars: add tcp-wrappers to default DISTRO_FEATURES 2013-01-18 2:56 [PATCH 0/2] define and use tcp-wrappers DISTRO_FEATURE rongqing.li 2013-01-18 2:56 ` [PATCH 1/2] xinetd: enable tcp-wrappers support by DISTRO_FEATURE rongqing.li @ 2013-01-18 2:56 ` rongqing.li 2013-01-18 8:24 ` Martin Jansa 1 sibling, 1 reply; 9+ messages in thread From: rongqing.li @ 2013-01-18 2:56 UTC (permalink / raw) To: randy.macleod, joe.macdonald, openembedded-core From: "Roy.Li" <rongqing.li@windriver.com> tcp-wrappers DISTRO_FEATURES only is used in xinetd currently, but other packages maybe need it to enable tcp-wrapper support, like vsftpd. Signed-off-by: Roy.Li <rongqing.li@windriver.com> --- meta/conf/distro/include/default-distrovars.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/meta/conf/distro/include/default-distrovars.inc b/meta/conf/distro/include/default-distrovars.inc index 9002fd6..9126825 100644 --- a/meta/conf/distro/include/default-distrovars.inc +++ b/meta/conf/distro/include/default-distrovars.inc @@ -19,7 +19,8 @@ DISTRO_FEATURES_LIBC_DEFAULT ?= "ipv4 ipv6 libc-backtrace libc-big-macros libc-b libc-posix-wchar-io" DISTRO_FEATURES_LIBC ?= "${DISTRO_FEATURES_LIBC_DEFAULT}" DISTRO_FEATURES_LIBC_class-nativesdk = "${DISTRO_FEATURES_LIBC_DEFAULT}" -DISTRO_FEATURES ?= "alsa argp bluetooth ext2 irda largefile pcmcia usbgadget usbhost wifi xattr nfs zeroconf pci 3g x11 ${DISTRO_FEATURES_LIBC}" +DISTRO_FEATURES ?= "alsa argp bluetooth ext2 irda largefile pcmcia usbgadget usbhost wifi xattr nfs zeroconf pci 3g x11 tcp-wrappers \ + ${DISTRO_FEATURES_LIBC}" IMAGE_FEATURES ?= "" -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] default-distrovars: add tcp-wrappers to default DISTRO_FEATURES 2013-01-18 2:56 ` [PATCH 2/2] default-distrovars: add tcp-wrappers to default DISTRO_FEATURES rongqing.li @ 2013-01-18 8:24 ` Martin Jansa 2013-01-19 4:42 ` Rongqing Li 0 siblings, 1 reply; 9+ messages in thread From: Martin Jansa @ 2013-01-18 8:24 UTC (permalink / raw) To: rongqing.li; +Cc: openembedded-core, joe.macdonald [-- Attachment #1: Type: text/plain, Size: 1670 bytes --] On Fri, Jan 18, 2013 at 10:56:23AM +0800, rongqing.li@windriver.com wrote: > From: "Roy.Li" <rongqing.li@windriver.com> > > tcp-wrappers DISTRO_FEATURES only is used in xinetd currently, but other > packages maybe need it to enable tcp-wrapper support, like vsftpd. > > Signed-off-by: Roy.Li <rongqing.li@windriver.com> > --- > meta/conf/distro/include/default-distrovars.inc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meta/conf/distro/include/default-distrovars.inc b/meta/conf/distro/include/default-distrovars.inc > index 9002fd6..9126825 100644 > --- a/meta/conf/distro/include/default-distrovars.inc > +++ b/meta/conf/distro/include/default-distrovars.inc > @@ -19,7 +19,8 @@ DISTRO_FEATURES_LIBC_DEFAULT ?= "ipv4 ipv6 libc-backtrace libc-big-macros libc-b > libc-posix-wchar-io" > DISTRO_FEATURES_LIBC ?= "${DISTRO_FEATURES_LIBC_DEFAULT}" > DISTRO_FEATURES_LIBC_class-nativesdk = "${DISTRO_FEATURES_LIBC_DEFAULT}" > -DISTRO_FEATURES ?= "alsa argp bluetooth ext2 irda largefile pcmcia usbgadget usbhost wifi xattr nfs zeroconf pci 3g x11 ${DISTRO_FEATURES_LIBC}" > +DISTRO_FEATURES ?= "alsa argp bluetooth ext2 irda largefile pcmcia usbgadget usbhost wifi xattr nfs zeroconf pci 3g x11 tcp-wrappers \ > + ${DISTRO_FEATURES_LIBC}" DISTRO_FEATURES_BACKFILL maybe? > > IMAGE_FEATURES ?= "" > > -- > 1.7.10.4 > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] default-distrovars: add tcp-wrappers to default DISTRO_FEATURES 2013-01-18 8:24 ` Martin Jansa @ 2013-01-19 4:42 ` Rongqing Li 0 siblings, 0 replies; 9+ messages in thread From: Rongqing Li @ 2013-01-19 4:42 UTC (permalink / raw) To: Martin Jansa; +Cc: openembedded-core, joe.macdonald On 01/18/2013 04:24 PM, Martin Jansa wrote: > On Fri, Jan 18, 2013 at 10:56:23AM +0800, rongqing.li@windriver.com wrote: >> From: "Roy.Li" <rongqing.li@windriver.com> >> >> tcp-wrappers DISTRO_FEATURES only is used in xinetd currently, but other >> packages maybe need it to enable tcp-wrapper support, like vsftpd. >> >> Signed-off-by: Roy.Li <rongqing.li@windriver.com> >> --- >> meta/conf/distro/include/default-distrovars.inc | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/meta/conf/distro/include/default-distrovars.inc b/meta/conf/distro/include/default-distrovars.inc >> index 9002fd6..9126825 100644 >> --- a/meta/conf/distro/include/default-distrovars.inc >> +++ b/meta/conf/distro/include/default-distrovars.inc >> @@ -19,7 +19,8 @@ DISTRO_FEATURES_LIBC_DEFAULT ?= "ipv4 ipv6 libc-backtrace libc-big-macros libc-b >> libc-posix-wchar-io" >> DISTRO_FEATURES_LIBC ?= "${DISTRO_FEATURES_LIBC_DEFAULT}" >> DISTRO_FEATURES_LIBC_class-nativesdk = "${DISTRO_FEATURES_LIBC_DEFAULT}" >> -DISTRO_FEATURES ?= "alsa argp bluetooth ext2 irda largefile pcmcia usbgadget usbhost wifi xattr nfs zeroconf pci 3g x11 ${DISTRO_FEATURES_LIBC}" >> +DISTRO_FEATURES ?= "alsa argp bluetooth ext2 irda largefile pcmcia usbgadget usbhost wifi xattr nfs zeroconf pci 3g x11 tcp-wrappers \ >> + ${DISTRO_FEATURES_LIBC}" > > DISTRO_FEATURES_BACKFILL maybe? > Ok, if no one objects this, I will move it to DISTRO_FEATURES_BACKFILL Thanks -Roy >> >> IMAGE_FEATURES ?= "" >> >> -- >> 1.7.10.4 >> >> >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > -- Best Reagrds, Roy | RongQing Li ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-01-19 5:09 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-01-18 2:56 [PATCH 0/2] define and use tcp-wrappers DISTRO_FEATURE rongqing.li 2013-01-18 2:56 ` [PATCH 1/2] xinetd: enable tcp-wrappers support by DISTRO_FEATURE rongqing.li 2013-01-18 8:26 ` Martin Jansa 2013-01-19 4:37 ` Rongqing Li 2013-01-19 4:45 ` Saul Wold 2013-01-19 4:53 ` Rongqing Li 2013-01-18 2:56 ` [PATCH 2/2] default-distrovars: add tcp-wrappers to default DISTRO_FEATURES rongqing.li 2013-01-18 8:24 ` Martin Jansa 2013-01-19 4:42 ` Rongqing Li
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox