Re: [PATCH 01/11] libpcap: Add missing libusb dependency

[Khem Raj <raj.khem@gmail.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/24/2013 02:49 PM, Richard Purdie wrote:
> On Thu, 2013-01-24 at 15:42 -0700, Chris Larson wrote:
>> 
>> On Thu, Jan 24, 2013 at 3:14 PM, Khem Raj <raj.khem@gmail.com>
>> wrote: On Thu, Jan 24, 2013 at 1:50 PM, Richard Purdie 
>> <richard.purdie@linuxfoundation.org> wrote:
>>> Do we need libusb support in libpcap? What does this
>> dependency buy us
>>> and couldn't we force it off instead?
>> 
>> 
>> its needed to support canusb in libpcap, I would say yes we 
>> should support it but disabling it would be ok too although all
>> my builds were silently using libusb so I think unknowingly may
>> be but we are already shipping with canusb support.
>> 
>> I'd personally prefer it disabled, but I'd think at the very
>> least it should be a PACKAGECONFIG entry, whether its included in
>> the default value of PACKAGECONFIG itself or not.
>> 
> Agreed, PACKAGECONFIG, default off is the way to go with this IMO
> too.
> 

OK I have turned it into a PACKAGECONFIG which is off by default.
Disabling canusb support in 1.3 was buggy and it really did not
disable it so I had to backport relevant patches from libpcap upstream
but now
all looks good.

I have pushed V2 into pull tree please take a look.

> Cheers,
> 
> Richard
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlECClQACgkQuwUzVZGdMxTkKACaApmk49aFcWyV8Vcn/I7TToPo
y0MAn2uGa7LTEt+PPy2aMOgsVX4oKdHF
=qLRK
-----END PGP SIGNATURE-----