From: Radu Moisan <radu.moisan@intel.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] polkit: Enable systemd support
Date: Fri, 01 Feb 2013 12:22:01 +0200 [thread overview]
Message-ID: <510B9749.6040801@intel.com> (raw)
In-Reply-To: <CAJTo0LZ3tvB6t13utWrzXhqE7mx58ypkFosUdtwj=XuMbPXRNw@mail.gmail.com>
On 02/01/2013 11:44 AM, Burton, Ross wrote:
> On 1 February 2013 09:22, Radu Moisan <radu.moisan@intel.com> wrote:
>> enable/disable support as relevant
> Please write a more verbose comment, something along the lines of
> "systemd is auto-detected unless disabled explicitly, potentially
> contaminating sstate".
>
>> +# there is no --enable/--disable option for consolekit and it's not picked by shlibs, so add it to DEPENDS
> It's not picked up by shlibs because it's a dbus call not a library
> call, and that's *RDEPENDS* not depends.
I did change that manually because I assumed it was a typo. However it
make sense to add consolekit as a runtime dependency, but the
documentation specifically says PACKAGECONFIG will add to DEPENDS. How
is it different in this patch? The PACKAGECONFIG[systemd] is clearly
specifying a build time dependency, why the PACKAGECONFIG[consolekit] is
specifying a runtime dependency? How can I discriminate in this context?
Radu
next prev parent reply other threads:[~2013-02-01 10:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 9:22 [PATCH] polkit: Enable systemd support Radu Moisan
2013-02-01 9:39 ` Andreas Müller
2013-02-01 9:46 ` Radu Moisan
2013-02-01 9:47 ` Burton, Ross
2013-02-01 9:49 ` Radu Moisan
2013-02-01 9:44 ` Burton, Ross
2013-02-01 10:22 ` Radu Moisan [this message]
2013-02-01 10:26 ` Martin Jansa
2013-02-01 10:27 ` Burton, Ross
2013-02-01 11:40 ` Radu Moisan
-- strict thread matches above, loose matches on Subject: below --
2013-02-01 11:37 Radu Moisan
2013-02-01 12:04 ` Burton, Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510B9749.6040801@intel.com \
--to=radu.moisan@intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox