* [PATCH] polkit: Enable systemd support
@ 2013-02-01 9:22 Radu Moisan
2013-02-01 9:39 ` Andreas Müller
2013-02-01 9:44 ` Burton, Ross
0 siblings, 2 replies; 12+ messages in thread
From: Radu Moisan @ 2013-02-01 9:22 UTC (permalink / raw)
To: openembedded-core
enable/disable support as relevant
Signed-off-by: Radu Moisan <radu.moisan@intel.com>
Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
---
meta/recipes-extended/polkit/polkit_0.104.bb | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-extended/polkit/polkit_0.104.bb b/meta/recipes-extended/polkit/polkit_0.104.bb
index 2c0aaca..08e016a 100644
--- a/meta/recipes-extended/polkit/polkit_0.104.bb
+++ b/meta/recipes-extended/polkit/polkit_0.104.bb
@@ -7,8 +7,13 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=155db86cdbafa7532b41f390409283eb \
DEPENDS = "expat glib-2.0 intltool-native gobject-introspection-stub"
-PACKAGECONFIG = "${@base_contains('DISTRO_FEATURES', 'pam', 'pam', '', d)}"
+PACKAGECONFIG = "${@base_contains('DISTRO_FEATURES', 'pam', 'pam', '', d)} \
+ ${@base_contains('DISTRO_FEATURES','systemd','systemd','consolekit',d)}"
+
PACKAGECONFIG[pam] = "--with-authfw=pam,--with-authfw=shadow,libpam,libpam"
+PACKAGECONFIG[systemd] = "--enable-systemd,--disable-systemd,systemd"
+# there is no --enable/--disable option for consolekit and it's not picked by shlibs, so add it to DEPENDS
+PACKAGECONFIG[consolekit] = ",,,consolekit"
PR = "r9"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH] polkit: Enable systemd support
2013-02-01 9:22 [PATCH] polkit: Enable systemd support Radu Moisan
@ 2013-02-01 9:39 ` Andreas Müller
2013-02-01 9:46 ` Radu Moisan
2013-02-01 9:47 ` Burton, Ross
2013-02-01 9:44 ` Burton, Ross
1 sibling, 2 replies; 12+ messages in thread
From: Andreas Müller @ 2013-02-01 9:39 UTC (permalink / raw)
To: Radu Moisan; +Cc: openembedded-core
On Fri, Feb 1, 2013 at 10:22 AM, Radu Moisan <radu.moisan@intel.com> wrote:
> enable/disable support as relevant
>
> Signed-off-by: Radu Moisan <radu.moisan@intel.com>
> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
What caused my sign-off - or is it a hint that meta-oe/meta-systemd
need alignment with this?
Andreas
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] polkit: Enable systemd support
2013-02-01 9:39 ` Andreas Müller
@ 2013-02-01 9:46 ` Radu Moisan
2013-02-01 9:47 ` Burton, Ross
1 sibling, 0 replies; 12+ messages in thread
From: Radu Moisan @ 2013-02-01 9:46 UTC (permalink / raw)
To: Andreas Müller; +Cc: openembedded-core
On 02/01/2013 11:39 AM, Andreas Müller wrote:
> On Fri, Feb 1, 2013 at 10:22 AM, Radu Moisan <radu.moisan@intel.com> wrote:
>> enable/disable support as relevant
>>
>> Signed-off-by: Radu Moisan <radu.moisan@intel.com>
>> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> What caused my sign-off - or is it a hint that meta-oe/meta-systemd
> need alignment with this?
You were the only reference I had from meta-openembedded.
Radu
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] polkit: Enable systemd support
2013-02-01 9:39 ` Andreas Müller
2013-02-01 9:46 ` Radu Moisan
@ 2013-02-01 9:47 ` Burton, Ross
2013-02-01 9:49 ` Radu Moisan
1 sibling, 1 reply; 12+ messages in thread
From: Burton, Ross @ 2013-02-01 9:47 UTC (permalink / raw)
To: Andreas Müller; +Cc: openembedded-core
On 1 February 2013 09:39, Andreas Müller <schnitzeltony@googlemail.com> wrote:
> On Fri, Feb 1, 2013 at 10:22 AM, Radu Moisan <radu.moisan@intel.com> wrote:
>> enable/disable support as relevant
>>
>> Signed-off-by: Radu Moisan <radu.moisan@intel.com>
>> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> What caused my sign-off - or is it a hint that meta-oe/meta-systemd
> need alignment with this?
This patch is the meta-oe appends merged into oe-core - so yes once
this has been integrated the meta-oe and meta-systemd bbappends can be
removed.
Actually looking at the commit log, it appears that JaMa did the
important commit so credit to him should be given.
Ross
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] polkit: Enable systemd support
2013-02-01 9:47 ` Burton, Ross
@ 2013-02-01 9:49 ` Radu Moisan
0 siblings, 0 replies; 12+ messages in thread
From: Radu Moisan @ 2013-02-01 9:49 UTC (permalink / raw)
To: Burton, Ross; +Cc: openembedded-core
On 02/01/2013 11:47 AM, Burton, Ross wrote:
> On 1 February 2013 09:39, Andreas Müller <schnitzeltony@googlemail.com> wrote:
>> On Fri, Feb 1, 2013 at 10:22 AM, Radu Moisan <radu.moisan@intel.com> wrote:
>>> enable/disable support as relevant
>>>
>>> Signed-off-by: Radu Moisan <radu.moisan@intel.com>
>>> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
>> What caused my sign-off - or is it a hint that meta-oe/meta-systemd
>> need alignment with this?
> This patch is the meta-oe appends merged into oe-core - so yes once
> this has been integrated the meta-oe and meta-systemd bbappends can be
> removed.
>
> Actually looking at the commit log, it appears that JaMa did the
> important commit so credit to him should be given.
Noted.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] polkit: Enable systemd support
2013-02-01 9:22 [PATCH] polkit: Enable systemd support Radu Moisan
2013-02-01 9:39 ` Andreas Müller
@ 2013-02-01 9:44 ` Burton, Ross
2013-02-01 10:22 ` Radu Moisan
1 sibling, 1 reply; 12+ messages in thread
From: Burton, Ross @ 2013-02-01 9:44 UTC (permalink / raw)
To: Radu Moisan; +Cc: openembedded-core
On 1 February 2013 09:22, Radu Moisan <radu.moisan@intel.com> wrote:
> enable/disable support as relevant
Please write a more verbose comment, something along the lines of
"systemd is auto-detected unless disabled explicitly, potentially
contaminating sstate".
> +# there is no --enable/--disable option for consolekit and it's not picked by shlibs, so add it to DEPENDS
It's not picked up by shlibs because it's a dbus call not a library
call, and that's *RDEPENDS* not depends.
Ross
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] polkit: Enable systemd support
2013-02-01 9:44 ` Burton, Ross
@ 2013-02-01 10:22 ` Radu Moisan
2013-02-01 10:26 ` Martin Jansa
2013-02-01 10:27 ` Burton, Ross
0 siblings, 2 replies; 12+ messages in thread
From: Radu Moisan @ 2013-02-01 10:22 UTC (permalink / raw)
To: Burton, Ross; +Cc: openembedded-core
On 02/01/2013 11:44 AM, Burton, Ross wrote:
> On 1 February 2013 09:22, Radu Moisan <radu.moisan@intel.com> wrote:
>> enable/disable support as relevant
> Please write a more verbose comment, something along the lines of
> "systemd is auto-detected unless disabled explicitly, potentially
> contaminating sstate".
>
>> +# there is no --enable/--disable option for consolekit and it's not picked by shlibs, so add it to DEPENDS
> It's not picked up by shlibs because it's a dbus call not a library
> call, and that's *RDEPENDS* not depends.
I did change that manually because I assumed it was a typo. However it
make sense to add consolekit as a runtime dependency, but the
documentation specifically says PACKAGECONFIG will add to DEPENDS. How
is it different in this patch? The PACKAGECONFIG[systemd] is clearly
specifying a build time dependency, why the PACKAGECONFIG[consolekit] is
specifying a runtime dependency? How can I discriminate in this context?
Radu
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] polkit: Enable systemd support
2013-02-01 10:22 ` Radu Moisan
@ 2013-02-01 10:26 ` Martin Jansa
2013-02-01 10:27 ` Burton, Ross
1 sibling, 0 replies; 12+ messages in thread
From: Martin Jansa @ 2013-02-01 10:26 UTC (permalink / raw)
To: Radu Moisan; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1213 bytes --]
On Fri, Feb 01, 2013 at 12:22:01PM +0200, Radu Moisan wrote:
>
> On 02/01/2013 11:44 AM, Burton, Ross wrote:
> > On 1 February 2013 09:22, Radu Moisan <radu.moisan@intel.com> wrote:
> >> enable/disable support as relevant
> > Please write a more verbose comment, something along the lines of
> > "systemd is auto-detected unless disabled explicitly, potentially
> > contaminating sstate".
> >
> >> +# there is no --enable/--disable option for consolekit and it's not picked by shlibs, so add it to DEPENDS
> > It's not picked up by shlibs because it's a dbus call not a library
> > call, and that's *RDEPENDS* not depends.
>
> I did change that manually because I assumed it was a typo. However it
> make sense to add consolekit as a runtime dependency, but the
> documentation specifically says PACKAGECONFIG will add to DEPENDS. How
> is it different in this patch? The PACKAGECONFIG[systemd] is clearly
> specifying a build time dependency, why the PACKAGECONFIG[consolekit] is
> specifying a runtime dependency? How can I discriminate in this context?
3rd (DEPENDS) or 4th (RDEPENDS) parameter is the key difference.
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] polkit: Enable systemd support
2013-02-01 10:22 ` Radu Moisan
2013-02-01 10:26 ` Martin Jansa
@ 2013-02-01 10:27 ` Burton, Ross
2013-02-01 11:40 ` Radu Moisan
1 sibling, 1 reply; 12+ messages in thread
From: Burton, Ross @ 2013-02-01 10:27 UTC (permalink / raw)
To: Radu Moisan; +Cc: openembedded-core
On 1 February 2013 10:22, Radu Moisan <radu.moisan@intel.com> wrote:
> I did change that manually because I assumed it was a typo. However it make
> sense to add consolekit as a runtime dependency, but the documentation
> specifically says PACKAGECONFIG will add to DEPENDS. How is it different in
> this patch? The PACKAGECONFIG[systemd] is clearly specifying a build time
> dependency, why the PACKAGECONFIG[consolekit] is specifying a runtime
> dependency? How can I discriminate in this context?
I spoke to Radu online already, but I'll repeat again here in case
anyone else is confused by PACKAGECONFIG.
The latest documentation is here:
http://www.yoctoproject.org/docs/latest/ref-manual/ref-manual.html#var-P
The key point is that the 3rd argument is DEPENDS, and the fourth is
RDEPENDS. Many instances of PACKAGECONFIG will leave out the fourth,
but in this case the third is empty (note the extra commas) so
consolekit is added as a runtime dependency.
Ross
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] polkit: Enable systemd support
2013-02-01 10:27 ` Burton, Ross
@ 2013-02-01 11:40 ` Radu Moisan
0 siblings, 0 replies; 12+ messages in thread
From: Radu Moisan @ 2013-02-01 11:40 UTC (permalink / raw)
To: Burton, Ross; +Cc: openembedded-core
On 02/01/2013 12:27 PM, Burton, Ross wrote:
> On 1 February 2013 10:22, Radu Moisan <radu.moisan@intel.com> wrote:
>> I did change that manually because I assumed it was a typo. However it make
>> sense to add consolekit as a runtime dependency, but the documentation
>> specifically says PACKAGECONFIG will add to DEPENDS. How is it different in
>> this patch? The PACKAGECONFIG[systemd] is clearly specifying a build time
>> dependency, why the PACKAGECONFIG[consolekit] is specifying a runtime
>> dependency? How can I discriminate in this context?
> I spoke to Radu online already, but I'll repeat again here in case
> anyone else is confused by PACKAGECONFIG.
>
> The latest documentation is here:
> http://www.yoctoproject.org/docs/latest/ref-manual/ref-manual.html#var-P
>
> The key point is that the 3rd argument is DEPENDS, and the fourth is
> RDEPENDS. Many instances of PACKAGECONFIG will leave out the fourth,
> but in this case the third is empty (note the extra commas) so
> consolekit is added as a runtime dependency.
>
> Ross
Thanks guys for the clarification. Very useful info, I didn't notice the
extra comma.
Radu
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] polkit: Enable systemd support
@ 2013-02-01 11:37 Radu Moisan
2013-02-01 12:04 ` Burton, Ross
0 siblings, 1 reply; 12+ messages in thread
From: Radu Moisan @ 2013-02-01 11:37 UTC (permalink / raw)
To: openembedded-core
By default the polkit will autodetect if systemd is available
and setup the configuraton accordingly, potentially
contaminating sstate.
In this patch systemd is explicitly enabled/disabled.
When enabled, polkit will use systemd for session tarcking,
otherwise it will use ConsoleKit.
Signed-off-by: Radu Moisan <radu.moisan@intel.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
meta/recipes-extended/polkit/polkit_0.104.bb | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-extended/polkit/polkit_0.104.bb b/meta/recipes-extended/polkit/polkit_0.104.bb
index 2c0aaca..ab2547b 100644
--- a/meta/recipes-extended/polkit/polkit_0.104.bb
+++ b/meta/recipes-extended/polkit/polkit_0.104.bb
@@ -7,8 +7,13 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=155db86cdbafa7532b41f390409283eb \
DEPENDS = "expat glib-2.0 intltool-native gobject-introspection-stub"
-PACKAGECONFIG = "${@base_contains('DISTRO_FEATURES', 'pam', 'pam', '', d)}"
+PACKAGECONFIG = "${@base_contains('DISTRO_FEATURES', 'pam', 'pam', '', d)} \
+ ${@base_contains('DISTRO_FEATURES','systemd','systemd','consolekit',d)}"
+
PACKAGECONFIG[pam] = "--with-authfw=pam,--with-authfw=shadow,libpam,libpam"
+PACKAGECONFIG[systemd] = "--enable-systemd,--disable-systemd,systemd"
+# there is no --enable/--disable option for consolekit and it's not picked by shlibs, so add it to RDEPENDS
+PACKAGECONFIG[consolekit] = ",,,consolekit"
PR = "r9"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH] polkit: Enable systemd support
2013-02-01 11:37 Radu Moisan
@ 2013-02-01 12:04 ` Burton, Ross
0 siblings, 0 replies; 12+ messages in thread
From: Burton, Ross @ 2013-02-01 12:04 UTC (permalink / raw)
To: Radu Moisan; +Cc: openembedded-core
On 1 February 2013 11:37, Radu Moisan <radu.moisan@intel.com> wrote:
> By default the polkit will autodetect if systemd is available
> and setup the configuraton accordingly, potentially
> contaminating sstate.
> In this patch systemd is explicitly enabled/disabled.
> When enabled, polkit will use systemd for session tarcking,
> otherwise it will use ConsoleKit.
>
> Signed-off-by: Radu Moisan <radu.moisan@intel.com>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Acked-by: Ross Burton <ross.burton@intel.com>
Ross
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2013-02-01 12:20 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-01 9:22 [PATCH] polkit: Enable systemd support Radu Moisan
2013-02-01 9:39 ` Andreas Müller
2013-02-01 9:46 ` Radu Moisan
2013-02-01 9:47 ` Burton, Ross
2013-02-01 9:49 ` Radu Moisan
2013-02-01 9:44 ` Burton, Ross
2013-02-01 10:22 ` Radu Moisan
2013-02-01 10:26 ` Martin Jansa
2013-02-01 10:27 ` Burton, Ross
2013-02-01 11:40 ` Radu Moisan
-- strict thread matches above, loose matches on Subject: below --
2013-02-01 11:37 Radu Moisan
2013-02-01 12:04 ` Burton, Ross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox