From: Darren Hart <dvhart@linux.intel.com>
To: Robert Yang <liezhi.yang@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 4/7] mkdebugfs.sh: convert the tab to 4 spaces
Date: Tue, 26 Feb 2013 14:59:36 -0800 [thread overview]
Message-ID: <512D3E58.1030905@linux.intel.com> (raw)
In-Reply-To: <04ccee436225f0a27f74cb9e7cb7b94b3796c965.1361862860.git.liezhi.yang@windriver.com>
And NACK on this one :-)
Shell scripts should use tabs.
--
Darren
On 02/26/2013 01:24 AM, Robert Yang wrote:
> [YOCTO #3848]
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
> .../e2fsprogs/e2fsprogs/mkdebugfs.sh | 74 +++++++++++-----------
> 1 file changed, 37 insertions(+), 37 deletions(-)
>
> diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs/mkdebugfs.sh b/meta/recipes-devtools/e2fsprogs/e2fsprogs/mkdebugfs.sh
> index 5dfa380..41a13cb 100644
> --- a/meta/recipes-devtools/e2fsprogs/e2fsprogs/mkdebugfs.sh
> +++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs/mkdebugfs.sh
> @@ -6,44 +6,44 @@ DEBUGFS="debugfs/debugfs"
> yes | mkfs.ext4 test.img
>
> {
> - CWD="/"
> - find $SRCDIR | while read FILE; do
> - #TGT=${FILE#$SRCDIR}
> - TGT=$(basename "${FILE#$SRCDIR}")
> - DIR=$(dirname "${FILE#$SRCDIR}")
> + CWD="/"
> + find $SRCDIR | while read FILE; do
> + #TGT=${FILE#$SRCDIR}
> + TGT=$(basename "${FILE#$SRCDIR}")
> + DIR=$(dirname "${FILE#$SRCDIR}")
>
> - # Skip the root dir
> - if [ -z "$TGT" ]; then
> - continue
> - fi
> + # Skip the root dir
> + if [ -z "$TGT" ]; then
> + continue
> + fi
>
> - if [ "$DIR" != "$CWD" ]; then
> - echo "cd $DIR"
> - CWD="$DIR"
> - fi
> + if [ "$DIR" != "$CWD" ]; then
> + echo "cd $DIR"
> + CWD="$DIR"
> + fi
>
> - case $(stat -c "%F" $FILE) in
> - "directory")
> - echo "mkdir $TGT"
> - ;;
> - "regular file")
> - echo "write $FILE $TGT"
> - ;;
> - "symbolic link")
> - LINK_TGT=$(ls -l $FILE | sed -e 's/.*-> //')
> - echo "symlink $TGT $LINK_TGT"
> - ;;
> - "block special file")
> - DEVNO=$(stat -c "%t %T" $FILE)
> - echo "mknod $TGT b $DEVNO"
> - ;;
> - "character special file")
> - DEVNO=$(stat -c "%t %T" $FILE)
> - echo "mknod $TGT c $DEVNO"
> - ;;
> - *)
> - echo "Unknown file $FILE" 1>&2
> - ;;
> - esac
> - done
> + case $(stat -c "%F" $FILE) in
> + "directory")
> + echo "mkdir $TGT"
> + ;;
> + "regular file")
> + echo "write $FILE $TGT"
> + ;;
> + "symbolic link")
> + LINK_TGT=$(ls -l $FILE | sed -e 's/.*-> //')
> + echo "symlink $TGT $LINK_TGT"
> + ;;
> + "block special file")
> + DEVNO=$(stat -c "%t %T" $FILE)
> + echo "mknod $TGT b $DEVNO"
> + ;;
> + "character special file")
> + DEVNO=$(stat -c "%t %T" $FILE)
> + echo "mknod $TGT c $DEVNO"
> + ;;
> + *)
> + echo "Unknown file $FILE" 1>&2
> + ;;
> + esac
> + done
> } | $DEBUGFS -w -f /dev/stdin $DEVICE
>
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel
next prev parent reply other threads:[~2013-02-26 23:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 9:24 [PATCH 0/7] Create ext* filesystems using debugfs Robert Yang
2013-02-26 9:24 ` [PATCH 1/7] e2fsprogs: upgrade to the git version (rename only) Robert Yang
2013-02-26 9:24 ` [PATCH 2/7] e2fsprogs: upgrade to the git version Robert Yang
2013-02-26 9:24 ` [PATCH 3/7] e2fsprogs: add the original mkdebugfs.sh Robert Yang
2013-02-26 9:24 ` [PATCH 4/7] mkdebugfs.sh: convert the tab to 4 spaces Robert Yang
2013-02-26 22:59 ` Darren Hart [this message]
2013-02-26 9:24 ` [PATCH 5/7] mkdebugfs.sh: several fixes Robert Yang
2013-02-26 17:43 ` Trevor Woerner
2013-02-26 21:50 ` Darren Hart
2013-02-26 9:24 ` [PATCH 6/7] e2fsprogs: ship mkfsdebug.sh Robert Yang
2013-02-26 21:49 ` Darren Hart
2013-02-26 9:24 ` [PATCH 7/7] image_types.bbclass: replace genext2fs with mkdebugfs.sh Robert Yang
2013-02-26 17:53 ` [PATCH 0/7] Create ext* filesystems using debugfs Trevor Woerner
2013-02-26 21:52 ` Darren Hart
2013-02-26 22:37 ` Trevor Woerner
2013-02-26 23:00 ` Darren Hart
2013-02-26 23:01 ` Trevor Woerner
2013-02-26 17:55 ` Saul Wold
2013-02-26 21:58 ` Darren Hart
2013-02-26 18:15 ` Phil Blundell
2013-02-26 22:03 ` Darren Hart
2013-02-27 2:25 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512D3E58.1030905@linux.intel.com \
--to=dvhart@linux.intel.com \
--cc=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox