* [PATCH 0/2] Rename mesa-dri recipe to mesa
@ 2013-03-05 14:38 Laurentiu Palcu
2013-03-05 14:38 ` [PATCH 1/2] mesa: rename mesa-dri recipe to just mesa Laurentiu Palcu
2013-03-05 14:38 ` [PATCH 2/2] Replace references to mesa-dri with mesa in all files Laurentiu Palcu
0 siblings, 2 replies; 6+ messages in thread
From: Laurentiu Palcu @ 2013-03-05 14:38 UTC (permalink / raw)
To: openembedded-core
Hi all,
This patchset will rename the "mesa-dri" recipe to "mesa" and will replace
all occurences to mesa-dri in recipes/configs.
The changes and the upgrade path were tested on qemux86 and on an atom-pc
ideapad s10-3t. No issues observed.
For more info, as to why this was needed, go here:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=3385
Thanks,
Laurentiu
Laurentiu Palcu (2):
mesa: rename mesa-dri recipe to just mesa
Replace references to mesa-dri with mesa in all files
meta-yocto-bsp/conf/machine/atom-pc.conf | 2 +-
meta/conf/distro/include/default-providers.inc | 6 +++---
meta/conf/machine/include/ia32-base.inc | 4 ++--
meta/conf/machine/include/qemu.inc | 8 ++++----
meta/conf/machine/qemux86-64.conf | 8 ++++----
meta/conf/machine/qemux86.conf | 8 ++++----
meta/recipes-graphics/mesa/libglu_9.0.0.bb | 2 +-
meta/recipes-graphics/mesa/mesa-common.inc | 4 ++--
.../mesa/{mesa-dri.inc => mesa.inc} | 11 ++++++++---
.../mesa/{mesa-dri_9.0.2.bb => mesa_9.0.2.bb} | 2 +-
.../mesa/{mesa-dri_git.bb => mesa_git.bb} | 4 ++--
meta/recipes-graphics/wayland/weston_1.0.3.bb | 6 +++---
.../recipes-graphics/xorg-xserver/xserver-xorg.inc | 2 +-
.../arch/i386/conf/machine/{{=machine}}.conf | 2 +-
.../arch/qemu/conf/machine/{{=machine}}.conf | 8 ++++----
15 files changed, 41 insertions(+), 36 deletions(-)
rename meta/recipes-graphics/mesa/{mesa-dri.inc => mesa.inc} (65%)
rename meta/recipes-graphics/mesa/{mesa-dri_9.0.2.bb => mesa_9.0.2.bb} (75%)
rename meta/recipes-graphics/mesa/{mesa-dri_git.bb => mesa_git.bb} (39%)
--
1.7.9.5
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] mesa: rename mesa-dri recipe to just mesa
2013-03-05 14:38 [PATCH 0/2] Rename mesa-dri recipe to mesa Laurentiu Palcu
@ 2013-03-05 14:38 ` Laurentiu Palcu
2013-03-05 14:50 ` Phil Blundell
2013-03-05 14:38 ` [PATCH 2/2] Replace references to mesa-dri with mesa in all files Laurentiu Palcu
1 sibling, 1 reply; 6+ messages in thread
From: Laurentiu Palcu @ 2013-03-05 14:38 UTC (permalink / raw)
To: openembedded-core
[YOCTO #3385]
Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
---
meta/recipes-graphics/mesa/libglu_9.0.0.bb | 2 +-
meta/recipes-graphics/mesa/mesa-common.inc | 4 ++--
.../mesa/{mesa-dri.inc => mesa.inc} | 11 ++++++++---
.../mesa/{mesa-dri_9.0.2.bb => mesa_9.0.2.bb} | 2 +-
.../mesa/{mesa-dri_git.bb => mesa_git.bb} | 4 ++--
5 files changed, 14 insertions(+), 9 deletions(-)
rename meta/recipes-graphics/mesa/{mesa-dri.inc => mesa.inc} (65%)
rename meta/recipes-graphics/mesa/{mesa-dri_9.0.2.bb => mesa_9.0.2.bb} (75%)
rename meta/recipes-graphics/mesa/{mesa-dri_git.bb => mesa_git.bb} (39%)
diff --git a/meta/recipes-graphics/mesa/libglu_9.0.0.bb b/meta/recipes-graphics/mesa/libglu_9.0.0.bb
index 7980749..06d30f9 100644
--- a/meta/recipes-graphics/mesa/libglu_9.0.0.bb
+++ b/meta/recipes-graphics/mesa/libglu_9.0.0.bb
@@ -8,7 +8,7 @@ LICENSE = "MIT"
LIC_FILES_CHKSUM = "file://include/GL/glu.h;endline=29;md5=6b79c570f644363b356456e7d44471d9 \
file://src/libtess/tess.c;endline=29;md5=6b79c570f644363b356456e7d44471d9"
-# Epoch as this used to be part of mesa-dri
+# Epoch as this used to be part of mesa
PE = "2"
PR = "0"
diff --git a/meta/recipes-graphics/mesa/mesa-common.inc b/meta/recipes-graphics/mesa/mesa-common.inc
index 1ff08fb..bedaafb 100644
--- a/meta/recipes-graphics/mesa/mesa-common.inc
+++ b/meta/recipes-graphics/mesa/mesa-common.inc
@@ -18,7 +18,7 @@ DEPENDS = "expat makedepend-native flex-native bison-native"
PROVIDES = "virtual/libgl virtual/libgles1 virtual/libgles2 virtual/egl"
-# for mesa-dri and mesa-xlib
+# for mesa and mesa-xlib
FILESEXTRAPATHS_append := "${THISDIR}/mesa:"
inherit autotools pkgconfig pythonnative
@@ -41,7 +41,7 @@ PACKAGECONFIG[wayland] = ",,wayland"
# Multiple virtual/gl providers being built breaks staging
EXCLUDE_FROM_WORLD = "1"
-# Remove the mesa-dri dependency on mesa-dri-dev, as mesa-dri is empty
+# Remove the mesa dependency on mesa-dev, as mesa is empty
RDEPENDS_${PN}-dev = ""
PACKAGES =+ "libegl-mesa libegl-mesa-dev \
diff --git a/meta/recipes-graphics/mesa/mesa-dri.inc b/meta/recipes-graphics/mesa/mesa.inc
similarity index 65%
rename from meta/recipes-graphics/mesa/mesa-dri.inc
rename to meta/recipes-graphics/mesa/mesa.inc
index e43150b..a692bb7 100644
--- a/meta/recipes-graphics/mesa/mesa-dri.inc
+++ b/meta/recipes-graphics/mesa/mesa.inc
@@ -18,11 +18,16 @@ PACKAGECONFIG[egl] = "--enable-egl --with-egl-platforms=${EGL_PLATFORMS}, --disa
python populate_packages_prepend() {
dri_drivers_root = os.path.join(d.getVar('libdir', True), "dri")
-
- do_split_packages(d, dri_drivers_root, '^(.*)_dri\.so$', 'mesa-dri-driver-%s', 'Mesa %s DRI driver', extra_depends='')
+
+ pkgs = ['mesa', 'mesa-dev', 'mesa-dbg']
+ pkgs += do_split_packages(d, dri_drivers_root, '^(.*)_dri\.so$', 'mesa-driver-%s', 'Mesa %s DRI driver', extra_depends='')
+ for pkg in pkgs:
+ d.setVar("RPROVIDES_%s" % pkg, pkg.replace("mesa-", "mesa-dri-"))
+ d.setVar("RCONFLICTS_%s" % pkg, pkg.replace("mesa-", "mesa-dri-"))
+ d.setVar("RREPLACES_%s" % pkg, pkg.replace("mesa-", "mesa-dri-"))
}
-PACKAGES_DYNAMIC += "^mesa-dri-driver-.*"
+PACKAGES_DYNAMIC += "^mesa-driver-.*"
FILES_${PN}-dbg += "${libdir}/dri/.debug/*"
diff --git a/meta/recipes-graphics/mesa/mesa-dri_9.0.2.bb b/meta/recipes-graphics/mesa/mesa_9.0.2.bb
similarity index 75%
rename from meta/recipes-graphics/mesa/mesa-dri_9.0.2.bb
rename to meta/recipes-graphics/mesa/mesa_9.0.2.bb
index 26b56e4..1a1bf24 100644
--- a/meta/recipes-graphics/mesa/mesa-dri_9.0.2.bb
+++ b/meta/recipes-graphics/mesa/mesa_9.0.2.bb
@@ -1,4 +1,4 @@
require mesa-common.inc
require mesa-${PV}.inc
-require mesa-dri.inc
+require mesa.inc
PR = "${INC_PR}.0"
diff --git a/meta/recipes-graphics/mesa/mesa-dri_git.bb b/meta/recipes-graphics/mesa/mesa_git.bb
similarity index 39%
rename from meta/recipes-graphics/mesa/mesa-dri_git.bb
rename to meta/recipes-graphics/mesa/mesa_git.bb
index 69a433e..aca4df8 100644
--- a/meta/recipes-graphics/mesa/mesa-dri_git.bb
+++ b/meta/recipes-graphics/mesa/mesa_git.bb
@@ -1,8 +1,8 @@
require mesa-common.inc
require mesa-git.inc
-require mesa-dri.inc
+require mesa.inc
-# this needs to be lower than -1 because all mesa-dri have -1 and git version has highest PV, but shouldn't be default
+# this needs to be lower than -1 because all mesa have -1 and git version has highest PV, but shouldn't be default
DEFAULT_PREFERENCE = "-2"
PR = "${INC_PR}.0"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] Replace references to mesa-dri with mesa in all files
2013-03-05 14:38 [PATCH 0/2] Rename mesa-dri recipe to mesa Laurentiu Palcu
2013-03-05 14:38 ` [PATCH 1/2] mesa: rename mesa-dri recipe to just mesa Laurentiu Palcu
@ 2013-03-05 14:38 ` Laurentiu Palcu
1 sibling, 0 replies; 6+ messages in thread
From: Laurentiu Palcu @ 2013-03-05 14:38 UTC (permalink / raw)
To: openembedded-core
[YOCTO #3385]
Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
---
meta-yocto-bsp/conf/machine/atom-pc.conf | 2 +-
meta/conf/distro/include/default-providers.inc | 6 +++---
meta/conf/machine/include/ia32-base.inc | 4 ++--
meta/conf/machine/include/qemu.inc | 8 ++++----
meta/conf/machine/qemux86-64.conf | 8 ++++----
meta/conf/machine/qemux86.conf | 8 ++++----
meta/recipes-graphics/wayland/weston_1.0.3.bb | 6 +++---
.../recipes-graphics/xorg-xserver/xserver-xorg.inc | 2 +-
.../arch/i386/conf/machine/{{=machine}}.conf | 2 +-
.../arch/qemu/conf/machine/{{=machine}}.conf | 8 ++++----
10 files changed, 27 insertions(+), 27 deletions(-)
diff --git a/meta-yocto-bsp/conf/machine/atom-pc.conf b/meta-yocto-bsp/conf/machine/atom-pc.conf
index e97b173..b1c2ae1 100644
--- a/meta-yocto-bsp/conf/machine/atom-pc.conf
+++ b/meta-yocto-bsp/conf/machine/atom-pc.conf
@@ -19,7 +19,7 @@ XSERVER ?= "xserver-xorg \
xf86-input-evdev \
xf86-input-synaptics \
xf86-video-intel \
- mesa-dri-driver-i915"
+ mesa-driver-i915"
#MACHINE_EXTRA_RDEPENDS = "rt2860"
diff --git a/meta/conf/distro/include/default-providers.inc b/meta/conf/distro/include/default-providers.inc
index ebf2a09..39ce7cc 100644
--- a/meta/conf/distro/include/default-providers.inc
+++ b/meta/conf/distro/include/default-providers.inc
@@ -5,9 +5,9 @@ PREFERRED_PROVIDER_virtual/db ?= "db"
PREFERRED_PROVIDER_virtual/db-native ?= "db-native"
PREFERRED_PROVIDER_virtual/xserver ?= "xserver-xorg"
PREFERRED_PROVIDER_virtual/xserver-xf86 ?= "xserver-xorg"
-PREFERRED_PROVIDER_virtual/libgl ?= "mesa-dri"
-PREFERRED_PROVIDER_virtual/libgles1 ?= "mesa-dri"
-PREFERRED_PROVIDER_virtual/libgles2 ?= "mesa-dri"
+PREFERRED_PROVIDER_virtual/libgl ?= "mesa"
+PREFERRED_PROVIDER_virtual/libgles1 ?= "mesa"
+PREFERRED_PROVIDER_virtual/libgles2 ?= "mesa"
PREFERRED_PROVIDER_virtual/update-alternatives ?= "opkg"
PREFERRED_PROVIDER_virtual/update-alternatives-native ?= "opkg-native"
PREFERRED_PROVIDER_virtual/libx11 ?= "libx11"
diff --git a/meta/conf/machine/include/ia32-base.inc b/meta/conf/machine/include/ia32-base.inc
index 0798bf8..921c740 100644
--- a/meta/conf/machine/include/ia32-base.inc
+++ b/meta/conf/machine/include/ia32-base.inc
@@ -39,11 +39,11 @@ XSERVER_IA32_EXT = " \
"
XSERVER_IA32_I915 = "xf86-video-intel \
- mesa-dri-driver-i915 \
+ mesa-driver-i915 \
"
XSERVER_IA32_I965 = "xf86-video-intel \
- mesa-dri-driver-i965 \
+ mesa-driver-i965 \
"
XSERVER_IA32_VESA = "xf86-video-vesa"
diff --git a/meta/conf/machine/include/qemu.inc b/meta/conf/machine/include/qemu.inc
index 52215b3..29caec9 100644
--- a/meta/conf/machine/include/qemu.inc
+++ b/meta/conf/machine/include/qemu.inc
@@ -1,10 +1,10 @@
PREFERRED_PROVIDER_virtual/xserver ?= "xserver-xorg"
-PREFERRED_PROVIDER_virtual/libgl ?= "mesa-dri"
-PREFERRED_PROVIDER_virtual/libgles1 ?= "mesa-dri"
-PREFERRED_PROVIDER_virtual/libgles2 ?= "mesa-dri"
+PREFERRED_PROVIDER_virtual/libgl ?= "mesa"
+PREFERRED_PROVIDER_virtual/libgles1 ?= "mesa"
+PREFERRED_PROVIDER_virtual/libgles2 ?= "mesa"
XSERVER ?= "xserver-xorg \
- mesa-dri-driver-swrast \
+ mesa-driver-swrast \
xf86-input-evdev \
xf86-input-mouse \
xf86-video-fbdev \
diff --git a/meta/conf/machine/qemux86-64.conf b/meta/conf/machine/qemux86-64.conf
index 3852b89..23a7108 100644
--- a/meta/conf/machine/qemux86-64.conf
+++ b/meta/conf/machine/qemux86-64.conf
@@ -3,9 +3,9 @@
#@DESCRIPTION: Machine configuration for running a common x86
PREFERRED_PROVIDER_virtual/xserver ?= "xserver-xorg"
-PREFERRED_PROVIDER_virtual/libgl ?= "mesa-dri"
-PREFERRED_PROVIDER_virtual/libgles1 ?= "mesa-dri"
-PREFERRED_PROVIDER_virtual/libgles2 ?= "mesa-dri"
+PREFERRED_PROVIDER_virtual/libgl ?= "mesa"
+PREFERRED_PROVIDER_virtual/libgles1 ?= "mesa"
+PREFERRED_PROVIDER_virtual/libgles2 ?= "mesa"
require conf/machine/include/tune-x86_64.inc
@@ -14,7 +14,7 @@ KERNEL_IMAGETYPE = "bzImage"
SERIAL_CONSOLE = "115200 ttyS0"
XSERVER ?= "xserver-xorg \
- mesa-dri-driver-swrast \
+ mesa-driver-swrast \
xf86-input-vmmouse \
xf86-input-keyboard \
xf86-input-evdev \
diff --git a/meta/conf/machine/qemux86.conf b/meta/conf/machine/qemux86.conf
index ee14bec..d13dc84 100644
--- a/meta/conf/machine/qemux86.conf
+++ b/meta/conf/machine/qemux86.conf
@@ -3,9 +3,9 @@
#@DESCRIPTION: Machine configuration for running a common x86
PREFERRED_PROVIDER_virtual/xserver ?= "xserver-xorg"
-PREFERRED_PROVIDER_virtual/libgl ?= "mesa-dri"
-PREFERRED_PROVIDER_virtual/libgles1 ?= "mesa-dri"
-PREFERRED_PROVIDER_virtual/libgles2 ?= "mesa-dri"
+PREFERRED_PROVIDER_virtual/libgl ?= "mesa"
+PREFERRED_PROVIDER_virtual/libgles1 ?= "mesa"
+PREFERRED_PROVIDER_virtual/libgles2 ?= "mesa"
require conf/machine/include/tune-i586.inc
@@ -14,7 +14,7 @@ KERNEL_IMAGETYPE = "bzImage"
SERIAL_CONSOLE = "115200 ttyS0"
XSERVER ?= "xserver-xorg \
- mesa-dri-driver-swrast \
+ mesa-driver-swrast \
xf86-input-vmmouse \
xf86-input-keyboard \
xf86-input-evdev \
diff --git a/meta/recipes-graphics/wayland/weston_1.0.3.bb b/meta/recipes-graphics/wayland/weston_1.0.3.bb
index afe8235..f769312 100644
--- a/meta/recipes-graphics/wayland/weston_1.0.3.bb
+++ b/meta/recipes-graphics/wayland/weston_1.0.3.bb
@@ -14,7 +14,7 @@ SRC_URI[sha256sum] = "3136a7d2f654ea3e946d4217f7e25321248ad2921f1f4e2504dda58968
inherit autotools pkgconfig
DEPENDS = "libxkbcommon gdk-pixbuf pixman cairo glib-2.0 mtdev jpeg"
-DEPENDS += "wayland mesa-dri virtual/egl"
+DEPENDS += "wayland mesa virtual/egl"
EXTRA_OECONF = "--disable-android-compositor --enable-setuid-install"
EXTRA_OECONF += "--disable-tablet-shell --disable-xwayland"
@@ -25,9 +25,9 @@ PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'wayland', 'kms wayland',
${@base_contains('DISTRO_FEATURES', 'opengles2', 'gles', '', d)} \
"
# Weston on KMS
-PACKAGECONFIG[kms] = "--enable-drm-compositor --enable-weston-launch,--disable-drm-compositor --disable-weston-launch,drm udev mesa-dri libpam"
+PACKAGECONFIG[kms] = "--enable-drm-compositor --enable-weston-launch,--disable-drm-compositor --disable-weston-launch,drm udev mesa libpam"
# Weston on Wayland (nested Weston)
-PACKAGECONFIG[wayland] = "--enable-wayland-compositor,--disable-wayland-compositor,mesa-dri"
+PACKAGECONFIG[wayland] = "--enable-wayland-compositor,--disable-wayland-compositor,mesa"
# Weston on X11
PACKAGECONFIG[x11] = "--enable-x11-compositor,--disable-x11-compositor,virtual/libx11 libxcb libxcb libxcursor cairo"
diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg.inc b/meta/recipes-graphics/xorg-xserver/xserver-xorg.inc
index 5d5443c..795410b 100644
--- a/meta/recipes-graphics/xorg-xserver/xserver-xorg.inc
+++ b/meta/recipes-graphics/xorg-xserver/xserver-xorg.inc
@@ -126,7 +126,7 @@ PACKAGECONFIG ??= "udev ${@base_contains('DISTRO_FEATURES', 'opengl', 'glx', '',
PACKAGECONFIG[udev] = "--enable-config-udev,--disable-config-udev,udev"
PACKAGECONFIG[glx] = "--enable-dri --enable-dri2 --enable-glx --enable-glx-tls,\
--disable-dri --disable-dri2 --disable-glx,\
- xf86driproto dri2proto mesa-dri"
+ xf86driproto dri2proto mesa"
do_install_append () {
# Its assumed base-files creates this for us
diff --git a/scripts/lib/bsp/substrate/target/arch/i386/conf/machine/{{=machine}}.conf b/scripts/lib/bsp/substrate/target/arch/i386/conf/machine/{{=machine}}.conf
index 86d6a53..304382d 100644
--- a/scripts/lib/bsp/substrate/target/arch/i386/conf/machine/{{=machine}}.conf
+++ b/scripts/lib/bsp/substrate/target/arch/i386/conf/machine/{{=machine}}.conf
@@ -57,7 +57,7 @@ XSERVER ?= "${XSERVER_IA32_BASE} \
{{ if xserver == "y" and xserver_choice == "xserver_emgd": }}
PREFERRED_VERSION_xserver-xorg ?= "1.9.3"
-PREFERRED_VERSION_mesa-dri ?= "7.11"
+PREFERRED_VERSION_mesa ?= "7.11"
PREFERRED_VERSION_emgd-driver-bin ?= "1.14"
{{ if xserver == "y" and xserver_choice == "xserver_vesa" or xserver_choice == "xserver_emgd": }}
diff --git a/scripts/lib/bsp/substrate/target/arch/qemu/conf/machine/{{=machine}}.conf b/scripts/lib/bsp/substrate/target/arch/qemu/conf/machine/{{=machine}}.conf
index de3b279..e618c61 100644
--- a/scripts/lib/bsp/substrate/target/arch/qemu/conf/machine/{{=machine}}.conf
+++ b/scripts/lib/bsp/substrate/target/arch/qemu/conf/machine/{{=machine}}.conf
@@ -15,9 +15,9 @@ PREFERRED_VERSION_{{=preferred_kernel}} ?= "{{=preferred_kernel_version}}%"
{{ if qemuarch == "i386" or qemuarch == "x86_64": }}
PREFERRED_PROVIDER_virtual/xserver ?= "xserver-xorg"
-PREFERRED_PROVIDER_virtual/libgl ?= "mesa-dri"
-PREFERRED_PROVIDER_virtual/libgles1 ?= "mesa-dri"
-PREFERRED_PROVIDER_virtual/libgles2 ?= "mesa-dri"
+PREFERRED_PROVIDER_virtual/libgl ?= "mesa"
+PREFERRED_PROVIDER_virtual/libgles1 ?= "mesa"
+PREFERRED_PROVIDER_virtual/libgles2 ?= "mesa"
{{ input type:"choicelist" name:"qemuarch" prio:"5" msg:"Which qemu architecture would you like to use?" default:"i386" }}
{{ input type:"choice" val:"i386" msg:"i386 (32-bit)" }}
@@ -45,7 +45,7 @@ KERNEL_IMAGETYPE = "bzImage"
SERIAL_CONSOLE = "115200 ttyS0"
# We bypass swrast but we need it to be present for X to load correctly
XSERVER ?= "xserver-xorg \
- mesa-dri-driver-swrast \
+ mesa-driver-swrast \
xf86-input-vmmouse \
xf86-input-keyboard \
xf86-input-evdev \
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] mesa: rename mesa-dri recipe to just mesa
2013-03-05 14:38 ` [PATCH 1/2] mesa: rename mesa-dri recipe to just mesa Laurentiu Palcu
@ 2013-03-05 14:50 ` Phil Blundell
2013-03-05 15:00 ` Burton, Ross
0 siblings, 1 reply; 6+ messages in thread
From: Phil Blundell @ 2013-03-05 14:50 UTC (permalink / raw)
To: Laurentiu Palcu; +Cc: openembedded-core
On Tue, 2013-03-05 at 16:38 +0200, Laurentiu Palcu wrote:
> -# for mesa-dri and mesa-xlib
> +# for mesa and mesa-xlib
> FILESEXTRAPATHS_append := "${THISDIR}/mesa:"
Presumably you don't need that anymore.
> --- a/meta/recipes-graphics/mesa/mesa-dri_git.bb
> +++ b/meta/recipes-graphics/mesa/mesa_git.bb
> -# this needs to be lower than -1 because all mesa-dri have -1 and git version has highest PV, but shouldn't be default
> +# this needs to be lower than -1 because all mesa have -1 and git version has highest PV, but shouldn't be default
> DEFAULT_PREFERENCE = "-2"
Is that comment still true?
Also, the commit message for this patch is exceptionally terse. Please
explain why this renaming is a desirable thing.
thanks
p.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] mesa: rename mesa-dri recipe to just mesa
2013-03-05 14:50 ` Phil Blundell
@ 2013-03-05 15:00 ` Burton, Ross
2013-03-05 16:50 ` Laurentiu Palcu
0 siblings, 1 reply; 6+ messages in thread
From: Burton, Ross @ 2013-03-05 15:00 UTC (permalink / raw)
To: Phil Blundell; +Cc: openembedded-core
Man, Phil was quick today. I'll throw away my draft and reply to this
instead...
On 5 March 2013 14:50, Phil Blundell <pb@pbcl.net> wrote:
>> -# for mesa-dri and mesa-xlib
>> +# for mesa and mesa-xlib
>> FILESEXTRAPATHS_append := "${THISDIR}/mesa:"
>
> Presumably you don't need that anymore.
I thought I had this fixed a month ago, but obviously it didn't get
merged - probably lost in the ELC madness.
>> -# this needs to be lower than -1 because all mesa-dri have -1 and git version has highest PV, but shouldn't be default
>> +# this needs to be lower than -1 because all mesa have -1 and git version has highest PV, but shouldn't be default
>> DEFAULT_PREFERENCE = "-2"
>
> Is that comment still true?
I was just saying to Laurentiu off-list that only mesa_git should have
a preference of -1, as there isn't mesa-dri/mesa-xlib to complicate
matters anymore.
> Also, the commit message for this patch is exceptionally terse. Please
> explain why this renaming is a desirable thing.
It's desirable because "dri" is redundant, there isn't any
alternative. It's a build of mesa, so let's call it mesa.
Ross
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] mesa: rename mesa-dri recipe to just mesa
2013-03-05 15:00 ` Burton, Ross
@ 2013-03-05 16:50 ` Laurentiu Palcu
0 siblings, 0 replies; 6+ messages in thread
From: Laurentiu Palcu @ 2013-03-05 16:50 UTC (permalink / raw)
To: Burton, Ross; +Cc: openembedded-core
Thanks. I'll make the changes and resend. Also, I'll squash the commits
into a single one to be easily bisectable.
Laurentiu
On 03/05/2013 05:00 PM, Burton, Ross wrote:
> Man, Phil was quick today. I'll throw away my draft and reply to this
> instead...
>
> On 5 March 2013 14:50, Phil Blundell <pb@pbcl.net> wrote:
>>> -# for mesa-dri and mesa-xlib
>>> +# for mesa and mesa-xlib
>>> FILESEXTRAPATHS_append := "${THISDIR}/mesa:"
>>
>> Presumably you don't need that anymore.
>
> I thought I had this fixed a month ago, but obviously it didn't get
> merged - probably lost in the ELC madness.
>
>>> -# this needs to be lower than -1 because all mesa-dri have -1 and git version has highest PV, but shouldn't be default
>>> +# this needs to be lower than -1 because all mesa have -1 and git version has highest PV, but shouldn't be default
>>> DEFAULT_PREFERENCE = "-2"
>>
>> Is that comment still true?
>
> I was just saying to Laurentiu off-list that only mesa_git should have
> a preference of -1, as there isn't mesa-dri/mesa-xlib to complicate
> matters anymore.
>
>> Also, the commit message for this patch is exceptionally terse. Please
>> explain why this renaming is a desirable thing.
>
> It's desirable because "dri" is redundant, there isn't any
> alternative. It's a build of mesa, so let's call it mesa.
>
> Ross
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-03-05 17:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-05 14:38 [PATCH 0/2] Rename mesa-dri recipe to mesa Laurentiu Palcu
2013-03-05 14:38 ` [PATCH 1/2] mesa: rename mesa-dri recipe to just mesa Laurentiu Palcu
2013-03-05 14:50 ` Phil Blundell
2013-03-05 15:00 ` Burton, Ross
2013-03-05 16:50 ` Laurentiu Palcu
2013-03-05 14:38 ` [PATCH 2/2] Replace references to mesa-dri with mesa in all files Laurentiu Palcu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox