* [PATCH v3 1/3] qt-mobility: Add bluez dependency if DISTRO_FEATURES has bluetooth
2013-03-19 21:54 [PATCH v3 0/3] qt-mobility: improved recipe eu
@ 2013-03-19 21:54 ` eu
2013-03-19 21:54 ` [PATCH v3 2/3] qt-mobility: Add pulseaudio dependency if DISTRO_FEATURES has pulseaudio eu
2013-03-19 21:54 ` [PATCH v3 3/3] qt-mobility: added list of modules to be compiled eu
2 siblings, 0 replies; 10+ messages in thread
From: eu @ 2013-03-19 21:54 UTC (permalink / raw)
To: openembedded-core; +Cc: Felipe F. Tonello
From: "Felipe F. Tonello" <ftonello@cercacor.com>
Some modules doesn't requires bluez4 to compile. So it's unnecessary to have
it as dependency.
Signed-off-by: Felipe F. Tonello <ftonello@cercacor.com>
---
meta/recipes-qt/qt4/qt-mobility_1.2.0.inc | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc b/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
index 7778630..e5e671e 100644
--- a/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
+++ b/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
@@ -1,5 +1,6 @@
HOMEPAGE = "http://qt.nokia.com"
-DEPENDS += "pulseaudio bluez4"
+DEPENDS += "pulseaudio"
+DEPENDS += "${@base_contains('DISTRO_FEATURES', 'bluetooth', 'bluez4', '', d)}"
LICENSE = "LGPLv2.1"
LIC_FILES_CHKSUM = "file://LICENSE.LGPL;md5=fbc093901857fcd118f065f900982c24 \
@@ -30,6 +31,8 @@ qtm_plugins := "/usr/lib/${qtm_dir}/plugins/QtMobility"
qtm_data := "/usr/share/${qtm_dir}"
qtm_imports := "/usr/lib/${qtm_dir}/imports"
+qtm_bluezflag ?= "${@base_contains('DISTRO_FEATURES', 'bluetooth', 'yes', 'no', d)}"
+
do_configure_prepend() {
cp qtmobility.pro qtmobility.pro.old
sed -e 's@...QT_INSTALL_DATA.@${qtm_data}@' <qtmobility.pro.old >qtmobility.pro
@@ -49,7 +52,7 @@ do_configure_prepend() {
echo QT_MOBILITY_EXAMPLES = ${qtm_examples} >>./config.pri
echo QT_MOBILITY_DEMOS = ${qtm_demos} >>./config.pri
echo QT_CONFIG ${qtm_glflags} >>./config.pri
- echo bluez_enabled = yes >>./config.pri
+ echo bluez_enabled = ${qtm_bluezflag} >>./config.pri
echo ${qtm_extra_config} >>./config.pri
echo CONFIG += ${qtm_embedded} >>./config.pri
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v3 2/3] qt-mobility: Add pulseaudio dependency if DISTRO_FEATURES has pulseaudio
2013-03-19 21:54 [PATCH v3 0/3] qt-mobility: improved recipe eu
2013-03-19 21:54 ` [PATCH v3 1/3] qt-mobility: Add bluez dependency if DISTRO_FEATURES has bluetooth eu
@ 2013-03-19 21:54 ` eu
2013-03-20 14:04 ` Otavio Salvador
2013-03-19 21:54 ` [PATCH v3 3/3] qt-mobility: added list of modules to be compiled eu
2 siblings, 1 reply; 10+ messages in thread
From: eu @ 2013-03-19 21:54 UTC (permalink / raw)
To: openembedded-core; +Cc: Felipe F. Tonello
From: "Felipe F. Tonello" <ftonello@cercacor.com>
Signed-off-by: Felipe F. Tonello <ftonello@cercacor.com>
---
meta/recipes-qt/qt4/qt-mobility_1.2.0.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc b/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
index e5e671e..fca4cb0 100644
--- a/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
+++ b/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
@@ -1,5 +1,5 @@
HOMEPAGE = "http://qt.nokia.com"
-DEPENDS += "pulseaudio"
+DEPENDS += "${@base_contains('DISTRO_FEATURES', 'pulseaudio', 'pulseaudio', '', d)}"
DEPENDS += "${@base_contains('DISTRO_FEATURES', 'bluetooth', 'bluez4', '', d)}"
LICENSE = "LGPLv2.1"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v3 2/3] qt-mobility: Add pulseaudio dependency if DISTRO_FEATURES has pulseaudio
2013-03-19 21:54 ` [PATCH v3 2/3] qt-mobility: Add pulseaudio dependency if DISTRO_FEATURES has pulseaudio eu
@ 2013-03-20 14:04 ` Otavio Salvador
2013-03-20 14:56 ` Burton, Ross
0 siblings, 1 reply; 10+ messages in thread
From: Otavio Salvador @ 2013-03-20 14:04 UTC (permalink / raw)
To: eu@felipetonello.com
Cc: Felipe F. Tonello,
Patches and discussions about the oe-core layer
On Tue, Mar 19, 2013 at 6:54 PM, <eu@felipetonello.com> wrote:
> From: "Felipe F. Tonello" <ftonello@cercacor.com>
>
> Signed-off-by: Felipe F. Tonello <ftonello@cercacor.com>
> ---
> meta/recipes-qt/qt4/qt-mobility_1.2.0.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc b/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
> index e5e671e..fca4cb0 100644
> --- a/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
> +++ b/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
> @@ -1,5 +1,5 @@
> HOMEPAGE = "http://qt.nokia.com"
> -DEPENDS += "pulseaudio"
> +DEPENDS += "${@base_contains('DISTRO_FEATURES', 'pulseaudio', 'pulseaudio', '', d)}"
> DEPENDS += "${@base_contains('DISTRO_FEATURES', 'bluetooth', 'bluez4', '', d)}"
Is it possible to explicitly enable/disable pulseaudio support?
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v3 2/3] qt-mobility: Add pulseaudio dependency if DISTRO_FEATURES has pulseaudio
2013-03-20 14:04 ` Otavio Salvador
@ 2013-03-20 14:56 ` Burton, Ross
2013-03-20 15:04 ` Otavio Salvador
0 siblings, 1 reply; 10+ messages in thread
From: Burton, Ross @ 2013-03-20 14:56 UTC (permalink / raw)
To: Otavio Salvador
Cc: Felipe F. Tonello,
Patches and discussions about the oe-core layer
On 20 March 2013 14:04, Otavio Salvador <otavio@ossystems.com.br> wrote:
> Is it possible to explicitly enable/disable pulseaudio support?
Isn't PA one of those "all or nothing" options? If your system is
using PA then you want support for it everywhere, if it's not then you
don't want it present at all.
Ross
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 2/3] qt-mobility: Add pulseaudio dependency if DISTRO_FEATURES has pulseaudio
2013-03-20 14:56 ` Burton, Ross
@ 2013-03-20 15:04 ` Otavio Salvador
2013-03-20 15:08 ` Burton, Ross
0 siblings, 1 reply; 10+ messages in thread
From: Otavio Salvador @ 2013-03-20 15:04 UTC (permalink / raw)
To: Burton, Ross
Cc: Felipe F. Tonello,
Patches and discussions about the oe-core layer
On Wed, Mar 20, 2013 at 11:56 AM, Burton, Ross <ross.burton@intel.com> wrote:
> On 20 March 2013 14:04, Otavio Salvador <otavio@ossystems.com.br> wrote:
>> Is it possible to explicitly enable/disable pulseaudio support?
>
> Isn't PA one of those "all or nothing" options? If your system is
> using PA then you want support for it everywhere, if it's not then you
> don't want it present at all.
Yes but if we don't explicitly disable/enable it we risk to do a host
contamination (for example building for same host arch)
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3 3/3] qt-mobility: added list of modules to be compiled
2013-03-19 21:54 [PATCH v3 0/3] qt-mobility: improved recipe eu
2013-03-19 21:54 ` [PATCH v3 1/3] qt-mobility: Add bluez dependency if DISTRO_FEATURES has bluetooth eu
2013-03-19 21:54 ` [PATCH v3 2/3] qt-mobility: Add pulseaudio dependency if DISTRO_FEATURES has pulseaudio eu
@ 2013-03-19 21:54 ` eu
2013-03-20 18:12 ` Paul Eggleton
2 siblings, 1 reply; 10+ messages in thread
From: eu @ 2013-03-19 21:54 UTC (permalink / raw)
To: openembedded-core; +Cc: Felipe F. Tonello
From: "Felipe F. Tonello" <ftonello@cercacor.com>
This is useful for users that want to .bbappend this recipe to select specific
modules to be compiled.
Signed-off-by: Felipe F. Tonello <ftonello@cercacor.com>
---
meta/recipes-qt/qt4/qt-mobility_1.2.0.inc | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc b/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
index fca4cb0..b0ab613 100644
--- a/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
+++ b/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
@@ -18,7 +18,7 @@ SRC_URI = "http://get.qt.nokia.com/qt/add-ons/qt-mobility-opensource-src-${PV}.t
SRC_URI[md5sum]="ea5db5a8d3dd4709c2926dceda646bd8"
SRC_URI[sha256sum]="ee3c88975e04139ac9589f76d4be646d44fcbc4c8c1cf2db621abc154cf0ba44"
-PR = "r7"
+PR = "r8"
S = "${WORKDIR}/qt-mobility-opensource-src-${PV}"
@@ -31,6 +31,8 @@ qtm_plugins := "/usr/lib/${qtm_dir}/plugins/QtMobility"
qtm_data := "/usr/share/${qtm_dir}"
qtm_imports := "/usr/lib/${qtm_dir}/imports"
+qtm_modules_list ?= "bearer contacts gallery location publishsubscribe messaging multimedia \
+systeminfo serviceframework sensors versit organizer feedback connectivity"
qtm_bluezflag ?= "${@base_contains('DISTRO_FEATURES', 'bluetooth', 'yes', 'no', d)}"
do_configure_prepend() {
@@ -44,7 +46,7 @@ do_configure_prepend() {
cp staticconfig.pri staticconfig.pri.old
echo "include(${STAGING_DATADIR}/${qtm_dir}/mkspecs/qconfig.pri)" >staticconfig.pri
cat staticconfig.pri.old >>staticconfig.pri
- ./configure -qmake-exec qmake2 -prefix /usr -examples -demos
+ ./configure -qmake-exec qmake2 -prefix /usr -examples -demos -modules "${qtm_modules_list}"
echo QT_MOBILITY_BIN = ${qtm_bin} >>./config.pri
echo QT_MOBILITY_LIB = ${qtm_lib} >>./config.pri
echo QT_MOBILITY_INCLUDE = ${qtm_include} >>./config.pri
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v3 3/3] qt-mobility: added list of modules to be compiled
2013-03-19 21:54 ` [PATCH v3 3/3] qt-mobility: added list of modules to be compiled eu
@ 2013-03-20 18:12 ` Paul Eggleton
2013-03-20 18:31 ` Felipe Ferreri Tonello
0 siblings, 1 reply; 10+ messages in thread
From: Paul Eggleton @ 2013-03-20 18:12 UTC (permalink / raw)
To: eu; +Cc: Felipe F. Tonello, openembedded-core
Hi Felipe,
On Tuesday 19 March 2013 14:54:13 eu@felipetonello.com wrote:
> From: "Felipe F. Tonello" <ftonello@cercacor.com>
>
> This is useful for users that want to .bbappend this recipe to select
> specific modules to be compiled.
>
> Signed-off-by: Felipe F. Tonello <ftonello@cercacor.com>
> ---
> meta/recipes-qt/qt4/qt-mobility_1.2.0.inc | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
> b/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc index fca4cb0..b0ab613 100644
> --- a/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
> +++ b/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
> @@ -18,7 +18,7 @@ SRC_URI =
> "http://get.qt.nokia.com/qt/add-ons/qt-mobility-opensource-src-${PV}.t
> SRC_URI[md5sum]="ea5db5a8d3dd4709c2926dceda646bd8"
> SRC_URI[sha256sum]="ee3c88975e04139ac9589f76d4be646d44fcbc4c8c1cf2db621abc1
> 54cf0ba44"
>
> -PR = "r7"
> +PR = "r8"
>
> S = "${WORKDIR}/qt-mobility-opensource-src-${PV}"
>
> @@ -31,6 +31,8 @@ qtm_plugins := "/usr/lib/${qtm_dir}/plugins/QtMobility"
> qtm_data := "/usr/share/${qtm_dir}"
> qtm_imports := "/usr/lib/${qtm_dir}/imports"
>
> +qtm_modules_list ?= "bearer contacts gallery location publishsubscribe
> messaging multimedia \ +systeminfo serviceframework sensors versit
> organizer feedback connectivity" qtm_bluezflag ?=
> "${@base_contains('DISTRO_FEATURES', 'bluetooth', 'yes', 'no', d)}"
Typically variable names like this should be upper case; I know we've got some
lower case ones in here already but let's not introduce any more that we'll
have difficulty changing later.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v3 3/3] qt-mobility: added list of modules to be compiled
2013-03-20 18:12 ` Paul Eggleton
@ 2013-03-20 18:31 ` Felipe Ferreri Tonello
0 siblings, 0 replies; 10+ messages in thread
From: Felipe Ferreri Tonello @ 2013-03-20 18:31 UTC (permalink / raw)
To: Paul Eggleton; +Cc: openembedded-core
Hi Paul,
On 03/20/2013 11:12 AM, Paul Eggleton wrote:
> Hi Felipe,
>
> On Tuesday 19 March 2013 14:54:13 eu@felipetonello.com wrote:
>> From: "Felipe F. Tonello" <ftonello@cercacor.com>
>>
>> This is useful for users that want to .bbappend this recipe to select
>> specific modules to be compiled.
>>
>> Signed-off-by: Felipe F. Tonello <ftonello@cercacor.com>
>> ---
>> meta/recipes-qt/qt4/qt-mobility_1.2.0.inc | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
>> b/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc index fca4cb0..b0ab613 100644
>> --- a/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
>> +++ b/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
>> @@ -18,7 +18,7 @@ SRC_URI =
>> "http://get.qt.nokia.com/qt/add-ons/qt-mobility-opensource-src-${PV}.t
>> SRC_URI[md5sum]="ea5db5a8d3dd4709c2926dceda646bd8"
>> SRC_URI[sha256sum]="ee3c88975e04139ac9589f76d4be646d44fcbc4c8c1cf2db621abc1
>> 54cf0ba44"
>>
>> -PR = "r7"
>> +PR = "r8"
>>
>> S = "${WORKDIR}/qt-mobility-opensource-src-${PV}"
>>
>> @@ -31,6 +31,8 @@ qtm_plugins := "/usr/lib/${qtm_dir}/plugins/QtMobility"
>> qtm_data := "/usr/share/${qtm_dir}"
>> qtm_imports := "/usr/lib/${qtm_dir}/imports"
>>
>> +qtm_modules_list ?= "bearer contacts gallery location publishsubscribe
>> messaging multimedia \ +systeminfo serviceframework sensors versit
>> organizer feedback connectivity" qtm_bluezflag ?=
>> "${@base_contains('DISTRO_FEATURES', 'bluetooth', 'yes', 'no', d)}"
>
> Typically variable names like this should be upper case; I know we've got some
> lower case ones in here already but let's not introduce any more that we'll
> have difficulty changing later.
Alright. I just sent a v4.
Felipe
^ permalink raw reply [flat|nested] 10+ messages in thread