Re: [oe][meta-oe][PATCH 2/4] xterm: add latest version of xterm

[Mark Hatle <mark.hatle@windriver.com>]

On 4/10/13 2:36 PM, Martin Jansa wrote:
> On Wed, Apr 10, 2013 at 08:10:11PM +0200, Marco wrote:
>> Il 10/04/2013 18:56, Trevor Woerner ha scritto:
>>> This whole thread has me thoroughly confused. Isn't xterm_277.bb
>>> <http://xterm_277.bb> already part of meta-openembedded?
>>>
>>> $ find . -name "*xterm*" -print
>>> ./meta-openembedded/meta-oe/recipes-graphics/xorg-app/xterm_277.bb
>>> <http://xterm_277.bb>
>>>
>>> And from what I can tell, it was added over a year ago by Koen:
>>>
>>> $ git log meta-oe/recipes-graphics/xorg-app/xterm_277.bb
>>> <http://xterm_277.bb>
>>> commit a38efd953c0bfef80fd6819c8339c1d1e79364b3
>>> Author: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org
>>> <mailto:marcin.juszkiewicz@linaro.org>>
>>> Date:   Thu Dec 13 10:35:26 2012 +0000
>>>
>>>       xterm: added gnu-configize for AArch64 support
>>>       Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org
>>> <mailto:marcin.juszkiewicz@linaro.org>>
>>>       Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com
>>> <mailto:Martin.Jansa@gmail.com>>
>>>
>>> commit 253b1d7bc35c5a2a12dd6a7f2f0c034a34bfae18
>>> Author: Koen Kooi <koen@dominion.thruhere.net
>>> <mailto:koen@dominion.thruhere.net>>
>>> Date:   Fri Jan 13 09:41:51 2012 +0100
>>>
>>>       xterm: update to 277
>>>       License checksum changed due to date changes
>>>       Signed-off-by: Koen Kooi <koen@dominion.thruhere.net
>>> <mailto:koen@dominion.thruhere.net>>
>>>
>>>
>>
>> Yes, it is copied from meta-openembedded into oe-core
>
> Then you should fix commit message too
>
>   * Recipe taken from oe-classic
>
> In all recipes you sent to oe-core.

See: http://openembedded.org/wiki/Commit_Patch_Message_Guidelines

Specifically the Example: Importing fro Elsewhere Unmodified (and modified)

It's a good idea to list where it came from the commit.. that way if the 
original location is ever changed, people can track what changes may need to be 
merged in.

--Mark

>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>